Re: [PATCH v14 11/12] usb: chipidea: udc: misuse flag CI_HDRC_REGS_SHARED and CI_HDRC_PULLUP_ON_VBUS

2013-08-09 Thread Peter Chen
On Fri, Aug 09, 2013 at 07:46:00PM +0800, Peter Chen wrote: > On Fri, Aug 09, 2013 at 04:23:11PM +0300, Alexander Shishkin wrote: > > Peter Chen writes: > > > > > CI_HDRC_REGS_SHARED stands for the controller registers is shared > > > with other USB drivers, if all USB drivers are at chipidea/, i

Re: [PATCH v14 11/12] usb: chipidea: udc: misuse flag CI_HDRC_REGS_SHARED and CI_HDRC_PULLUP_ON_VBUS

2013-08-09 Thread Peter Chen
On Fri, Aug 09, 2013 at 04:23:11PM +0300, Alexander Shishkin wrote: > Peter Chen writes: > > > CI_HDRC_REGS_SHARED stands for the controller registers is shared > > with other USB drivers, if all USB drivers are at chipidea/, it doesn't > > needed to set. > > We still have the msm driver that us

Re: [PATCH v14 11/12] usb: chipidea: udc: misuse flag CI_HDRC_REGS_SHARED and CI_HDRC_PULLUP_ON_VBUS

2013-08-09 Thread Alexander Shishkin
Peter Chen writes: > CI_HDRC_REGS_SHARED stands for the controller registers is shared > with other USB drivers, if all USB drivers are at chipidea/, it doesn't > needed to set. We still have the msm driver that uses REGS_SHARED. > CI_HDRC_PULLUP_ON_VBUS stands for pullup dp when the vbus is on

[PATCH v14 11/12] usb: chipidea: udc: misuse flag CI_HDRC_REGS_SHARED and CI_HDRC_PULLUP_ON_VBUS

2013-08-02 Thread Peter Chen
CI_HDRC_REGS_SHARED stands for the controller registers is shared with other USB drivers, if all USB drivers are at chipidea/, it doesn't needed to set. CI_HDRC_PULLUP_ON_VBUS stands for pullup dp when the vbus is on. This flag doesn't need to set if the vbus is always on for gadget since dp has al