Re: [PATCH v2][RESEND] usb: gadget: core: Fix ->udc_set_speed() speed handling

2017-11-02 Thread Alan Stern
On Thu, 2 Nov 2017, Roger Quadros wrote: > On 01/11/17 17:45, Alan Stern wrote: > > On Wed, 1 Nov 2017, Roger Quadros wrote: > > > >>> Roger, would you like to send in a follow-up patch that removes the now > >>> unnecessary code from dummy_udc_set_speed() in dummy_hcd.c? > >>> > >> > >> Sure.

Re: [PATCH v2][RESEND] usb: gadget: core: Fix ->udc_set_speed() speed handling

2017-11-02 Thread Roger Quadros
On 01/11/17 17:45, Alan Stern wrote: > On Wed, 1 Nov 2017, Roger Quadros wrote: > >>> Roger, would you like to send in a follow-up patch that removes the now >>> unnecessary code from dummy_udc_set_speed() in dummy_hcd.c? >>> >> >> Sure. I have a question though. >> >> In dummy_udc_set_speed()

Re: [PATCH v2][RESEND] usb: gadget: core: Fix ->udc_set_speed() speed handling

2017-11-01 Thread Alan Stern
On Wed, 1 Nov 2017, Roger Quadros wrote: > > Roger, would you like to send in a follow-up patch that removes the now > > unnecessary code from dummy_udc_set_speed() in dummy_hcd.c? > > > > Sure. I have a question though. > > In dummy_udc_set_speed() we should just set gadget.speed to whatever

Re: [PATCH v2][RESEND] usb: gadget: core: Fix ->udc_set_speed() speed handling

2017-11-01 Thread Roger Quadros
Hi Alan, On 01/11/17 16:24, Alan Stern wrote: > On Tue, 31 Oct 2017, Roger Quadros wrote: > >> Currently UDC core calls ->udc_set_speed() with the speed parameter >> containing the maximum speed supported by the gadget function >> driver. This might very well be more than that supported by the

Re: [PATCH v2][RESEND] usb: gadget: core: Fix ->udc_set_speed() speed handling

2017-11-01 Thread Alan Stern
On Tue, 31 Oct 2017, Roger Quadros wrote: > Currently UDC core calls ->udc_set_speed() with the speed parameter > containing the maximum speed supported by the gadget function > driver. This might very well be more than that supported by the > UDC controller driver. > > Select the lesser of the

[PATCH v2][RESEND] usb: gadget: core: Fix ->udc_set_speed() speed handling

2017-10-31 Thread Roger Quadros
Currently UDC core calls ->udc_set_speed() with the speed parameter containing the maximum speed supported by the gadget function driver. This might very well be more than that supported by the UDC controller driver. Select the lesser of the 2 speeds so both UDC and gadget function driver are