Re: [PATCH v2] USB: cdc-wdm: fix read buffer overflow

2013-03-12 Thread Greg Kroah-Hartman
On Tue, Mar 12, 2013 at 10:56:20AM +0100, Oliver Neukum wrote: On Monday 11 March 2013 22:11:55 Bjørn Mork wrote: What ever was decided here? Can someone please send me the patch that you two agreed would solve this problem? I believe Oliver's patch titled cdc-wdm: fix buffer overflow

Re: [PATCH v2] USB: cdc-wdm: fix read buffer overflow

2013-03-11 Thread Greg Kroah-Hartman
On Fri, Feb 15, 2013 at 12:30:11PM +0100, Bjørn Mork wrote: Oliver Neukum oli...@neukum.org writes: On Friday 15 February 2013 08:53:28 Bjørn Mork wrote: Oliver Neukum oli...@neukum.org writes: We have to let user space recover. To do so we need to indicate when exactly we dropped

Re: [PATCH v2] USB: cdc-wdm: fix read buffer overflow

2013-03-11 Thread Bjørn Mork
Greg Kroah-Hartman gre...@linuxfoundation.org writes: On Fri, Feb 15, 2013 at 12:30:11PM +0100, Bjørn Mork wrote: Oliver Neukum oli...@neukum.org writes: On Friday 15 February 2013 08:53:28 Bjørn Mork wrote: Oliver Neukum oli...@neukum.org writes: We have to let user space recover. To

Re: [PATCH v2] USB: cdc-wdm: fix read buffer overflow

2013-02-15 Thread Oliver Neukum
On Friday 15 February 2013 08:53:28 Bjørn Mork wrote: Oliver Neukum oli...@neukum.org writes: We have to let user space recover. To do so we need to indicate when exactly we dropped data. The problem with that is that this is likely to happen when a client just doesn't care. It will just

[PATCH v2] USB: cdc-wdm: fix read buffer overflow

2013-02-14 Thread Bjørn Mork
Do not scribble past end of buffer. Check if the userspace buffer has enough space available before attempting to move more data there. Drop new data on overflow. Cc: stable sta...@vger.kernel.org Signed-off-by: Bjørn Mork bj...@mork.no --- Oliver Neukum oneu...@suse.de writes: I am afraid

Re: [PATCH v2] USB: cdc-wdm: fix read buffer overflow

2013-02-14 Thread Oliver Neukum
On Thursday 14 February 2013 18:10:43 Bjørn Mork wrote: Do not scribble past end of buffer. Check if the userspace buffer has enough space available before attempting to move more data there. Drop new data on overflow. Cc: stable sta...@vger.kernel.org Signed-off-by: Bjørn Mork

Re: [PATCH v2] USB: cdc-wdm: fix read buffer overflow

2013-02-14 Thread Bjørn Mork
Oliver Neukum oli...@neukum.org writes: On Thursday 14 February 2013 18:10:43 Bjørn Mork wrote: Do not scribble past end of buffer. Check if the userspace buffer has enough space available before attempting to move more data there. Drop new data on overflow. Cc: stable