Re: [PATCH v2] usb: hcd.h: construct hub class request conastants from simpler constants

2016-11-18 Thread Greg KH
On Fri, Nov 18, 2016 at 01:18:19PM +0200, Tal Shorer wrote: > Currently, each hub class request constant is defined by a line like: > > The "magic" number for the high byte is one of 0x20, 0xa0, 0x23, 0xa3. > The 0x80 bit that changes inditace USB_DIR_IN, and the 0x03 that > pops up is the differe

Re: [PATCH v2] usb: hcd.h: construct hub class request conastants from simpler constants

2016-11-18 Thread Greg KH
On Fri, Nov 18, 2016 at 01:18:19PM +0200, Tal Shorer wrote: > Currently, each hub class request constant is defined by a line like: > > The "magic" number for the high byte is one of 0x20, 0xa0, 0x23, 0xa3. Again, shouldn't there be something after your ":"? -- To unsubscribe from this list: send

[PATCH v2] usb: hcd.h: construct hub class request conastants from simpler constants

2016-11-18 Thread Tal Shorer
Currently, each hub class request constant is defined by a line like: The "magic" number for the high byte is one of 0x20, 0xa0, 0x23, 0xa3. The 0x80 bit that changes inditace USB_DIR_IN, and the 0x03 that pops up is the difference between USB_RECIP_DEVICE (0x00) and USB_RECIP_OTHER (0x03). The co