RE: [PATCH v2 03/12] staging: typec: tcpci: support port config passed via dt

e...@google.com; > Peter Chen <peter.c...@nxp.com>; garsi...@embeddedor.com; > o_leve...@orange.fr; shufan_...@richtek.com; linux-usb@vger.kernel.org; > devicet...@vger.kernel.org; dl-linux-imx <linux-...@nxp.com> > Subject: Re: [PATCH v2 03/12] staging: typec: tcpci: support

Re: [PATCH v2 03/12] staging: typec: tcpci: support port config passed via dt

Hi, On Mon, Mar 05, 2018 at 10:35:07AM +, Jun Li wrote: > > So it actually does make sense to define those properties for the > > "connector" node instead of TCPC parent. They are generic "Type-C" > > properties (right?), so we may want to use them with multiport devices as > > well. > > >

RE: [PATCH v2 03/12] staging: typec: tcpci: support port config passed via dt

e...@google.com; > Peter Chen <peter.c...@nxp.com>; garsi...@embeddedor.com; > o_leve...@orange.fr; shufan_...@richtek.com; linux-usb@vger.kernel.org; > devicet...@vger.kernel.org; dl-linux-imx <linux-...@nxp.com> > Subject: Re: [PATCH v2 03/12] staging: typec: tcpci: support

Re: [PATCH v2 03/12] staging: typec: tcpci: support port config passed via dt

On Mon, Mar 05, 2018 at 08:53:00AM +, Jun Li wrote: > > On Mon, Feb 26, 2018 at 02:30:53PM +, Jun Li wrote: > > > > > + child = of_get_child_by_name(tcpci->dev->of_node, "connector"); > > > > > + if (!child) { > > > > > + dev_err(tcpci->dev, "failed to get connector

RE: [PATCH v2 03/12] staging: typec: tcpci: support port config passed via dt

e...@google.com; > Peter Chen <peter.c...@nxp.com>; garsi...@embeddedor.com; > o_leve...@orange.fr; shufan_...@richtek.com; linux-usb@vger.kernel.org; > devicet...@vger.kernel.org; dl-linux-imx <linux-...@nxp.com> > Subject: Re: [PATCH v2 03/12] staging: typec: tc

Re: [PATCH v2 03/12] staging: typec: tcpci: support port config passed via dt

Hi, On Mon, Feb 26, 2018 at 02:30:53PM +, Jun Li wrote: > > > + child = of_get_child_by_name(tcpci->dev->of_node, "connector"); > > > + if (!child) { > > > + dev_err(tcpci->dev, "failed to get connector node.\n"); > > > + return -EINVAL; > > > + } > > > > Why do you need

RE: [PATCH v2 03/12] staging: typec: tcpci: support port config passed via dt

t; > a.ha...@samsung.com; mark.rutl...@arm.com; yue...@google.com; > Peter Chen <peter.c...@nxp.com>; garsi...@embeddedor.com; > o_leve...@orange.fr; shufan_...@richtek.com; linux-usb@vger.kernel.org; > devicet...@vger.kernel.org; dl-linux-imx <linux-...@nxp.com> > Subject:

Re: [PATCH v2 03/12] staging: typec: tcpci: support port config passed via dt

Hi, On Mon, Feb 26, 2018 at 07:49:10PM +0800, Li Jun wrote: > User can define the typec port properties in tcpci node to setup > the port config. > > Signed-off-by: Li Jun > --- > Changes for v2: > - Use infra APIs to get sink and source config. > - Improve the error message. >

[PATCH v2 03/12] staging: typec: tcpci: support port config passed via dt

User can define the typec port properties in tcpci node to setup the port config. Signed-off-by: Li Jun --- Changes for v2: - Use infra APIs to get sink and source config. - Improve the error message. drivers/staging/typec/tcpci.c | 70