Re: [PATCH v2 05/12] usb: typec: tcpm: Set USB role switch to device mode when configured as such

2018-02-25 Thread Guenter Roeck
On 02/25/2018 07:25 AM, Hans de Goede wrote: Setting the mux to MUX_NONE and the switch to USB_SWITCH_DISCONNECT when the data-role is device is not correct. Plenty of devices support operating as USB device through a (separate) USB device controller. We really need 2 different versions of

[PATCH v2 05/12] usb: typec: tcpm: Set USB role switch to device mode when configured as such

2018-02-25 Thread Hans de Goede
Setting the mux to MUX_NONE and the switch to USB_SWITCH_DISCONNECT when the data-role is device is not correct. Plenty of devices support operating as USB device through a (separate) USB device controller. We really need 2 different versions of USB_SWITCH_CONNECT, USB_SWITCH_CONNECT_HOST and