RE: [PATCH v2 1/4] usb: renesas_usbhs: fix spinlock suspected in a gadget complete function

Hi, Hi, On Fri, Mar 13, 2015 at 01:14:01AM +, yoshihiro shimoda wrote: diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c index e0384af77e56..e9d75d85be59 100644 --- a/drivers/usb/renesas_usbhs/mod_gadget.c +++

Re: [PATCH v2 1/4] usb: renesas_usbhs: fix spinlock suspected in a gadget complete function

Hi, On Fri, Mar 13, 2015 at 01:14:01AM +, yoshihiro shimoda wrote: diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c index e0384af77e56..e9d75d85be59 100644 --- a/drivers/usb/renesas_usbhs/mod_gadget.c +++

Re: [PATCH v2 1/4] usb: renesas_usbhs: fix spinlock suspected in a gadget complete function

Hi, On Thu, Mar 12, 2015 at 05:40:56AM +, yoshihiro shimoda wrote: Hi, On Thu, Mar 12, 2015 at 04:33:41AM +, yoshihiro shimoda wrote: Hi Geert-san again, Hi Geert-san, Thank you for the reply again! Hi Shimoda-san, On Mon, Feb 16, 2015 at 2:52 AM,

RE: [PATCH v2 1/4] usb: renesas_usbhs: fix spinlock suspected in a gadget complete function

Hi, Hi, On Thu, Mar 12, 2015 at 05:40:56AM +, yoshihiro shimoda wrote: Hi, snip try something like below: diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c index e0384af77e56..e9d75d85be59 100644 ---

RE: [PATCH v2 1/4] usb: renesas_usbhs: fix spinlock suspected in a gadget complete function

Hi Geert-san again, Hi Geert-san, Thank you for the reply again! Hi Shimoda-san, On Mon, Feb 16, 2015 at 2:52 AM, Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com wrote: According to the gadget.h, a complete function will always be called with interrupts disabled. However,

Re: [PATCH v2 1/4] usb: renesas_usbhs: fix spinlock suspected in a gadget complete function

Hi, On Thu, Mar 12, 2015 at 04:33:41AM +, yoshihiro shimoda wrote: Hi Geert-san again, Hi Geert-san, Thank you for the reply again! Hi Shimoda-san, On Mon, Feb 16, 2015 at 2:52 AM, Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com wrote: According to the

RE: [PATCH v2 1/4] usb: renesas_usbhs: fix spinlock suspected in a gadget complete function

Hi, On Thu, Mar 12, 2015 at 04:33:41AM +, yoshihiro shimoda wrote: Hi Geert-san again, Hi Geert-san, Thank you for the reply again! Hi Shimoda-san, On Mon, Feb 16, 2015 at 2:52 AM, Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com wrote: According to the

RE: [PATCH v2 1/4] usb: renesas_usbhs: fix spinlock suspected in a gadget complete function

Hi Geert-san, Thank you for the reply again! Hi Shimoda-san, On Mon, Feb 16, 2015 at 2:52 AM, Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com wrote: According to the gadget.h, a complete function will always be called with interrupts disabled. However, sometimes usbhsg_queue_pop()

Re: [PATCH v2 1/4] usb: renesas_usbhs: fix spinlock suspected in a gadget complete function

Hi Shimoda-san, On Mon, Feb 16, 2015 at 2:52 AM, Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com wrote: According to the gadget.h, a complete function will always be called with interrupts disabled. However, sometimes usbhsg_queue_pop() function is called with interrupts enabled. So, this

[PATCH v2 1/4] usb: renesas_usbhs: fix spinlock suspected in a gadget complete function

According to the gadget.h, a complete function will always be called with interrupts disabled. However, sometimes usbhsg_queue_pop() function is called with interrupts enabled. So, this function should calls local_irq_save() before this calls the usb_gadget_giveback_request(). Otherwise, there is