Re: [PATCH v3] smsc95xx: Add comments to the registers definition

2017-04-13 Thread martin
On 12/04/17 22:10, woojung@microchip.com wrote: > Sorry forgetting that you are referring RPi which uses LAN9514. > Because these LEDs' GPIO can vary per chip (LAN9500, 9514..), it would be > better > not putting GPIO number. LAN9500 are GPIO 10/9/8 as described. > > > While we are here,

RE: [PATCH v3] smsc95xx: Add comments to the registers definition

2017-04-12 Thread Woojung.Huh
> I based my comments on the datasheet. For the LED_GPIO_CFG register, the > datasheet says: > > This register configures the external GPIO[2:0] pins. > > QFN package description also indicates GPIOs 0, 1 & 2. > As an example for the LAN9514, pin 22 of the QFN indicates: > > nSPD_LED/GPIO2 > >

Re: [PATCH v3] smsc95xx: Add comments to the registers definition

2017-04-12 Thread martin
On 12/04/17 14:25, woojung@microchip.com wrote: > > +/* LED General Purpose IO Configuration Register */ > > +#define LED_GPIO_CFG (0x24) > > +#define LED_GPIO_CFG_SPD_LED (0x0100)/* GPIO2 as SPD LED > > */ > > +#define LED_GPIO_CFG_LNK_LED (0x0010)/*

Re: [PATCH v3] smsc95xx: Add comments to the registers definition

2017-04-12 Thread David Miller
From: Martin Wetterwald Date: Wed, 12 Apr 2017 11:24:05 +0200 > This chip is used by a lot of embedded devices and also by the Raspberry > Pi 1, 2 & 3 which were created to promote the study of computer > sciences. Students wanting to learn kernel / network device driver >

RE: [PATCH v3] smsc95xx: Add comments to the registers definition

2017-04-12 Thread Woojung.Huh
> +/* LED General Purpose IO Configuration Register */ > +#define LED_GPIO_CFG (0x24) > +#define LED_GPIO_CFG_SPD_LED (0x0100)/* GPIO2 as SPD LED > */ > +#define LED_GPIO_CFG_LNK_LED (0x0010)/* GPIO1 as LNK LED > */ > +#define LED_GPIO_CFG_FDX_LED (0x0001)/* GPIO0

Re: [PATCH v3] smsc95xx: Add comments to the registers definition

2017-04-12 Thread Andrew Lunn
On Wed, Apr 12, 2017 at 11:24:05AM +0200, Martin Wetterwald wrote: > This chip is used by a lot of embedded devices and also by the Raspberry > Pi 1, 2 & 3 which were created to promote the study of computer > sciences. Students wanting to learn kernel / network device driver > programming through

Re: [PATCH v3] smsc95xx: Add comments to the registers definition

2017-04-12 Thread Steve Glendinning
On 12 April 2017 at 10:24, Martin Wetterwald wrote: > This chip is used by a lot of embedded devices and also by the Raspberry > Pi 1, 2 & 3 which were created to promote the study of computer > sciences. Students wanting to learn kernel / network device driver > programming

[PATCH v3] smsc95xx: Add comments to the registers definition

2017-04-12 Thread Martin Wetterwald
This chip is used by a lot of embedded devices and also by the Raspberry Pi 1, 2 & 3 which were created to promote the study of computer sciences. Students wanting to learn kernel / network device driver programming through those devices can only rely on the Linux kernel driver source to make