Re: [PATCH v3] usb: wusbcore: Use put_unaligned_le32

2017-11-01 Thread Greg KH
On Tue, Oct 31, 2017 at 11:41:45PM +0530, Himanshu Jha wrote: > On Tue, Oct 17, 2017 at 05:14:30PM +0530, Himanshu Jha wrote: > > Hi Greg, > > > Use put_unaligned_le32 rather than using byte ordering function and > > memcpy which makes code clear. > > Also, add the header file where it is

Re: [PATCH v3] usb: wusbcore: Use put_unaligned_le32

2017-10-31 Thread Himanshu Jha
On Tue, Oct 17, 2017 at 05:14:30PM +0530, Himanshu Jha wrote: Hi Greg, > Use put_unaligned_le32 rather than using byte ordering function and > memcpy which makes code clear. > Also, add the header file where it is declared. > I hope my patch is in your queue! > Done using Coccinelle and

[PATCH v3] usb: wusbcore: Use put_unaligned_le32

2017-10-17 Thread Himanshu Jha
Use put_unaligned_le32 rather than using byte ordering function and memcpy which makes code clear. Also, add the header file where it is declared. Done using Coccinelle and semantic patch used is : @ rule1 @ identifier tmp; expression ptr,x; type T; @@ - tmp = cpu_to_le32(x); <+... when !=