On 15.06.2017 23:53, Ian Pilcher wrote:
On 06/15/2017 03:17 PM, Greg KH wrote:
wait_usec is a count here:
Well ... I was trying to convert it into a parameter that was less
confusing. I've eliminated it in "suggestion v2" below.
You aren't sleeping any :(
Oh $DIETY!
Always return real e
On 06/15/2017 03:17 PM, Greg KH wrote:
wait_usec is a count here:
Well ... I was trying to convert it into a parameter that was less
confusing. I've eliminated it in "suggestion v2" below.
You aren't sleeping any :(
Oh $DIETY!
Always return real error codes, never make up random numbers.
On Thu, Jun 15, 2017 at 02:59:35PM -0500, Ian Pilcher wrote:
> On 06/15/2017 01:58 AM, Jiahau Chang wrote:
> > +void usb_asmedia_modifyflowcontrol(struct pci_dev *pdev)
> > +{
> > + unsigned char value;
> > + unsigned long wait_time_count;
> > +
> > + /*check device can accept command*/
> > +
On 06/15/2017 01:58 AM, Jiahau Chang wrote:
+void usb_asmedia_modifyflowcontrol(struct pci_dev *pdev)
+{
+ unsigned char value;
+ unsigned long wait_time_count;
+
+ /*check device can accept command*/
+ wait_time_count = 1000;
+ while (wait_time_count) {
+
Hi Jiahau,
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.12-rc5 next-20170615]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Jiahau-Chang/xhci-Bad-Ethernet-performance
On Thu, Jun 15, 2017 at 02:58:21PM +0800, Jiahau Chang wrote:
> When USB Ethernet is plugged in ASMEDIA ASM1042A xHCI host, bad
> performance was manifesting in Web browser use (like download
> large file such as ISO image). It is known limitation of
> ASM1042A that is not compatible with driver sc
When USB Ethernet is plugged in ASMEDIA ASM1042A xHCI host, bad
performance was manifesting in Web browser use (like download
large file such as ISO image). It is known limitation of
ASM1042A that is not compatible with driver scheduling,
As a workaround we can modify flow control handling of ASM10