Re: [PATCH v3 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

2018-01-27 Thread Benjamin Herrenschmidt
On Fri, 2018-01-26 at 12:55 +0800, Fengguang Wu wrote: > > > > > > UDCVDBG(vhub, "irq status=%08x, ep_acks=%08x ep_nacks=%08x\n", > > > > This is rather bogus too. m32r's readl() is returning unsigned long, it > > should be unsigned int or u32. > > Unfortunately m32r is marked orphaned in

Re: [PATCH v3 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

2018-01-25 Thread Fengguang Wu
On Fri, Jan 26, 2018 at 10:58:56AM +1100, Benjamin Herrenschmidt wrote: On Wed, 2018-01-24 at 11:30 +0800, kbuild test robot wrote: Hi Benjamin, I love your patch! Perhaps something to improve: [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.15-rc9 next-20180119] [if

Re: [PATCH v3 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

2018-01-25 Thread Benjamin Herrenschmidt
On Wed, 2018-01-24 at 11:30 +0800, kbuild test robot wrote: > Hi Benjamin, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on balbi-usb/next] > [also build test WARNING on v4.15-rc9 next-20180119] > [if your patch is applied to the wrong git tree, please drop us

Re: [PATCH v3 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub (fwd)

2018-01-24 Thread Benjamin Herrenschmidt
9 about the comparison > with the unsigned value. Ah right, fixed that too. Thanks ! Ben. > > julia > > -- Forwarded message -- > Date: Wed, 24 Jan 2018 09:09:59 +0800 > From: kbuild test robot > To: kbu...@01.org > Cc: Julia Lawall > Subject: Re: [

Re: [PATCH v3 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub (fwd)

2018-01-24 Thread Julia Lawall
800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH v3 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub CC: kbuild-...@01.org In-Reply-To: <2018012716.7039-2-b...@kernel.crashing.org> References: <2018012716.7039-2-b...@kernel.crashing.

Re: [PATCH v3 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

2018-01-23 Thread kbuild test robot
Hi Benjamin, I love your patch! Perhaps something to improve: [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.15-rc9 next-20180119] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/l

Re: [PATCH v3 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

2018-01-23 Thread kbuild test robot
Hi Benjamin, I love your patch! Perhaps something to improve: [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.15-rc9 next-20180119] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/l

Re: [PATCH v3 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

2018-01-23 Thread Benjamin Herrenschmidt
On Wed, 2018-01-24 at 09:50 +0800, kbuild test robot wrote: > Hi Benjamin, > > I love your patch! Yet something to improve: > > [auto build test ERROR on balbi-usb/next] > [also build test ERROR on v4.15-rc9] > [if your patch is applied to the wrong git tree, please drop us a note to > help impr

Re: [PATCH v3 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

2018-01-23 Thread kbuild test robot
Hi Benjamin, I love your patch! Yet something to improve: [auto build test ERROR on balbi-usb/next] [also build test ERROR on v4.15-rc9] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Benjamin-

[PATCH v3 2/2] usb/gadget: Add driver for Aspeed SoC virtual hub

2018-01-22 Thread Benjamin Herrenschmidt
The Aspeed BMC SoCs support a "virtual hub" function. It provides some HW support for a top-level USB2 hub behind which sit 5 gadget "ports". This driver adds support for the full functionality, emulating the hub standard requests and exposing 5 UDC gadget drivers corresponding to the ports. The