Re: [PATCH v4 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.

2015-11-18 Thread Dave Penkler
Hi Andy, On Sun, Nov 15, 2015 at 10:04:10PM +0200, Andy Shevchenko wrote: > On Sun, Nov 15, 2015 at 8:39 PM, Dave Penkler wrote: snip > > + > > Redundant empty line. > ok > > > + data->iin_bTag = 2; > > Hmm??? Why 2? > A-ha, below I found a comment.

Re: [PATCH v4 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.

2015-11-15 Thread Andy Shevchenko
On Sun, Nov 15, 2015 at 8:39 PM, Dave Penkler wrote: > Background: > When performing a read on an instrument that is executing a function > that runs longer than the USB timeout the instrument may hang and > require a device reset to recover. The READ_STATUS_BYTE operation >

[PATCH v4 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.

2015-11-15 Thread Dave Penkler
Background: When performing a read on an instrument that is executing a function that runs longer than the USB timeout the instrument may hang and require a device reset to recover. The READ_STATUS_BYTE operation always returns even when the instrument is busy permitting to poll for the