Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-03-22 Thread Baolin Wang
Hi, On 22 March 2017 at 20:43, Mathias Nyman wrote: > On 22.03.2017 12:40, Baolin Wang wrote: >> >> Hi, >> >> On 22 March 2017 at 17:00, Felipe Balbi wrote: >>> >>> >>> Hi, >>> >>> Baolin Wang writes: I

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-03-22 Thread Mathias Nyman
On 22.03.2017 12:40, Baolin Wang wrote: Hi, On 22 March 2017 at 17:00, Felipe Balbi wrote: Hi, Baolin Wang writes: I don't yet understand why we can't just keep runtime pm disabled as a default for xhci platform devices. It could be enabled by

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-03-22 Thread Baolin Wang
Hi, On 22 March 2017 at 17:00, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> I don't yet understand why we can't just keep runtime pm disabled as a >> default for xhci platform devices. >> It could be enabled by whatever creates the

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-03-22 Thread Felipe Balbi
Hi, Baolin Wang writes: > I don't yet understand why we can't just keep runtime pm disabled as a > default for xhci platform devices. > It could be enabled by whatever creates the platform device by setting > some > device property > (or

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-03-21 Thread Baolin Wang
Hi, On 21 March 2017 at 16:07, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: I don't yet understand why we can't just keep runtime pm disabled as a default for xhci platform devices. It could be enabled by whatever creates the

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-03-21 Thread Felipe Balbi
Hi, Baolin Wang writes: >>> I don't yet understand why we can't just keep runtime pm disabled as a >>> default for xhci platform devices. >>> It could be enabled by whatever creates the platform device by setting some >>> device property >>> (or equivalent), which would

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-03-21 Thread Baolin Wang
Hi Mathias, On 21 February 2017 at 10:09, Baolin Wang wrote: >> Do you have any comments about this patch? Thanks. >> >>>drivers/usb/host/xhci-plat.c | 41 >>> - >>>1 file changed, 36 insertions(+), 5

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-02-20 Thread Baolin Wang
On 20 February 2017 at 23:10, Mathias Nyman wrote: > On 20.02.2017 04:47, Baolin Wang wrote: >> >> Hi Mathias, >> >> On 6 February 2017 at 13:26, Baolin Wang wrote: >>> >>> Hi Mathias, >>> >>> On 31 January 2017 at 21:14, Mathias Nyman >>>

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-02-20 Thread Mathias Nyman
On 20.02.2017 04:47, Baolin Wang wrote: Hi Mathias, On 6 February 2017 at 13:26, Baolin Wang wrote: Hi Mathias, On 31 January 2017 at 21:14, Mathias Nyman wrote: On 16.01.2017 12:56, Baolin Wang wrote: Hi Mathias, Hi Sorry about

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-02-19 Thread Baolin Wang
Hi Mathias, On 6 February 2017 at 13:26, Baolin Wang wrote: > Hi Mathias, > > On 31 January 2017 at 21:14, Mathias Nyman > wrote: >> On 16.01.2017 12:56, Baolin Wang wrote: >>> >>> Hi Mathias, >> >> >> Hi >> >> Sorry about the long review

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-02-05 Thread Baolin Wang
Hi Robert, On 26 January 2017 at 01:30, Robert Foss wrote: > Looks good to me. > > Feel free to add my r-b. OK, thanks for your reviewing. -- Baolin.wang Best Regards -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-02-05 Thread Baolin Wang
Hi Mathias, On 31 January 2017 at 21:14, Mathias Nyman wrote: > On 16.01.2017 12:56, Baolin Wang wrote: >> >> Hi Mathias, > > > Hi > > Sorry about the long review delay > CC Alan in case my pm assumptions need to be corrected > > >> >> On 13 December 2016 at 15:49,

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-01-31 Thread Mathias Nyman
On 16.01.2017 12:56, Baolin Wang wrote: Hi Mathias, Hi Sorry about the long review delay CC Alan in case my pm assumptions need to be corrected On 13 December 2016 at 15:49, Baolin Wang wrote: Enable the xhci plat runtime PM for parent device to suspend/resume

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-01-25 Thread Robert Foss
Looks good to me. Feel free to add my r-b. On 2016-12-13 02:49 AM, Baolin Wang wrote: Enable the xhci plat runtime PM for parent device to suspend/resume xhci. Also call pm_runtime_get_noresume() in probe() function in case the parent device doesn't call suspend/resume callback by runtime PM

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2017-01-16 Thread Baolin Wang
Hi Mathias, On 13 December 2016 at 15:49, Baolin Wang wrote: > Enable the xhci plat runtime PM for parent device to suspend/resume xhci. > Also call pm_runtime_get_noresume() in probe() function in case the parent > device doesn't call suspend/resume callback by runtime

[PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

2016-12-12 Thread Baolin Wang
Enable the xhci plat runtime PM for parent device to suspend/resume xhci. Also call pm_runtime_get_noresume() in probe() function in case the parent device doesn't call suspend/resume callback by runtime PM now. Signed-off-by: Baolin Wang --- Changes since v4: - No