Re: [PATCH v6 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-10-10 Thread Linus Walleij
On Fri, Oct 7, 2016 at 5:31 PM, Martyn Welch wrote: > WRT this driver, I think I need to keep set_single_ended, but change > .direction_input > to always return a failure and have .direction_output always return success to > avoid pins being driven in unexpected

Re: [PATCH v6 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-10-07 Thread Martyn Welch
On Fri, Oct 07, 2016 at 04:31:26PM +0100, Martyn Welch wrote: > Also, if an output can only be open-drain, attempting to set the pin as > push-pull succeeds because gpiolib (currently) assumes that a pin can > always be p-p and doesn't even check the return value of it's call to >

Re: [PATCH v6 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-10-07 Thread Martyn Welch
On Tue, Oct 04, 2016 at 02:13:26PM +0200, Linus Walleij wrote: > On Sat, Sep 24, 2016 at 12:50 AM, Martyn Welch > wrote: > > > This patch adds support for the GPIO found on the CP2105. > > > > This device supports either push-pull or open-drain modes, it doesn't >

Re: [PATCH v6 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-10-04 Thread Linus Walleij
On Sat, Sep 24, 2016 at 12:50 AM, Martyn Welch wrote: > This patch adds support for the GPIO found on the CP2105. > This device supports either push-pull or open-drain modes, it doesn't > provide an explicit input mode, though the state of the GPIO can be read >

[PATCH v6 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-09-23 Thread Martyn Welch
This patch adds support for the GPIO found on the CP2105. Unlike the GPIO provided by some of the other devices supported by the cp210x driver, the GPIO on the CP2015 is muxed on pins otherwise used for serial control lines. The GPIO have been configured in 2 separate banks as the choice to