Re: [PATCH v6 5/8] usb: add usb port auto power off mechanism

2013-01-22 Thread Lan Tianyu
On 2013/1/23 1:18, Greg KH wrote: On Wed, Jan 23, 2013 at 12:58:09AM +0800, Lan Tianyu wrote The above line, as written is under 80 characters, so I don't understand the issue. If I do following, scripts/checkpatch.pl will complain over 80 characters. @@ -3767,7 +3814,9 @@ if

Re: [PATCH v6 5/8] usb: add usb port auto power off mechanism

2013-01-22 Thread Greg KH
On Wed, Jan 23, 2013 at 12:58:09AM +0800, Lan Tianyu wrote: > On 2013/1/23 0:02, Greg KH wrote: > >On Tue, Jan 22, 2013 at 11:32:13PM +0800, Lan Tianyu wrote: > >>On 2013/1/22 5:30, Greg KH wrote: > @@ -3758,7 +3805,9 @@ static int hub_port_debounce(struct usb_hub *hub, > int port1) >

Re: [PATCH v6 5/8] usb: add usb port auto power off mechanism

2013-01-22 Thread Lan Tianyu
On 2013/1/23 0:02, Greg KH wrote: On Tue, Jan 22, 2013 at 11:32:13PM +0800, Lan Tianyu wrote: On 2013/1/22 5:30, Greg KH wrote: On Mon, Jan 21, 2013 at 10:18:04PM +0800, Lan Tianyu wrote: @@ -127,7 +128,7 @@ static inline char *portspeed(struct usb_hub *hub, int portstatus) } /* Note tha

Re: [PATCH v6 5/8] usb: add usb port auto power off mechanism

2013-01-22 Thread Greg KH
On Tue, Jan 22, 2013 at 11:32:13PM +0800, Lan Tianyu wrote: > On 2013/1/22 5:30, Greg KH wrote: > >On Mon, Jan 21, 2013 at 10:18:04PM +0800, Lan Tianyu wrote: > >>@@ -127,7 +128,7 @@ static inline char *portspeed(struct usb_hub *hub, int > >>portstatus) > >> } > >> > >> /* Note that hdev or one

Re: [PATCH v6 5/8] usb: add usb port auto power off mechanism

2013-01-22 Thread Lan Tianyu
On 2013/1/22 5:30, Greg KH wrote: On Mon, Jan 21, 2013 at 10:18:04PM +0800, Lan Tianyu wrote: This patch is to add usb port auto power off mechanism. When usb device is suspending, usb core will suspend usb port and usb port runtime pm callback will clear PORT_POWER feature to power off port if

Re: [PATCH v6 5/8] usb: add usb port auto power off mechanism

2013-01-21 Thread Greg KH
On Mon, Jan 21, 2013 at 10:18:04PM +0800, Lan Tianyu wrote: > This patch is to add usb port auto power off mechanism. > When usb device is suspending, usb core will suspend usb port and > usb port runtime pm callback will clear PORT_POWER feature to > power off port if all conditions were met. Thes