Re: [PATCHv15 2/3] usb: USB Type-C connector class

2017-01-26 Thread Felipe Balbi
Hi, Heikki Krogerus writes: > On Wed, Jan 25, 2017 at 10:39:17AM -0800, Guenter Roeck wrote: >> On Mon, Jan 23, 2017 at 04:44:23PM +0200, Felipe Balbi wrote: >> > >> > Hi, >> > >> > Heikki Krogerus writes: >> > > +static void

Re: [PATCHv15 2/3] usb: USB Type-C connector class

2017-01-26 Thread Heikki Krogerus
On Wed, Jan 25, 2017 at 10:39:17AM -0800, Guenter Roeck wrote: > On Mon, Jan 23, 2017 at 04:44:23PM +0200, Felipe Balbi wrote: > > > > Hi, > > > > Heikki Krogerus writes: > > > +static void typec_report_identity(struct device *dev) > > > +{ > > > +

Re: [PATCHv15 2/3] usb: USB Type-C connector class

2017-01-25 Thread Guenter Roeck
On Mon, Jan 23, 2017 at 04:44:23PM +0200, Felipe Balbi wrote: > > Hi, > > Heikki Krogerus writes: > > +static void typec_report_identity(struct device *dev) > > +{ > > + sysfs_notify(>kobj, "identity", "id_header"); > > + sysfs_notify(>kobj, "identity",

Re: [PATCHv15 2/3] usb: USB Type-C connector class

2017-01-25 Thread Heikki Krogerus
Hi Guenter, On Tue, Jan 24, 2017 at 01:47:18PM -0800, Guenter Roeck wrote: > > +static ssize_t product_show(struct device *dev, struct device_attribute > > *attr, > > + char *buf) > > +{ > > + struct usb_pd_identity *id = get_pd_identity(dev); > > + > > + return

Re: [PATCHv15 2/3] usb: USB Type-C connector class

2017-01-25 Thread Heikki Krogerus
Hi, On Mon, Jan 23, 2017 at 04:44:23PM +0200, Felipe Balbi wrote: > Heikki Krogerus writes: > > +static void typec_report_identity(struct device *dev) > > +{ > > + sysfs_notify(>kobj, "identity", "id_header"); > > + sysfs_notify(>kobj, "identity",

Re: [PATCHv15 2/3] usb: USB Type-C connector class

2017-01-24 Thread Guenter Roeck
On Mon, Jan 16, 2017 at 05:56:13PM +0300, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role swapping, and when the port

Re: [PATCHv15 2/3] usb: USB Type-C connector class

2017-01-23 Thread Felipe Balbi
Hi, Heikki Krogerus writes: > +static void typec_report_identity(struct device *dev) > +{ > + sysfs_notify(>kobj, "identity", "id_header"); > + sysfs_notify(>kobj, "identity", "cert_stat"); > + sysfs_notify(>kobj, "identity", "product"); if you

Re: [PATCHv15 2/3] usb: USB Type-C connector class

2017-01-17 Thread Heikki Krogerus
Hi Greg, On Mon, Jan 16, 2017 at 04:35:24PM +0100, Greg KH wrote: > On Mon, Jan 16, 2017 at 05:56:13PM +0300, Heikki Krogerus wrote: > > The purpose of USB Type-C connector class is to provide > > unified interface for the user space to get the status and > > basic information about USB Type-C

Re: [PATCHv15 2/3] usb: USB Type-C connector class

2017-01-16 Thread Mika Westerberg
On Mon, Jan 16, 2017 at 04:35:24PM +0100, Greg KH wrote: > On Mon, Jan 16, 2017 at 05:56:13PM +0300, Heikki Krogerus wrote: > > The purpose of USB Type-C connector class is to provide > > unified interface for the user space to get the status and > > basic information about USB Type-C connectors

Re: [PATCHv15 2/3] usb: USB Type-C connector class

2017-01-16 Thread Greg KH
On Mon, Jan 16, 2017 at 05:56:13PM +0300, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role swapping, and when the port

[PATCHv15 2/3] usb: USB Type-C connector class

2017-01-16 Thread Heikki Krogerus
The purpose of USB Type-C connector class is to provide unified interface for the user space to get the status and basic information about USB Type-C connectors on a system, control over data role swapping, and when the port supports USB Power Delivery, also control over power role swapping and