Re: [RFC] usb: gadget: scheduling while atomic in pxa27x_udc, IS_ERR_OR_NULL test, duplicated definition

2017-02-22 Thread Petr Cvek
Dne 22.2.2017 v 21:46 Robert Jarzmik napsal(a): > Petr Cvek writes: > > Hi Petr, > >> I found a few problems with the PXA27x UDC. >> >> usb_function_activate() in drivers/usb/gadget/composite.c >> >> does spin_lock_irqsave() and then calls >> >>

Re: [RFC] usb: gadget: scheduling while atomic in pxa27x_udc, IS_ERR_OR_NULL test, duplicated definition

2017-02-22 Thread Robert Jarzmik
Petr Cvek writes: Hi Petr, > I found a few problems with the PXA27x UDC. > > usb_function_activate() in drivers/usb/gadget/composite.c > > does spin_lock_irqsave() and then calls > > gadget->ops->pullup() in drivers/usb/gadget/udc/core.c > > which is set to

[RFC] usb: gadget: scheduling while atomic in pxa27x_udc, IS_ERR_OR_NULL test, duplicated definition

2017-02-21 Thread Petr Cvek
Hi, I found a few problems with the PXA27x UDC. usb_function_activate() in drivers/usb/gadget/composite.c does spin_lock_irqsave() and then calls gadget->ops->pullup() in drivers/usb/gadget/udc/core.c which is set to pxa_udc_pullup(), which should be called not in interrupt