RE: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-06-11 Thread Peter Chen
> >Can you confirm that ULPI phys works with IMX6? > >It seems that IMX53 and IMX6 use the same chipidea controller and should have >the >same behaviour. So I wonder if the issue I encounter can be a SOC issue. > Fabien, all imx6 series uses UTMI PHYs, so I am afraid I can't verify it. Peter

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-06-09 Thread Fabien Lahoudere
Hi Peter On Fri, 2017-06-09 at 08:26 +, Peter Chen wrote: >   > > > > I have a look at your patches > > (http://www.spinics.net/lists/linux-usb/msg157134.html) > > and I wonder if power sequence is applicable only on hub node? > > No, power sequence can be used for any devices which needs

RE: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-06-09 Thread Peter Chen
> >I have a look at your patches >(http://www.spinics.net/lists/linux-usb/msg157134.html) >and I wonder if power sequence is applicable only on hub node? No, power sequence can be used for any devices which needs to carry out power on before probe. > hub are probed too >late (after

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-06-08 Thread Fabien Lahoudere
Hi Peter I have a look at your patches (http://www.spinics.net/lists/linux-usb/msg157134.html) and I wonder if power sequence is applicable only on hub node? hub are probed too late (after ci_ulpi_init). Do you think it is possible to read a power sequence in dts from ci_ulpi_init? Thanks

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-06-07 Thread Fabien Lahoudere
On Wed, 2017-06-07 at 09:43 +0800, Peter Chen wrote: > On Tue, Jun 06, 2017 at 07:36:10PM +0200, Fabien Lahoudere wrote: > > Hi Peter, > > > > On Tue, 2017-06-06 at 09:55 +0800, Peter Chen wrote: > > > On Mon, Jun 05, 2017 at 11:52:26AM +0200, Fabien Lahoudere wrote: > > > > On Mon, 2017-06-05 at

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-06-06 Thread Peter Chen
On Tue, Jun 06, 2017 at 07:36:10PM +0200, Fabien Lahoudere wrote: > Hi Peter, > > On Tue, 2017-06-06 at 09:55 +0800, Peter Chen wrote: > > On Mon, Jun 05, 2017 at 11:52:26AM +0200, Fabien Lahoudere wrote: > > > On Mon, 2017-06-05 at 17:43 +0800, Peter Chen wrote: > > > > On Mon, Jun 05, 2017 at

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-06-06 Thread Fabien Lahoudere
Hi Peter, On Tue, 2017-06-06 at 09:55 +0800, Peter Chen wrote: > On Mon, Jun 05, 2017 at 11:52:26AM +0200, Fabien Lahoudere wrote: > > On Mon, 2017-06-05 at 17:43 +0800, Peter Chen wrote: > > > On Mon, Jun 05, 2017 at 10:57:00AM +0200, Fabien Lahoudere wrote: > > > > On Fri, 2017-06-02 at 15:00

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-06-05 Thread Peter Chen
On Mon, Jun 05, 2017 at 11:52:26AM +0200, Fabien Lahoudere wrote: > On Mon, 2017-06-05 at 17:43 +0800, Peter Chen wrote: > > On Mon, Jun 05, 2017 at 10:57:00AM +0200, Fabien Lahoudere wrote: > > > On Fri, 2017-06-02 at 15:00 -0700, Stephen Boyd wrote: > > > > On 05/26, Fabien Lahoudere wrote: > >

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-06-05 Thread Fabien Lahoudere
On Mon, 2017-06-05 at 17:43 +0800, Peter Chen wrote: > On Mon, Jun 05, 2017 at 10:57:00AM +0200, Fabien Lahoudere wrote: > > On Fri, 2017-06-02 at 15:00 -0700, Stephen Boyd wrote: > > > On 05/26, Fabien Lahoudere wrote: > > > > Hello > > > > > > > > I modify ci_hrdc_imx_probe to bypass "data->phy

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-06-05 Thread Peter Chen
On Mon, Jun 05, 2017 at 10:57:00AM +0200, Fabien Lahoudere wrote: > On Fri, 2017-06-02 at 15:00 -0700, Stephen Boyd wrote: > > On 05/26, Fabien Lahoudere wrote: > > > Hello > > > > > > I modify ci_hrdc_imx_probe to bypass "data->phy = > > > devm_usb_get_phy_by_phandle(>dev, > > > "fsl,usbphy",

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-06-05 Thread Fabien Lahoudere
On Fri, 2017-06-02 at 15:00 -0700, Stephen Boyd wrote: > On 05/26, Fabien Lahoudere wrote: > > Hello > > > > I modify ci_hrdc_imx_probe to bypass "data->phy = > > devm_usb_get_phy_by_phandle(>dev, > > "fsl,usbphy", 0);". Everything works as expected and call ci_ulpi_init. > > > > The problem is

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-06-02 Thread Stephen Boyd
On 05/26, Fabien Lahoudere wrote: > Hello > > I modify ci_hrdc_imx_probe to bypass "data->phy = > devm_usb_get_phy_by_phandle(>dev, > "fsl,usbphy", 0);". Everything works as expected and call ci_ulpi_init. > > The problem is that in ci_ulpi_init, before calling "ci->ulpi = >

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-05-26 Thread Fabien Lahoudere
Hello I modify ci_hrdc_imx_probe to bypass "data->phy = devm_usb_get_phy_by_phandle(>dev, "fsl,usbphy", 0);". Everything works as expected and call ci_ulpi_init. The problem is that in ci_ulpi_init, before calling "ci->ulpi = ulpi_register_interface(ci->dev, >ulpi_ops);" (to initialize our

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-05-25 Thread Fabien Lahoudere
On Tue, 2017-05-23 at 14:00 -0700, Stephen Boyd wrote: > On 05/23, Fabien Lahoudere wrote: > > Hi, > > > > We investigate on the topic and now our device tree look like: > > > > in imx53.dtsi: > > > > usbh2: usb@53f80400 { > > compatible = "fsl,imx53-usb", "fsl,imx27-usb"; > > reg =

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-05-23 Thread Stephen Boyd
On 05/23, Fabien Lahoudere wrote: > Hi, > > We investigate on the topic and now our device tree look like: > > in imx53.dtsi: > > usbh2: usb@53f80400 { > compatible = "fsl,imx53-usb", "fsl,imx27-usb"; > reg = <0x53f80400 0x0200>; > interrupts = <16>; > clocks = <

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-05-23 Thread Fabien Lahoudere
Hi, We investigate on the topic and now our device tree look like: in imx53.dtsi: usbh2: usb@53f80400 { compatible = "fsl,imx53-usb", "fsl,imx27-usb"; reg = <0x53f80400 0x0200>; interrupts = <16>; clocks = < IMX5_CLK_USBOH3_GATE>; fsl,usbmisc = < 2>;  

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-04-20 Thread Peter Chen
On Wed, Apr 19, 2017 at 06:14:13AM +, Peter Senna Tschudin wrote: > We need the SMSC USB3315 clock and regulator to always be initialized. > We also need the PHY driver to take the PHY out of reset. This patch > extends the existing USB generic nop phy driver to include a new > initialization

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-04-19 Thread Sergei Shtylyov
On 04/19/2017 01:24 PM, Peter Senna Tschudin wrote: We need the SMSC USB3315 clock and regulator to always be initialized. We also need the PHY driver to take the PHY out of reset. This patch extends the existing USB generic nop phy driver to include a new initialization path. A new compatible

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-04-19 Thread Peter Senna Tschudin
On Wed, Apr 19, 2017 at 01:03:23PM +0300, Sergei Shtylyov wrote: > Hello! > > On 4/19/2017 9:14 AM, Peter Senna Tschudin wrote: > > > We need the SMSC USB3315 clock and regulator to always be initialized. > > We also need the PHY driver to take the PHY out of reset. This patch > > extends the

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-04-19 Thread Sergei Shtylyov
Hello! On 4/19/2017 9:14 AM, Peter Senna Tschudin wrote: We need the SMSC USB3315 clock and regulator to always be initialized. We also need the PHY driver to take the PHY out of reset. This patch extends the existing USB generic nop phy driver to include a new initialization path. A new

[RFC] usb-phy-generic: Add support to SMSC USB3315

2017-04-19 Thread Peter Senna Tschudin
We need the SMSC USB3315 clock and regulator to always be initialized. We also need the PHY driver to take the PHY out of reset. This patch extends the existing USB generic nop phy driver to include a new initialization path. A new compatible string "smsc,usb3315" is used to decide which