Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

On 08/31/2016 01:24 PM, Oliver Neukum wrote: > On Wed, 2016-08-31 at 12:48 +0300, Binyamin Sharet wrote: > >> Sure, but could you send me the cdc-acm.c file that this patch applies to? >> Otherwise I need to patch it manually each time... > Patch already applied. > > HTH >

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

On Wed, 2016-08-31 at 12:48 +0300, Binyamin Sharet wrote: > Sure, but could you send me the cdc-acm.c file that this patch applies to? > Otherwise I need to patch it manually each time... Patch already applied. HTH Oliver /* * cdc-acm.c * * Copyright (c) 1999 Armin

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

On 08/31/2016 12:27 PM, Oliver Neukum wrote: > On Fri, 2016-08-26 at 18:02 +, Binyamin Sharet (bsharet) wrote: > >> I think the reason is that in case of quirks == NO_UNION_NORMAL it gets the >> data >> and control interfaces and then jumps to skip_normal probe, in which case >> there are no

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

On Fri, 2016-08-26 at 18:02 +, Binyamin Sharet (bsharet) wrote: > I think the reason is that in case of quirks == NO_UNION_NORMAL it gets the > data > and control interfaces and then jumps to skip_normal probe, in which case > there are no > checks whether data_interface,

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

> > On 26 Aug 2016, at 09:38, Oliver Neukum wrote: > > >> Hi Oliver, >> >> It will take me some time to test it on v4.4.6-v7, so I have tried applying >> the patch >> to v4.4 but it failed in the 4th hunk (line 47). >> >> Please advise, should I: >> >> - manually edit the

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

> Hi Oliver, > > It will take me some time to test it on v4.4.6-v7, so I have tried applying > the patch > to v4.4 but it failed in the 4th hunk (line 47). > > Please advise, should I: > > - manually edit the file on v4.4 and retest? Please do that. Regards Oliver

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

> On 25 Aug 2016, at 17:24, Oliver Neukum wrote: > > On Thu, 2016-08-25 at 13:53 +, Binyamin Sharet (bsharet) wrote: >>> > >> It’s a good thing you asked, as I forgot to test this one… >> >> Just to be sure - which tag should I use for testing this one? >> Is v4.4 OK? >

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

On Thu, 2016-08-25 at 13:53 +, Binyamin Sharet (bsharet) wrote: > > > It’s a good thing you asked, as I forgot to test this one… > > Just to be sure - which tag should I use for testing this one? > Is v4.4 OK? Yes, perfect. Thanks Oliver -- To unsubscribe from

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

> > On 25 Aug 2016, at 15:59, Oliver Neukum wrote: > > On Wed, 2016-08-17 at 15:26 +0200, Oliver Neukum wrote: >> On Tue, 2016-08-16 at 16:46 +0300, Binyamin Sharet wrote: >>> Kernel version: raspberrypi 4.4.6-v7+ #871 >>> Driver source file: drivers/usb/class/cdc-acm.c >>>

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

On Wed, 2016-08-17 at 15:26 +0200, Oliver Neukum wrote: > On Tue, 2016-08-16 at 16:46 +0300, Binyamin Sharet wrote: > > Kernel version: raspberrypi 4.4.6-v7+ #871 > > Driver source file: drivers/usb/class/cdc-acm.c > > Umap2 command line: umap2vsscan -P -s 22b8:2d93 > > Hi, > > could you retest

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

On Thu, 2016-08-18 at 10:11 +0300, Binyamin Sharet wrote: > Hi, > > On 08/17/2016 04:26 PM, Oliver Neukum wrote: > > On Tue, 2016-08-16 at 16:46 +0300, Binyamin Sharet wrote: > >> Kernel version: raspberrypi 4.4.6-v7+ #871 > >> Driver source file: drivers/usb/class/cdc-acm.c > >> Umap2 command

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

Hi, On 08/17/2016 04:26 PM, Oliver Neukum wrote: > On Tue, 2016-08-16 at 16:46 +0300, Binyamin Sharet wrote: >> Kernel version: raspberrypi 4.4.6-v7+ #871 >> Driver source file: drivers/usb/class/cdc-acm.c >> Umap2 command line: umap2vsscan -P -s 22b8:2d93 > Hi, > > could you retest this kernel

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

On 08/17/2016 04:26 PM, Oliver Neukum wrote: > On Tue, 2016-08-16 at 16:46 +0300, Binyamin Sharet wrote: >> Kernel version: raspberrypi 4.4.6-v7+ #871 >> Driver source file: drivers/usb/class/cdc-acm.c >> Umap2 command line: umap2vsscan -P -s 22b8:2d93 > Hi, > > could you retest this kernel with

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

On Tue, 2016-08-16 at 16:46 +0300, Binyamin Sharet wrote: > Kernel version: raspberrypi 4.4.6-v7+ #871 > Driver source file: drivers/usb/class/cdc-acm.c > Umap2 command line: umap2vsscan -P -s 22b8:2d93 Hi, could you retest this kernel with the attached fix, so I know whether it can go into

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

On 08/17/2016 01:18 PM, Binyamin Sharet wrote: > On 08/17/2016 01:06 PM, Oliver Neukum wrote: >> On Tue, 2016-08-16 at 16:46 +0300, Binyamin Sharet wrote: >>> Kernel version: raspberrypi 4.4.6-v7+ #871 >>> Driver source file: drivers/usb/class/cdc-acm.c >>> Umap2 command line: umap2vsscan -P -s

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

On Wed, 2016-08-17 at 13:18 +0300, Binyamin Sharet wrote: > I have retested this issue with ubuntu 16.04, using kernel 4.7-rc2 > and it was not reproduced. Hi, thanks a lot, that was most informative. I'll make a patch for the stable series. The current fix cannot be backported. Thanks

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

On 08/17/2016 01:06 PM, Oliver Neukum wrote: > On Tue, 2016-08-16 at 16:46 +0300, Binyamin Sharet wrote: >> Kernel version: raspberrypi 4.4.6-v7+ #871 >> Driver source file: drivers/usb/class/cdc-acm.c >> Umap2 command line: umap2vsscan -P -s 22b8:2d93 >> >> After connecting such a device, NULL

Re: [Umap2][5/11][22b8:2d93] NULL pointer dereference

On Tue, 2016-08-16 at 16:46 +0300, Binyamin Sharet wrote: > Kernel version: raspberrypi 4.4.6-v7+ #871 > Driver source file: drivers/usb/class/cdc-acm.c > Umap2 command line: umap2vsscan -P -s 22b8:2d93 > > After connecting such a device, NULL pointer dereference in the kernel > and USB stops

[Umap2][5/11][22b8:2d93] NULL pointer dereference

Kernel version: raspberrypi 4.4.6-v7+ #871 Driver source file: drivers/usb/class/cdc-acm.c Umap2 command line: umap2vsscan -P -s 22b8:2d93 After connecting such a device, NULL pointer dereference in the kernel and USB stops responding. Binyamin Sharet Cisco, STARE-C << Attached: