Re: CPU lock-ups with 4.12.0+ kernels related to usb_storage

2017-07-26 Thread Alan Stern
On Wed, 26 Jul 2017, Christoph Hellwig wrote: > On Thu, Jul 13, 2017 at 01:00:29PM -0400, Alan Stern wrote: > > All right. In the meantime, changing usb-storage won't hurt. > > Arthur, can you test the patch below? > > Do you plan to send this fix to Greg for 4.13-rc? I just submitted it.

Re: CPU lock-ups with 4.12.0+ kernels related to usb_storage

2017-07-26 Thread Christoph Hellwig
On Thu, Jul 13, 2017 at 01:00:29PM -0400, Alan Stern wrote: > All right. In the meantime, changing usb-storage won't hurt. > Arthur, can you test the patch below? Do you plan to send this fix to Greg for 4.13-rc? -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body

Re: CPU lock-ups with 4.12.0+ kernels related to usb_storage

2017-07-17 Thread Arthur Marsh
Arthur Marsh wrote on 14/07/17 04:18: Alan Stern wrote on 14/07/17 02:30: All right. In the meantime, changing usb-storage won't hurt. Arthur, can you test the patch below? Alan Stern Index: usb-4.x/drivers/usb/storage/usb.c

Re: CPU lock-ups with 4.12.0+ kernels related to usb_storage

2017-07-13 Thread Arthur Marsh
Alan Stern wrote on 14/07/17 02:30: All right. In the meantime, changing usb-storage won't hurt. Arthur, can you test the patch below? Alan Stern Index: usb-4.x/drivers/usb/storage/usb.c === ---

Re: CPU lock-ups with 4.12.0+ kernels related to usb_storage

2017-07-13 Thread Alan Stern
On Wed, 12 Jul 2017, Christoph Hellwig wrote: > On Wed, Jul 12, 2017 at 12:10:02PM -0400, Alan Stern wrote: > > This is pretty conclusive. The problem comes about because > > usb_stor_control_thread() calls scsi_mq_done() while holding > > shost->host_lock, and then scsi_eh_scmd_add() tries to

Re: CPU lock-ups with 4.12.0+ kernels related to usb_storage

2017-07-12 Thread Christoph Hellwig
On Wed, Jul 12, 2017 at 12:10:02PM -0400, Alan Stern wrote: > This is pretty conclusive. The problem comes about because > usb_stor_control_thread() calls scsi_mq_done() while holding > shost->host_lock, and then scsi_eh_scmd_add() tries to acquire that > same lock. > > I don't know why this

Re: CPU lock-ups with 4.12.0+ kernels related to usb_storage

2017-07-12 Thread Alan Stern
On Thu, 13 Jul 2017, Arthur Marsh wrote: > Thanks for the advice, I've enabled CONFIG_FRAME_POINTER and managed to > catch 1 more log triggered by issuing a > > blkid > > command after inserting a USB stick. > > The problem is that I can't be certain of triggering the problem when > testing

Re: CPU lock-ups with 4.12.0+ kernels related to usb_storage

2017-07-12 Thread Arthur Marsh
Alan Stern wrote on 11/07/17 23:30: For your future tests, it would help to enable CONFIG_FRAME_POINTER. If it is worthwhile doing a git-bisect on usb-storage I could do that also. I agree with Matt; it's quite possible that the real bug is somewhere else and it just shows up in

Re: CPU lock-ups with 4.12.0+ kernels related to usb_storage

2017-07-11 Thread Alan Stern
On Tue, 11 Jul 2017, Arthur Marsh wrote: > I've had several lock-ups on recent 4.12.0+ kernels that I've built. > > The machine has an Asus M3A78 Pro motherboard and 4-core AMD CPU. > > The only usb-storage in use is an external Seagate HDD with one ntfs-3g > filesystem and another ext3

Re: CPU lock-ups with 4.12.0+ kernels related to usb_storage

2017-07-11 Thread Greg KH
On Tue, Jul 11, 2017 at 03:30:58PM +0930, Arthur Marsh wrote: > I've had several lock-ups on recent 4.12.0+ kernels that I've built. Did older kernels work? Doing 'git bisect' would be great to track down the problem. thanks, greg k-h -- To unsubscribe from this list: send the line

Re: CPU lock-ups with 4.12.0+ kernels related to usb_storage

2017-07-11 Thread Arthur Marsh
Matthew Dharm wrote on 11/07/17 15:54: What else is plugged in? The top line of the log snippet you sent shows an error from a USB video device... I wonder if the error occurred in a different part of the stack, and it just finally bombs-out in usb-storage Matt On Mon, Jul 10, 2017 at

Re: CPU lock-ups with 4.12.0+ kernels related to usb_storage

2017-07-11 Thread Matthew Dharm
What else is plugged in? The top line of the log snippet you sent shows an error from a USB video device... I wonder if the error occurred in a different part of the stack, and it just finally bombs-out in usb-storage Matt On Mon, Jul 10, 2017 at 11:00 PM, Arthur Marsh

CPU lock-ups with 4.12.0+ kernels related to usb_storage

2017-07-11 Thread Arthur Marsh
I've had several lock-ups on recent 4.12.0+ kernels that I've built. The machine has an Asus M3A78 Pro motherboard and 4-core AMD CPU. The only usb-storage in use is an external Seagate HDD with one ntfs-3g filesystem and another ext3 filesystem mounted. A recent kernel log showed: Jul 11