Re: Incompleteness of HW capability registers (Was: [PATCH] staging: dwc2: fix thinko in dwc2_hc_set_even_odd_frame())

2013-07-17 Thread Matthijs Kooijman
Hey Stephen, Ah, that makes sense. It wasn't clear to me from the config structure that some of the variables didn't correspond directly to config fields/registers in the HW. I have a patch pending that separates configured values from hardware values, which would help here. I'll try to send

Re: Incompleteness of HW capability registers (Was: [PATCH] staging: dwc2: fix thinko in dwc2_hc_set_even_odd_frame())

2013-07-16 Thread Stephen Warren
On 07/15/2013 02:27 AM, Matthijs Kooijman wrote: Hi Stephen, I'm not sure how many of the below driver parameters are actually required. I think as least the three fifo size parameters, plus max_transfer_size and max_packet_count, are needed. I'm curious why any of them are required; why

Incompleteness of HW capability registers (Was: [PATCH] staging: dwc2: fix thinko in dwc2_hc_set_even_odd_frame())

2013-07-15 Thread Matthijs Kooijman
Hi Stephen, I'm not sure how many of the below driver parameters are actually required. I think as least the three fifo size parameters, plus max_transfer_size and max_packet_count, are needed. I'm curious why any of them are required; why aren't the values embedded in the HW registers