Re: [PATCH] USB: serial: option: adding support for ublox R410M

2018-05-02 Thread Johan Hovold
On Thu, Apr 26, 2018 at 02:12:32PM -0500, Dan Williams wrote: > On Thu, 2018-04-26 at 18:29 +0200, Johan Hovold wrote: > > On Thu, Apr 26, 2018 at 11:22:25PM +0700, Lars Melin wrote: > > > On 4/26/2018 23:12, Johan Hovold wrote: > > > > On Thu, Apr 26, 2018 at 06:40:46PM +0700, Lars Melin wrote: >

RE: [PATCH] USB: serial: option: adding support for ublox R410M

2018-04-26 Thread 林上智
> > Option is likely the right driver for this device. > > qcaux was mainly for mobile phones that have a TTY (often cdc-acm) as the > modem port > and a secondary DIAG/DM port driven by qcaux. The DM port doesn't have an > interrupt > endpoint thus it's not a normal modem port requiring

Re: [PATCH] USB: serial: option: adding support for ublox R410M

2018-04-26 Thread Dan Williams
On Thu, 2018-04-26 at 18:29 +0200, Johan Hovold wrote: > On Thu, Apr 26, 2018 at 11:22:25PM +0700, Lars Melin wrote: > > On 4/26/2018 23:12, Johan Hovold wrote: > > > On Thu, Apr 26, 2018 at 06:40:46PM +0700, Lars Melin wrote: > > > > On 4/26/2018 18:39, Lars Melin wrote: > > > > > On 4/26/2018

Re: [PATCH] USB: serial: option: adding support for ublox R410M

2018-04-26 Thread Johan Hovold
On Thu, Apr 26, 2018 at 11:22:25PM +0700, Lars Melin wrote: > On 4/26/2018 23:12, Johan Hovold wrote: > > On Thu, Apr 26, 2018 at 06:40:46PM +0700, Lars Melin wrote: > >> On 4/26/2018 18:39, Lars Melin wrote: > >>> On 4/26/2018 18:19, Bjørn Mork wrote: > Anyway, Qualcomm based designs are

Re: [PATCH] USB: serial: option: adding support for ublox R410M

2018-04-26 Thread Lars Melin
On 4/26/2018 23:12, Johan Hovold wrote: On Thu, Apr 26, 2018 at 06:40:46PM +0700, Lars Melin wrote: On 4/26/2018 18:39, Lars Melin wrote: On 4/26/2018 18:19, Bjørn Mork wrote: Anyway, Qualcomm based designs are definitely handled by both drivers. Using qcserial only makes sense if the

Re: [PATCH] USB: serial: option: adding support for ublox R410M

2018-04-26 Thread Johan Hovold
On Thu, Apr 26, 2018 at 06:40:46PM +0700, Lars Melin wrote: > On 4/26/2018 18:39, Lars Melin wrote: > > On 4/26/2018 18:19, Bjørn Mork wrote: > >> Anyway, Qualcomm based designs are definitely handled by both drivers. > >> Using qcserial only makes sense if the interface layout matches one of > >>

Re: [PATCH] USB: serial: option: adding support for ublox R410M

2018-04-26 Thread Lars Melin
On 4/26/2018 18:39, Lars Melin wrote: On 4/26/2018 18:19, Bjørn Mork wrote: Anyway, Qualcomm based designs are definitely handled by both drivers. Using qcserial only makes sense if the interface layout matches one of the defined shared schemes, which currently are: QCSERIAL_G2K = 0,    /*

Re: [PATCH] USB: serial: option: adding support for ublox R410M

2018-04-26 Thread Lars Melin
On 4/26/2018 18:19, Bjørn Mork wrote: Anyway, Qualcomm based designs are definitely handled by both drivers. Using qcserial only makes sense if the interface layout matches one of the defined shared schemes, which currently are: QCSERIAL_G2K = 0, /* Gobi 2000 */

Re: [PATCH] USB: serial: option: adding support for ublox R410M

2018-04-26 Thread Bjørn Mork
Johan Hovold writes: > On Thu, Apr 26, 2018 at 02:48:54PM +0700, Lars Melin wrote: >> On 4/26/2018 14:09, Johan Hovold wrote: >> > On Thu, Apr 26, 2018 at 02:28:31PM +0800, SZ Lin (林上智) wrote: >> >> This patch adds support for ublox R410M PID 0x90b2 USB modem to option >> >>

Re: [PATCH] USB: serial: option: adding support for ublox R410M

2018-04-26 Thread Johan Hovold
On Thu, Apr 26, 2018 at 02:48:54PM +0700, Lars Melin wrote: > On 4/26/2018 14:09, Johan Hovold wrote: > > On Thu, Apr 26, 2018 at 02:28:31PM +0800, SZ Lin (林上智) wrote: > >> This patch adds support for ublox R410M PID 0x90b2 USB modem to option > >> driver, this module supports LTE Cat M1 / NB1. >

Re: [PATCH] USB: serial: option: adding support for ublox R410M

2018-04-26 Thread Lars Melin
On 4/26/2018 14:09, Johan Hovold wrote: On Thu, Apr 26, 2018 at 02:28:31PM +0800, SZ Lin (林上智) wrote: This patch adds support for ublox R410M PID 0x90b2 USB modem to option driver, this module supports LTE Cat M1 / NB1. Interface layout: 0: QCDM/DIAG 1: ADB 2: AT 3: RMNET Signed-off-by: SZ

Re: [PATCH] USB: serial: option: adding support for ublox R410M

2018-04-26 Thread Johan Hovold
On Thu, Apr 26, 2018 at 02:28:31PM +0800, SZ Lin (林上智) wrote: > This patch adds support for ublox R410M PID 0x90b2 USB modem to option > driver, this module supports LTE Cat M1 / NB1. > > Interface layout: > 0: QCDM/DIAG > 1: ADB > 2: AT > 3: RMNET > > Signed-off-by: SZ Lin (林上智)