RE: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout

2016-04-10 Thread Rajesh Bhagat
g; Sriram Dash <sriram.d...@nxp.com> > Subject: Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI > commmand timeout > > On 01.04.2016 06:55, Rajesh Bhagat wrote: > > >>> > >>> Please share your opinion on other changes for patch submissio

Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout

2016-04-01 Thread Mathias Nyman
On 01.04.2016 06:55, Rajesh Bhagat wrote: Please share your opinion on other changes for patch submission as well as resume time. I think more effort should be put into investigating why this happens in the first place. What is the root cause? why doesn't xhci start properly after

RE: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout

2016-03-31 Thread Rajesh Bhagat
g; Sriram Dash <sriram.d...@nxp.com> > Subject: Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI > commmand timeout > > On 31.03.2016 06:51, Rajesh Bhagat wrote: > > > > > > > > Hello Mathias, > > > > Thanks a lot for you

Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout

2016-03-31 Thread Mathias Nyman
On 31.03.2016 06:51, Rajesh Bhagat wrote: Hello Mathias, Thanks a lot for your support. Attached patch is working and allows the completion handler to be called. And resume operation completes and shell comes back (but with lot of errors). Now, some other points which needs our attention

RE: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout

2016-03-30 Thread Rajesh Bhagat
g; Sriram Dash <sriram.d...@nxp.com> > Subject: Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI > commmand timeout > > On 28.03.2016 09:13, Rajesh Bhagat wrote: > > > > > >> -Original Message- > >> From: Mathias Nyman [mailto:

Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout

2016-03-29 Thread Mathias Nyman
x- ker...@vger.kernel.org; Sriram Dash <sriram.d...@nxp.com> Subject: Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout On 23.03.2016 05:53, Rajesh Bhagat wrote: IMO, The assumption that "xhci_abort_cmd_ring would always generate an event and handle_cmd_completio

RE: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout

2016-03-28 Thread Rajesh Bhagat
g; Sriram Dash <sriram.d...@nxp.com> > Subject: Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI > commmand timeout > > On 23.03.2016 05:53, Rajesh Bhagat wrote: > > >>> IMO, The assumption that "xhci_abort_cmd_ring would always gen

Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout

2016-03-23 Thread Mathias Nyman
On 23.03.2016 05:53, Rajesh Bhagat wrote: IMO, The assumption that "xhci_abort_cmd_ring would always generate an event and handle_cmd_completion would be called" will not be always be true if HW is in bad state. Please share your opinion. writing the CA (command abort) bit in CRCR

RE: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout

2016-03-22 Thread Rajesh Bhagat
g; Sriram Dash <sriram.d...@nxp.com> > Subject: Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI > commmand timeout > > On 22.03.2016 07:19, Rajesh Bhagat wrote: > > > > > >> -Original Message- > >> From: Mathias Nyman [m

Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout

2016-03-22 Thread Mathias Nyman
; linux- ker...@vger.kernel.org Cc: gre...@linuxfoundation.org; Sriram Dash <sriram.d...@nxp.com> Subject: Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout On 21.03.2016 06:18, Rajesh Bhagat wrote: Hi I think clearing the whole command ring is a bit too

RE: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout

2016-03-21 Thread Rajesh Bhagat
r...@vger.kernel.org > Cc: gre...@linuxfoundation.org; Sriram Dash <sriram.d...@nxp.com> > Subject: Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI > commmand timeout > > On 21.03.2016 06:18, Rajesh Bhagat wrote: > > > > > >> > >> Hi

RE: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout

2016-03-21 Thread Alan Stern
On Mon, 21 Mar 2016, Rajesh Bhagat wrote: > I agree to your point. Actually the intent was to check the return status of > reset_device which > is currently being ignored. I encountered the reset_device failure case in > resume operation (STR) > which is increasing the time of resume and

Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout

2016-03-21 Thread Mathias Nyman
On 21.03.2016 06:18, Rajesh Bhagat wrote: Hi I think clearing the whole command ring is a bit too much in this case. It may cause issues for all attached devices when one command times out. Hi Mathias, I understand your point, But I want to understand how would completion handler be

RE: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout

2016-03-20 Thread Rajesh Bhagat
.@intel.com; Sriram Dash > <sriram.d...@nxp.com> > Subject: Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI > commmand timeout > > On Fri, 18 Mar 2016, Rajesh Bhagat wrote: > > > --- a/drivers/usb/core/hub.c > > +

RE: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout

2016-03-20 Thread Rajesh Bhagat
mathias.ny...@intel.com; Sriram Dash > <sriram.d...@nxp.com> > Subject: Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI > commmand timeout > > On 18.03.2016 09:01, Rajesh Bhagat wrote: > > We are facing issue while performing the system resume operation

Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout

2016-03-19 Thread Mathias Nyman
On 18.03.2016 09:01, Rajesh Bhagat wrote: We are facing issue while performing the system resume operation from STR where XHCI is going to indefinite hang/sleep state due to wait_for_completion API called in function xhci_alloc_dev for command TRB_ENABLE_SLOT which never completes. Now,

Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout

2016-03-18 Thread Alan Stern
On Fri, 18 Mar 2016, Rajesh Bhagat wrote: > --- a/drivers/usb/core/hub.c > +++ b/drivers/usb/core/hub.c > @@ -2897,10 +2897,14 @@ done: > /* The xHC may think the device is already reset, >* so ignore the status. >*/ > -