RE: [PATCH 2/2 v7] typec: tcpm: Only request matching pdos

2017-11-28 Thread Adam Thomson
On 28 November 2017 02:07, Guenter Roeck wrote: > On 11/27/2017 05:38 PM, Badhri Jagan Sridharan wrote: > > On Thu, Nov 23, 2017 at 3:10 AM, Adam Thomson > > wrote: > >> On 16 November 2017 01:02, Badhri Jagan Sridharan wrote: > >> > >>> At present, TCPM code

RE: [PATCH 2/2 v7] typec: tcpm: Only request matching pdos

2017-11-28 Thread Adam Thomson
On 28 November 2017 01:38, Badhri Jagan Sridharan wrote: > > examples in the kernel where this happens. Where are these functions likely > > to > > be called from, as wherever that is it will need a reference to the port? > > Actually should we be adding DT bindings to set supported src/snk PDOs

Re: [PATCH 2/2 v7] typec: tcpm: Only request matching pdos

2017-11-27 Thread Guenter Roeck
On 11/27/2017 05:38 PM, Badhri Jagan Sridharan wrote: On Thu, Nov 23, 2017 at 3:10 AM, Adam Thomson wrote: On 16 November 2017 01:02, Badhri Jagan Sridharan wrote: At present, TCPM code assumes that local device supports variable/batt pdos and always

Re: [PATCH 2/2 v7] typec: tcpm: Only request matching pdos

2017-11-27 Thread Badhri Jagan Sridharan
On Thu, Nov 23, 2017 at 3:10 AM, Adam Thomson wrote: > On 16 November 2017 01:02, Badhri Jagan Sridharan wrote: > >> At present, TCPM code assumes that local device supports >> variable/batt pdos and always selects the pdo with highest >> possible power within

RE: [PATCH 2/2 v7] typec: tcpm: Only request matching pdos

2017-11-23 Thread Adam Thomson
On 16 November 2017 01:02, Badhri Jagan Sridharan wrote: > At present, TCPM code assumes that local device supports > variable/batt pdos and always selects the pdo with highest > possible power within the board limit. This assumption > might not hold good for all devices. To overcome this, > this