Re: [PATCH v10 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-11 Thread ajaykuee
Hi Peter > On Sep 10, 2018, at 11:29 PM, Peter Rosin wrote: > >> On 2018-09-11 06:30, Ajay Gupta wrote: >> Hi Peter, >> >>> +static int ucsi_ccg_send_data(struct ucsi_ccg *uc) { >>> +unsigned char buf1[USBC_MSG_OUT_SIZE]; >>> +unsigned char

Re: [PATCH v10 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-11 Thread Peter Rosin
On 2018-09-11 06:30, Ajay Gupta wrote: > Hi Peter, > >> +static int ucsi_ccg_send_data(struct ucsi_ccg *uc) { >> +unsigned char buf1[USBC_MSG_OUT_SIZE]; >> +unsigned char buf2[USBC_CONTROL_SIZE]; >> +int status; >> +u16 rab; >> +

RE: [PATCH v10 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-10 Thread Ajay Gupta
Hi Peter, > +static int ucsi_ccg_send_data(struct ucsi_ccg *uc) { > +unsigned char buf1[USBC_MSG_OUT_SIZE]; > +unsigned char buf2[USBC_CONTROL_SIZE]; > +int status; > +u16 rab; > + > +memcpy(buf1, (u8

Re: [PATCH v10 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-10 Thread Peter Rosin
On 2018-09-10 23:53, Ajay Gupta wrote: > Hi Peter > +static int ucsi_ccg_send_data(struct ucsi_ccg *uc) { + unsigned char buf1[USBC_MSG_OUT_SIZE]; + unsigned char buf2[USBC_CONTROL_SIZE]; + int status; + u16 rab; +

RE: [PATCH v10 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-10 Thread Ajay Gupta
Hi Peter > > > +static int ucsi_ccg_send_data(struct ucsi_ccg *uc) { > > > + unsigned char buf1[USBC_MSG_OUT_SIZE]; > > > + unsigned char buf2[USBC_CONTROL_SIZE]; > > > + int status; > > > + u16 rab; > > > + > > > + memcpy(buf1, (u8 *)(uc->ppm.data)

RE: [PATCH v10 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-10 Thread Ajay Gupta
Hi Peter > > +static int ucsi_ccg_send_data(struct ucsi_ccg *uc) { > > + unsigned char buf1[USBC_MSG_OUT_SIZE]; > > + unsigned char buf2[USBC_CONTROL_SIZE]; > > + int status; > > + u16 rab; > > + > > + memcpy(buf1, (u8 *)(uc->ppm.data) +

Re: [PATCH v10 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-10 Thread Peter Rosin
On 2018-09-10 20:51, Ajay Gupta wrote: > +static int ucsi_ccg_send_data(struct ucsi_ccg *uc) { > + unsigned char buf1[USBC_MSG_OUT_SIZE]; > + unsigned char buf2[USBC_CONTROL_SIZE]; > + int status; > + u16 rab; > + > + memcpy(buf1, (u8 *)(uc->ppm.data) +

RE: [PATCH v10 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-10 Thread Ajay Gupta
Hi Peter, > >>> +static int ccg_read(struct ucsi_ccg *uc, u16 rab, u8 *data, u32 > >>> +len) { > >>> + struct i2c_client *client = uc->client; > >>> + unsigned char buf[2]; > >>> + struct i2c_msg msgs[] = { > >>> + { > >>> + .addr = client->addr, > >>> +

Re: [PATCH v10 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-10 Thread Peter Rosin
On 2018-09-10 19:32, Ajay Gupta wrote: >>> +static int ccg_read(struct ucsi_ccg *uc, u16 rab, u8 *data, u32 len) >>> +{ >>> + struct i2c_client *client = uc->client; >>> + unsigned char buf[2]; >>> + struct i2c_msg msgs[] = { >>> + { >>> + .addr = client->addr,

RE: [PATCH v10 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-10 Thread Ajay Gupta
Hi Peter, > > Latest NVIDIA GPU cards have a Cypress CCGx Type-C controller over I2C > > interface. > > > > This UCSI I2C driver uses I2C bus driver interface for communicating > > with Type-C controller. > > > > Signed-off-by: Ajay Gupta > > Reviewed-by: Andy Shevchenko > > Acked-by: Heikki

Re: [PATCH v10 2/2] usb: typec: ucsi: add support for Cypress CCGx

2018-09-08 Thread Peter Rosin
On 2018-09-08 02:09, Ajay Gupta wrote: > Latest NVIDIA GPU cards have a Cypress CCGx Type-C controller > over I2C interface. > > This UCSI I2C driver uses I2C bus driver interface for communicating > with Type-C controller. > > Signed-off-by: Ajay Gupta > Reviewed-by: Andy Shevchenko >