Re: [PATCH] usb: phy: generic: request regulator optionally

2016-09-07 Thread Stefan Agner
On 2016-09-07 11:53, Mark Brown wrote: > On Tue, Sep 06, 2016 at 11:01:15AM -0700, Stefan Agner wrote: >> On 2016-09-06 01:22, Mark Brown wrote: > >> > This is nonsense unless the device can work without this supply. Given >> > that the supply is called VCC that doesn't seem entirely likely. >

Re: [PATCH] usb: phy: generic: request regulator optionally

2016-09-07 Thread Mark Brown
On Tue, Sep 06, 2016 at 11:01:15AM -0700, Stefan Agner wrote: > On 2016-09-06 01:22, Mark Brown wrote: > > This is nonsense unless the device can work without this supply. Given > > that the supply is called VCC that doesn't seem entirely likely. > Afaik it is kind of a generic device tree

Re: [PATCH] usb: phy: generic: request regulator optionally

2016-09-07 Thread Felipe Balbi
Hi, Roger Quadros writes: Stefan Agner writes: >>> > According to the device tree bindings the vcc-supply is optional. >>> >>> This is nonsense unless the device can work without this supply. Given >>> that the supply is called VCC that doesn't seem

Re: [PATCH] usb: phy: generic: request regulator optionally

2016-09-07 Thread Roger Quadros
Hi Stefan, On 06/09/16 21:01, Stefan Agner wrote: > On 2016-09-06 01:22, Mark Brown wrote: >> On Tue, Sep 06, 2016 at 10:45:19AM +0300, Felipe Balbi wrote: >>> Stefan Agner writes: >> According to the device tree bindings the vcc-supply is optional. >> >> This is nonsense

Re: [PATCH] usb: phy: generic: request regulator optionally

2016-09-06 Thread Stefan Agner
On 2016-09-06 01:22, Mark Brown wrote: > On Tue, Sep 06, 2016 at 10:45:19AM +0300, Felipe Balbi wrote: >> Stefan Agner writes: > >> > According to the device tree bindings the vcc-supply is optional. > > This is nonsense unless the device can work without this supply. Given >

Re: [PATCH] usb: phy: generic: request regulator optionally

2016-09-06 Thread Mark Brown
On Tue, Sep 06, 2016 at 10:45:19AM +0300, Felipe Balbi wrote: > Stefan Agner writes: > > According to the device tree bindings the vcc-supply is optional. This is nonsense unless the device can work without this supply. Given that the supply is called VCC that doesn't seem

Re: [PATCH] usb: phy: generic: request regulator optionally

2016-09-06 Thread Felipe Balbi
Mark, Stefan Agner writes: > According to the device tree bindings the vcc-supply is optional. > So far the driver did request the regulator using devm_regulator_get > which creates a dummy regulator for convenience. Since we can have > the supply unconnected, we should make