Re: [PATCH net-next v2 1/3] net/usb/r8152: support aggregation

2013-08-15 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Wed, 14 Aug 2013 20:54:38 +0800 Enable the tx/rx aggregation which could contain one or more packets for each bulk in/out. This could reduce the loading of the host controller by sending less bulk transfer. The rx packets in the bulk in buffer

Re: [PATCH net-next v2 1/3] net/usb/r8152: support aggregation

2013-08-15 Thread Francois Romieu
Hayes Wang hayesw...@realtek.com : [...] diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 11c51f2..abb0b9f 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c [...] @@ -315,13 +318,34 @@ struct tx_desc { u32 opts2; }; +struct rx_agg { +

RE: [PATCH net-next v2 1/3] net/usb/r8152: support aggregation

2013-08-15 Thread hayeswang
Francois Romieu [mailto:rom...@fr.zoreil.com] Sent: Thursday, August 15, 2013 8:26 PM To: Hayeswang Cc: net...@vger.kernel.org; nic_swsd; linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org; David Miller Subject: Re: [PATCH net-next v2 1/3] net/usb/r8152: support aggregation

Re: [PATCH net-next v2 1/3] net/usb/r8152: support aggregation

2013-08-15 Thread Francois Romieu
hayeswang hayesw...@realtek.com : Francois Romieu [mailto:rom...@fr.zoreil.com] [...] The forward declaration is not needed. The r8152_submit_rx() need the declaration of read_bulk_callback(), and the read_bulk_callback() need the declaration of r8152_submit_rx(), too. It likes a dead