Re: [PATCH resend v3 1/4] usb: usbip tool: Check the return of get_nports()

2017-05-19 Thread Shuah Khan
On 05/19/2017 12:46 AM, Yuyang Du wrote: > On Thu, May 18, 2017 at 03:53:04PM +0300, Sergei Shtylyov wrote: >>> + if (vhci_driver->nports <=0) { >> >>Please add a space after <= too. > > Indeed. Thanks. > > Hi Greg, > > Do you want me to send another version to fix this? > Yes. Please

Re: [PATCH resend v3 1/4] usb: usbip tool: Check the return of get_nports()

2017-05-19 Thread Yuyang Du
On Thu, May 18, 2017 at 03:53:04PM +0300, Sergei Shtylyov wrote: > >+if (vhci_driver->nports <=0) { > >Please add a space after <= too. Indeed. Thanks. Hi Greg, Do you want me to send another version to fix this? Thanks, Yuyang -- To unsubscribe from this list: send the line

Re: [PATCH resend v3 1/4] usb: usbip tool: Check the return of get_nports()

2017-05-18 Thread Yuyang Du
On Thu, May 18, 2017 at 03:53:04PM +0300, Sergei Shtylyov wrote: > >From: Yuyang Du > > > >If we get nonpositive number of ports, there is no sense to > >Negative? Negative and zero. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of

Re: [PATCH resend v3 1/4] usb: usbip tool: Check the return of get_nports()

2017-05-18 Thread Sergei Shtylyov
Hello! On 05/18/2017 12:50 PM, Yuyang Du wrote: From: Yuyang Du If we get nonpositive number of ports, there is no sense to Negative? continue, then fail gracefully. In addition, the commit 0775a9cbc694e8c72 ("usbip: vhci extension: modifications to vhci driver")