Re: [PATCH v2 4/7] phy-sun4i-usb: Add support for phy_set_mode

2016-08-19 Thread Kishon Vijay Abraham I
Hi, On Thursday 18 August 2016 03:47 PM, Felipe Balbi wrote: > > Hi, > > Hans de Goede writes: > > [...] > >> void sun4i_usb_phy_set_squelch_detect(struct phy *_phy, bool enabled) >> { >> struct sun4i_usb_phy *phy = phy_get_drvdata(_phy); > [...]

Re: [PATCH v2 4/7] phy-sun4i-usb: Add support for phy_set_mode

2016-08-18 Thread Felipe Balbi
Hi, Hans de Goede writes: [...] > void sun4i_usb_phy_set_squelch_detect(struct phy *_phy, bool enabled) > { > struct sun4i_usb_phy *phy = phy_get_drvdata(_phy); [...] $ scripts/checkpatch.pl

Re: [PATCH v2 4/7] phy-sun4i-usb: Add support for phy_set_mode

2016-08-18 Thread Hans de Goede
HI, On 18-08-16 09:40, Felipe Balbi wrote: Hi, Hans de Goede writes: Hi, On 08/16/2016 03:48 PM, Sergei Shtylyov wrote: Hello. On 08/15/2016 10:21 PM, Hans de Goede wrote: Together with some musb sunxi glue changes this allows run-time dr_mode switching support via

Re: [PATCH v2 4/7] phy-sun4i-usb: Add support for phy_set_mode

2016-08-18 Thread Felipe Balbi
Hi, Hans de Goede writes: > Hi, > > On 08/16/2016 03:48 PM, Sergei Shtylyov wrote: >> Hello. >> >> On 08/15/2016 10:21 PM, Hans de Goede wrote: >> >>> Together with some musb sunxi glue changes this allows run-time dr_mode >>> switching support via the "mode" musb sysfs

Re: [PATCH v2 4/7] phy-sun4i-usb: Add support for phy_set_mode

2016-08-16 Thread Hans de Goede
Hi, On 08/16/2016 03:48 PM, Sergei Shtylyov wrote: Hello. On 08/15/2016 10:21 PM, Hans de Goede wrote: Together with some musb sunxi glue changes this allows run-time dr_mode switching support via the "mode" musb sysfs attribute. Signed-off-by: Hans de Goede ---

Re: [PATCH v2 4/7] phy-sun4i-usb: Add support for phy_set_mode

2016-08-16 Thread Sergei Shtylyov
Hello. On 08/15/2016 10:21 PM, Hans de Goede wrote: Together with some musb sunxi glue changes this allows run-time dr_mode switching support via the "mode" musb sysfs attribute. Signed-off-by: Hans de Goede --- drivers/phy/phy-sun4i-usb.c | 24