Re: [PATCH v3] usb:serial:pl2303: add GPIOs interface on PL2303

2014-07-23 Thread Linus Walleij
On Mon, Jul 21, 2014 at 4:46 AM, Wang YanQing udkni...@gmail.com wrote: PL2303HX has two GPIOs, this patch add interface for it. Signed-off-by: Wang YanQing udkni...@gmail.com --- Changes v2-v3: 1: fix errors and warnings reported by Daniele Forsi checked with checkpatch.pl 2: fix

Re: [PATCH v3] usb:serial:pl2303: add GPIOs interface on PL2303

2014-07-21 Thread Wang YanQing
On Mon, Jul 21, 2014 at 07:46:46AM +0200, Andreas Mohr wrote: Hi, Did some more review, sorry ;) On Mon, Jul 21, 2014 at 10:46:24AM +0800, Wang YanQing wrote: +static struct gpio_chip template_chip = { + .label = pl2303-gpio, + .owner =

Re: [PATCH v3] usb:serial:pl2303: add GPIOs interface on PL2303

2014-07-20 Thread Andreas Mohr
Hi, Did some more review, sorry ;) On Mon, Jul 21, 2014 at 10:46:24AM +0800, Wang YanQing wrote: +static struct gpio_chip template_chip = { + .label = pl2303-gpio, + .owner = THIS_MODULE, + .direction_input= pl2303_gpio_direction_in, +