Re: [PATCH v3 1/2] usb: dwc3: Add Keystone specific glue layer

2013-12-12 Thread Felipe Balbi
Hi, On Tue, Dec 10, 2013 at 10:11:36AM -0500, Santosh Shilimkar wrote: +static int kdwc3_remove(struct platform_device *pdev) +{ + struct dwc3_keystone *kdwc = platform_get_drvdata(pdev); + + kdwc3_disable_irqs(kdwc); + clk_disable_unprepare(kdwc-clk); I hope the clock isn't

Re: [PATCH v3 1/2] usb: dwc3: Add Keystone specific glue layer

2013-12-12 Thread Felipe Balbi
On Thu, Dec 12, 2013 at 02:36:01PM -0500, Santosh Shilimkar wrote: On Thursday 12 December 2013 12:48 PM, Felipe Balbi wrote: Hi, On Tue, Dec 10, 2013 at 10:11:36AM -0500, Santosh Shilimkar wrote: +static int kdwc3_remove(struct platform_device *pdev) +{ +struct dwc3_keystone

Re: [PATCH v3 1/2] usb: dwc3: Add Keystone specific glue layer

2013-12-12 Thread Santosh Shilimkar
On Thursday 12 December 2013 02:41 PM, Felipe Balbi wrote: On Thu, Dec 12, 2013 at 02:36:01PM -0500, Santosh Shilimkar wrote: On Thursday 12 December 2013 12:48 PM, Felipe Balbi wrote: Hi, On Tue, Dec 10, 2013 at 10:11:36AM -0500, Santosh Shilimkar wrote: +static int kdwc3_remove(struct

Re: [PATCH v3 1/2] usb: dwc3: Add Keystone specific glue layer

2013-12-10 Thread Santosh Shilimkar
On Monday 09 December 2013 09:51 PM, Balbi, Felipe wrote: Hi, On Mon, Dec 09, 2013 at 05:17:03PM -0500, WingMan Kwok wrote: +static void kdwc3_enable_irqs(struct dwc3_keystone *kdwc) +{ +u32 val; + +val = kdwc3_readl(kdwc-usbss, USBSS_IRQENABLE_SET_0); +val =

Re: [PATCH v3 1/2] usb: dwc3: Add Keystone specific glue layer

2013-12-09 Thread Felipe Balbi
Hi, On Mon, Dec 09, 2013 at 05:17:03PM -0500, WingMan Kwok wrote: +static void kdwc3_enable_irqs(struct dwc3_keystone *kdwc) +{ + u32 val; + + val = kdwc3_readl(kdwc-usbss, USBSS_IRQENABLE_SET_0); + val = USBSS_IRQ_COREIRQ_EN; this misses the | in |=. I can fix it up while