Re: [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

On Jun 15 2017 or thereabouts, Jiri Kosina wrote: > On Tue, 13 Jun 2017, Benjamin Tissoires wrote: > > > BTW, the merge with your for-next branch is going to be tricky :( > > I've just pushed the for-next merge. Second/third pair of eyes (scripted > eyes even better :) ) would be appreciated. >

Re: [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

On Tue, 13 Jun 2017, Benjamin Tissoires wrote: > BTW, the merge with your for-next branch is going to be tricky :( I've just pushed the for-next merge. Second/third pair of eyes (scripted eyes even better :) ) would be appreciated. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from

Re: [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

On Tue, 13 Jun 2017, Benjamin Tissoires wrote: > > I tried to cook some script that formats the list in the same way than > > yours. > > > > I just noticed that you have in CONFIG_HID_CHICONY: > > { HID_USB_DEVICE(USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_ASUS_AK1D) }, > > while in v4.12-rc5

Re: [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

On Jun 13 2017 or thereabouts, Benjamin Tissoires wrote: > On Jun 13 2017 or thereabouts, Jiri Kosina wrote: > > So I've now pushed the latest version to 'for-4.12/driver-matching-fix' of > > hid.git, and if no more issues are discovered, I'll push that to Linus > > this week so that we finally

Re: [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

On Jun 13 2017 or thereabouts, Jiri Kosina wrote: > So I've now pushed the latest version to 'for-4.12/driver-matching-fix' of > hid.git, and if no more issues are discovered, I'll push that to Linus > this week so that we finally get rid of this long-lasting PITA (while > still heading towards

Re: [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

On Fri, 9 Jun 2017, Hans de Goede wrote: > So I've decided to just go ahead and give this patch a second pair > of eyes, it is mostly good, but I did find some issues, comments > inline. Thanks for all the comments, highly appreciated. [ ... snipped the ones that have been put into v2 ... ] >

Re: [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

Hi, On 09-06-17 13:25, Jiri Kosina wrote: On Fri, 9 Jun 2017, Jiri Kosina wrote: This is something I've been wanting to fix for ages, but never really got to it. So let's take this as the final impulse to do it. So I'd suggest to go with something like the below for 4.12-rc. Hmm? From:

Re: [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

Hi, On 09-06-17 15:00, Benjamin Tissoires wrote: On Jun 09 2017 or thereabouts, Jiri Kosina wrote: On Fri, 9 Jun 2017, Jiri Kosina wrote: This is something I've been wanting to fix for ages, but never really got to it. So let's take this as the final impulse to do it. So I'd suggest to go

Re: [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

On Jun 09 2017 or thereabouts, Jiri Kosina wrote: > On Fri, 9 Jun 2017, Jiri Kosina wrote: > > > This is something I've been wanting to fix for ages, but never really got > > to it. So let's take this as the final impulse to do it. > > So I'd suggest to go with something like the below for

Re: [PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

Hi, On 09-06-17 13:25, Jiri Kosina wrote: On Fri, 9 Jun 2017, Jiri Kosina wrote: This is something I've been wanting to fix for ages, but never really got to it. So let's take this as the final impulse to do it. So I'd suggest to go with something like the below for 4.12-rc. Hmm? Looks

[PATCH] HID: let generic driver yield control iff specific driver has been enabled (was Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works)

On Fri, 9 Jun 2017, Jiri Kosina wrote: > This is something I've been wanting to fix for ages, but never really got > to it. So let's take this as the final impulse to do it. So I'd suggest to go with something like the below for 4.12-rc. Hmm? From: Jiri Kosina Subject:

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

Bjørn Mork writes: > But I should probably go google now, before I repeat too mcuh of the > previous discussions ;-) I guess this is the previous proposal: https://lwn.net/Articles/121227/ and discussion: http://lkml.iu.edu/hypermail/linux/kernel/0502.1/index.html#0438 The

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

Greg KH writes: > On Fri, Jun 09, 2017 at 10:52:42AM +0200, Bjørn Mork wrote: >> Greg KH writes: >> >> > On Fri, Jun 09, 2017 at 10:21:47AM +0200, Jiri Kosina wrote: >> >> Longer-term, we'd ideally make 'generic' driver special and let it attach >> >> as a 'last

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

On Jun 09 2017 or thereabouts, Greg KH wrote: > On Fri, Jun 09, 2017 at 10:52:42AM +0200, Bjørn Mork wrote: > > Greg KH writes: > > > > > On Fri, Jun 09, 2017 at 10:21:47AM +0200, Jiri Kosina wrote: > > >> Longer-term, we'd ideally make 'generic' driver special and let it > > >>

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

On Fri, Jun 09, 2017 at 10:52:42AM +0200, Bjørn Mork wrote: > Greg KH writes: > > > On Fri, Jun 09, 2017 at 10:21:47AM +0200, Jiri Kosina wrote: > >> Longer-term, we'd ideally make 'generic' driver special and let it attach > >> as a 'last resort driver' if none of the specific

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

Hi, On 09-06-17 10:52, Bjørn Mork wrote: Greg KH writes: On Fri, Jun 09, 2017 at 10:21:47AM +0200, Jiri Kosina wrote: Longer-term, we'd ideally make 'generic' driver special and let it attach as a 'last resort driver' if none of the specific driver picked the device up

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

Greg KH writes: > On Fri, Jun 09, 2017 at 10:21:47AM +0200, Jiri Kosina wrote: >> Longer-term, we'd ideally make 'generic' driver special and let it attach >> as a 'last resort driver' if none of the specific driver picked the device >> up during probe. But I don't think our

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

On Fri, Jun 09, 2017 at 10:21:47AM +0200, Jiri Kosina wrote: > Longer-term, we'd ideally make 'generic' driver special and let it attach > as a 'last resort driver' if none of the specific driver picked the device > up during probe. But I don't think our current driver model allows this >

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

On Fri, 9 Jun 2017, Hans de Goede wrote: > Right, so this is not really a problem with this specific patch, but > with how the hid_have_special_driver array works in general currently it > has very few #if IS_ENABLED(CONFIG_FOO) guards around all the devices it > blacklists the generic HID

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

Hi, First of all lets add the HID subsys maintainers to the To list (done). On 08-06-17 22:17, Linus Torvalds wrote: On Thu, Jun 8, 2017 at 12:49 PM, Alan Stern wrote: So maybe CONFIG_HID_ASUS should default to Y? I'll leave it up to Hans to straighten this out.

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

On Thu, Jun 8, 2017 at 12:49 PM, Alan Stern wrote: > > So maybe CONFIG_HID_ASUS should default to Y? I'll leave it up to Hans > to straighten this out. No, I think the main problem is that the hid_have_special_driver[] array change is garbage. It adds the ASUS ID,

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

On Thu, 8 Jun 2017, Alan Cox wrote: > > Normally in this situation I'd recommend bisection. However, this case > > may be simple enough for a usbmon trace to provide the answer. > > With a shared file system between the T100TA and a big machine it's not > too hard to do some builds: > > commit

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

> Normally in this situation I'd recommend bisection. However, this case > may be simple enough for a usbmon trace to provide the answer. With a shared file system between the T100TA and a big machine it's not too hard to do some builds: commit 76dd1fbebbaebab294dc09230960238746b883b1 is the

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

On Wed, 7 Jun 2017, Alan Cox wrote: > On Wed, 7 Jun 2017 18:07:44 +0200 > Greg KH wrote: > > > On Wed, Jun 07, 2017 at 04:27:30PM +0100, Alan Cox wrote: > > > Booting 4.12-rc gives you a machine where neither the keyboard or the > > > mouse of the base-station work. > > > > > >

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

On Wed, 7 Jun 2017 18:07:44 +0200 Greg KH wrote: > On Wed, Jun 07, 2017 at 04:27:30PM +0100, Alan Cox wrote: > > Booting 4.12-rc gives you a machine where neither the keyboard or the > > mouse of the base-station work. > > > > Other USB devices work - including plugging in an

Re: Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

On Wed, Jun 07, 2017 at 04:27:30PM +0100, Alan Cox wrote: > Booting 4.12-rc gives you a machine where neither the keyboard or the > mouse of the base-station work. > > Other USB devices work - including plugging in an external USB keyboard > and mouse. > > Removing the basestation and replugging

Two regressions on BYT/T ASUS T100TA 4.12-rc: #2 Keyboard no longer works

Booting 4.12-rc gives you a machine where neither the keyboard or the mouse of the base-station work. Other USB devices work - including plugging in an external USB keyboard and mouse. Removing the basestation and replugging it has no effect. The base station is seen in lsusb. Bus 001 Device