Re: gadgetfs, functionfs, composite

2012-08-16 Thread Michal Nazarewicz
Sebastian Andrzej Siewior bige...@linutronix.de writes: On 08/15/2012 08:28 PM, Michal Nazarewicz wrote: sendpage() splice() would probably do more good, no? splice() is for moving data between two files descriptors, so that won't be that useful with FFS (I mean, it could be useful in

Re: gadgetfs, functionfs, composite

2012-08-15 Thread Felipe Balbi
On Tue, Aug 14, 2012 at 10:21:16PM +0200, Sebastian Andrzej Siewior wrote: The remaining non-composite users are: - dbgp very simple, not doing much ep0 - file_storage will be removed in v3.8 - gadgetfs Here are my problems at a central spot. So gadgetfs. Its ep0 handling can be

Re: gadgetfs, functionfs, composite

2012-08-15 Thread Felipe Balbi
HI, On Wed, Aug 15, 2012 at 10:17:46AM +0200, Sebastian Andrzej Siewior wrote: On 08/15/2012 08:11 AM, Felipe Balbi wrote: So gadgetfs. Its ep0 handling can be done in kernel and some requests can be offloded to userland. Lets assume the host sends USB_REQ_SET_INTERFACE and -usermode_setup is

Re: gadgetfs, functionfs, composite

2012-08-15 Thread Michal Nazarewicz
Sebastian Andrzej Siewior bige...@linutronix.de writes: So gadgetfs. Its ep0 handling can be done in kernel and some requests can be offloded to userland. Lets assume the host sends USB_REQ_SET_INTERFACE and -usermode_setup is set. That means it returns with 0 (aka ACKs the request), wakes up

Re: gadgetfs, functionfs, composite

2012-08-15 Thread Greg KH
On Wed, Aug 15, 2012 at 11:20:09AM +0300, Felipe Balbi wrote: Based on this it looks like we are stuck with this? No cleaning lady here? Either that or we keep gadgetfs out of the whole configfs rewrite and schedule gadgetfs for removal on v4.8 or something... I agree, we need to keep it

Re: gadgetfs, functionfs, composite

2012-08-15 Thread Sebastian Andrzej Siewior
On 08/15/2012 03:38 PM, Michal Nazarewicz wrote: At this point the cleaning lady in my woke up: May I please remove inode.c, please? We don't need two APIs for the same thing. Like Felipe and Alan has pointed, GFS API is not compatible with FFS API, so just deleting it could potentially break

Re: gadgetfs, functionfs, composite

2012-08-15 Thread Michal Nazarewicz
Sebastian Andrzej Siewior bige...@linutronix.de writes: On 08/15/2012 03:38 PM, Michal Nazarewicz wrote: Having said that, at the moment, FFS does not support asynch IO which GFS has implemented. I have it on my TODO list but never got to implementing it. sendpage() splice() would probably

gadgetfs, functionfs, composite

2012-08-14 Thread Sebastian Andrzej Siewior
The remaining non-composite users are: - dbgp very simple, not doing much ep0 - file_storage will be removed in v3.8 - gadgetfs Here are my problems at a central spot. So gadgetfs. Its ep0 handling can be done in kernel and some requests can be offloded to userland. Lets assume the host