Re: usb/gadget: warning in ep_write_iter/__alloc_pages_nodemask

2016-12-14 Thread Alan Stern
On Wed, 14 Dec 2016, Michal Hocko wrote: > On Tue 13-12-16 08:33:34, Alan Stern wrote: > > On Tue, 13 Dec 2016, Michal Hocko wrote: > > > > > > > That being said, what ep_write_iter does sounds quite stupit. It just > > > > > allocates a large continuous buffer which seems to be under user > > >

Re: usb/gadget: warning in ep_write_iter/__alloc_pages_nodemask

2016-12-14 Thread Michal Hocko
On Wed 14-12-16 11:13:11, Alan Stern wrote: > On Wed, 14 Dec 2016, Michal Hocko wrote: > > > On Tue 13-12-16 08:33:34, Alan Stern wrote: > > > On Tue, 13 Dec 2016, Michal Hocko wrote: [...] > > > > Well, my point was that it is not really hard to imagine to deplete > > > > larger contiguous memory

Re: usb/gadget: warning in ep_write_iter/__alloc_pages_nodemask

2016-12-14 Thread Michal Hocko
On Tue 13-12-16 08:33:34, Alan Stern wrote: > On Tue, 13 Dec 2016, Michal Hocko wrote: > > > > > That being said, what ep_write_iter does sounds quite stupit. It just > > > > allocates a large continuous buffer which seems to be under user > > > > control... Aka no good! It should do that per pag

Re: usb/gadget: warning in ep_write_iter/__alloc_pages_nodemask

2016-12-13 Thread Alan Stern
On Tue, 13 Dec 2016, Michal Hocko wrote: > > > That being said, what ep_write_iter does sounds quite stupit. It just > > > allocates a large continuous buffer which seems to be under user > > > control... Aka no good! It should do that per pages or something like > > > that. Something worth fixin

Re: usb/gadget: warning in ep_write_iter/__alloc_pages_nodemask

2016-12-13 Thread Michal Hocko
On Mon 12-12-16 16:12:16, Alan Stern wrote: > On Mon, 12 Dec 2016, Michal Hocko wrote: > > > On Mon 12-12-16 21:32:35, Andrey Konovalov wrote: > > > On Mon, Dec 12, 2016 at 9:31 PM, Andrey Konovalov > > > wrote: > > > > Hi! > > > > > > > > While running the syzkaller fuzzer I've got the followin

Re: usb/gadget: warning in ep_write_iter/__alloc_pages_nodemask

2016-12-12 Thread Alan Stern
On Mon, 12 Dec 2016, Michal Hocko wrote: > On Mon 12-12-16 21:32:35, Andrey Konovalov wrote: > > On Mon, Dec 12, 2016 at 9:31 PM, Andrey Konovalov > > wrote: > > > Hi! > > > > > > While running the syzkaller fuzzer I've got the following error report. > > > > > > The issue is that the len argume

Re: usb/gadget: warning in ep_write_iter/__alloc_pages_nodemask

2016-12-12 Thread Michal Hocko
On Mon 12-12-16 21:32:35, Andrey Konovalov wrote: > On Mon, Dec 12, 2016 at 9:31 PM, Andrey Konovalov > wrote: > > Hi! > > > > While running the syzkaller fuzzer I've got the following error report. > > > > The issue is that the len argument is not checked for being too big. Well, the value is c

Re: usb/gadget: warning in ep_write_iter/__alloc_pages_nodemask

2016-12-12 Thread Alan Stern
On Mon, 12 Dec 2016, Andrey Konovalov wrote: > On Mon, Dec 12, 2016 at 9:31 PM, Andrey Konovalov > wrote: > > Hi! > > > > While running the syzkaller fuzzer I've got the following error report. > > > > The issue is that the len argument is not checked for being too big. > > > > WARNING: CPU: 1 P

Re: usb/gadget: warning in ep_write_iter/__alloc_pages_nodemask

2016-12-12 Thread Andrey Konovalov
On Mon, Dec 12, 2016 at 9:31 PM, Andrey Konovalov wrote: > Hi! > > While running the syzkaller fuzzer I've got the following error report. > > The issue is that the len argument is not checked for being too big. > > WARNING: CPU: 1 PID: 9935 at mm/page_alloc.c:3511 > __alloc_pages_nodemask+0x159c/

usb/gadget: warning in ep_write_iter/__alloc_pages_nodemask

2016-12-12 Thread Andrey Konovalov
Hi! While running the syzkaller fuzzer I've got the following error report. The issue is that the len argument is not checked for being too big. WARNING: CPU: 1 PID: 9935 at mm/page_alloc.c:3511 __alloc_pages_nodemask+0x159c/0x1e20 Kernel panic - not syncing: panic_on_warn set ... CPU: 1 PID: 9