RE: [PATCH] usb: ohci-exynos: use clk_prepare_enable and clk_disable_unprepare

2012-10-04 Thread Jingoo Han
On Wednesday, October 03, 2012 8:42 AM Thomas Abraham wrote Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare calls as required by common clock framework. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Acked-by: Jingoo Han jg1@samsung.com Best

Re: [PATCH 04/25] MIPS: Netlogic: use ehci-platform driver

2012-10-04 Thread Jonas Gorski
On 3 October 2012 17:02, Florian Fainelli flor...@openwrt.org wrote: Signed-off-by: Florian Fainelli flor...@openwrt.org --- arch/mips/netlogic/xlr/platform.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/mips/netlogic/xlr/platform.c b/arch/mips/netlogic/xlr/platform.c

Re: [PATCH 20/25] MIPS: Netlogic: convert to use OHCI platform driver

2012-10-04 Thread Jonas Gorski
On 3 October 2012 17:03, Florian Fainelli flor...@openwrt.org wrote: Signed-off-by: Florian Fainelli flor...@openwrt.org --- arch/mips/netlogic/xlr/platform.c |5 + 1 file changed, 5 insertions(+) diff --git a/arch/mips/netlogic/xlr/platform.c b/arch/mips/netlogic/xlr/platform.c

[PATCH] usb: musb: am35xx: drop spurious unplugging a device

2012-10-04 Thread Stefano Babic
On AM3517, tx and rx interrupt are detected together with the disconnect event. This generates a kernel panic in musb_interrupt, because rx / tx are handled after disconnect. This issue was seen with Technexion's TAM3517 SOM. Unplugging a device, tx / rx interrupts togetehr with disconnect are

Re: some question about xhci spec

2012-10-04 Thread Alan Stern
On Thu, 4 Oct 2012, loody wrote: hi all: in xhci spec rev1.0 05/21/10 section 6.2.3.4, there is a line said For SuperSpeed endpoints this field shall be set to the value defined in the bMaxBurst field of the SuperSpeed Endpoint Companion Descriptor. Refer to section 8.6.8 of

Re: [PATCH 04/25] MIPS: Netlogic: use ehci-platform driver

2012-10-04 Thread Florian Fainelli
On Wednesday 03 October 2012 12:47:58 Alan Stern wrote: On Wed, 3 Oct 2012, Florian Fainelli wrote: Signed-off-by: Florian Fainelli flor...@openwrt.org IMO, patches should always have a non-empty changelog. Even if it is relatively trivial. The same comment applies to several other

[PATCH 00/24 v2] USB: OHCI and EHCI platform driver conversions

2012-10-04 Thread Florian Fainelli
Hi all, This patch series contains various EHCI and OHCI conversions as well as some cleanups in the existing OHCI HCD driver regarding suspend/resume as suggested by Alan Stern. Changes since previous version summed up are: - improved various commit messages - changed the logic regarding

[PATCH 04/24 v2] MIPS: Netlogic: use ehci-platform driver

2012-10-04 Thread Florian Fainelli
The EHCI platform driver is suitable for use by the Netlogic XLR platform since there is nothing specific that the EHCI XLR platform driver does. Signed-off-by: Florian Fainelli flor...@openwrt.org --- Changes since v1: - really change driver name to ehci-platform - slightly reworded commit

[PATCH 08/24 v2] USB: EHCI: remove Alchemy EHCI driver

2012-10-04 Thread Florian Fainelli
The platform code has been converted to use the ehci-platform driver instead thus obsoleting the ehci-au1xxx driver, which can be removed. Signed-off-by: Florian Fainelli flor...@openwrt.org --- Changes since v1: - reworded commit message drivers/usb/host/ehci-au1xxx.c | 184

[PATCH 10/24 v2] USB: EHCI: remove CNS3xxx EHCI platform driver

2012-10-04 Thread Florian Fainelli
The users have been converted to use the ehci platform driver instead, thus making the ehci-cns3xxx driver obsolete, so remove it. Signed-off-by: Florian Fainelli flor...@openwrt.org --- Changes since v1: - only remove the corresponding chunk from ehci-hcd drivers/usb/host/Kconfig|6

[PATCH 18/24 v2] USB: OHCI: remove CNS3xxx OHCI platform driver

2012-10-04 Thread Florian Fainelli
All users have been converted to use the OHCI platform driver instead, thus making ohci-cns3xxx, so remove it. Signed-off-by: Florian Fainelli flor...@openwrt.org --- Changes since v1: - reworded commit message drivers/usb/host/Kconfig|6 +- drivers/usb/host/ohci-cns3xxx.c | 166

[PATCH 21/24 v2] sh: convert boards to use the OHCI platform driver

2012-10-04 Thread Florian Fainelli
Signed-off-by: Florian Fainelli flor...@openwrt.org --- No changes since v1 arch/sh/kernel/cpu/sh3/setup-sh7720.c |6 +- arch/sh/kernel/cpu/sh4a/setup-sh7757.c |6 +- arch/sh/kernel/cpu/sh4a/setup-sh7763.c |6 +- arch/sh/kernel/cpu/sh4a/setup-sh7786.c |6 +- 4

[PATCH 23/24 v2] MIPS: Alchemy: use the OHCI platform driver

2012-10-04 Thread Florian Fainelli
Convert the Alchemy platform to register the ohci-platform driver, now that the ohci-platform driver properly handles the specific ohci-au1xxx resume from suspend case. This also greatly simplifies the power_{on,off} callbacks and make them work on platform device id instead of checking the OHCI

[PATCH 24/24 v2] USB: OHCI: remove Alchemy OHCI platform driver.

2012-10-04 Thread Florian Fainelli
All users have been converted to use the OHCI platform driver instead, thus making ohci-au1xxx obsolete, remove it. Signed-off-by: Florian Fainelli flor...@openwrt.org --- Changes since v1: - rebased on top of the latest OHCI HCD changes drivers/usb/host/ohci-au1xxx.c | 234

[PATCH 22/24 v2] USB: OHCI: remove OHCI SH platform driver

2012-10-04 Thread Florian Fainelli
All users have been converted to use the OHCI platform driver instead, thus making ohci-sh obsolete, so remove it. Signed-off-by: Florian Fainelli flor...@openwrt.org --- No changes since v1 drivers/usb/host/Kconfig|6 +- drivers/usb/host/ohci-hcd.c |5 -- drivers/usb/host/ohci-sh.c

[PATCH 19/24 v2] MIPS: Netlogic: convert to use OHCI platform driver

2012-10-04 Thread Florian Fainelli
The OHCI platform driver is suitable for use by the Netlogic XLR platform so use this driver instead of the OHCI XLS platform driver. Signed-off-by: Florian Fainelli flor...@openwrt.org --- Changes since v1: - really make the code register the ohci-platform driver instead of ohci-xls

[PATCH 16/24 v2] USB: OHCI: remove PNX8550 OHCI driver

2012-10-04 Thread Florian Fainelli
The users have been converted to use the platform OHCI driver instead, thus making the ohci-pnx8550 driver obsolete, so remove it. Signed-off-by: Florian Fainelli flor...@openwrt.org --- No changes since v1 drivers/usb/host/ohci-hcd.c |5 - drivers/usb/host/ohci-pnx8550.c | 243

[PATCH 17/24 v2] ARM: cns3xxx: use OHCI platform driver

2012-10-04 Thread Florian Fainelli
Since both the EHCI and OHCI platform drivers use the same power_{on,off} callbacks, rename them to cns3xx_usb_power_{on,off} to show that they are shared. Signed-off-by: Florian Fainelli flor...@openwrt.org --- No changes since v1 arch/arm/mach-cns3xxx/cns3420vb.c | 18 +- 1

[PATCH 11/24 v2] USB: ohci: allow platform driver to specify the number of ports

2012-10-04 Thread Florian Fainelli
Signed-off-by: Florian Fainelli flor...@openwrt.org --- No changes since v1 drivers/usb/host/ohci-platform.c |4 include/linux/usb/ohci_pdriver.h |2 ++ 2 files changed, 6 insertions(+) diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c index

[PATCH 01/24 v2] USB: EHCI: remove IXP4xx EHCI driver

2012-10-04 Thread Florian Fainelli
This driver is not registered by any in-tree user. If needed it the EHCI driver can be reinstatied using the ehci-platform driver with caps_offset to 0x100. Signed-off-by: Florian Fainelli flor...@openwrt.org --- Changes since v1: - slightly reworded commit message drivers/usb/host/ehci-hcd.c

[PATCH 02/24 v2] MIPS: Loongson 1B: use ehci-platform instead of ehci-ls1x.

2012-10-04 Thread Florian Fainelli
The Loongson 1B EHCI driver does nothing more than what the EHCI platform driver already does, so use the generic implementation. Signed-off-by: Florian Fainelli flor...@openwrt.org --- No changes since v1 arch/mips/configs/ls1b_defconfig |1 + arch/mips/loongson1/common/platform.c |

[PATCH 05/24 v2] USB: EHCI: remove Netlogic XLS EHCI driver

2012-10-04 Thread Florian Fainelli
The platform code has been migrated to register the ehci-platform driver, thus obsoleting the ehci-xls driver, which can be removed. Signed-off-by: Florian Fainelli flor...@openwrt.org --- Changes since v1: - reworded commit message drivers/usb/host/ehci-hcd.c |5 --

[PATCH 07/24 v2] MIPS: Alchemy: use the ehci platform driver

2012-10-04 Thread Florian Fainelli
Use the ehci platform driver power_{on,suspend,off} callbacks to perform the USB block gate enabling/disabling as what the ehci-au1xxx.c driver does. Update the db1200 and db1300 defconfigs to now select the EHCI platform driver. Signed-off-by: Florian Fainelli flor...@openwrt.org --- Changes

[PATCH 12/24] USB: ohci: move ohci_pci_{suspend,resume} to ohci-hcd.c

2012-10-04 Thread Florian Fainelli
As suggested by Alan Stern, move the ohci-pci.c ohci_pci_{suspend,resume} routines to ohci-hcd.c. Due to their move, also rename them to ohci_{suspend,resume} to make it clear they operate on ohci_hcd. Since they are not necessarily called, annotate them with __maybe_unused. Signed-off-by:

[PATCH 13/24] USB: ohci: remove check for RH already suspended in ohci_suspend

2012-10-04 Thread Florian Fainelli
As suggested by Alan Stern, the code checking for the OHCI Root Hub already suspended is no longer required since the bug it fixes has not been seen in ages, remove that check making ohci_suspend much simpler. Signed-off-by: Florian Fainelli flor...@openwrt.org --- drivers/usb/host/ohci-hcd.c |

[PATCH 09/24 v2] ARM: cns3xxx: use ehci platform driver

2012-10-04 Thread Florian Fainelli
Signed-off-by: Florian Fainelli flor...@openwrt.org --- No change since v1 arch/arm/mach-cns3xxx/cns3420vb.c | 44 - 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-cns3xxx/cns3420vb.c b/arch/arm/mach-cns3xxx/cns3420vb.c index

[PATCH 06/24 v2] USB: EHCI: add no_io_watchdog platform_data parameter to ehci-platform

2012-10-04 Thread Florian Fainelli
Enhance the ehci-platform driver to also accept no_io_watchdog as a platform data parameter. When no_io_watchdog is set to 1, the ehci controller will set ehci-need_io_watchdog to 0. Since most EHCI controllers do need the I/O watchdog to be on, only let those which need it to turn the watchdog

[PATCH 03/24 v2] USB: EHCI: remove Loongson 1B EHCI driver.

2012-10-04 Thread Florian Fainelli
The platform code registering the Loongson 1B EHCI driver has now been converted to register the ehci-platform driver instead, thus obsoleting the ehci-ls1x driver, which can be removed. Signed-off-by: Florian Fainelli flor...@openwrt.org --- Changes since v1: - reworded commit message

[PATCH v4] Enable USB peripheral on dm365 EVM

2012-10-04 Thread Constantine Shulyupin
From: Constantine Shulyupin co...@makelinux.com Signed-off-by: Constantine Shulyupin co...@makelinux.com --- Note: USBPHY_CTL_PADDR and USBPHY_CLKFREQ_24MHZ are defined in board-dm365-evm.c because davinci.h can't be included from drivers/usb/musb/. May be davinci.h should be renamed and

Re: Dead lock in ehci hcd (3.5.3) with usb-serial adapters.

2012-10-04 Thread Alan Stern
On Thu, 4 Oct 2012, jx chang wrote: Hi, all, Recently I get a dead lock in ehci_hcd and hope someone can look at my analysis. The symptom is: When I set loglevel=8 in command line and set console=ttyUSB0, 115200n8..., and connect a usb-serial adapter to my target device (a tablet

[PATCH 1/1] musb : remove generic_interrupt and have all drivers define the isr on their own. Remove some unneeded CONFIG_SOC_OMAP_3430 instances

2012-10-04 Thread Philippe De Swert
This patch is based on the discussion of a previous patch to fix an issue where the omap2430 musb driver is not working for N9/N950. Moving all the interrupt handling to the devices. Avoids inclusion of generic interrupt and breakage due to sometimes misleading CONFIG options. This makes sure

Re: [PATCH v4] Enable USB peripheral on dm365 EVM

2012-10-04 Thread Greg KH
On Thu, Oct 04, 2012 at 06:22:33PM +0200, Constantine Shulyupin wrote: From: Constantine Shulyupin co...@makelinux.com Signed-off-by: Constantine Shulyupin co...@makelinux.com --- Note: USBPHY_CTL_PADDR and USBPHY_CLKFREQ_24MHZ are defined in board-dm365-evm.c because davinci.h can't

Re: Dead lock in ehci hcd (3.5.3) with usb-serial adapters.

2012-10-04 Thread Greg KH
On Thu, Oct 04, 2012 at 12:52:24PM -0400, Alan Stern wrote: On Thu, 4 Oct 2012, jx chang wrote: Hi, all, Recently I get a dead lock in ehci_hcd and hope someone can look at my analysis. The symptom is: When I set loglevel=8 in command line and set console=ttyUSB0,

MUSB regression in linux next at least for pandboard

2012-10-04 Thread Tony Lindgren
Hi Felipe Kishon, Looks like musb is broken at least on pandaboard es in current linux next while it works with v3.6: [1.933074] musb-hdrc: version 6.0, ?dma?, otg (peripheral+host) [1.939422] unable to find transceiver of type USB2 PHYrouping on. Total pages: 251648 [1.945190] HS

Re: Dead lock in ehci hcd (3.5.3) with usb-serial adapters.

2012-10-04 Thread jx chang
Alan and Greg, Appreciate your quick feedback. I guess even if I could fix dead lock with other APIs like spin_is_locked(), it will just make code convoluted. I don't think there is a solution either. Thanks lot for the help! On Thu, Oct 4, 2012 at 10:24 AM, Greg KH gre...@linuxfoundation.org

[PATCH] usb: dwc3: gadget: fix 'endpoint always busy' bug

2012-10-04 Thread Felipe Balbi
If a USB transfer has already been started, meaning we have already issued StartTransfer command to that particular endpoint, DWC3_EP_BUSY flag has also already been set. When we try to cancel this transfer which is already in controller's cache, we will not receive XferComplete event and we must

Re: MUSB regression in linux next at least for pandboard

2012-10-04 Thread Felipe Balbi
Hi, On Thu, Oct 04, 2012 at 10:31:08AM -0700, Tony Lindgren wrote: Hi Felipe Kishon, Looks like musb is broken at least on pandaboard es in current linux next while it works with v3.6: [1.933074] musb-hdrc: version 6.0, ?dma?, otg (peripheral+host) [1.939422] unable to find

fl1000 usb3 controller vanished

2012-10-04 Thread Jan-Simon Möller
Hi all! Here's summary from bug 48331 (bugzilla.kernel.org) as requested. Hardware: Asus g74sx / i7-2, 3x USB2 ports, 1x USB3 port OS: openSUSE 11.4 with latest stable kernel (- 3.6 atm) With the (old) distro kernel the USB3 port does not work at all. Started to work with 2.6.39 but now it

Re: [PATCH 06/24 v2] USB: EHCI: add no_io_watchdog platform_data parameter to ehci-platform

2012-10-04 Thread Alan Stern
On Thu, 4 Oct 2012, Florian Fainelli wrote: Enhance the ehci-platform driver to also accept no_io_watchdog as a platform data parameter. When no_io_watchdog is set to 1, the ehci controller will set ehci-need_io_watchdog to 0. Since most EHCI controllers do need the I/O watchdog to be on,

Re: Mouse and keyboard freeze on Ivy Bridge platform

2012-10-04 Thread Sébastien Dinot
Hi, Jonathan Nieder a écrit : Sebastien: for reference, here's a way to build a kernel with CONFIG_USB_DEBUG enabled. Thank you for these useful instructions, I had not compiled a kernel for some years. Sébastien -- Sébastien Dinot, sebastien.di...@free.fr http://sebastien.dinot.free.fr/ Ne

Re: Mouse and keyboard freeze on Ivy Bridge platform

2012-10-04 Thread Alan Stern
On Thu, 4 Oct 2012, Sébastien Dinot wrote: Hi, Alan Stern a écrit : Please build a kernel with CONFIG_USB_DEBUG enabled. Done (3.6.0+ kernel) When a hang occurs, get a list of hang tasks (Alt-SysRq-w probably won't work, but echo w /proc/sysrq-trigger from a network login

Re: Mouse and keyboard freeze on Ivy Bridge platform

2012-10-04 Thread Sébastien Dinot
Alan Stern a écrit : The log file shows lots and lots of low-level communication errors. They could be caused by bad cabling or by bad USB hardware in your computer. It's unlikely that they were caused by the mouse or keyboard, because the log shows errors for both of them starting at exactly

Re: [PATCH 00/24 v2] USB: OHCI and EHCI platform driver conversions

2012-10-04 Thread Florian Fainelli
Le 04/10/2012 21:36, Alan Stern a écrit : On Thu, 4 Oct 2012, Florian Fainelli wrote: Hi all, This patch series contains various EHCI and OHCI conversions as well as some cleanups in the existing OHCI HCD driver regarding suspend/resume as suggested by Alan Stern. Changes since previous

[PATCH 04/16] ARM: OMAP: Make plat/fpga.h local to arch/arm/plat-omap

2012-10-04 Thread Tony Lindgren
There's no need to have this file in plat/fpga.h. We can make it local to plat-omap replacing fpga_read/write functions directly with readb/writeb as that's how they are already defined in fpga.h. Note that 2420 based H4 is also using the fpga, so let's keep the led support around in plat-omap

Re: [PATCH] EHCI: Update qTD next pointer in QH overlay region during unlink

2012-10-04 Thread Alan Stern
On Fri, 7 Sep 2012, Pavankumar Kondeti wrote: There is a possibility of QH overlay region having reference to a stale qTD pointer during unlink. Consider an endpoint having two pending qTD before unlink process begins. The endpoint's QH queue looks like this. qTD1 -- qTD2 -- Dummy To

Re: FTDI USB-to-UART converters and tcdrain()

2012-10-04 Thread Greg KH
On Tue, Oct 02, 2012 at 05:56:30PM +0200, Jarkko Huijts wrote: Hello knowledgeable people, I have a question regarding tcdrain() and kernel driver drivers/usb/serial/ftdi_sio.c (for a family of USB-to-UART converter chips from FTDI). I'm using an FT232RL and kernel 2.6.38-16. (The driver

Re: Mouse and keyboard freeze on Ivy Bridge platform

2012-10-04 Thread Sarah Sharp
On Thu, Oct 04, 2012 at 11:36:06PM +0200, Sébastien Dinot wrote: Alan Stern a écrit : The log file shows lots and lots of low-level communication errors. They could be caused by bad cabling or by bad USB hardware in your computer. It's unlikely that they were caused by the mouse or

[PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-04 Thread Dmytro Milinevskyy
Signed-off-by: Dmytro Milinevskyy milinevs...@gmail.com --- drivers/usb/gadget/f_ncm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/gadget/f_ncm.c b/drivers/usb/gadget/f_ncm.c index b651b52..fce45ab 100644 --- a/drivers/usb/gadget/f_ncm.c +++

Re: some question about xhci ep0 setting

2012-10-04 Thread Sarah Sharp
On Thu, Oct 04, 2012 at 01:47:44PM +0800, loody wrote: Hi all: from below out put slot context it shows ep0 consumer cycle bit is 1 but why when we enqueue control transfer we purposely leave setup status cycle bit as 0. (below I purpose dump control trb content and 0xcf01c80c should be

Re: MUSB regression in linux next at least for pandboard

2012-10-04 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [121004 11:04]: Hi, On Thu, Oct 04, 2012 at 10:31:08AM -0700, Tony Lindgren wrote: Hi Felipe Kishon, Looks like musb is broken at least on pandaboard es in current linux next while it works with v3.6: [1.933074] musb-hdrc: version 6.0, ?dma?, otg

Re: [PATCH 14/24] USB: ohci: merge ohci_finish_controller_resume with ohci_resume

2012-10-04 Thread Jingoo Han
On Friday, October 05, 2012 12:18 AM Florian Fainelli wrote Merge ohci_finish_controller_resume with ohci_resume as suggested by Alan Stern. Since ohci_finish_controller_resume no longer exists, update the various OHCI drivers to call ohci_resume() instead. Some drivers used to set

Re: some question about xhci ep0 setting

2012-10-04 Thread loody
hi Sarah: 2012/10/5 Sarah Sharp sarah.a.sh...@linux.intel.com: On Thu, Oct 04, 2012 at 01:47:44PM +0800, loody wrote: Hi all: from below out put slot context it shows ep0 consumer cycle bit is 1 but why when we enqueue control transfer we purposely leave setup status cycle bit as 0. (below

Re: some question about xhci spec

2012-10-04 Thread loody
hi alan: 2012/10/4 Alan Stern st...@rowland.harvard.edu: On Thu, 4 Oct 2012, loody wrote: hi all: in xhci spec rev1.0 05/21/10 section 6.2.3.4, there is a line said For SuperSpeed endpoints this field shall be set to the value defined in the bMaxBurst field of the