We can remove the if (urb-actual_length) { check because checking for
while (i urb-actual_length) { is sufficient. This lets us pull the
code in one indent level.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c
len comes from the USB transfer and it's probably correct. The thing
is that we already have similar checks like:
if (data[i] = serial-num_ports) {
So adding a sanity test here matches the rest of the code and is a good
idea.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff
Hi Kukjin,
On Fri, Mar 15, 2013 at 1:32 PM, Vivek Gautam gautam.vi...@samsung.com wrote:
This patch-set is in continuation with patch-series:
[PATCH v4 0/4] Enable ehci, ohci and dwc3 devices on exynos5250
out of which follwowing patches have been picked up:
ARM: Exynos5250: Enabling
On Thu, Apr 04, 2013 at 10:34:57AM +0530, Vivek Gautam wrote:
Hi Sarah,
On Wed, Apr 3, 2013 at 10:57 PM, Sarah Sharp
sarah.a.sh...@linux.intel.com wrote:
Question: Do you still need this patch for 3.10?
Felipe's 'next' is closed for 3.10, so this series won't be making it
to 3.10 now,
Hi,
On Wed, Apr 03, 2013 at 05:54:11PM -0600, Stephen Warren wrote:
struct phy {
struct device *dev;
struct module *owner;
int (*init)(struct phy *phy);
int (*exit)(struct phy *phy);
int (*suspend)(struct phy *phy);
int (*resume)(struct
Hi,
On Wed, Apr 03, 2013 at 02:14:02PM -0400, Alan Stern wrote:
Lets suppose DWC3 enables runtime_pm on USB 2 type phy,
it will try to go into suspend state and thereby call runtime_suspend(),
if any.
And PHY will come to active state only when its consumer wakes it up,
and this
On Thu, Apr 4, 2013 at 12:40 PM, Felipe Balbi ba...@ti.com wrote:
On Thu, Apr 04, 2013 at 10:34:57AM +0530, Vivek Gautam wrote:
Hi Sarah,
On Wed, Apr 3, 2013 at 10:57 PM, Sarah Sharp
sarah.a.sh...@linux.intel.com wrote:
Question: Do you still need this patch for 3.10?
Felipe's 'next' is
Hi,
On 04/04/2013 02:42 AM, Tony Lindgren wrote:
Hi,
* Roger Quadros rog...@ti.com [130319 07:31]:
Register a device tree clock provider for AUX clocks
on the OMAP4 SoC. Also provide the binding information.
Signed-off-by: Roger Quadros rog...@ti.com
---
Svetoslav Neykov svetos...@neykov.name writes:
Add support for the usb controller in AR933x platform.
The controller supports both host or device mode (defined at startup)
but not OTG.
The patches are tested on WR703n router running OpenWRT in device mode.
You forgot to mention the
Michael Grzeschik m...@pengutronix.de writes:
On Wed, Apr 03, 2013 at 05:10:48PM +0300, Alexander Shishkin wrote:
Michael Grzeschik m...@pengutronix.de writes:
Hi Felipe,
On Thu, Mar 28, 2013 at 11:52:38AM +0100, Michael Grzeschik wrote:
Hi,
this series solves some memroy issues
Hi,
On Thu, Apr 04, 2013 at 10:52:28AM +0300, Alexander Shishkin wrote:
Michael Grzeschik m...@pengutronix.de writes:
Hi Felipe,
On Thu, Mar 28, 2013 at 11:52:38AM +0100, Michael Grzeschik wrote:
Hi,
this series solves some memroy issues with the chipidea udc
The
From: Alexander Shishkin [mailto:alexander.shish...@linux.intel.com]
Svetoslav Neykov svetos...@neykov.name writes:
Add support for the usb controller in AR933x platform.
The controller supports both host or device mode (defined at startup)
but not OTG.
The patches are tested on WR703n
Hi,
my compiler is Clang on MacOS 10.7.5.
I run
./configure --disable-log --prefix=/opt/local
make CFLAGS=-arch i386 -arch x86_64 -mmacosx-version-min=10.6
and here's the output:
Making all in libusb
CC libusb_1_0_la-core.lo
core.c:1755:30: warning: use of logical '' with constant
Hi Christopher,
On Wed, Apr 03, 2013, Christopher Waid wrote:
On 03/20/2013 05:45 PM, Christopher Waid wrote:
On 03/20/2013 02:57 PM, Gustavo Padovan wrote:
* Christopher Waid ch...@thinkpenguin.com [2013-03-20 14:13:14 -0400]:
On 03/18/2013 03:13 PM, Greg KH wrote:
On Mon, Mar 18, 2013 at
Hi,
On Thu, Apr 4, 2013 at 12:48 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Wed, Apr 03, 2013 at 02:14:02PM -0400, Alan Stern wrote:
Lets suppose DWC3 enables runtime_pm on USB 2 type phy,
it will try to go into suspend state and thereby call runtime_suspend(),
if any.
And PHY
Hi,
On Wednesday 03 April 2013 09:17 PM, Felipe Balbi wrote:
Hi,
On Wed, Apr 03, 2013 at 08:02:52PM +0530, Kishon Vijay Abraham I wrote:
+ ret = -EINVAL;
+ goto err0;
+ }
+
+ if (!phy_class)
+ phy_core_init();
why don't you setup the
Hi,
On Thursday 04 April 2013 03:16 AM, Sylwester Nawrocki wrote:
On 04/03/2013 02:53 PM, Kishon Vijay Abraham I wrote:
.
.
snip
.
.
diff --git a/Documentation/phy.txt b/Documentation/phy.txt
new file mode 100644
index 000..7785ec0
--- /dev/null
+++ b/Documentation/phy.txt
@@ -0,0 +1,113
Hi,
On Thu, Apr 04, 2013 at 02:26:51PM +0530, Vivek Gautam wrote:
Lets suppose DWC3 enables runtime_pm on USB 2 type phy,
it will try to go into suspend state and thereby call
runtime_suspend(), if any.
And PHY will come to active state only when its consumer wakes it up,
and
Hi Matthijs,
What driver does the USB controller in your TI board use?
The driver used by the USB controller is MUSB_HDRC.
This problem sounds familiar to a problem I have observed in an Ralink
RT3052 board, which uses the dwc_otg / dwc2 driver. Here, the problem
was that the host
Hi,
This series contains two fixes, both of which are also applicable to
-stable.
Michael Grzeschik (2):
usb: chipidea: udc: fix memory access of shared memory on armv5
machines
usb: chipidea: udc: fix memory leak in _ep_nuke
drivers/usb/chipidea/udc.c |8
From: Michael Grzeschik m.grzesc...@pengutronix.de
The udc uses an shared dma memory space between hard and software. This
memory layout is described in ci13xxx_qh and ci13xxx_td which are marked
with the attribute ((packed)).
The compiler currently does not know about the alignment of the
From: Michael Grzeschik m.grzesc...@pengutronix.de
In hardware_enqueue code adds one extra td with dma_pool_alloc if
mReq-req.zero is true. When _ep_nuke will be called for that endpoint,
dma_pool_free will not be called to free that memory again. That patch
fixes this.
Cc: stable
Hi,
On 04/04/2013 11:21 AM, Kishon Vijay Abraham I wrote:
On Thursday 04 April 2013 03:16 AM, Sylwester Nawrocki wrote:
On 04/03/2013 02:53 PM, Kishon Vijay Abraham I wrote:
+4. Getting a reference to the PHY
+
+Before the controller can make use of the PHY, it has to get a
reference to
Hi,
On Thursday 04 April 2013 04:11 PM, Sylwester Nawrocki wrote:
Hi,
On 04/04/2013 11:21 AM, Kishon Vijay Abraham I wrote:
On Thursday 04 April 2013 03:16 AM, Sylwester Nawrocki wrote:
On 04/03/2013 02:53 PM, Kishon Vijay Abraham I wrote:
+4. Getting a reference to the PHY
+
+Before the
Dnia Środa, 3 Kwietnia 2013 21:33 Greg KH gre...@linuxfoundation.org
napisał(a)
On Wed, Apr 03, 2013 at 09:02:50PM +0200, Tomasz Miś wrote:
Dnia Środa, 3 Kwietnia 2013 20:26 Greg KH napisał(a)
A: No.
Q: Should I include quotations after my reply?
Hi,
On 02/07/2013 04:10 PM, Grazvydas Ignotas wrote:
On Thu, Feb 7, 2013 at 11:16 AM, Roger Quadros rog...@ti.com wrote:
snip
It seems the beagleboard problem is related to OMAP silicon errata [1].
Apparently, remote wakeup as well as host issued wakeup break omap-ehci and
have
nothing to
correcting misleading subject line.
was (Re: MUSB regression in linux next at least for pandboard)
On 04/04/2013 02:36 PM, Roger Quadros wrote:
Hi,
On 02/07/2013 04:10 PM, Grazvydas Ignotas wrote:
On Thu, Feb 7, 2013 at 11:16 AM, Roger Quadros rog...@ti.com wrote:
snip
It seems the
-Original Message-
From: linux-tegra-ow...@vger.kernel.org [mailto:linux-tegra-
ow...@vger.kernel.org] On Behalf Of Stephen Warren
Sent: Thursday, April 04, 2013 12:38 AM
To: Venu Byravarasu
Cc: gre...@linuxfoundation.org; ba...@ti.com;
st...@rowland.harvard.edu;
-Original Message-
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Thursday, April 04, 2013 1:06 AM
To: Venu Byravarasu
Cc: gre...@linuxfoundation.org; ba...@ti.com;
st...@rowland.harvard.edu; linux-te...@vger.kernel.org; linux-
u...@vger.kernel.org;
On Wed, Apr 3, 2013 at 12:16 PM, Yegor Yefremov
yegorsli...@googlemail.com wrote:
On Wed, Apr 3, 2013 at 9:12 AM, Yegor Yefremov
yegorsli...@googlemail.com wrote:
On Tue, Apr 2, 2013 at 4:36 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Tue, 2 Apr 2013, Yegor Yefremov wrote:
On Tue, Apr
-Original Message-
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Thursday, April 04, 2013 12:47 AM
To: Venu Byravarasu
Cc: gre...@linuxfoundation.org; ba...@ti.com;
st...@rowland.harvard.edu; linux-te...@vger.kernel.org; linux-
u...@vger.kernel.org;
Hello.
On 04-04-2013 10:33, Dan Carpenter wrote:
We can remove the if (urb-actual_length) { check because checking for
while (i urb-actual_length) { is sufficient. This lets us pull the
code in one indent level.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git
On Thu, Apr 04, 2013 at 10:07:06AM +0530, Puneet Sharma wrote:
Hello,
I want to test USB keyboard for XHCI in u-boot and to do that i need the
Interrupt transfer code in XHCI controller driver in u-boot. If
possible, can you help me to give that piece of code or can you help me
to figure
From: Kurt Kanzenbach ly80t...@cip.cs.fau.de
In each errorcase spin_unlock_irq is called and -EINVAL is returned.
To simplify that I created a label called err doing that.
On Success count will be returned.
Signed-off-by: Kurt Kanzenbach ly80t...@cip.cs.fau.de
Signed-off-by: Stefan Reif
Call freeaddrinfo when connect/listen fails.
Call usbip_host_driver_close on error.
Signed-off-by: Stefan Reif ke42c...@cip.cs.fau.de
---
drivers/staging/usbip/userspace/src/usbip_network.c | 4 ++--
drivers/staging/usbip/userspace/src/usbipd.c| 7 ++-
2 files changed, 8
Fix an indent.
Signed-off-by: Stefan Reif ke42c...@cip.cs.fau.de
---
drivers/staging/usbip/usbip_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/usbip/usbip_common.c
b/drivers/staging/usbip/usbip_common.c
index 539fa57..7b97df6 100644
---
From: Kurt Kanzenbach ly80t...@cip.cs.fau.de
This patch simplified stub_device_free cleanup function:
- changed return type to void, since the return value is
not checked anywhere
- kfree is NULL-safe, so removed if statement
- deleted debug-message
Signed-off-by: Kurt Kanzenbach
From: Kurt Kanzenbach ly80t...@cip.cs.fau.de
Since the names.c/names.h are taken from another project, some
functions which names.c provides aren't used by usbipd.
This patch fixes:
- removed useless comments
- unified debug/error messages by using the macros
provided by usbip_common.h
-
From: Kurt Kanzenbach ly80t...@cip.cs.fau.de
The command `usbip attach' uses --host for specifing
the remote host, while `usbip list' uses --remote.
This is confusing and this patch adapts this.
In Addition changed the manpage and README accordingly.
Before:
$ usbip attach --host host -b busid
Remove broken preprocessor macro hardware. It is unused and it
references an element (pdev in vhci_hcd) that does not exist.
Signed-off-by: Stefan Reif ke42c...@cip.cs.fau.de
---
drivers/staging/usbip/vhci.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/usbip/vhci.h
From: Kurt Kanzenbach ly80t...@cip.cs.fau.de
In each if-else case return is called. This is why
these if-else-statements are useless. Removing them
improves understanding and readability.
Signed-off-by: Kurt Kanzenbach ly80t...@cip.cs.fau.de
Signed-off-by: Stefan Reif ke42c...@cip.cs.fau.de
---
From: Kurt Kanzenbach ly80t...@cip.cs.fau.de
Since no usbip_name function is used in usbipd, it's not
necessary to parse usb.ids file at startup.
Signed-off-by: Kurt Kanzenbach ly80t...@cip.cs.fau.de
Signed-off-by: Stefan Reif ke42c...@cip.cs.fau.de
---
From: Kurt Kanzenbach ly80t...@cip.cs.fau.de
This for loop is not needed, since STUB_BUSID_OTHER is defined as 0.
In Addition added a comment if STUB_BUSID_OTHER changes sometime.
Signed-off-by: Kurt Kanzenbach ly80t...@cip.cs.fau.de
Signed-off-by: Stefan Reif ke42c...@cip.cs.fau.de
---
From: Kurt Kanzenbach ly80t...@cip.cs.fau.de
The `usbip list -l' command shows your local usb-devices.
Example:
$ usbip list -l
$ Local USB devices
$ =
$ - busid 1-1 (13fe:1d00)
$ 1-1:1.0 - usb-storage
$
$ - busid 1-2 (0409:55aa)
$ 1-2:1.0 - hub
However
Code cleanup for the usbip driver.
- delete unused code
- improve readability
- improve usability of the command line tools
Kurt and I did this work together.
Kurt Kanzenbach (10):
staging: usbip: reformat function stub_recv_cmd_unlink()
staging: usbip: removed enumeration of comments
re-indent funtion pickup_urb_and_free_priv to improve readability.
Signed-off-by: Stefan Reif ke42c...@cip.cs.fau.de
---
drivers/staging/usbip/vhci_rx.c | 54 ++---
1 file changed, 29 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/usbip/vhci_rx.c
replace numbers in code by ascii text constants as suggested
by Dan Carpenter:
http://driverdev.linuxdriverproject.org/pipermail/devel/2013-February/035907.html
Signed-off-by: Stefan Reif ke42c...@cip.cs.fau.de
---
drivers/staging/usbip/userspace/libsrc/names.c | 4 ++--
1 file changed, 2
From: Kurt Kanzenbach ly80t...@cip.cs.fau.de
Enumerations for one comment makes no sense.
This is why this should be removed.
Signed-off-by: Kurt Kanzenbach ly80t...@cip.cs.fau.de
Signed-off-by: Stefan Reif ke42c...@cip.cs.fau.de
---
drivers/staging/usbip/stub_dev.c | 2 +-
From: Kurt Kanzenbach ly80t...@cip.cs.fau.de
Reformat function stub_recv_cmd_unlink() to improve readability.
Signed-off-by: Kurt Kanzenbach ly80t...@cip.cs.fau.de
Signed-off-by: Stefan Reif ke42c...@cip.cs.fau.de
---
drivers/staging/usbip/stub_rx.c | 98
On Thu, 4 Apr 2013, Felipe Balbi wrote:
Some subsystems handle this issue by calling pm_runtime_get_sync()
before probing a driver and pm_runtime_put_sync() after unbinding the
driver. If the driver is runtime-PM-enabled, it then does its own
put_sync near the end of its probe
Hi Ravi,
On Friday 29 March 2013 14:14:35 B, Ravi wrote:
Laurent/Ming Lei
Since the uvc_video_complete() callback handler called from interrupt
context, video post processing or memcpy can be deferred to tasklet or
bottom half, rather than doing it in interrupt context.
If that's
Hi,
I discovered that the optional strings and their indices of interface
descriptors are not exported in debugfs when I was looking at usbview's
source (https://github.com/gregkh/usbview/issues/5).
I am not sure yet if they are cached (e.g. in rawdescriptors in struct
usb_device or even more
Hi Alan,
On Thursday 28 March 2013 10:45:27 Alan Stern wrote:
On Thu, 28 Mar 2013, Laurent Pinchart wrote:
The camera fails to start video streaming after having been autosuspend.
Add a new quirk to selectively disable autosuspend for devices that
don't support it.
Signed-off-by:
This patch encloses all symbols depending on USB_XHCI_HCD within an if
USB_XHCI_HCD / endif block.
Acked-by: Alan Stern st...@rowland.harvard.edu
Signed-off-by: Florian Fainelli flor...@openwrt.org
---
Changes in v3:
- added Alan's Acked-by tag
drivers/usb/host/Kconfig |6 --
1 file
These 5 patches contain my Kconfig cleanup on which I based the removal
of the USB_ARCH_HAS_* patches. They have been suggested by Alan Stern
as part of an earlier conversations.
Let me know what you think about it so I can post subsequent work based
on it.
Thanks! Fainelli (5):
USB: regroup
This patch removes the depends on USB from all config symbols in
drivers/usb/host/Kconfig and replace that with an if USB / endif block
as suggested by Alan Stern. Some source ... Kconfig lines have been
shuffled around to permit a better regroupment of the Kconfig files
depending on config USB
Just like the OHCI counter part we just can remove the architecture
specific symbols which prevent these configuration symbols from being
selected by platforms/architectures requiring it. The original
implementation did not scale at all since it required each and every
single architecture to be
Thist patch removes the depends on USB_EHCI_HCD that the various USB
EHCI HCD drivers use and encloses every driver within an if USB_EHCI_HCD
/ endif block. The EHCI HCD platform and Octeon drivers have been moved
around to remain enclosed within this block.
Signed-off-by: Florian Fainelli
This patch removes the various depends on USB_OHCI_HCD from the OHCI HCD
drivers and enclose them within an if USB_OHCI_HCD / endif block. The
Octeon OHCI HCD driver has been moved around to remain in this block.
Acked-by: Alan Stern st...@rowland.harvard.edu
Signed-off-by: Florian Fainelli
Hi Sergio,
Thanks for catching this! However, the inline comment is a bit much for
a simple NULL pointer check. Can you remove the comment and resubmit
this patch?
Thanks,
Sarah Sharp
On Wed, Apr 03, 2013 at 03:52:07PM -0700, Sergio Aguirre wrote:
It is possible that we fail on
* Rajendra Nayak rna...@ti.com [130403 22:25]:
On Thursday 04 April 2013 05:12 AM, Tony Lindgren wrote:
How about just add a minimal drivers/clk/omap/clk-xyz.c that takes
the configuration from DT and is based on the binding we already have in
On Thu, Apr 04, 2013 at 01:02:45PM +0530, Vivek Gautam wrote:
On Thu, Apr 4, 2013 at 12:40 PM, Felipe Balbi ba...@ti.com wrote:
On Thu, Apr 04, 2013 at 10:34:57AM +0530, Vivek Gautam wrote:
Hi Sarah,
On Wed, Apr 3, 2013 at 10:57 PM, Sarah Sharp
sarah.a.sh...@linux.intel.com wrote:
* Roger Quadros rog...@ti.com [130404 00:39]:
On 04/04/2013 02:42 AM, Tony Lindgren wrote:
--- a/arch/arm/mach-omap2/cclock44xx_data.c
+++ b/arch/arm/mach-omap2/cclock44xx_data.c
@@ -27,6 +27,7 @@
#include linux/clk-private.h
#include linux/clkdev.h
#include linux/io.h
+#include
Commits
9574323 xHCI: test USB2 software LPM
b92cc66 xHCI: add aborting command ring function
introduce useful functions which involves lists manipulations.
If for whatever reason we fall into fail path in xhci_mem_init() we
may access the lists in xhci_mem_cleanup() before they
Hi,
On Thu, Apr 04, 2013 at 04:52:15PM +0200, Laurent Pinchart wrote:
Laurent/Ming Lei
Since the uvc_video_complete() callback handler called from interrupt
context, video post processing or memcpy can be deferred to tasklet or
bottom half, rather than doing it in interrupt context.
-Original Message-
From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com]
Sent: Thursday, April 04, 2013 9:33 AM
To: Aguirre Rodriguez, Sergio A
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] xhci: prevent from potential null pointer dereference
on failed init
Hi Sergio,
It is possible that we fail on xhci_mem_init, just before doing
the INIT_LIST_HEAD, and calling xhci_mem_cleanup.
Problem is that, the list_for_each_entry_safe macro, dereferences next
assuming is not NULL (which is the case for a uninitialized list).
Let's protect from that.
Signed-off-by:
Hi Sergio,
On 04/04/2013 09:57 AM, Sergio Aguirre wrote:
It is possible that we fail on xhci_mem_init, just before doing
the INIT_LIST_HEAD, and calling xhci_mem_cleanup.
Problem is that, the list_for_each_entry_safe macro, dereferences next
assuming is not NULL (which is the case for a
On Thursday 04 April 2013 19:49:26 Felipe Balbi wrote:
On Thu, Apr 04, 2013 at 04:52:15PM +0200, Laurent Pinchart wrote:
Laurent/Ming Lei
Since the uvc_video_complete() callback handler called from
interrupt
context, video post processing or memcpy can be deferred to
Sarah Sharp sarah.a.sh...@linux.intel.com writes:
Thanks for catching this! However, the inline comment is a bit much for
a simple NULL pointer check. Can you remove the comment and resubmit
this patch?
And maybe handle failure to initialize cancel_cmd_list as well? It has
the same problem.
On Thu, 4 Apr 2013, Florian Fainelli wrote:
These 5 patches contain my Kconfig cleanup on which I based the removal
of the USB_ARCH_HAS_* patches. They have been suggested by Alan Stern
as part of an earlier conversations.
Let me know what you think about it so I can post subsequent work
-Original Message-
From: Bjørn Mork [mailto:bj...@mork.no]
Sent: Thursday, April 04, 2013 10:01 AM
To: Sarah Sharp
Cc: Aguirre Rodriguez, Sergio A; linux-usb@vger.kernel.org
Subject: Re: [PATCH] xhci: prevent from potential null pointer dereference
on failed init
Sarah Sharp
Hi,
On Thu, Apr 04, 2013 at 05:57:24PM +0200, Florian Fainelli wrote:
diff --git a/drivers/usb/misc/sisusbvga/Kconfig
b/drivers/usb/misc/sisusbvga/Kconfig
index 30ea7ca..0d03a52 100644
--- a/drivers/usb/misc/sisusbvga/Kconfig
+++ b/drivers/usb/misc/sisusbvga/Kconfig
@@ -1,7 +1,7 @@
Hi David,
Thanks for the review.
-Original Message-
From: Cohen, David A
Sent: Thursday, April 04, 2013 10:03 AM
To: Aguirre Rodriguez, Sergio A
Cc: linux-usb@vger.kernel.org; Sarah Sharp; Kanigeri, Hari K
Subject: Re: [PATCH v2] xhci: prevent from potential null pointer
It is possible that we fail on xhci_mem_init, just before doing
the INIT_LIST_HEAD, and calling xhci_mem_cleanup.
Problem is that, the list_for_each_entry_safe macro, assumes
list heads are initialized (not NULL), and dereferences their 'next'
pointer, causing a kernel panic if this is not yet
Hi Sergio,
On 04/04/2013 10:32 AM, Sergio Aguirre wrote:
It is possible that we fail on xhci_mem_init, just before doing
the INIT_LIST_HEAD, and calling xhci_mem_cleanup.
Problem is that, the list_for_each_entry_safe macro, assumes
list heads are initialized (not NULL), and dereferences their
On Thu, 4 Apr 2013, Yegor Yefremov wrote:
I reworked my test script, so that I can tell timeout from wrong
string. I have two cases now. On my am335x based system I get timeout
with 3.2 kernel and errors like here
(http://www.newit.co.uk/forum/index.php?topic=313.0) for 3.8.
On x86 I get
On Thu, 4 Apr 2013, Felipe Balbi wrote:
Hi,
On Thu, Apr 04, 2013 at 05:57:24PM +0200, Florian Fainelli wrote:
diff --git a/drivers/usb/misc/sisusbvga/Kconfig
b/drivers/usb/misc/sisusbvga/Kconfig
index 30ea7ca..0d03a52 100644
--- a/drivers/usb/misc/sisusbvga/Kconfig
+++
On 04/04/2013 07:01 AM, Venu Byravarasu wrote:
-Original Message-
From: Stephen Warren [mailto:swar...@wwwdotorg.org]
Sent: Thursday, April 04, 2013 12:47 AM
To: Venu Byravarasu
Cc: gre...@linuxfoundation.org; ba...@ti.com;
st...@rowland.harvard.edu; linux-te...@vger.kernel.org;
Hi,
On Thu, Apr 04, 2013 at 01:42:18PM -0400, Alan Stern wrote:
diff --git a/drivers/usb/misc/sisusbvga/Kconfig
b/drivers/usb/misc/sisusbvga/Kconfig
index 30ea7ca..0d03a52 100644
--- a/drivers/usb/misc/sisusbvga/Kconfig
+++ b/drivers/usb/misc/sisusbvga/Kconfig
@@ -1,7 +1,7 @@
On Thu, Apr 04, 2013 at 04:13:20PM +0200, Stefan Tauner wrote:
Hi,
I discovered that the optional strings and their indices of interface
descriptors are not exported in debugfs when I was looking at usbview's
source (https://github.com/gregkh/usbview/issues/5).
I am not sure yet if they
On 2013.04.04 09:27, nico wrote:
Making all in libusb
CC libusb_1_0_la-core.lo
core.c:1755:30: warning: use of logical '' with constant operand
Thanks for the report, and the test.
This is now fixed in RC3, along with a couple minor issues.
The new RC is available from:
On 04/04/13 00:22, Stephen Rothwell wrote:
Hi all,
Changes since 20130403:
on x86_64, when CONFIG_BUG is not enabled:
CC [M] drivers/usb/gadget/configfs.o
drivers/usb/gadget/configfs.c: In function 'config_usb_cfg_unlink':
drivers/usb/gadget/configfs.c:442:2: error: implicit
This one could probably have been broken into separate patches.
+ if (buf[0] == 'P' buf[1] == 'H' buf[2] == 'Y'
+ buf[3] == 'S' buf[4] == 'D'
+ buf[5] == 'E' buf[6] == 'S' /*isspace(buf[7])*/
+ buf[7] == ' ') {
Hi,
merci beaucoup to everyone for your work...
Le 04/04/13 20:35, Pete Batard a écrit :
On 2013.04.04 09:27, nico wrote:
Making all in libusb
CC libusb_1_0_la-core.lo
core.c:1755:30: warning: use of logical '' with constant operand
Thanks for the report, and the test.
This is now
On Thu, Apr 04, 2013 at 04:03:04PM +0200, Stefan Reif wrote:
+ switch (status) {
+ case -ENOENT:
+ /* fall through */
+ case -ECONNRESET:
If two case statements are right next to each other then they don't
need a fall through comment.
On Thu, Apr 04, 2013 at 10:10:10PM +0300, Dan Carpenter wrote:
+ if (buf[0] == 'P' buf[1] == 'H' buf[2] == 'Y'
+ buf[3] == 'S' buf[4] == 'D'
+ buf[5] == 'E' buf[6] == 'S' /*isspace(buf[7])*/
+ buf[7] == ' ') {
Someone else is already working on a patch to fix part of this:
http://marc.info/?l=linux-usbm=136509667003716w=2
Please coordinate with them.
Also, two people trying to solve the same simple bug and using almost
exactly the same commit messages seems like too much of a coincidence.
Are you
On Thu, Apr 04, 2013 at 10:32:13AM -0700, Sergio Aguirre wrote:
+ INIT_LIST_HEAD(xhci-lpm_failed_devs);
+ INIT_LIST_HEAD(xhci-cancel_cmd_list);
+
page_size = xhci_readl(xhci, xhci-op_regs-page_size);
xhci_dbg(xhci, Supported page size register = 0x%x\n, page_size);
On Thursday 04 April 2013, Felipe Balbi wrote:
On Thu, Apr 04, 2013 at 01:42:18PM -0400, Alan Stern wrote:
diff --git a/drivers/usb/misc/sisusbvga/Kconfig
b/drivers/usb/misc/sisusbvga/Kconfig
index 30ea7ca..0d03a52 100644
--- a/drivers/usb/misc/sisusbvga/Kconfig
+++
On 04/04/2013 12:31 PM, Sarah Sharp wrote:
On Thu, Apr 04, 2013 at 10:32:13AM -0700, Sergio Aguirre wrote:
+ INIT_LIST_HEAD(xhci-lpm_failed_devs);
+ INIT_LIST_HEAD(xhci-cancel_cmd_list);
+
page_size = xhci_readl(xhci, xhci-op_regs-page_size);
xhci_dbg(xhci, Supported
With the hcd is now a direct member of struct musb, we can now simply
eliminate the musb_to_hcd() macro. There aren't that many users left
anyway, as some where already fixed up when parts were factored out to
musb_host.c
Signed-off-by: Daniel Mack zon...@gmail.com
---
Initialize the host and gagdet subsystems of the musb driver only when
the appropriate mode is selected from platform data, or device-tree
information, respectively.
Refuse to start the gadget part if the port is in host-only mode.
Signed-off-by: Daniel Mack zon...@gmail.com
---
This makes building the actual object files optional to the selected
mode, which saves users who know which kind of USB mode support they
need some binary size.
Unimplemented functions are stubbed out with static inline functions.
Signed-off-by: Daniel Mack zon...@gmail.com
---
Hi all,
here are some patches to separate the HCD and gadget part of the musb
driver so they can be deselected in Kconfig. They also make the driver
keep track of the configured port mode that is set from DT, so the
actual runtime configuration can be selected dynamically.
One thing that is
Let the function declarations live in the header file the belong to,
which makes it cleaner when they're stubbed out later.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/musb/musb_core.h | 17 -
drivers/usb/musb/musb_gadget.h | 17 +++--
The musb struct is currently allocated along with the hcd, which makes
it difficult to build a driver that only acts as gadget device.
Fix this by allocation musb directly, and keep the hcd around as pointer.
struct hc_driver musb_hc_driver can now also be static to musb_host.c,
and the macro
The functionality meant to be represented by this symbol will be
re-added later, but for now, USB_GADGET_MUSB_HDRC is in fact unused and
can be dropped.
Signed-off-by: Daniel Mack zon...@gmail.com
---
drivers/usb/gadget/Kconfig | 8
1 file changed, 8 deletions(-)
diff --git
On Thu, Apr 04, 2013 at 12:50:03PM -0700, David Cohen wrote:
On 04/04/2013 12:31 PM, Sarah Sharp wrote:
On Thu, Apr 04, 2013 at 10:32:13AM -0700, Sergio Aguirre wrote:
+ INIT_LIST_HEAD(xhci-lpm_failed_devs);
+ INIT_LIST_HEAD(xhci-cancel_cmd_list);
+
page_size = xhci_readl(xhci,
tty_port_tty_get might return a tty which is NULL. But it is
dereferenced unconditionally in edge_send. Stop dereferencing that by
sending usb_serial_port pointer around.
Signed-off-by: Jiri Slaby jsl...@suse.cz
Cc: Johan Hovold jhov...@gmail.com
Cc: linux-usb@vger.kernel.org
---
1 - 100 of 121 matches
Mail list logo
