Hi ,
please notice blow./
On Tuesday, October 29, 2013 09:06 AM, Chris Ruehl wrote:
Hi,
when tried to activate the USB-OTG or USBH2 with the FDT the system oops
[ 1.034403] ehci-mxc: Freescale On-Chip EHCI Host driver
[ 1.041158] Unable to handle kernel NULL pointer dereference at
virtual
The tx/rx would access the memory which is out of the desired range.
Modify the method of checking the end of the memory to avoid it.
Signed-off-by: Hayes Wang hayesw...@realtek.com
---
drivers/net/usb/r8152.c | 30 +-
1 file changed, 17 insertions(+), 13 deletions(-)
Correct some declaration.
Signed-off-by: Hayes Wang hayesw...@realtek.com
---
drivers/net/usb/r8152.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 1647931..b92b7f4 100644
---
These could fix some driver issues.
Hayes Wang (3):
r8152: fix tx/rx memory overflow
r8152: modify the tx flow
r8152: fix incorrect type in assignment
drivers/net/usb/r8152.c | 100 +---
1 file changed, 36 insertions(+), 64 deletions(-)
--
Let rtl8152_start_xmit() to queue packet only, and tx_bottom() would
send all of the packets. This simplify the code and make sure all the
packet would be sent by the original order.
Support stopping and waking tx queue. The maximum tx queue length
is 60.
Signed-off-by: Hayes Wang
Du, ChangbinX changbinx...@intel.com writes:
From: Du, Changbin changbinx...@intel.com
In cdc_ncm_bind() function, it call cdc_ncm_bind_common() to setup usb.
But cdc_ncm_bind_common() may meet error and cause usbnet_disconnect()
be called which calls free_netdev(net).
I am sure you are
Greg Suarez gpsuarez2...@gmail.com writes:
Some MBIM devices send back-to-back USB_CDC_NOTIFY_RESPONSE_AVAILABLE
notifications
when sending a message over multiple fragments or when there are unsolicited
messages available.
Count up the number of USB_CDC_NOTIFY_RESPONSE_AVAILABLE
The only notification supported by the Device Management class is
Response Available. But this driver is also used as a subdriver of
other CDC classes, allowing notifications like Speed Change and
Network Connection. This results in log messages which are only
confusing to an end user:
On Mon, Oct 28, 2013 at 07:50:44PM +0100, Frank Schäfer wrote:
Mika Westerberg has reported that the fixed+improved divisor based baud rate
encoding method doesn't work anymore with his HXD device.
So until we've found out what's going on, reintroduce the old encoding
algorithm
and use it
On Tue, 2013-10-29 at 09:52 +0100, Bjørn Mork wrote:
The only notification supported by the Device Management class is
Response Available. But this driver is also used as a subdriver of
other CDC classes, allowing notifications like Speed Change and
Network Connection. This results in log
Hi Chris,
On Tue, Oct 29, 2013 at 5:15 AM, Chris Ruehl chris.ru...@gtsys.com.hk wrote:
Fabio was right, the imx27 uses the ChipIdea for its USB my dts config was
wrong.
More accurate settings for the OTG and H2 are:
usbotg: usb@10024000 {
compatible = fsl,imx27-usb;
reg = 0x10024000
Oliver Neukum oneu...@suse.de writes:
On Tue, 2013-10-29 at 09:52 +0100, Bjørn Mork wrote:
The only notification supported by the Device Management class is
Response Available. But this driver is also used as a subdriver of
other CDC classes, allowing notifications like Speed Change and
Hi Laurent-san,
(2013/10/29 7:49), Laurent Pinchart wrote:
Turn clk_enable() and clk_disable() calls into clk_prepare_enable() and
clk_disable_unprepare() to get ready for the migration to the common
clock framework.
Cc: Felipe Balbi ba...@ti.com
Cc: linux-usb@vger.kernel.org
Hi Laurent-san,
(2013/10/29 7:49), Laurent Pinchart wrote:
Turn clk_enable() and clk_disable() calls into clk_prepare_enable() and
clk_disable_unprepare() to get ready for the migration to the common
clock framework.
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Cc: Yoshihiro Shimoda
Hi,
On Monday 28 October 2013 07:22 PM, Kamil Debski wrote:
Hi Kishon,
Thank you for your review! I will answer your comments below.
From: Kishon Vijay Abraham I [mailto:kis...@ti.com]
Sent: Friday, October 25, 2013 5:40 PM
Hi,
On Friday 25 October 2013 07:45 PM, Kamil Debski wrote:
Hi Fabio,
On Tuesday, October 29, 2013 05:32 PM, Fabio Estevam wrote:
Hi Chris,
On Tue, Oct 29, 2013 at 5:15 AM, Chris Ruehl chris.ru...@gtsys.com.hk wrote:
Fabio was right, the imx27 uses the ChipIdea for its USB my dts config was
wrong.
More accurate settings for the OTG and H2 are:
Hi,
From: Kishon Vijay Abraham I [mailto:kis...@ti.com]
Sent: Tuesday, October 29, 2013 10:55 AM
Hi,
On Monday 28 October 2013 08:11 PM, Vivek Gautam wrote:
Hi Kishon,
On Fri, Oct 25, 2013 at 9:13 PM, Kishon Vijay Abraham I
kis...@ti.com wrote:
Hi,
On Friday 25 October 2013
Hi,
From: Tomasz Figa [mailto:tomasz.f...@gmail.com]
Sent: Monday, October 28, 2013 9:00 PM
Hi Kamil,
On Monday 28 of October 2013 14:52:19 Kamil Debski wrote:
Hi Kishon,
Thank you for your review! I will answer your comments below.
[snip]
+
+ switch (drv-cfg-cpu) {
Hi,
On Tuesday 29 October 2013 03:44 PM, Kamil Debski wrote:
Hi,
From: Kishon Vijay Abraham I [mailto:kis...@ti.com]
Sent: Tuesday, October 29, 2013 10:55 AM
Hi,
On Monday 28 October 2013 08:11 PM, Vivek Gautam wrote:
Hi Kishon,
On Fri, Oct 25, 2013 at 9:13 PM, Kishon Vijay Abraham I
Hi,
On Mon, Oct 28, 2013 at 06:12:59PM -0700, David Cohen wrote:
gadget_is_dwc3() is necessary to check whether we are running on
Desineware USB3 DRD controller.
This macro was previously removed by commit
ed9cbda63d45638b69ce62412e3a3c7b00644835 due to it wasn't needed
anymore. We're
Hi,
On Mon, Oct 28, 2013 at 06:13:00PM -0700, David Cohen wrote:
DWC3 requires buffer size to be aligned to maxpacketsize of an out
endpoint. ffs_epfile_io() needs to pad epout buffer to match above
condition if DWC3 controller is used.
This patch solves an specific situation but a more
On Mon, 28 Oct 2013, Prasad Koya wrote:
Hi
I tried resetting usb device when it gets ETIMEDOUT during get
descriptor. On second retry, I don't see timeout. Please see this
patch:
Index: linux-3.4/drivers/usb/core/hub.c
===
+/*
+ * DWC3 requires buffer size to be aligned to maxpacketsize
+ * of an out endpoint.
+ * FIXME: a more generic solution might be necessary.
+ */
see, gadget drivers shouldn't have to know about DWC3 at all. They need
to know
On Mon, 28 Oct 2013, Luke-Jr wrote:
https://bugzilla.kernel.org/show_bug.cgi?id=63961
Kernel version 3.10.15
[1774470.503558] hub 2-1.3:1.0: hub_port_status failed (err = -71)
[1774475.483021] hub 2-1.4:1.0: config failed, can't get hub status (err -110)
[1774475.483042] BUG: unable to
On Mon, 28 Oct 2013, Dan Williams wrote:
In fact, the reason for calling usb_autopm_get_interface was to prevent
the hub from being suspended while we change the port's power state.
Something like this may still be needed.
With the device model change and no longer telling the hub
We have sg_miter_* APIs for accessing scsi sg buffer, so
use them to make code clean and bug free.
Cc: Matthew Dharm mdharm-...@one-eyed-alien.net
Cc: Alan Stern st...@rowland.harvard.edu
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Signed-off-by: Ming Lei ming@canonical.com
---
sg_copy_buffer() can't meet demand for some drrivers(such usb
mass storage), so we have to use the sg_miter_* APIs to access
sg buffer, then need export sg_miter_skip() for these drivers.
The API is needed for converting to sg_miter_* APIs in USB storage
driver for accessing sg buffer.
Cc:
USB phy controls USB channels 0 and 2 which are shared between
PCI USB host controllers and USBHS/USBSS respectively.
This Initializes USB phy driver earlier because we need it
before PCI USB host controllers are initialized.
Signed-off-by: Valentine Barshak valentine.bars...@cogentembedded.com
Hi Valentine,
Thank you for the patch.
On Tuesday 29 October 2013 20:21:06 Valentine Barshak wrote:
USB phy controls USB channels 0 and 2 which are shared between
PCI USB host controllers and USBHS/USBSS respectively.
This Initializes USB phy driver earlier because we need it
before PCI
Am 29.10.2013 10:07, schrieb Mika Westerberg:
On Mon, Oct 28, 2013 at 07:50:44PM +0100, Frank Schäfer wrote:
Mika Westerberg has reported that the fixed+improved divisor based baud rate
encoding method doesn't work anymore with his HXD device.
So until we've found out what's going on,
On 10/29/2013 09:00 PM, Laurent Pinchart wrote:
Hi Valentine,
Thank you for the patch.
On Tuesday 29 October 2013 20:21:06 Valentine Barshak wrote:
USB phy controls USB channels 0 and 2 which are shared between
PCI USB host controllers and USBHS/USBSS respectively.
This Initializes USB phy
I can't see any code in xhci-ring.c that ensures that a LINK
TRB is always correctly aligned when a transfer descriptor
has a link TRB in the middle of a chain of data TRBs.
See section 4.11.7.1 of the 1.0 version of the xhci specification.
I don't think we are seeing such issues, but any code
Am 29.10.2013 18:12, schrieb Frank Schäfer:
Am 29.10.2013 10:07, schrieb Mika Westerberg:
On Mon, Oct 28, 2013 at 07:50:44PM +0100, Frank Schäfer wrote:
Mika Westerberg has reported that the fixed+improved divisor based baud
rate
encoding method doesn't work anymore with his HXD device.
So
Am Montag, 28. Oktober 2013, 09:46:30 schrieben Sie:
The patch requires v3.12
I tried it.
It hasn't crashed, but it hasn't worked too.
Two traces are attached.
Regards,
Thomas
mbim-5150-20131029-any.pcapng.7z
Description: application/7z-compressed
mbim-5150-20131029-wwan0.pcapng.7z
Thomas Schäfer tschae...@t-online.de writes:
Am Montag, 28. Oktober 2013, 09:46:30 schrieben Sie:
The patch requires v3.12
I tried it.
It hasn't crashed, but it hasn't worked too.
Then it's working a lot better than expected :-)
Two traces are attached.
Thanks. I'll take a look, but I
Thomas Schäfer tschae...@t-online.de writes:
Am Montag, 28. Oktober 2013, 09:46:30 schrieben Sie:
The patch requires v3.12
I tried it.
It hasn't crashed, but it hasn't worked too.
Two traces are attached.
OK, I see two issues:
- dropping the incoming packets was not so smart wrt
On Tue, Oct 29, 2013 at 8:05 AM, Alan Stern st...@rowland.harvard.edu wrote:
On Mon, 28 Oct 2013, Dan Williams wrote:
In fact, the reason for calling usb_autopm_get_interface was to prevent
the hub from being suspended while we change the port's power state.
Something like this may still
Due to USB controllers may have different restrictions, usb gadget layer
needs to provide a generic way to inform gadget functions to complain
with non-standard requirements.
This patch adds 'quirks' field to struct usb_gadget and the first quirk
called USB_GADGET_QUIRK_EP_OUT_ALIGNED_SIZE
Use USB_GADGET_QUIRK_EP_OUT_ALIGNED_SIZE quirk to check if buffer size
requires to be aligned to maxpacketsize of an out endpoint.
ffs_epfile_io() needs to pad epout buffer to match above condition if
quirk is found.
Signed-off-by: David Cohen david.a.co...@linux.intel.com
---
Hi,
These patches are a proposal to add gadget quirks in an immediate objective to
adapt f_fs when using DWC3 controller. But the quirk solution is generic and
can be used by other controllers to adapt gadget functions to their
non-standard restrictions.
This change is necessary to make
DWC3 requires epout to have buffer size aligned to MaxPacketSize value.
This patch adds necessary quirk for it.
Signed-off-by: David Cohen david.a.co...@linux.intel.com
---
drivers/usb/dwc3/gadget.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc3/gadget.c
From: Hayes Wang hayesw...@realtek.com
Date: Tue, 29 Oct 2013 15:56:16 +0800
Support stopping and waking tx queue. The maximum tx queue length
is 60.
What is so special about the number 60? It seems arbitrary, and if
it isn't arbitrary you haven't described why this value was choosen.
I've
From: David Cohen
Sent: Tuesday, October 29, 2013 2:53 PM
These patches are a proposal to add gadget quirks in an immediate objective to
adapt f_fs when using DWC3 controller. But the quirk solution is generic and
can be used by other controllers to adapt gadget functions to their
On Mon, Oct 28, 2013 at 11:31:33PM +0800, Huang Rui wrote:
In Test 9 of usbtest module, it is used for performing chapter 9 tests N
times.
USB2.0 Extension descriptor is one of the generic device-level capbility
descriptors which added in section 9.6.2.1 of USB 3.0 spec.
This patch adds
On Mon, Oct 28, 2013 at 11:47:53AM +0100, Marek Vasut wrote:
Dear Hector Palacios,
Dear Peter,
On 10/25/2013 08:02 AM, Peter Chen wrote:
According to Freescale imx28 Errata, ENGR119653 USB: ARM to USB
register error issue, All USB register write operations must
use the ARM SWP
On Tue, Oct 29, 2013 at 09:19:09PM +0400, Valentine wrote:
On 10/29/2013 09:00 PM, Laurent Pinchart wrote:
Hi Valentine,
Thank you for the patch.
On Tuesday 29 October 2013 20:21:06 Valentine Barshak wrote:
USB phy controls USB channels 0 and 2 which are shared between
PCI USB host
On Tue, Oct 29, 2013 at 04:54:47PM -0700, gre...@linuxfoundation.org wrote:
On Mon, Oct 28, 2013 at 11:47:53AM +0100, Marek Vasut wrote:
Dear Hector Palacios,
Dear Peter,
On 10/25/2013 08:02 AM, Peter Chen wrote:
According to Freescale imx28 Errata, ENGR119653 USB: ARM to USB
If the user chooses peripheral mode for this controller, the vbus
regulator doesn't need to get, since the host will supply the vbus,
it can save one vbus pin for other usage.
Signed-off-by: Peter Chen peter.c...@freescale.com
Tested-by: Frank Li frank...@freescale.com
---
On Tue, Oct 29, 2013 at 04:50:25PM -0700, Greg Kroah-Hartman wrote:
On Mon, Oct 28, 2013 at 11:31:33PM +0800, Huang Rui wrote:
In Test 9 of usbtest module, it is used for performing chapter 9 tests N
times.
USB2.0 Extension descriptor is one of the generic device-level capbility
From: Du, ChangbinX changbinx...@intel.com
Date: Tue, 29 Oct 2013 03:30:42 +
In cdc_ncm_bind() function, it call cdc_ncm_bind_common() to setup usb.
But cdc_ncm_bind_common() may meet error and cause usbnet_disconnect()
be called which calls free_netdev(net). Thus usbnet structure(alloced
Individual controller driver has different requirement for wakeup
setting, so move it from core to itself. In order to align with
current etting the default wakeup setting is enabled (except for
chipidea host).
Pass compile test with below commands:
make O=outout/all allmodconfig
David Miller [mailto:da...@davemloft.net]
Sent: Wednesday, October 30, 2013 5:50 AM
To: Hayeswang
Cc: net...@vger.kernel.org; nic_swsd;
linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org
Subject: Re: [PATCH net 2/3] r8152: modify the tx flow
From: Hayes Wang hayesw...@realtek.com
On Wed, Oct 30, 2013 at 08:53:42AM +0800, Peter Chen wrote:
On Tue, Oct 29, 2013 at 04:54:47PM -0700, gre...@linuxfoundation.org wrote:
On Mon, Oct 28, 2013 at 11:47:53AM +0100, Marek Vasut wrote:
Dear Hector Palacios,
Dear Peter,
On 10/25/2013 08:02 AM, Peter Chen wrote:
From: hayeswang hayesw...@realtek.com
Date: Wed, 30 Oct 2013 11:03:55 +0800
David Miller [mailto:da...@davemloft.net]
Sent: Wednesday, October 30, 2013 5:50 AM
To: Hayeswang
Cc: net...@vger.kernel.org; nic_swsd;
linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org
Subject: Re: [PATCH
Due to imx28 needs ARM swp instruction for writing, we set
CI_HDRC_IMX28_WRITE_FIX for imx28.
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/chipidea/ci_hdrc_imx.c | 32 ++--
1 files changed, 26 insertions(+), 6 deletions(-)
diff --git
According to Freescale imx28 Errata, ENGR119653 USB: ARM to USB
register error issue, All USB register write operations must
use the ARM SWP instruction. So, we implement special hw_write
and hw_test_and_clear for imx28.
Discussion for it at below:
In Test 9 of usbtest module, it is used for performing chapter 9 tests N
times. This patch adds to support getting bos descriptor test scenario for
USB 3.0.
Signed-off-by: Huang Rui ray.hu...@amd.com
Acked-by: Alan Stern st...@rowland.harvard.edu
---
drivers/usb/misc/usbtest.c | 13 +
In Test 9 of usbtest module, it is used for performing chapter 9 tests N
times.
USB2.0 Extension descriptor is one of the generic device-level capbility
descriptors which added in section 9.6.2.1 of USB 3.0 spec.
This patch adds to support getting usb2.0 extension descriptor test
scenario for
Hi all,
The following patches implement Binary Device Object Store (BOS) descriptor
set tests in section 9.6.2 of USB 3.0 SPEC. At current usbtest module, it
only supports USB 2.0 chapter 9 tests, so this updates extend the testing
scope to cover the USB 3.0 new descriptors.
Changes from v1 -
In Test 9 of usbtest module, it is used for performing chapter 9 tests N
times.
SuperSpeed USB Device Capability descriptor is one of the generic
device-level capbility descriptors which added in section 9.6.2.2 of USB
3.0 spec.
This patch adds to support getting SuperSpeed USB Device Capability
In Test 9 of usbtest module, it is used for performing chapter 9 tests N
times.
Container ID descriptor is one of the generic device-level capbility
descriptors which added in section 9.6.2.3 of USB 3.0 spec.
This patch adds to support getting Container ID descriptor test scenario
for USB 3.0.
61 matches
Mail list logo