Re: USB to Serial converter code pl2303

2014-02-21 Thread Karsten Malcher
Am 20.02.2014 19:19, schrieb Frank Schäfer: We have tested different baud rates with the PL2303HX china clones. All are working including non standard baud rates. Urgh... Karsten... don't confuse the people. :/ Yes, _your_ clones behave exactly like HX originals, but others don't. O.K. - all

Re: [PATCH v10 01/15] usb: doc: phy-mxs: Add more compatible strings

2014-02-21 Thread Mark Rutland
On Thu, Feb 20, 2014 at 05:14:30AM +, Peter Chen wrote: Add fsl,imx6q-usbphy for imx6dq and imx6dl, add fsl,imx6sl-usbphy for imx6sl. Signed-off-by: Peter Chen peter.c...@freescale.com --- Documentation/devicetree/bindings/usb/mxs-phy.txt |3 ++- 1 files changed, 2 insertions(+),

Re: [PATCH v10 04/15] usb: doc: phy-mxs: update binding for adding anatop phandle

2014-02-21 Thread Mark Rutland
On Thu, Feb 20, 2014 at 05:14:33AM +, Peter Chen wrote: Add anatop phandle which is used to access anatop registers to control PHY's power and other USB operations. Signed-off-by: Peter Chen peter.c...@freescale.com --- Documentation/devicetree/bindings/usb/mxs-phy.txt |2 ++ 1

Re: [PATCH v10 10/15] usb: phy-mxs: Add implementation of set_wakeup

2014-02-21 Thread Mark Rutland
On Thu, Feb 20, 2014 at 05:14:39AM +, Peter Chen wrote: When we need the PHY can be waken up by external signals, we can call this API. Besides, we call mxs_phy_disconnect_line at this API to close the connection between USB PHY and controller, after that, the line state from controller is

RE: [PATCH v10 01/15] usb: doc: phy-mxs: Add more compatible strings

2014-02-21 Thread Peter Chen
Required properties: -- compatible: Should be fsl,imx23-usbphy +- compatible: fsl,imx23-usbphy for imx23 and imx28, fsl,imx6q- usbphy + for imx6dq and imx6dl, fsl,imx6sl-usbphy for imx6sl Minor nit, but could we restructure this as something like the following, with each string

Re: [PATCH v10 01/15] usb: doc: phy-mxs: Add more compatible strings

2014-02-21 Thread Marc Kleine-Budde
On 02/21/2014 10:40 AM, Peter Chen wrote: Required properties: -- compatible: Should be fsl,imx23-usbphy +- compatible: fsl,imx23-usbphy for imx23 and imx28, fsl,imx6q- usbphy + for imx6dq and imx6dl, fsl,imx6sl-usbphy for imx6sl Minor nit, but could we restructure this as something

Re: [PATCH v10 04/15] usb: doc: phy-mxs: update binding for adding anatop phandle

2014-02-21 Thread Peter Chen
On Fri, Feb 21, 2014 at 09:14:44AM +, Mark Rutland wrote: On Thu, Feb 20, 2014 at 05:14:33AM +, Peter Chen wrote: Add anatop phandle which is used to access anatop registers to control PHY's power and other USB operations. Signed-off-by: Peter Chen peter.c...@freescale.com ---

Re: [PATCH v10 10/15] usb: phy-mxs: Add implementation of set_wakeup

2014-02-21 Thread Peter Chen
On Fri, Feb 21, 2014 at 09:21:27AM +, Mark Rutland wrote: On Thu, Feb 20, 2014 at 05:14:39AM +, Peter Chen wrote: When we need the PHY can be waken up by external signals, we can call this API. Besides, we call mxs_phy_disconnect_line at this API to close the connection between USB

Re: [PATCH v10 01/15] usb: doc: phy-mxs: Add more compatible strings

2014-02-21 Thread Peter Chen
On Fri, Feb 21, 2014 at 10:46:41AM +0100, Marc Kleine-Budde wrote: On 02/21/2014 10:40 AM, Peter Chen wrote: Required properties: -- compatible: Should be fsl,imx23-usbphy +- compatible: fsl,imx23-usbphy for imx23 and imx28, fsl,imx6q- usbphy + for imx6dq and imx6dl,

Re: musb - babble interrupt recovery

2014-02-21 Thread Michal Šmucr
Thank you for reply, On 21.2.2014 2:03, Felipe Balbi wrote: heh, you can drop the Mr. ;-) :-) We have another version in TI's tree (git.ti.com) which will be sent soonish for mainline. Just hashing out a few extra details. That sounds great and i didn't know about that repository. I'll

Re: musb - babble interrupt recovery

2014-02-21 Thread Roger Quadros
Hi Michal, On 02/21/2014 01:44 PM, Michal Šmucr wrote: Thank you for reply, On 21.2.2014 2:03, Felipe Balbi wrote: heh, you can drop the Mr. ;-) :-) We have another version in TI's tree (git.ti.com) which will be sent soonish for mainline. Just hashing out a few extra details. That

Re: [PATCH 1/2] usb: dwc3: core: continue probing if usb phy library returns -ENODEV/-ENXIO

2014-02-21 Thread Kishon Vijay Abraham I
Hi Roger, On Wednesday 19 February 2014 06:07 PM, Roger Quadros wrote: Hi, On 02/12/2014 11:46 AM, Kishon Vijay Abraham I wrote: On Wednesday 29 January 2014 08:17 PM, Heikki Krogerus wrote: Hi, On Tue, Jan 28, 2014 at 10:30:36AM -0600, Felipe Balbi wrote: On Tue, Jan 28, 2014 at

Re: [PATCH v10 01/15] usb: doc: phy-mxs: Add more compatible strings

2014-02-21 Thread Mark Rutland
On Fri, Feb 21, 2014 at 09:40:29AM +, Peter Chen wrote: Required properties: -- compatible: Should be fsl,imx23-usbphy +- compatible: fsl,imx23-usbphy for imx23 and imx28, fsl,imx6q- usbphy + for imx6dq and imx6dl, fsl,imx6sl-usbphy for imx6sl Minor nit, but could we

Re: [RFC/PATCH] usb/xhci: avoid kernel panic on xhci_suspend()

2014-02-21 Thread Mathias Nyman
On 01/08/2014 09:53 PM, David Cohen wrote: On Wed, Jan 08, 2014 at 10:48:06AM -0500, Alan Stern wrote: On Tue, 7 Jan 2014, Greg KH wrote: On Tue, Jan 07, 2014 at 05:44:26PM -0800, David Cohen wrote: From: jianqian jianqiang.t...@intel.com There is a possible kernel panic faced on

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Mark Rutland
On Fri, Feb 21, 2014 at 01:41:03PM +, Michal Simek wrote: Hi Mark, On 02/21/2014 01:04 PM, Mark Rutland wrote: On Thu, Feb 20, 2014 at 06:23:13PM +, Felipe Balbi wrote: Hi, On Wed, Feb 19, 2014 at 03:10:45PM +0530, Subbaraya Sundeep Bhatta wrote: This patch adds xilinx axi

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Michal Simek
If we can point to standard interrupt description then please point me to exact description you would like to see here and we can change it. Unfortunately I'm not aware of a generic interrupts document. I just don't see the point in each document listing interrupt-parent as a requiredp

Re: musb - babble interrupt recovery

2014-02-21 Thread Michal Šmucr
Hi Roger, thanks for those patches, actually i briefly approached them during my googling, but at first i didn't relate subject with Babble situation. Closely reading description about SUSPENDM bit behavior during resume makes sense. On 21.2.2014 13:03, Roger Quadros wrote: Could you

Re: [PATCH 3/7] IBM Akebono: Add support to the OHCI platform driver for PPC476GTR

2014-02-21 Thread Arnd Bergmann
On Friday 21 February 2014 17:31:29 Alistair Popple wrote: +static const struct of_device_id ohci_of_match[] = { + { .compatible = usb-ohci, }, + {}, +}; + static const struct platform_device_id ohci_platform_table[] = { { ohci-platform, 0 }, { } @@ -198,6

Re: [PATCH 4/7] ECHI Platform: Merge ppc-of EHCI driver into the ehci-platform driver

2014-02-21 Thread Arnd Bergmann
On Friday 21 February 2014 11:48:03 Mark Rutland wrote: + + np = of_find_compatible_node(NULL, NULL, ibm,usb-ohci-440epx); + if (np != NULL) { + /* claim we really affected by usb23 erratum */ + if (!of_address_to_resource(np, 0, res)) +

Re: [PATCH 5/9] usb: don't use PREPARE_DELAYED_WORK

2014-02-21 Thread Alan Stern
On Thu, 20 Feb 2014, Greg Kroah-Hartman wrote: On Thu, Feb 20, 2014 at 03:44:27PM -0500, Tejun Heo wrote: PREPARE_[DELAYED_]WORK() are being phased out. They have few users and a nasty surprise in terms of reentrancy guarantee as workqueue considers work items to be different if they

Re: [PATCH 5/9] usb: don't use PREPARE_DELAYED_WORK

2014-02-21 Thread Tejun Heo
On Fri, Feb 21, 2014 at 10:06:05AM -0500, Alan Stern wrote: I think it should be fine to use INIT_DELAYED_WORK(), but Alan would know best. Alan? That's right; INIT_DELAYED_WORK() should be fine. Provided there's no problem doing it from within the previous work routine. Yeah, that's

Re: Warning from USC core on kernel 3.13

2014-02-21 Thread Alan Stern
On Thu, 20 Feb 2014, Larry Finger wrote: Alan, The Lenovo Yogi 13 tablet comes with a Realtek RTL8723AU wireless device built in. Realtek sent me a driver that I modified so that it would build on new kernels, and created a GitHub repo so that it would be available to the community.

Re: usb audio breaks ohci-pci

2014-02-21 Thread Alan Stern
On Thu, 20 Feb 2014, Dennis New wrote: Anyway, I finally got around to writing a diagnostic patch for you to try. This should be applied with no other patches present. It requires CONFIG_USB_DEBUG to be enabled, and it should add a fair amount of debugging information to the dmesg

Re: [PATCH 3/7] IBM Akebono: Add support to the OHCI platform driver for PPC476GTR

2014-02-21 Thread Alan Stern
On Fri, 21 Feb 2014, Alistair Popple wrote: The IBM Akebono board uses the PPC476GTR SoC which has a OHCI compliant USB host interface. This patch adds support for it to the OHCI platform driver. As we use device tree to pass platform specific data instead of platform data we remove the

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Felipe Balbi
Hi, On Fri, Feb 21, 2014 at 11:27:07AM +, Subbaraya Sundeep Bhatta wrote: From the looks of it, I doubt this was actually tested, you need a lot of work on this driver. Tested on both ARM and Microblaze architectures with Mass storage gadget. Will send a v2 after addressing all your

Re: [PATCH 4/7] ECHI Platform: Merge ppc-of EHCI driver into the ehci-platform driver

2014-02-21 Thread Alan Stern
On Fri, 21 Feb 2014, Alistair Popple wrote: Currently the ppc-of driver uses the compatibility string usb-ehci. This means platforms that use device-tree and implement an EHCI compatible interface have to either use the ppc-of driver or add a compatible line to the ehci-platform driver. It

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Felipe Balbi
Hi, On Fri, Feb 21, 2014 at 12:04:54PM +, Mark Rutland wrote: +Example: + axi-usb2-device@42e0 { +compatible = xlnx,axi-usb2-device-4.00.a; +interrupt-parent = 0x1; +interrupts = 0x0

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Felipe Balbi
Hi, On Fri, Feb 21, 2014 at 02:41:03PM +0100, Michal Simek wrote: + /* Map the registers */ + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + udc-base_address = devm_ioremap_nocache(pdev-dev, res-start, + resource_size(res)); use

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Michal Simek
On 02/21/2014 04:42 PM, Felipe Balbi wrote: Hi, On Fri, Feb 21, 2014 at 02:41:03PM +0100, Michal Simek wrote: + /* Map the registers */ + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + udc-base_address = devm_ioremap_nocache(pdev-dev, res-start, +

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Felipe Balbi
On Fri, Feb 21, 2014 at 04:51:07PM +0100, Michal Simek wrote: On 02/21/2014 04:42 PM, Felipe Balbi wrote: Hi, On Fri, Feb 21, 2014 at 02:41:03PM +0100, Michal Simek wrote: + /* Map the registers */ + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); +

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Mark Rutland
On Fri, Feb 21, 2014 at 03:41:03PM +, Felipe Balbi wrote: Hi, On Fri, Feb 21, 2014 at 12:04:54PM +, Mark Rutland wrote: +Example: + axi-usb2-device@42e0 { +compatible = xlnx,axi-usb2-device-4.00.a; +

SPDX-License-Identifier (was: Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support)

2014-02-21 Thread Felipe Balbi
On Fri, Feb 21, 2014 at 05:04:26PM +0100, Michal Simek wrote: On 02/21/2014 05:04 PM, Greg Kroah-Hartman wrote: On Fri, Feb 21, 2014 at 07:38:16AM +0100, Michal Simek wrote: BTW: u-boot started to use SPDX-License-Identifier which will be nice to start to use. I agree, feel free to

Re: SPDX-License-Identifier

2014-02-21 Thread Michal Simek
On 02/21/2014 05:12 PM, Felipe Balbi wrote: On Fri, Feb 21, 2014 at 05:04:26PM +0100, Michal Simek wrote: On 02/21/2014 05:04 PM, Greg Kroah-Hartman wrote: On Fri, Feb 21, 2014 at 07:38:16AM +0100, Michal Simek wrote: BTW: u-boot started to use SPDX-License-Identifier which will be nice to

Re: SPDX-License-Identifier

2014-02-21 Thread Felipe Balbi
Hi, On Fri, Feb 21, 2014 at 05:18:39PM +0100, Michal Simek wrote: On 02/21/2014 05:12 PM, Felipe Balbi wrote: On Fri, Feb 21, 2014 at 05:04:26PM +0100, Michal Simek wrote: On 02/21/2014 05:04 PM, Greg Kroah-Hartman wrote: On Fri, Feb 21, 2014 at 07:38:16AM +0100, Michal Simek wrote: BTW:

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Arnd Bergmann
On Friday 21 February 2014 16:51:07 Michal Simek wrote: | | if (res-flags IORESOURCE_CACHEABLE) | dest_ptr = devm_ioremap(dev, res-start, size); | else | dest_ptr = devm_ioremap_nocache(dev, res-start, size); I have read it just not sure if

Re: [PATCH RFC] usb: gadget: Add xilinx axi usb2 device support

2014-02-21 Thread Greg Kroah-Hartman
On Fri, Feb 21, 2014 at 05:04:26PM +0100, Michal Simek wrote: On 02/21/2014 05:04 PM, Greg Kroah-Hartman wrote: On Fri, Feb 21, 2014 at 07:38:16AM +0100, Michal Simek wrote: BTW: u-boot started to use SPDX-License-Identifier which will be nice to start to use. I agree, feel free to

Re: SPDX-License-Identifier

2014-02-21 Thread Michal Simek
On 02/21/2014 05:56 PM, Greg Kroah-Hartman wrote: On Fri, Feb 21, 2014 at 10:20:45AM -0600, Felipe Balbi wrote: Hi, On Fri, Feb 21, 2014 at 05:18:39PM +0100, Michal Simek wrote: On 02/21/2014 05:12 PM, Felipe Balbi wrote: On Fri, Feb 21, 2014 at 05:04:26PM +0100, Michal Simek wrote: On

Re: [RFC PATCH] xhci: Prevent runtime pm from autosuspending during initialization

2014-02-21 Thread Dan Williams
On Fri, Feb 21, 2014 at 5:19 AM, Mathias Nyman mathias.ny...@linux.intel.com wrote: If autosuspend is set to zero the usb-2 roothub will try to suspend the controller before usb-3 parts are initialized. Prevent this by incrementing the usage counter before usb-2 registers its roothub.

Re: SPDX-License-Identifier

2014-02-21 Thread Theodore Ts'o
On Fri, Feb 21, 2014 at 09:57:20AM -0800, Greg Kroah-Hartman wrote: But shouldn't we at least write somewhere that it has connection to spdx.org where you can find out that licenses. Why? Are these licenses so unknown that no one knows what they are? And, as part of the

Patch to add Cressi Leonardo PID

2014-02-21 Thread Joerg Dorchain
Hello, the following patch adds an entry for the PID of a Cressi Leonardo diving computer interface to kernel 3.13.0. It is detected as FT232RL. Works with subsurface. Signed-off-by: Joerg Dorchain jo...@dorchain.net --- ftdi_sio.c.orig 2014-02-20 21:06:01.824231733 +0100 +++ ftdi_sio.c

Re: [RFC PATCH] xhci: Prevent runtime pm from autosuspending during initialization

2014-02-21 Thread Sarah Sharp
On Fri, Feb 21, 2014 at 01:57:25PM -0500, Alan Stern wrote: On Fri, 21 Feb 2014, Mathias Nyman wrote: This is how I gather it works: Round 1: add usb2 hcd usb_add_hcd() // primary usb2 hcd hcd-self.root_hub = usb_alloc_dev() hcd-driver-reset(hcd) - xhci_gen_setup()

[PATCH] usb: musb: USB_MUSB_DUAL_ROLE/USB_MUSB_GADGET should depend on HAS_DMA

2014-02-21 Thread Geert Uytterhoeven
If NO_DMA=y: drivers/built-in.o: In function `txstate': musb_gadget.c:(.text+0x35955a): undefined reference to `dma_unmap_single' musb_gadget.c:(.text+0x35957e): undefined reference to `dma_sync_single_for_cpu' drivers/built-in.o: In function `musb_g_giveback':

Re: [RFC PATCH] xhci: Prevent runtime pm from autosuspending during initialization

2014-02-21 Thread Dan Williams
On Fri, Feb 21, 2014 at 11:45 AM, Sarah Sharp sarah.a.sh...@linux.intel.com wrote: On Fri, Feb 21, 2014 at 01:57:25PM -0500, Alan Stern wrote: On Fri, 21 Feb 2014, Mathias Nyman wrote: This is how I gather it works: Round 1: add usb2 hcd usb_add_hcd() // primary usb2 hcd

Re: [RFC PATCH] xhci: Prevent runtime pm from autosuspending during initialization

2014-02-21 Thread Dan Williams
On Fri, Feb 21, 2014 at 10:45 AM, Mathias Nyman mathias.ny...@linux.intel.com wrote: @@ -4753,6 +4753,8 @@ int xhci_gen_setup(struct usb_hcd *hcd, xhci_get_quirks_t get_quirks) * companion controller. */ hcd-has_tt = 1; + /*

Re: [RFC PATCH] xhci: Prevent runtime pm from autosuspending during initialization

2014-02-21 Thread Alan Stern
On Fri, 21 Feb 2014, Sarah Sharp wrote: Why would this trigger xhci_suspend? Isn't we still running in the context of the probe routine? The controller won't be suspended until the probe call returns. Maybe it helps to look at the context of the bug report Mathias is trying to fix?

Re: [RFC PATCH] xhci: Prevent runtime pm from autosuspending during initialization

2014-02-21 Thread Alan Stern
On Fri, 21 Feb 2014, Dan Williams wrote: Round 2: add usb 3 hcd usb_add_hcd() // secondary usb3 hcd hcd-self.root_hub = usb_alloc_dev() hcd-driver-reset(hcd) - xhci_gen_setup() if(primary_hcd) // false .. else pm_runtime_put_noidle(hcd-self.controller) //

USB kernel oops

2014-02-21 Thread Nicholas Leippe
$ uname -a Linux hellcat 3.12.9-gentoo #1 SMP PREEMPT Mon Jan 27 08:32:22 MST 2014 x86_64 Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz GenuineIntel GNU/Linux distro: gentoo kernel: sys-kernel/gentoo-sources-3.12.9 oops: [531193.073318] usb 4-4.3.3: Failed to set U1 timeout to 0x0,error code -71

Re: More Info

2014-02-21 Thread Sarah Sharp
On Thu, Feb 20, 2014 at 04:02:43PM -0800, Jay S wrote: I tried yet another USB 3.0 external HDD enclosure with the 1 TB WD drive that has been the source of all these problems. This one is made by Icy Dock. It's a MB080U35-1SB, and has USB 3.0 as well as eSATA. I figured the eSATA would work

Re: [PATCH v2] storage: accept some UAS devices if streams are unavailable

2014-02-21 Thread Sarah Sharp
On Tue, Feb 11, 2014 at 08:36:04PM +0100, oli...@neukum.org wrote: From: Oliver Neukum oneu...@suse.de On some older XHCIs streams are not supported and the UAS driver will fail at probe time. For those devices storage should try to bind to UAS devices. This patch adds a flag for stream

[PATCH v5 01/16] usb: disable port power control if not supported in wHubCharacteristics

2014-02-21 Thread Dan Williams
A hub indicates whether it supports per-port power control via the wHubCharacteristics field in its descriptor. If it is not supported a hub will still emulate ClearPortPower(PORT_POWER) requests by stopping the link state machine. However, since this does not save power do not bother

[PATCH v5 02/16] usb: assign default peer ports for root hubs

2014-02-21 Thread Dan Williams
Assume that the peer of a superspeed port is the port with the same id on the shared_hcd root hub. This identification scheme is required of external hubs by the USB3 spec [1]. However, for root hubs, tier mismatch may be in effect [2]. Tier mismatch can only be enumerated via platform

[PATCH v5 03/16] usb: assign usb3 external hub port peers

2014-02-21 Thread Dan Williams
Given that root hub port peers are already established, external hub peer ports can be determined by traversing the device topology: 1/ ascend to the parent hub and find the upstream port_dev 2/ walk -peer to find the peer port 3/ descend to the peer hub via -child 4/ find the port with the

[PATCH v5 06/16] usb: defer suspension of superspeed port while peer is powered

2014-02-21 Thread Dan Williams
ClearPortFeature(PORT_POWER) on a usb3 port places the port in either a DSPORT.Powered-off-detect / DSPORT.Powered-off-reset loop, or the DSPORT.Powered-off state. There is no way to ensure that RX terminations will persist in this state, so it is possible a device will degrade to its usb2

[PATCH v5 08/16] usb: usb3 ports do not support FEAT_C_ENABLE

2014-02-21 Thread Dan Williams
The port pm_runtime implementation unconditionally clears FEAT_C_ENABLE after clearing PORT_POWER, but the bit is reserved on usb3 hub ports. We expect khubd to be prevented from running because the port state is not RPM_ACTIVE, so we need to clear any errors for usb2 ports. Signed-off-by: Dan

[PATCH v5 07/16] usb: don't clear FEAT_C_ENABLE on usb_port_runtime_resume failure

2014-02-21 Thread Dan Williams
Three reasons: 1/ It's an invalid operation on usb3 ports 2/ There's no guarantee of when / if a usb2 port has entered an error state relative to PORT_POWER request 3/ The port is active / powered at this point, so khubd will clear it as a matter of course Signed-off-by: Dan Williams

[PATCH v5 04/16] usb: find internal hub tier mismatch via acpi

2014-02-21 Thread Dan Williams
ACPI identifies peer ports by setting their 'group_token' and 'group_position' _PLD data to the same value. If a platform has tier mismatch [1] , ACPI can override the default (USB3 defined) peer port association for internal hubs. External hubs follow the default peer association scheme.

[PATCH v5 14/16] usb: documentation for usb port power off mechanisms

2014-02-21 Thread Dan Williams
From: Lan Tianyu tianyu@intel.com describe the mechanisms for controlling port power policy and discovering the port power state. Cc: Oliver Neukum oneu...@suse.de Signed-off-by: Lan Tianyu tianyu@intel.com [sarah]: wordsmithing [djbw]: updates for peer port changes Signed-off-by: Dan

[PATCH v5 12/16] usb: resume (wakeup) child device when port is powered on

2014-02-21 Thread Dan Williams
Unconditionally wake up the child device when the power session is recovered. This address the following scenarios: 1/ The device may need a reset on power-session loss, without this change port power-on recovery exposes khubd to scenarios that usb_port_resume() is set to handle. Prior to

[RFC PATCH v5 16/16] usb, xhci: flush initial hub discovery to gate port power control

2014-02-21 Thread Dan Williams
Until all root hubs have been discovered and tier mismatch identified, port power control is unreliable. When a USB3 port is paired with an incorrect peer port there is chance a connected device will downgrade its connection to its USB2 pins. The downgrade occurs when the USB3 port is powered

[PATCH v5 05/16] usb: sysfs link peer ports

2014-02-21 Thread Dan Williams
The usb topology after this change will have symlinks between usb3 ports and their usb2 peers, for example: usb2/2-1/2-1:1.0/port1/peer = ../../../../usb3/3-1/3-1:1.0/port1 usb2/2-1/2-1:1.0/port2/peer = ../../../../usb3/3-1/3-1:1.0/port2 usb2/2-1/2-1:1.0/port3/peer =

[PATCH v5 09/16] usb: refactor port handling in hub_events()

2014-02-21 Thread Dan Williams
In preparation for synchronizing port handling with pm_runtime transitions refactor port handling into its own subroutine. We expect that clearing some status flags will be required regardless of the port state, so handle those first and group all non-trivial actions at the bottom of the routine.

[PATCH v5 00/16] port power control rework

2014-02-21 Thread Dan Williams
Toggling port power currently leads to three unintended disconnect scenarios that are addressed by this rework of port power recovery and usb device resume: 1/ Superspeed devices downgrade to their hispeed connection when rx-detection fails on the superspeed pins. Address this by preventing

[PATCH v5 10/16] usb: synchronize port poweroff and khubd

2014-02-21 Thread Dan Williams
If a port is powered-off, or in the process of being powered-off, prevent khubd from operating on it. Otherwise, the following sequence of events leading to an unintended disconnect may occur: Events: (0) set pm_qos_no_poweroff to '0' for port1 (1) hub 2-2:1.0: hub_resume (2) hub 2-2:1.0: port

[PATCH v5 15/16] usb: convert khubd to a workqueue

2014-02-21 Thread Dan Williams
Both a cleanup, as khubd open codes several facilities that are provided by workqueue, and an enabling step for flushing initial port discovery operations. A do { } while (0) loop in hub_event() is used to minimize code thrash. Signed-off-by: Dan Williams dan.j.willi...@intel.com ---

[PATCH v5 13/16] usb: force warm reset to break link re-connect livelock

2014-02-21 Thread Dan Williams
Resuming a powered down port sometimes results in the port state being stuck in the training sequence. hub 3-0:1.0: debounce: port 1: total 2000ms stable 0ms status 0x2e0 port1: can't get reconnection after setting port power on, status -110 hub 3-0:1.0: port 1 status .02e0 after resume,

[PATCH v5 11/16] usb: introduce port status lock

2014-02-21 Thread Dan Williams
In general we do not want khubd to act on port status changes that are the result of in progress resets or USB runtime PM operations. Specifically port power control testing has been able to trigger an unintended disconnect in hub_port_connect_change(), paraphrasing: if ((portstatus

[PATCH] phy-rcar-gen2-usb: always use 'dev' variable in probe() method

2014-02-21 Thread Sergei Shtylyov
The probe() method has the 'dev' local variable declared and used but strangely not in all cases where it should be... Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com --- This patch is against the 'next' branch of Felipe Balbi's 'usb.git' repo.

sisusb: Use static const, fix typo

2014-02-21 Thread Joe Perches
Reduce text a bit by using static const. Fix a symmetric typo and neaten a dev_info call to 80 columns. $ size drivers/usb/misc/sisusbvga/sisusb.o* textdata bss dec hex filename 3001648419180 44037ac05 drivers/usb/misc/sisusbvga/sisusb.o.new 300874841

Re: [PATCH 4/7] ECHI Platform: Merge ppc-of EHCI driver into the ehci-platform driver

2014-02-21 Thread Tony Prisk
On 22/02/14 00:48, Mark Rutland wrote: [Adding Tony Prisk to Cc] On Fri, Feb 21, 2014 at 06:31:30AM +, Alistair Popple wrote: Currently the ppc-of driver uses the compatibility string usb-ehci. This means platforms that use device-tree and implement an EHCI compatible interface have to

Re: USB kernel oops

2014-02-21 Thread Greg KH
On Fri, Feb 21, 2014 at 02:30:18PM -0700, Nicholas Leippe wrote: $ uname -a Linux hellcat 3.12.9-gentoo #1 SMP PREEMPT Mon Jan 27 08:32:22 MST 2014 x86_64 Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz GenuineIntel GNU/Linux distro: gentoo kernel: sys-kernel/gentoo-sources-3.12.9 oops:

[PATCH v2] u_ether: move hardware transmit to RX workqueue

2014-02-21 Thread Clanlab (Taiwan) Linux Project
In order to reduce the interrupt times in the embedded system, a receiving workqueue is introduced. This modification also enhanced the overall throughput as the benefits of reducing interrupt occurrence. Signed-off-by: Clanlab (Taiwan) Linux Project clanlab.p...@gmail.com Cc: David Brownell

Re: [PATCH v2] u_ether: move hardware transmit to RX workqueue

2014-02-21 Thread Greg Kroah-Hartman
On Sat, Feb 22, 2014 at 01:41:52PM +0800, Clanlab (Taiwan) Linux Project wrote: In order to reduce the interrupt times in the embedded system, a receiving workqueue is introduced. This modification also enhanced the overall throughput as the benefits of reducing interrupt occurrence.