Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Thierry Reding
On Mon, Aug 25, 2014 at 01:01:52PM -0600, Stephen Warren wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: [...] +static int tegra_xusb_mbox_probe(struct platform_device *pdev) +res = platform_get_resource(pdev, IORESOURCE_MEM, 0); +if (!res) +return -ENODEV;

About the reboot hang issue with EHCI driver on the Baytrail platform

2014-08-26 Thread Gavin Guo
Hi, I found that in the Baytrail-m platform if the USB3.0 Configuration in Pre-OS is set to Auto in the BIOS, the system will boot with EHCI-enabled. And test reboot 200 times. It sometimes hang in the shutdown process ehci-pci :00:1d.0: shutdown. I also found that sometimes hang in the

Re: [PATCH v2 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-08-26 Thread Mikko Perttunen
On 25/08/14 22:22, Stephen Warren wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: In addition to the PCIe and SATA PHYs, the XUSB pad controller also supports 3 UTMI, 2 HSIC, and 2 USB3 PHYs. Each USB3 PHY uses a single PCIe or SATA lane and is mapped to one of the three UTMI ports.

Re: [RFC PATCH 0/7] usb: gadget: add reset API at usb_gadget_driver

2014-08-26 Thread Peter Chen
On Mon, Aug 25, 2014 at 11:27:47AM -0400, Alan Stern wrote: On Mon, 25 Aug 2014, Peter Chen wrote: Hi Felipe Alan, It is the follow-up for: http://www.spinics.net/lists/linux-usb/msg112193.html This patchset adds reset API at usb_gadget_driver, the UDC driver can call it at

Re: [PATCH] xhci: Disable streams on Via XHCI with device-id 0x3432

2014-08-26 Thread Hans de Goede
Hi, On 08/25/2014 08:14 PM, Greg Kroah-Hartman wrote: On Mon, Aug 25, 2014 at 12:21:56PM +0200, Hans de Goede wrote: This is a bit bigger hammer then I would like to use for this, but for now it will have to make do. I'm working on getting my hands on one of these so that I can try to get

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Arnd Bergmann
On Tuesday 26 August 2014 08:57:31 Thierry Reding wrote: On Mon, Aug 25, 2014 at 01:01:52PM -0600, Stephen Warren wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: [...] +static int tegra_xusb_mbox_probe(struct platform_device *pdev) +res = platform_get_resource(pdev,

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Thierry Reding
On Tue, Aug 26, 2014 at 09:43:50AM +0200, Arnd Bergmann wrote: On Tuesday 26 August 2014 08:57:31 Thierry Reding wrote: On Mon, Aug 25, 2014 at 01:01:52PM -0600, Stephen Warren wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: [...] +static int tegra_xusb_mbox_probe(struct

Re: [PATCH v2 3/4] usb: gadget: f_uac2: send reasonably sized packets

2014-08-26 Thread Daniel Mack
On 08/25/2014 07:22 PM, Jassi Brar wrote: On Mon, Aug 25, 2014 at 9:30 PM, Daniel Mack zon...@gmail.com wrote: @@ -187,7 +189,7 @@ agdev_iso_complete(struct usb_ep *ep, struct usb_request *req) if (substream-stream == SNDRV_PCM_STREAM_PLAYBACK) { src = prm-dma_area

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Arnd Bergmann
On Tuesday 26 August 2014 09:50:25 Thierry Reding wrote: On Tue, Aug 26, 2014 at 09:43:50AM +0200, Arnd Bergmann wrote: On Tuesday 26 August 2014 08:57:31 Thierry Reding wrote: On Mon, Aug 25, 2014 at 01:01:52PM -0600, Stephen Warren wrote: On 08/18/2014 11:08 AM, Andrew Bresticker

[PATCH v3 3/4] usb: gadget: f_uac2: handle partial dma area wrap

2014-08-26 Thread Daniel Mack
With packet sizes other than 512, payloads in the packets may wrap around the ALSA dma buffer partially, which leads to memory corruption and audible clicks and pops in the audio stream at the moment, because there is no boundary check before the memcpy(). In preparation to an implementation for

[PATCH v3 0/4] usb: gadget: f_uac2: cleanups and capture timing

2014-08-26 Thread Daniel Mack
Hi, this is v3 of the f_uac2 timing fixup series. Changes from v2: * swap path 3 and 4, so that the ALSA buffer wrap around fix comes in first. It's not actually a bug fix for the current code, but more a preparation to allow for smaller packets. * use the

[PATCH v3 4/4] usb: gadget: f_uac2: send reasonably sized packets

2014-08-26 Thread Daniel Mack
The UAC2 function driver currently responds to all packets at all times with wMaxPacketSize packets. That results in way too fast audio playback as the function driver (which is in fact supposed to define the audio stream pace) delivers as fast as it can. Fix this by pre-calculating the size of

[PATCH v3 2/4] usb: gadget: f_uac2: add short-hand for 'dev'

2014-08-26 Thread Daniel Mack
In afunc_bind() and afunc_set_alt(), uac2-pdev.dev are used multiple times. Adding a short-hand for them makes lines shorter so we can remove some line wraps. No functional change. Signed-off-by: Daniel Mack zon...@gmail.com --- drivers/usb/gadget/function/f_uac2.c | 29

[PATCH v3 1/4] usb: gadget: f_uac2: restructure some code in afunc_set_alt()

2014-08-26 Thread Daniel Mack
Restructure some code to make it easier to read. While at it, return -ENOMEM instead of -EINVAL if usb_ep_alloc_request() fails, and omit the logging in such cases (the mm core will complain loud enough). Signed-off-by: Daniel Mack zon...@gmail.com --- drivers/usb/gadget/function/f_uac2.c | 39

[PATCHv4 4/6] phy: remove the old lookup method

2014-08-26 Thread Heikki Krogerus
The users of the old method are now converted to the new one. Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com Tested-by: Vivek Gautam gautam.vi...@samsung.com --- drivers/phy/phy-bcm-kona-usb2.c | 2 +- drivers/phy/phy-berlin-sata.c| 2 +- drivers/phy/phy-core.c

RE: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread David Laight
From: Thierry Reding ... Is _nocache required? I don't see other drivers using it. I assume there's nothing special about the mbox registers. Most drivers should be using devm_ioremap_resource() which will use the _nocache variant of devm_ioremap() when appropriate. Usually the region

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Thierry Reding
On Tue, Aug 26, 2014 at 10:09:25AM +0200, Arnd Bergmann wrote: On Tuesday 26 August 2014 09:50:25 Thierry Reding wrote: On Tue, Aug 26, 2014 at 09:43:50AM +0200, Arnd Bergmann wrote: On Tuesday 26 August 2014 08:57:31 Thierry Reding wrote: On Mon, Aug 25, 2014 at 01:01:52PM -0600,

Re: [PATCH 2/2] usb: chipidea: msm: Initialize PHY on reset event

2014-08-26 Thread Peter Chen
On Mon, Aug 25, 2014 at 03:26:01PM +0300, Ivan T. Ivanov wrote: Initialize USB PHY after every Link controller reset Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com --- drivers/usb/chipidea/ci_hdrc_msm.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Arnd Bergmann
On Tuesday 26 August 2014 11:08:11 Thierry Reding wrote: On Tue, Aug 26, 2014 at 10:09:25AM +0200, Arnd Bergmann wrote: On Tuesday 26 August 2014 09:50:25 Thierry Reding wrote: On Tue, Aug 26, 2014 at 09:43:50AM +0200, Arnd Bergmann wrote: On Tuesday 26 August 2014 08:57:31 Thierry

RE: RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-26 Thread David Laight
From: Alan Stern On Mon, 25 Aug 2014, Alfredo Dal Ava Junior wrote: Well, it is causing problems anyway... from user perspective, it's a Linux compatibility issue, as it works fine on Windows. I'm not an expert, but I'm wondering that if usb-storage could set capacity as UNDETERMINED/

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Arnd Bergmann
On Tuesday 26 August 2014 08:54:53 David Laight wrote: From: Thierry Reding ... Is _nocache required? I don't see other drivers using it. I assume there's nothing special about the mbox registers. Most drivers should be using devm_ioremap_resource() which will use the _nocache

Re: [PATCH v3 7/9] usb: rename transceiver and phy to usb_phy in ChipIdea

2014-08-26 Thread Peter Chen
On Fri, Aug 22, 2014 at 05:50:18PM +0200, Antoine Ténart wrote: This patch prepares the introduction of the generic PHY support in the USB ChipIdea common functions. The USB PHY member of the ChipIdea structure ('transceiver') is renamed to 'usb_phy', the 'phy' member of the ChipIdea pdata

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Thierry Reding
On Tue, Aug 26, 2014 at 11:54:43AM +0200, Arnd Bergmann wrote: On Tuesday 26 August 2014 11:08:11 Thierry Reding wrote: On Tue, Aug 26, 2014 at 10:09:25AM +0200, Arnd Bergmann wrote: On Tuesday 26 August 2014 09:50:25 Thierry Reding wrote: On Tue, Aug 26, 2014 at 09:43:50AM +0200, Arnd

Re: [PATCH v3 8/9] usb: chipidea: move usb_otg into struct ci_hdrc

2014-08-26 Thread Peter Chen
On Fri, Aug 22, 2014 at 05:50:19PM +0200, Antoine Ténart wrote: Move the usb_otg member from struct usb_phy to struct ci_hdrc. Rework its initialization taking in account this modification. If the common usb_otg and usb_phy struct still has another's pointer, you may not need to add this

RE: [RFC PATCH 19/20] xhci: v1.0 scatterlist enqueue support (td-fragment rework)

2014-08-26 Thread David Laight
From: Alan Stern On Fri, 22 Aug 2014, Dan Williams wrote: v1.0 hosts require that TD-fragments (portions of a TD that do not end on a MPB boundary) not cross a TRB segment boundary. This constraint is in addition to the constraint that a TRB may not specify a transfer that crosses a

RE: [RFC PATCH 09/20] xhci: introduce ring ops to handle event vs non-event rings

2014-08-26 Thread David Laight
From: Dan Williams It's confusing (to me at least) to keep on remembering the differences between event rings (managed by the hardware) and non-event rings managed by the host. Replace if (ring-type == FOO) branches with ring ops that are specific to the type of ring. This is a tradeoff of

Re: [PATCH v3 9/9] usb: chipidea: add support to the generic PHY framework in ChipIdea

2014-08-26 Thread Peter Chen
On Fri, Aug 22, 2014 at 05:50:20PM +0200, Antoine Ténart wrote: This patch adds support of the PHY framework for ChipIdea drivers. Changes are done in both the ChipIdea common code and in the drivers accessing the PHY. This is done by adding a new PHY member in ChipIdea's structures and by

RE: [RFC PATCH 00/20] xhci: implement xhci-v1+ td-fragment rules, test

2014-08-26 Thread David Laight
From: Dan Williams Sending as an RFC primarily to get feedback on the unit testing approach while there's still time to yell at me in person at LinuxCon. Including Rusty in pursuit of comments on how to do mocked interfaces for testing purposes in-tree. === This series updates the xhci

RE: [RFC PATCH 19/20] xhci: v1.0 scatterlist enqueue support (td-fragment rework)

2014-08-26 Thread David Laight
From: Dan Williams v1.0 hosts require that TD-fragments (portions of a TD that do not end on a MPB boundary) not cross a TRB segment boundary. This constraint is in addition to the constraint that a TRB may not specify a transfer that crosses a 64K boundary. This enabling permits the driver to

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Arnd Bergmann
On Tuesday 26 August 2014 12:20:13 Thierry Reding wrote: On Tue, Aug 26, 2014 at 11:54:43AM +0200, Arnd Bergmann wrote: I'm not sure if it's really worth it. One thing we might do is just remove all definitions of ioremap_nocache and add a wrapper to include/linux/io.h, to make it more

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-26 Thread Thierry Reding
On Tue, Aug 26, 2014 at 01:35:34PM +0200, Arnd Bergmann wrote: On Tuesday 26 August 2014 12:20:13 Thierry Reding wrote: On Tue, Aug 26, 2014 at 11:54:43AM +0200, Arnd Bergmann wrote: I'm not sure if it's really worth it. One thing we might do is just remove all definitions of

re: net: Add ops-ndo_xmit_flush()

2014-08-26 Thread Dan Carpenter
Hello David S. Miller, The patch 4798248e4e02: net: Add ops-ndo_xmit_flush() from Aug 22, 2014, leads to the following static checker warning: drivers/usb/gadget/function/f_ncm.c:1104 ncm_tx_tasklet() error: NULL dereference inside function. drivers/usb/gadget/function/f_ncm.c

Re: RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-26 Thread Oliver Neukum
On Tue, 2014-08-26 at 09:58 +, David Laight wrote: Part of the problem is that usb-storage has no way to know that anything strange is going on. It's normal for READ CAPACITY(16) to fail (this depend on the SCSI level), and it's normal for the READ CAPACITY(10) to report a value less

Re: [PATCH v3 0/4] usb: gadget: f_uac2: cleanups and capture timing

2014-08-26 Thread Sebastian Reimers
Hi, Sebastian, could you give these patches a try? They seem to work well on a BBB setup here. Patch v3 works great on BBB as well with a Audio Loop and 48kHz/16 bit. No noise or clicks. Tomorrow I have time to test other combinations (sample-/rate/size). Sebastian signature.asc

RE: RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-26 Thread David Laight
From Oliver Neukum [mailto:oneu...@suse.de] On Tue, 2014-08-26 at 09:58 +, David Laight wrote: Part of the problem is that usb-storage has no way to know that anything strange is going on. It's normal for READ CAPACITY(16) to fail (this depend on the SCSI level), and it's normal for

re: staging: usbip: bugfix for isochronous packets and optimization

2014-08-26 Thread Dan Carpenter
This was promoted out of staging and there wasn't an email to the staging list. Normally I like to go through any remaining questions before the code is moved. The code looks pretty good, I just had one question. drivers/usb/usbip/usbip_common.c:712 usbip_pad_iso() warn: why is

RES: RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-26 Thread Alfredo Dal Ava Junior
On Mon, 26 Aug 2014, David Leight wrote: I wonder what the manufacturer would saw in response the bug where windows shows the incorrect size when trying to partition the disk? I contacted enclosure manufacturer (Welland) some weeks ago, they are supposed to escalate my questions to

Re: [PATCH v2 3/4] usb: gadget: f_uac2: send reasonably sized packets

2014-08-26 Thread Alan Stern
On Tue, 26 Aug 2014, Jassi Brar wrote: Cool... we can avoid runtime calculations by maybe picking the pre-defined 'length pattern' at module load time to match the rate selected. And have those many usb requests allocated and their 'length' initialized to the pattern. Then the rest of code

Re: [PATCH v2 3/4] usb: gadget: f_uac2: send reasonably sized packets

2014-08-26 Thread Daniel Mack
On 08/26/2014 05:08 PM, Alan Stern wrote: The normal approach is to perform a simple runtime calculation (no pre-allocated pattern). It's not complex. Let S be the number of samples per second at the nominal transfer rate (for example, S = 44100). Let R be the number of packets per

Re: About the reboot hang issue with EHCI driver on the Baytrail platform

2014-08-26 Thread Alan Stern
On Tue, 26 Aug 2014, Gavin Guo wrote: Hi, I found that in the Baytrail-m platform if the USB3.0 Configuration in Pre-OS is set to Auto in the BIOS, the system will boot with EHCI-enabled. And test reboot 200 times. It sometimes hang in the shutdown process ehci-pci :00:1d.0: shutdown.

Re: [PATCH v2 3/4] usb: gadget: f_uac2: send reasonably sized packets

2014-08-26 Thread Alan Stern
On Tue, 26 Aug 2014, Daniel Mack wrote: On 08/26/2014 05:08 PM, Alan Stern wrote: The normal approach is to perform a simple runtime calculation (no pre-allocated pattern). It's not complex. Let S be the number of samples per second at the nominal transfer rate (for example, S =

[PATCH] xhci-ring: Fix Null pointer dereference

2014-08-26 Thread Ricardo Ribalda Delgado
While testing a usb gadget I managed to crash completely the host computer. This was due to a NULL pointer derefence. This patch avoids the crash although the kernel still outputs some warnings. Without this patch, kernels from (at least) 3.14 can be crashed with mass storage gadgets. Affected

[PATCH] usb: gadget: net2280: Fix invalid handling of Reset irq

2014-08-26 Thread Ricardo Ribalda Delgado
Without this patch, some hosts keeps restarting indefinitely the target. Bug added on ae8e530a7e5d87592cb23996bee7fd6f1eb202ed usb: gadget: net2280: Code Cleanup Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com --- drivers/usb/gadget/udc/net2280.c | 2 +- 1 file changed, 1

Re: [PATCH] usb: gadget: net2280: Fix invalid handling of Reset irq

2014-08-26 Thread Felipe Balbi
On Tue, Aug 26, 2014 at 05:50:12PM +0200, Ricardo Ribalda Delgado wrote: Without this patch, some hosts keeps restarting indefinitely the target. Bug added on ae8e530a7e5d87592cb23996bee7fd6f1eb202ed usb: gadget: net2280: Code Cleanup this should be just above you Signed-off-by on the form:

[PATCH v2] usb: gadget: net2280: Fix invalid handling of Reset irq

2014-08-26 Thread Ricardo Ribalda Delgado
Without this patch, some hosts keep restarting indefinitely the target. Fixes: ae8e530 (usb: gadget: net2280: Code Cleanup) Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com --- v2: Request by Felipe Balbi Use Fixes: on commit message drivers/usb/gadget/udc/net2280.c | 2 +- 1

Re: staging: usbip: bugfix for isochronous packets and optimization

2014-08-26 Thread Valentina Manea
On Tue, Aug 26, 2014 at 6:12 AM, Dan Carpenter dan.carpen...@oracle.com wrote: This was promoted out of staging and there wasn't an email to the staging list. Normally I like to go through any remaining questions before the code is moved. The code looks pretty good, I just had one question.

Re: [RFC PATCH 09/20] xhci: introduce ring ops to handle event vs non-event rings

2014-08-26 Thread Dan Williams
On Tue, Aug 26, 2014 at 3:37 AM, David Laight david.lai...@aculab.com wrote: From: Dan Williams It's confusing (to me at least) to keep on remembering the differences between event rings (managed by the hardware) and non-event rings managed by the host. Replace if (ring-type == FOO) branches

[PATCHv4 00/12] usb: dwc2: Add support for dual role

2014-08-26 Thread dinguyen
From: Dinh Nguyen dingu...@opensource.altera.com Hello, This is version 4 of the patch series that combines the dwc2 gadget and host driver into a single dual role driver. Here are the main differences from V2: - Patch 9/12 : Move spin_lock_init() earlier up in the function to guarantee no

RE: [RFC PATCH 09/20] xhci: introduce ring ops to handle event vs non-event rings

2014-08-26 Thread David Laight
From: Dan Williams [mailto:dan.j.willi...@intel.com] On Tue, Aug 26, 2014 at 3:37 AM, David Laight david.lai...@aculab.com wrote: From: Dan Williams It's confusing (to me at least) to keep on remembering the differences between event rings (managed by the hardware) and non-event rings

[PATCHv4 03/12] usb: dwc2: Update the gadget driver to use common dwc2_hsotg structure

2014-08-26 Thread dinguyen
From: Dinh Nguyen dingu...@opensource.altera.com Adds the gadget data structure and appropriate data structure pointers to the common dwc2_hsotg data structure. To keep the driver data dereference code looking clean, the gadget variable declares are only available for peripheral and dual-role

[PATCHv4 01/12] usb: dwc2: Update Kconfig to support dual-role

2014-08-26 Thread dinguyen
From: Dinh Nguyen dingu...@opensource.altera.com Update DWC2 kconfig and makefile to support dual-role mode. The platform file will always get compiled for the case where the controller is directly connected to the CPU. So for loadable modules, only dwc2.ko is needed. Signed-off-by: Dinh Nguyen

[PATCHv4 07/12] usb: dwc2: Add call_gadget functions for perpheral mode interrupts

2014-08-26 Thread dinguyen
From: Dinh Nguyen dingu...@opensource.altera.com Update the dwc2 wakeup and suspend interrupt functions to use call_gadget when the IP is in peripheral mode. Signed-off-by: Dinh Nguyen dingu...@opensource.altera.com Acked-by: Paul Zimmerman pa...@synopsys.com --- drivers/usb/dwc2/core_intr.c |

[PATCHv4 09/12] usb: dwc2: initialize the spin_lock for both host and gadget

2014-08-26 Thread dinguyen
From: Dinh Nguyen dingu...@opensource.altera.com Move spin_lock_init to common location for both host and gadget. Signed-off-by: Dinh Nguyen dingu...@opensource.altera.com --- v4: move spin_lock_init up to make sure sure no locks can be taken before the init. --- drivers/usb/dwc2/hcd.c

[PATCHv4 05/12] usb: dwc2: Initialize the USB core for peripheral mode

2014-08-26 Thread dinguyen
From: Dinh Nguyen dingu...@opensource.altera.com Initialize the USB driver to peripheral mode when a B-Device connector is attached. Signed-off-by: Dinh Nguyen dingu...@opensource.altera.com Acked-by: Paul Zimmerman pa...@synopsys.com --- drivers/usb/dwc2/hcd.c | 1 + 1 file changed, 1

[PATCHv4 10/12] usb: dwc2: Add suspend/resume for gadget

2014-08-26 Thread dinguyen
From: Dinh Nguyen dingu...@opensource.altera.com Move suspend/resume code to common platform code. Signed-off-by: Dinh Nguyen dingu...@opensource.altera.com Acked-by: Paul Zimmerman pa...@synopsys.com --- drivers/usb/dwc2/core.h | 6 ++ drivers/usb/dwc2/gadget.c | 4 ++--

[PATCHv4 12/12] usb: dwc2: pci: Update pci portion of the dwc2 driver

2014-08-26 Thread dinguyen
From: Dinh Nguyen dingu...@opensource.altera.com Initialize the spinlock here as the original spinlock in the host driver has been removed. Signed-off-by: Dinh Nguyen dingu...@opensource.altera.com --- v4: moved spin_lock_init() up to make sure no locks can be taken before the init. ---

[PATCHv4 11/12] usb: dwc2: check that the host work queue is valid

2014-08-26 Thread dinguyen
From: Dinh Nguyen dingu...@opensource.altera.com The Host workqueue will not get initialized if the driver is configured for peripheral mode only. Thus we need to check for wq_otg before calling queue_work(). Signed-off-by: Dinh Nguyen dingu...@opensource.altera.com Acked-by: Paul Zimmerman

Re: [RFC PATCH 19/20] xhci: v1.0 scatterlist enqueue support (td-fragment rework)

2014-08-26 Thread Dan Williams
On Tue, Aug 26, 2014 at 3:55 AM, David Laight david.lai...@aculab.com wrote: From: Dan Williams v1.0 hosts require that TD-fragments (portions of a TD that do not end on a MPB boundary) not cross a TRB segment boundary. This constraint is in addition to the constraint that a TRB may not

Re: [RFC PATCH 09/20] xhci: introduce ring ops to handle event vs non-event rings

2014-08-26 Thread Dan Williams
On Tue, Aug 26, 2014 at 9:21 AM, David Laight david.lai...@aculab.com wrote: From: Dan Williams [mailto:dan.j.willi...@intel.com] On Tue, Aug 26, 2014 at 3:37 AM, David Laight david.lai...@aculab.com wrote: From: Dan Williams It's confusing (to me at least) to keep on remembering the

[PATCH] sisusb: add device id for Magic Control USB video

2014-08-26 Thread Stephen Hemminger
I have a j5 create (JUA210) USB 2 video device and adding it device id to SIS USB video gets it to work. Signed-off-by: Stephen Hemminger step...@networkplumber.org --- a/drivers/usb/misc/sisusbvga/sisusb.c 2014-08-25 21:00:51.398586614 -0700 +++ b/drivers/usb/misc/sisusbvga/sisusb.c

Re: [PATCH v2 3/4] usb: gadget: f_uac2: send reasonably sized packets

2014-08-26 Thread Jassi Brar
On Tue, Aug 26, 2014 at 9:18 PM, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 26 Aug 2014, Daniel Mack wrote: On 08/26/2014 05:08 PM, Alan Stern wrote: The normal approach is to perform a simple runtime calculation (no pre-allocated pattern). It's not complex. Let S be the

[PATCHv4 04/12] usb: dwc2: Add the appropriate init calls in platform code

2014-08-26 Thread dinguyen
From: Dinh Nguyen dingu...@opensource.altera.com Add the proper init calls for either host, gadget or both in platform.c Signed-off-by: Dinh Nguyen dingu...@opensource.altera.com Acked-by: Paul Zimmerman pa...@synopsys.com --- drivers/usb/dwc2/core.h | 13 +

Re: [PATCH v2 3/4] usb: gadget: f_uac2: send reasonably sized packets

2014-08-26 Thread Jassi Brar
On Tue, Aug 26, 2014 at 10:00 PM, Jassi Brar jassisinghb...@gmail.com wrote: On Tue, Aug 26, 2014 at 9:18 PM, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 26 Aug 2014, Daniel Mack wrote: On 08/26/2014 05:08 PM, Alan Stern wrote: The normal approach is to perform a simple runtime

Re: [PATCH v3 4/4] usb: gadget: f_uac2: send reasonably sized packets

2014-08-26 Thread Jassi Brar
On Tue, Aug 26, 2014 at 1:46 PM, Daniel Mack zon...@gmail.com wrote: +static void +afunc_set_p_pktsize(struct usb_gadget *gadget, struct audio_dev *agdev) +{ + unsigned i, residue, rate, factor, interval, framesize, pktsize, len; + struct snd_uac2_chip *uac2 = agdev-uac2; +

Re: About the reboot hang issue with EHCI driver on the Baytrail platform

2014-08-26 Thread Gavin Guo
Hi Alan, On Tue, Aug 26, 2014 at 11:38 PM, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 26 Aug 2014, Gavin Guo wrote: Hi, I found that in the Baytrail-m platform if the USB3.0 Configuration in Pre-OS is set to Auto in the BIOS, the system will boot with EHCI-enabled. And test reboot

Re: [PATCH v2 3/4] usb: gadget: f_uac2: send reasonably sized packets

2014-08-26 Thread Jassi Brar
On Tue, Aug 26, 2014 at 1:38 PM, Daniel Mack dan...@zonque.org wrote: On 08/25/2014 07:22 PM, Jassi Brar wrote: On Mon, Aug 25, 2014 at 9:30 PM, Daniel Mack zon...@gmail.com wrote: @@ -187,7 +189,7 @@ agdev_iso_complete(struct usb_ep *ep, struct usb_request *req) if

Re: About the reboot hang issue with EHCI driver on the Baytrail platform

2014-08-26 Thread Alan Stern
On Wed, 27 Aug 2014, Gavin Guo wrote: And IIRC, there is only one host controller within EHCI and XHCI can be enabled in the Baytrail platform. I'm also trying to find out the kernel parameters to disable the EHCI driver, but currently there is no available one. It's not a kernel

Re: [PATCH v2 3/4] usb: gadget: f_uac2: send reasonably sized packets

2014-08-26 Thread Alan Stern
On Tue, 26 Aug 2014, Jassi Brar wrote: On Tue, Aug 26, 2014 at 10:00 PM, Jassi Brar jassisinghb...@gmail.com wrote: On Tue, Aug 26, 2014 at 9:18 PM, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 26 Aug 2014, Daniel Mack wrote: On 08/26/2014 05:08 PM, Alan Stern wrote: The

Re: [PATCH v2 3/4] usb: gadget: f_uac2: send reasonably sized packets

2014-08-26 Thread Jassi Brar
On Tue, Aug 26, 2014 at 11:07 PM, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 26 Aug 2014, Jassi Brar wrote: On Tue, Aug 26, 2014 at 10:00 PM, Jassi Brar jassisinghb...@gmail.com wrote: On Tue, Aug 26, 2014 at 9:18 PM, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 26 Aug

Fwd: Instability when using USB Video Grabber with several xHCI hubs. There is one eHCI hub where it is stable

2014-08-26 Thread Rodrigo Severo
Hi, I have been trying to set several USB Video Grabbers on a few machines. The Video Grabbers are Oner Touch Video Capture dongles from Diammond Multimedia, a Connexant device with device ID 1f4d:0102. On an old machine with Advanced Micro Devices, Inc. [AMD/ATI] SB7x0/SB8x0/SB9x0 USB EHCI

Re: staging: usbip: bugfix for isochronous packets and optimization

2014-08-26 Thread Dan Carpenter
On Tue, Aug 26, 2014 at 09:06:17AM -0700, Valentina Manea wrote: On Tue, Aug 26, 2014 at 6:12 AM, Dan Carpenter dan.carpen...@oracle.com wrote: 707 /* 708 * loop over all packets from last to first (to prevent overwritting 709 * memory when

Re: [PATCH] xhci: Disable streams on Via XHCI with device-id 0x3432

2014-08-26 Thread Greg Kroah-Hartman
On Tue, Aug 26, 2014 at 09:35:32AM +0200, Hans de Goede wrote: Hi, On 08/25/2014 08:14 PM, Greg Kroah-Hartman wrote: On Mon, Aug 25, 2014 at 12:21:56PM +0200, Hans de Goede wrote: This is a bit bigger hammer then I would like to use for this, but for now it will have to make do. I'm

Re: staging: usbip: bugfix for isochronous packets and optimization

2014-08-26 Thread Greg Kroah-Hartman
On Tue, Aug 26, 2014 at 09:06:17AM -0700, Valentina Manea wrote: On Tue, Aug 26, 2014 at 6:12 AM, Dan Carpenter dan.carpen...@oracle.com wrote: This was promoted out of staging and there wasn't an email to the staging list. Normally I like to go through any remaining questions before the

Re: staging: usbip: bugfix for isochronous packets and optimization

2014-08-26 Thread Valentina Manea
On Tue, Aug 26, 2014 at 11:47 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Tue, Aug 26, 2014 at 09:06:17AM -0700, Valentina Manea wrote: On Tue, Aug 26, 2014 at 6:12 AM, Dan Carpenter dan.carpen...@oracle.com wrote: 707 /* 708 * loop over all packets from

Problem with USB-to-SATA adapters (was: AS2105-based enclosure size issues with 2TB HDDs)

2014-08-26 Thread Dale R. Worley
This is almost certainly a form of the problem reported in AS2105-based enclosure size issues with 2TB HDDs. I'm repeating my original message here so linux-usb can see it, and so it can be connected to the older thread. I'll address it in another message. I've appended James Bottomley's

Re: Problem with USB-to-SATA adapters (was: AS2105-based enclosure size issues with 2TB HDDs)

2014-08-26 Thread James Bottomley
On Tue, 2014-08-26 at 15:39 -0400, Dale R. Worley wrote: This is almost certainly a form of the problem reported in AS2105-based enclosure size issues with 2TB HDDs. I'm repeating my original message here so linux-usb can see it, and so it can be connected to the older thread. I'll address

[PATCH] usb: xhci: Fix OOPS in xhci error handling code

2014-08-26 Thread Al Cooper
The xhci driver will OOPS on resume from S2/S3 if dma_alloc_coherent() is out of memory. This is a result of two things: 1. xhci_mem_cleanup() in xhci-mem.c free's xhci-lpm_command if it's not NULL, but doesn't set it to NULL after the free. 2. xhci_mem_cleanup() is called twice on resume, once

Re: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-08-26 Thread Felipe Balbi
Hi, On Fri, Aug 22, 2014 at 04:56:46PM -0500, Felipe Balbi wrote: diff --git a/drivers/usb/dwc3/debug.c b/drivers/usb/dwc3/debug.c new file mode 100644 index 000..6d01e0c --- /dev/null +++ b/drivers/usb/dwc3/debug.c @@ -0,0 +1,33 @@ +/** + * debug.c - DesignWare USB3

RE: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-08-26 Thread Paul Zimmerman
From: Felipe Balbi [mailto:ba...@ti.com] Sent: Tuesday, August 26, 2014 1:42 PM On Fri, Aug 22, 2014 at 04:56:46PM -0500, Felipe Balbi wrote: ... yeah, it took longer than expected (been busy lately), but here's an example trace with all trace points enabled: # tracer: nop # #

Re: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-08-26 Thread Felipe Balbi
Hi, On Tue, Aug 26, 2014 at 09:21:55PM +, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Tuesday, August 26, 2014 1:42 PM On Fri, Aug 22, 2014 at 04:56:46PM -0500, Felipe Balbi wrote: ... yeah, it took longer than expected (been busy lately), but here's

[PATCH v4 0/5] usb: gadget: f_uac2: cleanups and capture timing

2014-08-26 Thread Daniel Mack
Hi, this is v4 of the f_uac2 timing fixup series. Changes from v3: * add another patch (3/5) to introduce agdev_to_uac2_opts() which is also needed in 5/5 * patch 5/5 only: move from a pre-calculated sequence of packet lengths to an accumulator that

[PATCH v4 1/5] usb: gadget: f_uac2: restructure some code in afunc_set_alt()

2014-08-26 Thread Daniel Mack
Restructure some code to make it easier to read. While at it, return -ENOMEM instead of -EINVAL if usb_ep_alloc_request() fails, and omit the logging in such cases (the mm core will complain loud enough). Signed-off-by: Daniel Mack zon...@gmail.com --- drivers/usb/gadget/function/f_uac2.c | 39

[PATCH v4 2/5] usb: gadget: f_uac2: add short-hand for 'dev'

2014-08-26 Thread Daniel Mack
In afunc_bind() and afunc_set_alt(), uac2-pdev.dev are used multiple times. Adding a short-hand for them makes lines shorter so we can remove some line wraps. No functional change. Signed-off-by: Daniel Mack zon...@gmail.com --- drivers/usb/gadget/function/f_uac2.c | 29

[PATCH v4 3/5] usb: gadget: f_uac2: introduce agdev_to_uac2_opts

2014-08-26 Thread Daniel Mack
Add a simple container_of() wrapper to get a struct f_uac2_opts from a struct struct audio_dev. Use it in two places where it is currently open-coded. Signed-off-by: Daniel Mack zon...@gmail.com --- drivers/usb/gadget/function/f_uac2.c | 10 -- 1 file changed, 8 insertions(+), 2

[PATCH v4 5/5] usb: gadget: f_uac2: send reasonably sized packets

2014-08-26 Thread Daniel Mack
The UAC2 function driver currently responds to all packets at all times with wMaxPacketSize packets. That results in way too fast audio playback as the function driver (which is in fact supposed to define the audio stream pace) delivers as fast as it can. Fix this by sizing each packet correctly

[PATCH v4 4/5] usb: gadget: f_uac2: handle partial dma area wrap

2014-08-26 Thread Daniel Mack
With packet sizes other than 512, payloads in the packets may wrap around the ALSA dma buffer partially, which leads to memory corruption and audible clicks and pops in the audio stream at the moment, because there is no boundary check before the memcpy(). In preparation to an implementation for

Re: About the reboot hang issue with EHCI driver on the Baytrail platform

2014-08-26 Thread Gavin Guo
Hi Alan, On Wed, Aug 27, 2014 at 1:26 AM, Alan Stern st...@rowland.harvard.edu wrote: On Wed, 27 Aug 2014, Gavin Guo wrote: And IIRC, there is only one host controller within EHCI and XHCI can be enabled in the Baytrail platform. I'm also trying to find out the kernel parameters to

Re: staging: usbip: bugfix for isochronous packets and optimization

2014-08-26 Thread Dan Carpenter
Fine. Sounds good. I just wanted to make sure. regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-08-26 Thread Jingoo Han
On Thursday, August 21, 2014 11:55 PM, Vivek Gautam wrote: Adding phy calibrate callback, which facilitates setting certain PHY settings post initialization of the PHY controller. Exynos5420 and Exynos5800 have 28nm USB 3.0 DRD PHY for which the Loss-of-Signal (LOS) Detector Threshold Level

Re: [PATCH v4 5/5] usb: gadget: f_uac2: send reasonably sized packets

2014-08-26 Thread Jassi Brar
On Wed, Aug 27, 2014 at 3:23 AM, Daniel Mack zon...@gmail.com wrote: The UAC2 function driver currently responds to all packets at all times with wMaxPacketSize packets. That results in way too fast audio playback as the function driver (which is in fact supposed to define the audio stream

Re: [PATCH v3 0/4] usb: gadget: f_uac2: cleanups and capture timing

2014-08-26 Thread Xuebing Wang
On 08/26/2014 08:50 PM, Sebastian Reimers wrote: Hi, Sebastian, could you give these patches a try? They seem to work well on a BBB setup here. Patch v3 works great on BBB as well with a Audio Loop and 48kHz/16 bit. No noise or clicks. Tomorrow I have time to test other combinations