Re: [PATCH v4 5/5] usb: gadget: f_uac2: send reasonably sized packets

2014-08-27 Thread Daniel Mack
On 08/27/2014 06:08 AM, Jassi Brar wrote: On Wed, Aug 27, 2014 at 3:23 AM, Daniel Mack zon...@gmail.com wrote: + uac2-p_interval = (1 (ep_desc-bInterval - 1)) * factor; + req_len = rate / uac2-p_interval; + if (opts-p_srate % uac2-p_interval) +

Re: [PATCH v4 5/5] usb: gadget: f_uac2: send reasonably sized packets

2014-08-27 Thread Jassi Brar
On Wed, Aug 27, 2014 at 12:20 PM, Daniel Mack dan...@zonque.org wrote: On 08/27/2014 06:08 AM, Jassi Brar wrote: On Wed, Aug 27, 2014 at 3:23 AM, Daniel Mack zon...@gmail.com wrote: + uac2-p_interval = (1 (ep_desc-bInterval - 1)) * factor; + req_len = rate /

Re: [PATCH v4 5/5] usb: gadget: f_uac2: send reasonably sized packets

2014-08-27 Thread Daniel Mack
On 08/27/2014 09:07 AM, Jassi Brar wrote: On Wed, Aug 27, 2014 at 12:20 PM, Daniel Mack dan...@zonque.org wrote: Hmm? The first USB_XFERS packets will only contain zeros, and we're only preparing those here. For every successive packet, the length is recalculated and the audio material is

Re: [PATCH v4 5/5] usb: gadget: f_uac2: send reasonably sized packets

2014-08-27 Thread Daniel Mack
On 08/27/2014 09:15 AM, Daniel Mack wrote: On 08/27/2014 09:07 AM, Jassi Brar wrote: On Wed, Aug 27, 2014 at 12:20 PM, Daniel Mack dan...@zonque.org wrote: Hmm? The first USB_XFERS packets will only contain zeros, and we're only preparing those here. For every successive packet, the length

Re: [PATCH v4 5/5] usb: gadget: f_uac2: send reasonably sized packets

2014-08-27 Thread Jassi Brar
On Wed, Aug 27, 2014 at 12:45 PM, Daniel Mack dan...@zonque.org wrote: On 08/27/2014 09:07 AM, Jassi Brar wrote: On Wed, Aug 27, 2014 at 12:20 PM, Daniel Mack dan...@zonque.org wrote: Hmm? The first USB_XFERS packets will only contain zeros, and we're only preparing those here. For every

Re: [PATCH v4 5/5] usb: gadget: f_uac2: send reasonably sized packets

2014-08-27 Thread Jassi Brar
On Wed, Aug 27, 2014 at 3:23 AM, Daniel Mack zon...@gmail.com wrote: @@ -1099,11 +1139,31 @@ afunc_set_alt(struct usb_function *fn, unsigned intf, unsigned alt) prm = uac2-c_prm; config_ep_by_speed(gadget, fn, ep); agdev-as_out_alt = alt; +

Re: [PATCH v4 5/5] usb: gadget: f_uac2: send reasonably sized packets

2014-08-27 Thread Daniel Mack
On 08/27/2014 09:28 AM, Jassi Brar wrote: On Wed, Aug 27, 2014 at 12:45 PM, Daniel Mack dan...@zonque.org wrote: On 08/27/2014 09:07 AM, Jassi Brar wrote: On Wed, Aug 27, 2014 at 12:20 PM, Daniel Mack dan...@zonque.org wrote: Hmm? The first USB_XFERS packets will only contain zeros, and we're

Re: [PATCH v4 5/5] usb: gadget: f_uac2: send reasonably sized packets

2014-08-27 Thread Daniel Mack
On 08/27/2014 09:35 AM, Jassi Brar wrote: On Wed, Aug 27, 2014 at 3:23 AM, Daniel Mack zon...@gmail.com wrote: + uac2-p_residue = 0; } else { dev_err(dev, %s:%d Error!\n, __func__, __LINE__); return -EINVAL; @@ -1128,7 +1188,7 @@

[PATCH v5 0/5] usb: gadget: f_uac2: cleanups and capture timing

2014-08-27 Thread Daniel Mack
Hi, this is v4 of the f_uac2 timing fixup series. Changes from v4: * Fix buffer setup in afunc_set_alt() Changes from v3: * add another patch (3/5) to introduce agdev_to_uac2_opts() which is also needed in 5/5 * patch 5/5 only: move from a

[PATCH v5 1/5] usb: gadget: f_uac2: restructure some code in afunc_set_alt()

2014-08-27 Thread Daniel Mack
Restructure some code to make it easier to read. While at it, return -ENOMEM instead of -EINVAL if usb_ep_alloc_request() fails, and omit the logging in such cases (the mm core will complain loud enough). Signed-off-by: Daniel Mack zon...@gmail.com --- drivers/usb/gadget/function/f_uac2.c | 39

[PATCH v5 2/5] usb: gadget: f_uac2: add short-hand for 'dev'

2014-08-27 Thread Daniel Mack
In afunc_bind() and afunc_set_alt(), uac2-pdev.dev are used multiple times. Adding a short-hand for them makes lines shorter so we can remove some line wraps. No functional change. Signed-off-by: Daniel Mack zon...@gmail.com --- drivers/usb/gadget/function/f_uac2.c | 29

[PATCH v5 3/5] usb: gadget: f_uac2: introduce agdev_to_uac2_opts

2014-08-27 Thread Daniel Mack
Add a simple container_of() wrapper to get a struct f_uac2_opts from a struct struct audio_dev. Use it in two places where it is currently open-coded. Signed-off-by: Daniel Mack zon...@gmail.com --- drivers/usb/gadget/function/f_uac2.c | 10 -- 1 file changed, 8 insertions(+), 2

[PATCH v5 5/5] usb: gadget: f_uac2: send reasonably sized packets

2014-08-27 Thread Daniel Mack
The UAC2 function driver currently responds to all packets at all times with wMaxPacketSize packets. That results in way too fast audio playback as the function driver (which is in fact supposed to define the audio stream pace) delivers as fast as it can. Fix this by sizing each packet correctly

[PATCH v5 4/5] usb: gadget: f_uac2: handle partial dma area wrap

2014-08-27 Thread Daniel Mack
With packet sizes other than 512, payloads in the packets may wrap around the ALSA dma buffer partially, which leads to memory corruption and audible clicks and pops in the audio stream at the moment, because there is no boundary check before the memcpy(). In preparation to an implementation for

Re: RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-27 Thread Oliver Neukum
On Tue, 2014-08-26 at 10:47 -0400, Alan Stern wrote: On Mon, 25 Aug 2014, Oliver Neukum wrote: Just set US_FL_NEEDS_CAP16. If READ CAPACITY(16) fails in that case, it is clear that something is wrong. It must be set or READ CAPACITY(10) alone would be taken as giving a valid answer. You

[PATCH] usb: dwc3: exynos: remove usb_phy_generic support

2014-08-27 Thread Bartlomiej Zolnierkiewicz
dwc3 driver is using the new Exynos5 SoC series USB DRD PHY driver (PHY_EXYNOS5_USBDRD which selects GENERIC_PHY) as can be seen by looking at the following commits: 7a4cf0fde054 (ARM: dts: Update DWC3 usb controller to use new phy driver for exynos5250) f070267b5fc1 (ARM: dts: Enable

Re: [PATCH v5 0/5] usb: gadget: f_uac2: cleanups and capture timing

2014-08-27 Thread Jassi Brar
On Wed, Aug 27, 2014 at 1:15 PM, Daniel Mack zon...@gmail.com wrote: Hi, this is v4 of the f_uac2 timing fixup series. Changes from v4: * Fix buffer setup in afunc_set_alt() Changes from v3: * add another patch (3/5) to introduce agdev_to_uac2_opts() which is

Re: Buffer I/O error after s2ram with usb storage

2014-08-27 Thread Matthieu CASTET
Ping I have got also a problem with a usb sdcard reader (without power cut during suspend) [ 1073.606668] PM: Entering mem sleep [ 1073.606742] Suspending console(s) (use no_console_suspend to debug) [ 1073.607146] sd 1:0:0:0: [sda] Synchronizing SCSI cache [ 1073.639076] sd 1:0:0:0: [sda]

Re: [PATCH v5 0/5] usb: gadget: f_uac2: cleanups and capture timing

2014-08-27 Thread Daniel Mack
On 08/27/2014 10:38 AM, Jassi Brar wrote: On Wed, Aug 27, 2014 at 1:15 PM, Daniel Mack zon...@gmail.com wrote: Daniel Mack (5): usb: gadget: f_uac2: restructure some code in afunc_set_alt() usb: gadget: f_uac2: add short-hand for 'dev' usb: gadget: f_uac2: introduce agdev_to_uac2_opts

[PATCH] usb: gadget: use $(srctree) instead of $(PWD) for includes

2014-08-27 Thread yegorslists
From: Yegor Yefremov yegorsli...@googlemail.com Using $(PWD) breaks builds when make was invoked from outside of the kernel tree. Signed-off-by: Yegor Yefremov yegorsli...@googlemail.com --- drivers/usb/gadget/Makefile |2 +- drivers/usb/gadget/function/Makefile |4 ++--

Re: [PATCH] usb: hub: Prevent hub autosuspend if usbcore.autosuspend is -1

2014-08-27 Thread Roger Quadros
On 08/04/2014 05:07 PM, Alan Stern wrote: On Mon, 4 Aug 2014, Roger Quadros wrote: If user specifies that USB autosuspend must be disabled by module parameter usbcore.autosuspend=-1 then we must prevent autosuspend of USB hub devices as well. commit 596d789a211d introduced in v3.8 changed

Re: [PATCH] xhci: Disable streams on Via XHCI with device-id 0x3432

2014-08-27 Thread Mathias Nyman
On 08/26/2014 09:55 PM, Greg Kroah-Hartman wrote: On Tue, Aug 26, 2014 at 09:35:32AM +0200, Hans de Goede wrote: Hi, On 08/25/2014 08:14 PM, Greg Kroah-Hartman wrote: On Mon, Aug 25, 2014 at 12:21:56PM +0200, Hans de Goede wrote: This is a bit bigger hammer then I would like to use for this,

Re: [PATCH 3/3] xhci: rework cycle bit checking for new dequeue pointers

2014-08-27 Thread Mathias Nyman
On 08/21/2014 01:06 AM, Joseph Salisbury wrote: On 08/19/2014 08:17 AM, Mathias Nyman wrote: When we manually need to move the TR dequeue pointer we need to set the correct cycle bit as well. Previously we used the trb pointer from the last event received as a base, but this was changed in

[PATCH v2] usb: hub: Prevent hub autosuspend if usbcore.autosuspend is -1

2014-08-27 Thread Roger Quadros
If user specifies that USB autosuspend must be disabled by module parameter usbcore.autosuspend=-1 then we must prevent autosuspend of USB hub devices as well. commit 596d789a211d introduced in v3.8 changed the original behaivour and stopped respecting the usbcore.autosuspend parameter for hubs.

Re: [PATCH] usb: dwc3: exynos: remove usb_phy_generic support

2014-08-27 Thread Jingoo Han
On Wednesday, August 27, 2014 4:53 PM, Bartlomiej Zolnierkiewicz wrote: dwc3 driver is using the new Exynos5 SoC series USB DRD PHY driver (PHY_EXYNOS5_USBDRD which selects GENERIC_PHY) as can be seen by looking at the following commits: 7a4cf0fde054 (ARM: dts: Update DWC3 usb controller

[PATCH] usb: gadget: net2280: Remove pci_class from PCI_TABLE

2014-08-27 Thread Ricardo Ribalda Delgado
Defining the vendor and the product id should be enough to discriminate the device. The reason for this patch is that there is a missmatch betweed the modalias showed by sysfs and the modalias generated by file2alias. One expects the programming interface in uppercase and the other generates it

[PATCH v3 1/2] usb: gadget: Refactor request completion

2014-08-27 Thread Michal Sojka
All USB peripheral controller drivers called completion routines directly. This patch moves the completion call from drivers to usb_gadget_giveback_request(), in order to have a place where common functionality can be added. All places in drivers/usb/ matching [-.]complete( were replaced with a

[PATCH v3 0/2] LED triggers for USB host and device

2014-08-27 Thread Michal Sojka
This adds LED triggers for USB host and device. First patch refactors UDC drivers as requested by Felipe Balbi, second patch adds the LED triggers. Changes from v2: - host/gadget triggers merged to a single file in usb/common/ - udc drivers refactored so that LED trigger works for all of them

[PATCH v3 2/2] usb: Add LED triggers for USB activity

2014-08-27 Thread Michal Sojka
With this patch, USB activity can be signaled by blinking a LED. There are two triggers, one for activity on USB host and one for USB gadget. Both trigger should work with all host/device controllers. Tested only with musb. Signed-off-by: Michal Sojka so...@merica.cz --- drivers/usb/Kconfig

Re: Buffer I/O error after s2ram with usb storage

2014-08-27 Thread Douglas Gilbert
On 14-08-27 04:40 AM, Matthieu CASTET wrote: Ping I have got also a problem with a usb sdcard reader (without power cut during suspend) [ 1073.606668] PM: Entering mem sleep [ 1073.606742] Suspending console(s) (use no_console_suspend to debug) [ 1073.607146] sd 1:0:0:0: [sda] Synchronizing

Re: [PATCH] xhci-ring: Fix Null pointer dereference

2014-08-27 Thread Mathias Nyman
On 08/26/2014 06:47 PM, Ricardo Ribalda Delgado wrote: While testing a usb gadget I managed to crash completely the host computer. This was due to a NULL pointer derefence. This patch avoids the crash although the kernel still outputs some warnings. Without this patch, kernels from (at

Re: [PATCH] xhci-ring: Fix Null pointer dereference

2014-08-27 Thread Ricardo Ribalda Delgado
At least I have seen the issue on Debian 3.14 and 3.16. Is your patch going to be backported to linux-stable? The computer crashes very very badly On Wed, Aug 27, 2014 at 4:25 PM, Mathias Nyman mathias.ny...@intel.com wrote: On 08/26/2014 06:47 PM, Ricardo Ribalda Delgado wrote: While testing a

Re: [PATCH 3/3] xhci: rework cycle bit checking for new dequeue pointers

2014-08-27 Thread Joseph Salisbury
On 08/27/2014 07:07 AM, Mathias Nyman wrote: On 08/21/2014 01:06 AM, Joseph Salisbury wrote: On 08/19/2014 08:17 AM, Mathias Nyman wrote: When we manually need to move the TR dequeue pointer we need to set the correct cycle bit as well. Previously we used the trb pointer from the last event

Re: [PATCH v5 5/5] usb: gadget: f_uac2: send reasonably sized packets

2014-08-27 Thread Alan Stern
On Wed, 27 Aug 2014, Daniel Mack wrote: The UAC2 function driver currently responds to all packets at all times with wMaxPacketSize packets. That results in way too fast audio playback as the function driver (which is in fact supposed to define the audio stream pace) delivers as fast as it

Re: About the reboot hang issue with EHCI driver on the Baytrail platform

2014-08-27 Thread Alan Stern
On Wed, 27 Aug 2014, Gavin Guo wrote: Still, why not use the BIOS setting to disable EHCI? It's hardware enablement policy. By default, we can't change the BIOS setting to make the bug disappear until we find out the bug is due to BIOS's bug. Add kernel parameters is the temporary solution

Re: RES: RES: AS2105-based enclosure size issues with 2TB HDDs

2014-08-27 Thread Alan Stern
On Wed, 27 Aug 2014, Oliver Neukum wrote: I don't think we want to add another SCSI flag to say that READ CAPACITY(10) is unreliable. Why not? It would only be friendly to tell the upper layer of a malfunction if we know about it. To what end? What will the upper layer do with this

Re: Buffer I/O error after s2ram with usb storage

2014-08-27 Thread Alan Stern
On Wed, 27 Aug 2014, Matthieu CASTET wrote: Ping I have got also a problem with a usb sdcard reader (without power cut during suspend) The usb storage driver call scsi_report_bus_reset after device reset, but because of commit dfcf7775 4, we don't ignore unit attention if sshdr.asc

Re: Buffer I/O error after s2ram with usb storage

2014-08-27 Thread Alan Stern
On Wed, 27 Aug 2014, Douglas Gilbert wrote: The unit attention doesn't look like a problem, it looks correct. If the system is unable to detect removable media being changed while the system is suspended, then If the media has a unique identifier, then this unit attention at wakeup

Re: [PATCH v3 1/2] usb: gadget: Refactor request completion

2014-08-27 Thread Alan Stern
On Wed, 27 Aug 2014, Michal Sojka wrote: All USB peripheral controller drivers called completion routines directly. This patch moves the completion call from drivers to usb_gadget_giveback_request(), in order to have a place where common functionality can be added. All places in

Re: [PATCH] xhci-ring: Fix Null pointer dereference

2014-08-27 Thread Mathias Nyman
On 08/27/2014 05:14 PM, Ricardo Ribalda Delgado wrote: At least I have seen the issue on Debian 3.14 and 3.16. Is your patch going to be backported to linux-stable? The computer crashes very very badly Yes, it is, but it might need some additional work as it won't apply cleanly on older

[PATCH] usb: gadget: f_uvc fix transition to video_ioctl2

2014-08-27 Thread Andrzej Pietrasiewicz
UVC video node is a TX device from the point of view of the gadget, so we cannot rely on the video struct being filled with zeros, because VFL_DIR_TX is actually 1. Suggested-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com ---

Re: [PATCH v3 0/4] usb: gadget: f_uac2: cleanups and capture timing

2014-08-27 Thread Sebastian Reimers
Hi Xuebing, Would you mind to share how did you run the test for both Playback/Capture? What host version are you using, as different Host enumerates (sends sequences of USB_REQ_SET_INTERFACE request differently)? sure, on client side (BBB) I have a jackd on top alsa running and connected

Re: [PATCH 0/7] g_webcam: Preparation for configfs

2014-08-27 Thread Andrzej Pietrasiewicz
W dniu 18.08.2014 o 21:45, Laurent Pinchart pisze: Hi Andrzej, Thank you for the patches. The series looks good, I only had a few comments. I have rebased the patches on top of my UVC gadget branch, addressed my comments (the modified patches are marked as such in the commit message) and

Status of g_webcam uvc-gadget

2014-08-27 Thread Ricardo Ribalda Delgado
Hello Is somebody using/supporting g_webcam? The only reference userland server is uvc-gadget from http://git.ideasonboard.org/?p=uvc-gadget.git;a=summary ? I have an industrial fpga camera that speaks v4l2, my plan is to export it as an uvc camera via usb3380 as a debug interface. Thanks! --

Re: [PATCH] xhci-ring: Fix Null pointer dereference

2014-08-27 Thread Ricardo Ribalda Delgado
Perhaps we could apply both patches to current tree and backport mine to older kernels? On Wed, Aug 27, 2014 at 5:27 PM, Mathias Nyman mathias.ny...@intel.com wrote: On 08/27/2014 05:14 PM, Ricardo Ribalda Delgado wrote: At least I have seen the issue on Debian 3.14 and 3.16. Is your patch

Re: [PATCH v2 1/9] of: Add NVIDIA Tegra XUSB mailbox binding

2014-08-27 Thread Andrew Bresticker
On Mon, Aug 25, 2014 at 11:48 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: diff --git a/include/dt-bindings/mailbox/tegra-xusb-mailbox.h b/include/dt-bindings/mailbox/tegra-xusb-mailbox.h +#define TEGRA_XUSB_MBOX_CHAN_HOST 0 +#define

Re: [PATCH v2 3/9] of: Update Tegra XUSB pad controller binding for USB

2014-08-27 Thread Stephen Warren
On 08/27/2014 10:36 AM, Andrew Bresticker wrote: On Mon, Aug 25, 2014 at 12:12 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: - #phy-cells: Should be 1. The specifier is the index of the PHY to reference. See

Re: [PATCH v2 4/9] pinctrl: tegra-xusb: Add USB PHY support

2014-08-27 Thread Andrew Bresticker
On Mon, Aug 25, 2014 at 12:22 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: In addition to the PCIe and SATA PHYs, the XUSB pad controller also supports 3 UTMI, 2 HSIC, and 2 USB3 PHYs. Each USB3 PHY uses a single PCIe or SATA lane and is

Re: [PATCH v2 3/9] of: Update Tegra XUSB pad controller binding for USB

2014-08-27 Thread Andrew Bresticker
On Mon, Aug 25, 2014 at 12:12 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: - #phy-cells: Should be 1. The specifier is the index of the PHY to reference. See dt-bindings/pinctrl/pinctrl-tegra-xusb.h for the list of valid values. +-

Re: [PATCH v5 5/5] usb: gadget: f_uac2: send reasonably sized packets

2014-08-27 Thread Daniel Mack
On 08/27/2014 04:18 PM, Alan Stern wrote: On Wed, 27 Aug 2014, Daniel Mack wrote: +/* + * Whenever there are more bytes in the accumulator than we + * need to add one more sample frame, increase this packet's + * size and decrease the

Re: About the reboot hang issue with EHCI driver on the Baytrail platform

2014-08-27 Thread Gavin Guo
Hi Alan, On Wed, Aug 27, 2014 at 10:38 PM, Alan Stern st...@rowland.harvard.edu wrote: On Wed, 27 Aug 2014, Gavin Guo wrote: Still, why not use the BIOS setting to disable EHCI? It's hardware enablement policy. By default, we can't change the BIOS setting to make the bug disappear until we

[PATCH v6 0/5] usb: gadget: f_uac2: cleanups and capture timing

2014-08-27 Thread Daniel Mack
Hi, this is v6 of the f_uac2 timing fixup series. Changes from v5: * Pre-calculate some more variables so we have to do their computation at runtime for each frame Changes from v4: * Fix buffer setup in afunc_set_alt() Changes from v3: * add another patch

[PATCH v6 5/5] usb: gadget: f_uac2: send reasonably sized packets

2014-08-27 Thread Daniel Mack
The UAC2 function driver currently responds to all packets at all times with wMaxPacketSize packets. That results in way too fast audio playback as the function driver (which is in fact supposed to define the audio stream pace) delivers as fast as it can. Fix this by sizing each packet correctly

[PATCH v6 2/5] usb: gadget: f_uac2: add short-hand for 'dev'

2014-08-27 Thread Daniel Mack
In afunc_bind() and afunc_set_alt(), uac2-pdev.dev are used multiple times. Adding a short-hand for them makes lines shorter so we can remove some line wraps. No functional change. Signed-off-by: Daniel Mack zon...@gmail.com --- drivers/usb/gadget/function/f_uac2.c | 29

[PATCH v6 4/5] usb: gadget: f_uac2: handle partial dma area wrap

2014-08-27 Thread Daniel Mack
With packet sizes other than 512, payloads in the packets may wrap around the ALSA dma buffer partially, which leads to memory corruption and audible clicks and pops in the audio stream at the moment, because there is no boundary check before the memcpy(). In preparation to an implementation for

[PATCH v6 3/5] usb: gadget: f_uac2: introduce agdev_to_uac2_opts

2014-08-27 Thread Daniel Mack
Add a simple container_of() wrapper to get a struct f_uac2_opts from a struct struct audio_dev. Use it in two places where it is currently open-coded. Signed-off-by: Daniel Mack zon...@gmail.com --- drivers/usb/gadget/function/f_uac2.c | 10 -- 1 file changed, 8 insertions(+), 2

[PATCH v6 1/5] usb: gadget: f_uac2: restructure some code in afunc_set_alt()

2014-08-27 Thread Daniel Mack
Restructure some code to make it easier to read. While at it, return -ENOMEM instead of -EINVAL if usb_ep_alloc_request() fails, and omit the logging in such cases (the mm core will complain loud enough). Signed-off-by: Daniel Mack zon...@gmail.com --- drivers/usb/gadget/function/f_uac2.c | 39

Re: [xhci] BUG: unable to handle kernel NULL pointer dereference at (null)

2014-08-27 Thread Dan Williams
d05446ae2128064a4bb8f74c84f6901ffb5c94bc # 00:33 60+ 1 Add linux-next specific files for 20140827 This script may reproduce the error. #!/bin/bash kernel=$1 initrd=quantal-core-x86_64.cgz wget --no-clobber https

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Andrew Bresticker
On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: The Tegra xHCI controller's firmware communicates requests to the host processor through a mailbox interface. While there is only a single communication channel,

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Stephen Warren
On 08/27/2014 11:38 AM, Andrew Bresticker wrote: On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: The Tegra xHCI controller's firmware communicates requests to the host processor through a mailbox interface. While

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Andrew Bresticker
On Wed, Aug 27, 2014 at 10:50 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/27/2014 11:38 AM, Andrew Bresticker wrote: On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/18/2014 11:08 AM, Andrew Bresticker wrote: +static int

Re: [PATCH] usb: dwc3: exynos: remove usb_phy_generic support

2014-08-27 Thread Vivek Gautam
Hi Baltlomiej, On Wed, Aug 27, 2014 at 1:22 PM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: dwc3 driver is using the new Exynos5 SoC series USB DRD PHY driver (PHY_EXYNOS5_USBDRD which selects GENERIC_PHY) as can be seen by looking at the following commits: 7a4cf0fde054

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Stephen Warren
On 08/27/2014 12:13 PM, Andrew Bresticker wrote: On Wed, Aug 27, 2014 at 10:50 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/27/2014 11:38 AM, Andrew Bresticker wrote: On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/18/2014 11:08 AM, Andrew

Re: [PATCH] usb: gadget: composite: dequeue cdev-req before free its buffer

2014-08-27 Thread Felipe Balbi
Hi, On Mon, Aug 25, 2014 at 04:49:12PM +0800, Li Jun wrote: As Felipe suggested, dequeue the cdev-req before free its buffer. Suggested-by: Felipe Balbi ba...@ti.com Signed-off-by: Li Jun b47...@freescale.com please read Documentation/SubmittingPatches. Your commit log does not make sense.

Re: [PATCH 2/2] doc: dt: mxs-phy: add compatible string for imx6sx-usbphy

2014-08-27 Thread Felipe Balbi
On Tue, Aug 26, 2014 at 10:55:18AM +0800, Peter Chen wrote: Add compatible string for imx6sx-usbphy. Signed-off-by: Peter Chen peter.c...@freescale.com do I need to take this one as well or will DT folks take care of patch 2 ? -- balbi signature.asc Description: Digital signature

Re: [RFC 2/2] usb: otg: Temporarily hold wakeupsource on charger and disconnect events

2014-08-27 Thread Felipe Balbi
On Fri, Aug 22, 2014 at 03:20:00PM +0530, Kiran Kumar Raparthy wrote: From: Todd Poynor toddpoy...@google.com usb: otg: Temporarily hold wakeupsource on charger and disconnect events Allow other parts of the system to react to the charger connect/disconnect event without allowing the

Re: [PATCH v6 2/3] usb: gadget: f_fs: add ioctl returning ep descriptor

2014-08-27 Thread Felipe Balbi
Hi, On Mon, Aug 25, 2014 at 11:16:28AM +0200, Robert Baldyga wrote: This patch introduces ioctl named FUNCTIONFS_ENDPOINT_DESC, which returns endpoint descriptor to userspace. It works only if function is active. Signed-off-by: Robert Baldyga r.bald...@samsung.com Acked-by: Michal

Re: [PATCH] usb: hub: Prevent hub autosuspend if usbcore.autosuspend is -1

2014-08-27 Thread Greg KH
On Wed, Aug 27, 2014 at 01:31:24PM +0300, Roger Quadros wrote: On 08/04/2014 05:07 PM, Alan Stern wrote: On Mon, 4 Aug 2014, Roger Quadros wrote: If user specifies that USB autosuspend must be disabled by module parameter usbcore.autosuspend=-1 then we must prevent autosuspend of USB

Re: Problem with USB-to-SATA adapters (was: AS2105-based enclosure size issues with 2TB HDDs)

2014-08-27 Thread Dale R. Worley
From: James Bottomley james.bottom...@hansenpartnership.com Did you try read capacity 16 on it? What happened? (the AS2105 rejects read capacity 16, so there's no reliable way to deduce the capacity of drives over 2TB). OK, I had to track down which package contains sg_readcap. The

Re: [PATCH 02/13] usb: udc: set the udc is ready to pullup dp when it needs

2014-08-27 Thread Felipe Balbi
On Wed, Aug 20, 2014 at 01:30:40PM +0800, Peter Chen wrote: On Tue, Aug 19, 2014 at 09:02:54PM +, Paul Zimmerman wrote: From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Peter Chen Sent: Tuesday, August 19, 2014 7:26 AM On Tue, Aug

Re: [PATCH v2 0/5] usb: phy: samsung: remove old USB PHY code

2014-08-27 Thread Felipe Balbi
Hi, On Fri, Aug 22, 2014 at 06:59:00PM +0200, Bartlomiej Zolnierkiewicz wrote: Hi, This patch series removes the old Samsung USB PHY drivers that got replaced by the new ones using the generic PHY layer. Depends on: - v3.17-rc1 branch of Linus' kernel Changes since v1

Re: [PATCH v2] usb: hub: Prevent hub autosuspend if usbcore.autosuspend is -1

2014-08-27 Thread Greg KH
On Wed, Aug 27, 2014 at 03:11:10PM +0300, Roger Quadros wrote: If user specifies that USB autosuspend must be disabled by module parameter usbcore.autosuspend=-1 then we must prevent autosuspend of USB hub devices as well. commit 596d789a211d introduced in v3.8 changed the original behaivour

Re: Problem with USB-to-SATA adapters (was: AS2105-based enclosure size issues with 2TB HDDs)

2014-08-27 Thread Dale R. Worley
What I find interesting is that Windows (at least, Windows 7 Professional) seems to be able to handle the deficient adapter. What I'd like to do is log the disk commands during the mounting sequence, preferably at both the SCSI and USB layers. Then at least we'll know exactly what the driver is

Re: [PATCH v2 5/5] usb: phy: samsung: remove old common USB PHY code

2014-08-27 Thread Felipe Balbi
Hi, On Fri, Aug 22, 2014 at 06:59:05PM +0200, Bartlomiej Zolnierkiewicz wrote: drivers/usb/phy/phy-samsung-usb[2,3] drivers got replaced by drivers/phy/phy-samsung-usb[2,3] ones and the old common Samsung USB PHY code is no longer used. Signed-off-by: Bartlomiej Zolnierkiewicz

Re: [PATCH] usb: gadget: net2280: Remove pci_class from PCI_TABLE

2014-08-27 Thread Greg Kroah-Hartman
On Wed, Aug 27, 2014 at 03:00:29PM +0200, Ricardo Ribalda Delgado wrote: Defining the vendor and the product id should be enough to discriminate the device. The reason for this patch is that there is a missmatch betweed the modalias showed by sysfs and the modalias generated by file2alias.

Re: [PATCH v2 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver

2014-08-27 Thread Jassi Brar
On 27 August 2014 23:08, Andrew Bresticker abres...@chromium.org wrote: On Mon, Aug 25, 2014 at 12:01 PM, Stephen Warren swar...@wwwdotorg.org wrote: I'm not even sure if it's appropriate for the low-level mailbox driver to know about the semantics of the message, rather than simply sending

Re: [PATCH v3 2/2] usb: Add LED triggers for USB activity

2014-08-27 Thread Greg Kroah-Hartman
On Wed, Aug 27, 2014 at 03:03:45PM +0200, Michal Sojka wrote: With this patch, USB activity can be signaled by blinking a LED. There are two triggers, one for activity on USB host and one for USB gadget. Both trigger should work with all host/device controllers. Tested only with musb.

Re: [PATCH] usb: dwc3: exynos: remove usb_phy_generic support

2014-08-27 Thread Felipe Balbi
Hi, On Wed, Aug 27, 2014 at 11:42:25PM +0530, Vivek Gautam wrote: On Wed, Aug 27, 2014 at 1:22 PM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: dwc3 driver is using the new Exynos5 SoC series USB DRD PHY driver (PHY_EXYNOS5_USBDRD which selects GENERIC_PHY) as can be seen by

Re: [PATCH v3 2/2] usb: Add LED triggers for USB activity

2014-08-27 Thread Felipe Balbi
On Wed, Aug 27, 2014 at 12:27:51PM -0700, Greg Kroah-Hartman wrote: On Wed, Aug 27, 2014 at 03:03:45PM +0200, Michal Sojka wrote: With this patch, USB activity can be signaled by blinking a LED. There are two triggers, one for activity on USB host and one for USB gadget. Both trigger

Re: [RFC PATCH 0/7] usb: gadget: add reset API at usb_gadget_driver

2014-08-27 Thread Felipe Balbi
Hi, On Tue, Aug 26, 2014 at 03:30:32PM +0800, Peter Chen wrote: On Mon, Aug 25, 2014 at 11:27:47AM -0400, Alan Stern wrote: On Mon, 25 Aug 2014, Peter Chen wrote: Hi Felipe Alan, It is the follow-up for: http://www.spinics.net/lists/linux-usb/msg112193.html This

Re: [PATCH] usb: gadget: net2280: Remove pci_class from PCI_TABLE

2014-08-27 Thread Ricardo Ribalda Delgado
Hello Greg On Wed, Aug 27, 2014 at 9:25 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Wed, Aug 27, 2014 at 03:00:29PM +0200, Ricardo Ribalda Delgado wrote: Defining the vendor and the product id should be enough to discriminate the device. The reason for this patch is that

Re: Problem with USB-to-SATA adapters (was: AS2105-based enclosure size issues with 2TB HDDs)

2014-08-27 Thread James Bottomley
On Wed, 2014-08-27 at 15:21 -0400, Dale R. Worley wrote: From: James Bottomley james.bottom...@hansenpartnership.com Did you try read capacity 16 on it? What happened? (the AS2105 rejects read capacity 16, so there's no reliable way to deduce the capacity of drives over 2TB). OK, I

Re: Problem with USB-to-SATA adapters (was: AS2105-based enclosure size issues with 2TB HDDs)

2014-08-27 Thread Alan Stern
On Wed, 27 Aug 2014, Dale R. Worley wrote: What I find interesting is that Windows (at least, Windows 7 Professional) seems to be able to handle the deficient adapter. So does Linux. The difference is that Windows believes the values in the partition table in preference to what the hardware

Re: [PATCH v3 1/2] usb: gadget: Refactor request completion

2014-08-27 Thread Michal Sojka
On Wed, Aug 27 2014, Michal Sojka wrote: All USB peripheral controller drivers called completion routines directly. This patch moves the completion call from drivers to usb_gadget_giveback_request(), in order to have a place where common functionality can be added. All places in drivers/usb/

Re: [PATCH v3 1/2] usb: gadget: Refactor request completion

2014-08-27 Thread Felipe Balbi
On Wed, Aug 27, 2014 at 03:03:44PM +0200, Michal Sojka wrote: All USB peripheral controller drivers called completion routines directly. This patch moves the completion call from drivers to usb_gadget_giveback_request(), in order to have a place where common functionality can be added. All

Re: [RFC PATCH 0/7] usb: gadget: add reset API at usb_gadget_driver

2014-08-27 Thread Alan Stern
On Wed, 27 Aug 2014, Felipe Balbi wrote: Hi Alan Felipe, During the changing UDC drivers process, I find we can't simply move usb_gadget_disconnect to usb_gadget_driver.disconnect, some UDC drivers (like dwc3) will be no chance to set software pullup bit (dp control always means

Re: [PATCH] usb: gadget: net2280: Remove pci_class from PCI_TABLE

2014-08-27 Thread Greg Kroah-Hartman
On Wed, Aug 27, 2014 at 09:39:43PM +0200, Ricardo Ribalda Delgado wrote: Hello Greg On Wed, Aug 27, 2014 at 9:25 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Wed, Aug 27, 2014 at 03:00:29PM +0200, Ricardo Ribalda Delgado wrote: Defining the vendor and the product id

Re: [RFC PATCH 0/7] usb: gadget: add reset API at usb_gadget_driver

2014-08-27 Thread Felipe Balbi
On Wed, Aug 27, 2014 at 04:20:25PM -0400, Alan Stern wrote: On Wed, 27 Aug 2014, Felipe Balbi wrote: Hi Alan Felipe, During the changing UDC drivers process, I find we can't simply move usb_gadget_disconnect to usb_gadget_driver.disconnect, some UDC drivers (like dwc3) will be

[PATCH v4 2/3] usb: Rename usb-common.c

2014-08-27 Thread Michal Sojka
In the next commit, we will want the usb-common module to be composed of two object files. Since Kbuild cannot append another object to an existing one, we need to rename usb-common.c to something else (common.c) and create usb-common.o by linking the wanted objects together. Currently,

[PATCH v4 3/3] usb: Add LED triggers for USB activity

2014-08-27 Thread Michal Sojka
With this patch, USB activity can be signaled by blinking a LED. There are two triggers, one for activity on USB host and one for USB gadget. Both trigger should work with all host/device controllers. Tested only with musb. Signed-off-by: Michal Sojka so...@merica.cz --- drivers/usb/Kconfig

[PATCH v4 1/3] usb: gadget: Refactor request completion

2014-08-27 Thread Michal Sojka
All USB peripheral controller drivers called completion routines directly. This patch moves the completion call from drivers to usb_gadget_giveback_request(), in order to have a place where common functionality can be added. All places in drivers/usb/ matching [-.]complete( were replaced with a

[PATCH v4 0/3] LED triggers for USB host and device

2014-08-27 Thread Michal Sojka
This adds LED triggers for USB host and device. First patch refactors UDC drivers as requested by Felipe Balbi, second is a preparation for the third, which adds the LED triggers. Changes from v3: - usb_gadget_giveback_request() moved outside of CONFIG_HAS_DMA conditioned block. - Added

Re: [PATCH v2] usb: hub: Prevent hub autosuspend if usbcore.autosuspend is -1

2014-08-27 Thread Greg KH
On Wed, Aug 27, 2014 at 12:23:39PM -0700, Greg KH wrote: On Wed, Aug 27, 2014 at 03:11:10PM +0300, Roger Quadros wrote: If user specifies that USB autosuspend must be disabled by module parameter usbcore.autosuspend=-1 then we must prevent autosuspend of USB hub devices as well. commit

Re: [PATCH] usb: gadget: net2280: Remove pci_class from PCI_TABLE

2014-08-27 Thread Ricardo Ribalda Delgado
Hello Greg Not many drivers define the pci interface and there is no other driver that has the same vendor and product id. Therefore I see no hurt in adding both patches, one to make the driver broader, and another to fix pci-sysfs. Also, the change on pci-sysfs might affect more stuff

Re: [PATCH v4 1/3] usb: gadget: Refactor request completion

2014-08-27 Thread Alan Stern
On Wed, 27 Aug 2014, Michal Sojka wrote: +/** + * usb_gadget_giveback_request - give the request back to the gadget layer + * Context: in_interrupt() + * + * This is called by device controller drivers in order to return the + * completed request back to the gadget layer. + */ +void

[PATCH 2/5] tools: ffs-test: convert to new descriptor format

2014-08-27 Thread Michal Nazarewicz
Since commit [ac8dde11: “Add flags to descriptors block”] functionfs supports a new, more powerful and extensible, descriptor format. Since ffs-test is probably the first thing users of the functionfs interface see when they start writing functionfs user space daemons, convert it to use the new

[PATCH 5/5] USB:gadget: Fix a warning while loading g_mass_storage

2014-08-27 Thread Michal Nazarewicz
From: Yang Wei wei.y...@windriver.com While loading g_mass_storage module, the following warning is triggered. WARNING: at drivers/usb/gadget/composite.c: usb_composite_setup_continue: Unexpected call Modules linked in: fat vfat minix nls_cp437 nls_iso8859_1 g_mass_storage [800179cc]

[PATCH 1/5] usb: gadget: f_fs: add usb_functionfs_descs_head_v2 structure

2014-08-27 Thread Michal Nazarewicz
The structure can be used with user space tools that use the new functionfs description format, for example as follows: static const struct { struct usb_functionfs_descs_head_v2 header; __le32 fs_count; __le32 hs_count; struct { … } fs_desc;

[PATCH 0/5] Small USB fixes/improvements

2014-08-27 Thread Michal Nazarewicz
Apparently I've slept over 3.17 merge window, so I guess this is for 3.18. Rebased on top of balbi/usb.git next. Michal Nazarewicz (4): usb: gadget: f_fs: add usb_functionfs_descs_head_v2 structure tools: ffs-test: convert to new descriptor format tools: ffs-test: add compatibility code

[PATCH 3/5] tools: ffs-test: add compatibility code for old kernels

2014-08-27 Thread Michal Nazarewicz
If ffs-test is used with a kernel prior to 3.14, which do not support the new descriptors format, it will fail when trying to write the descriptors. Add a function that converts the new descriptors to the legacy ones and use it to retry writing the descriptors using the legacy format. Also add

  1   2   >