[PATCH 8/20] USB: isp1760: fix misspelling of current function in string

2014-12-07 Thread Julia Lawall
Replace a misspelled function name by %s and then __func__. The function name starts with isp, not ips. This was done using Coccinelle, including the use of Levenshtein distance, as proposed by Rasmus Villemoes. Signed-off-by: Julia Lawall julia.law...@lip6.fr --- The semantic patch is

[PATCH 18/20] usb: gadget: fix misspelling of current function in string

2014-12-07 Thread Julia Lawall
Replace a misspelled function name by %s and then __func__. This was done using Coccinelle, including the use of Levenshtein distance, as proposed by Rasmus Villemoes. Signed-off-by: Julia Lawall julia.law...@lip6.fr --- The semantic patch is difficult to summarize, but is available in the

Re: [PATCH 2/2] usb: gadget: uvc: configfs support in uvc function

2014-12-07 Thread Laurent Pinchart
Hi Andrzej, On Friday 05 December 2014 15:17:43 Andrzej Pietrasiewicz wrote: Hi Laurent, thank you for your review. I generally agree with your comments but please see inline for some explanations. W dniu 28.11.2014 o 00:40, Laurent Pinchart pisze: Hi Andrzej, Thank you for the

Re: [PATCH 8/20] USB: isp1760: fix misspelling of current function in string

2014-12-07 Thread Jeremiah Mahler
Julia, On Sun, Dec 07, 2014 at 08:20:50PM +0100, Julia Lawall wrote: Replace a misspelled function name by %s and then __func__. The function name starts with isp, not ips. This was done using Coccinelle, including the use of Levenshtein distance, as proposed by Rasmus Villemoes.

Re: [PATCH 8/20] USB: isp1760: fix misspelling of current function in string

2014-12-07 Thread Julia Lawall
On Sun, 7 Dec 2014, Jeremiah Mahler wrote: Julia, On Sun, Dec 07, 2014 at 08:20:50PM +0100, Julia Lawall wrote: Replace a misspelled function name by %s and then __func__. The function name starts with isp, not ips. This was done using Coccinelle, including the use of

Re: [PATCHv2 1/3] usb: gadget: f_uvc: rename a macro to avoid conflicts

2014-12-07 Thread Laurent Pinchart
Hi Andrzej, Thank you for the patch. On Friday 05 December 2014 15:16:34 Andrzej Pietrasiewicz wrote: When configfs is integrated, CONFIGFS_ATTR_STRUCT and CONFIGFS_ATTR_OPS macros should be used, but the latter expects that tere is a to_f_uvc_opts function accepting a config_item, whereas

Re: [PATCHv2 2/3] usb: gadget: uvc: verify descriptors presence

2014-12-07 Thread Laurent Pinchart
Hi Andrzej, Thank you for the patch. On Friday 05 December 2014 15:16:35 Andrzej Pietrasiewicz wrote: If the caller of uvc_alloc() does not provide enough descriptors, binding the function should fail, so appropriate code is returned from uvc_copy_descriptors(). uvc_function_bind() is

Re: [PATCHv2 2/3] usb: gadget: uvc: verify descriptors presence

2014-12-07 Thread Laurent Pinchart
Hi Andrzej, On Sunday 07 December 2014 23:09:42 Laurent Pinchart wrote: On Friday 05 December 2014 15:16:35 Andrzej Pietrasiewicz wrote: If the caller of uvc_alloc() does not provide enough descriptors, binding the function should fail, so appropriate code is returned from

[sur40] Videobuf2 and/or DMA?

2014-12-07 Thread Florian Echtler
Hello everyone, I'm preparing to finally add support for the raw sensor video stream to my driver for the SUR40 touchscreen. However, after an extensive amount of Googling, I'm still not clear on the relationship between DMA transfers, the USB core and the videobuf2 framework. Specifically, I'd

Re: [PATCHv2 3/3] usb: gadget: uvc: configfs support in uvc function

2014-12-07 Thread Laurent Pinchart
Hi Andrzej, Thank you for the patch. I think we're nearly there :-) On Friday 05 December 2014 15:16:36 Andrzej Pietrasiewicz wrote: Add support for using the uvc function as a component of USB gadgets composed with configfs. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com ---

Re: [PATCH 0/20] fix misspelling of current function in string

2014-12-07 Thread Julian Calaby
Hi Julia, On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall julia.law...@lip6.fr wrote: These patches replace what appears to be a reference to the name of the current function but is misspelled in some way by either the name of the function itself, or by %s and then __func__ in an argument list.

Re: [PATCH 0/20] fix misspelling of current function in string

2014-12-07 Thread Joe Perches
On Sun, 2014-12-07 at 20:20 +0100, Julia Lawall wrote: These patches replace what appears to be a reference to the name of the current function but is misspelled in some way by either the name of the function itself, or by %s and then __func__ in an argument list. At least a few of these seem

Re: [PATCH v2 3/5] usb: dwc2: Add generic PHY framework support for dwc2 usb controler platform driver.

2014-12-07 Thread Yunzhi Li
Hi Paul: Thank you for replying. On 2014/12/6 3:04, Paul Zimmerman wrote: From: Yunzhi Li [mailto:l...@rock-chips.com] Sent: Friday, December 05, 2014 4:52 AM Get PHY parameters from devicetree and power off usb PHY during system suspend. Signed-off-by: Yunzhi Li l...@rock-chips.com ---

Re: [PATCH 0/20] fix misspelling of current function in string

2014-12-07 Thread Julia Lawall
On Mon, 8 Dec 2014, Julian Calaby wrote: Hi Julia, On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall julia.law...@lip6.fr wrote: These patches replace what appears to be a reference to the name of the current function but is misspelled in some way by either the name of the function itself,