Re: [PATCHv6 4/5] USB: gadget: atmel_usba_udc: Prepare for IRQ single edge support

2015-02-08 Thread Boris Brezillon
On Sat, 7 Feb 2015 20:37:23 +0100 Sylvain Rochet sylvain.roc...@finsecur.com wrote: Hello Nicolas, On Thu, Feb 05, 2015 at 06:19:55PM +0100, Nicolas Ferre wrote: Le 22/01/2015 18:14, Boris Brezillon a écrit : On Thu, 22 Jan 2015 17:56:44 +0100 Sylvain Rochet

Re: [PATCH 3/6] drivers: usb: core: hcd.c: remove assignment of variables in if conditions.

2015-02-08 Thread Sergei Shtylyov
Hello. On 2/8/2015 12:55 AM, Bas Peters wrote: This patch removes assignment of variables in if conditions, as specified in CodingStyle. Signed-off-by: Bas Peters baspeter...@gmail.com --- drivers/usb/core/hcd.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-)

Re: [PATCH 2/3] drivers: usb: storage: cypress_atacb.c: trivial checkpatch fixes

2015-02-08 Thread Sergei Shtylyov
On 2/8/2015 1:42 AM, Bas Peters wrote: Fixes errors thrown by checkpatch over a space issue and the incorrect indentation of a switch statement. Signed-off-by: Bas Peters baspeter...@gmail.com --- drivers/usb/storage/cypress_atacb.c | 17 - 1 file changed, 8 insertions(+),

Re: [PATCH 4/6] drivers: usb: core: hub.c: remove NULL initialization of static variables.

2015-02-08 Thread Sergei Shtylyov
On 2/8/2015 12:55 AM, Bas Peters wrote: NULL Rather 0-. initialization of static variables is unnecessary as GCC kindly does this for us. It's rather the C run-time library that does this. Signed-off-by: Bas Peters baspeter...@gmail.com [...] WBR, Sergei -- To unsubscribe from

Re: [PATCH 5/6] drivers: usb: core: hub.c: remove assignment of variables in if conditions.

2015-02-08 Thread Sergei Shtylyov
On 2/8/2015 12:55 AM, Bas Peters wrote: As specified in the CodingStyle. Signed-off-by: Bas Peters baspeter...@gmail.com --- drivers/usb/core/hub.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index

Re: [PATCH] usb: phy: am335x-control: check return value of bus_find_device

2015-02-08 Thread Sebastian Andrzej Siewior
On 02/08/2015 04:29 PM, David Dueck wrote: This fixes a potential null pointer dereference. Signed-off-by: David Dueck davidcdu...@googlemail.com Acked-by: Sebastian Andrzej Siewior bige...@linutronix.de Fixes: d4332013919a (driver core: dev_get_drvdata: Don't check for NULL dev) Greg, this

Re: [PATCH 1/2] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-02-08 Thread Ruslan Bilovol
Hi Alan, On Thu, Jan 29, 2015 at 5:56 PM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 29 Jan 2015, Ruslan Bilovol wrote: Change behavior during registration of gadgets and gadget drivers in udc-core. Instead of previous approach when for successful probe of usb gadget driver at

[PATCH] usb: phy: am335x-control: check return value of bus_find_device

2015-02-08 Thread David Dueck
This fixes a potential null pointer dereference. Signed-off-by: David Dueck davidcdu...@googlemail.com --- drivers/usb/phy/phy-am335x-control.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/phy/phy-am335x-control.c b/drivers/usb/phy/phy-am335x-control.c index

Re: [PATCH] usb: gadget: fix sparse warnings

2015-02-08 Thread Laurent Pinchart
Hi Felipe, On Thursday 05 February 2015 12:08:09 Felipe Balbi wrote: On Thu, Feb 05, 2015 at 05:02:46PM +0200, Laurent Pinchart wrote: Hi Prabhakar, Thank you for the patch. On Thursday 05 February 2015 13:02:18 Lad Prabhakar wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com

[PATCH v2] usb: core: Remove unneeded #ifdef and associated dead code

2015-02-08 Thread Andreas Ruprecht
In commit ceb6c9c862c8 (USB / PM: Drop CONFIG_PM_RUNTIME from the USB core), all occurrences of CONFIG_PM_RUNTIME in the USB core code were replaced by CONFIG_PM. This created the following structure of #ifdef blocks in drivers/usb/core/hub.c: [...] #ifdef CONFIG_PM #ifdef CONFIG_PM /* always

Re: Issues with commit 34b48db6 (block: remove artifical max_hw_sectors cap)

2015-02-08 Thread Kenneth R. Crudup
On Mon, 19 Jan 2015, Alan Stern wrote: ... If anyone (still?) cares about this bug, commit 3a9794d3 (sd: Fix max transfer length for 4k disks) fixes it, with no patches required. -Kenny -- Kenneth R. Crudup Sr. SW Engineer, Scott County Consulting, Silicon Valley -- To unsubscribe

Re: [PATCH v2] usb: core: Remove unneeded #ifdef and associated dead code

2015-02-08 Thread Rafael J. Wysocki
On Sunday, February 08, 2015 08:36:38 PM Andreas Ruprecht wrote: In commit ceb6c9c862c8 (USB / PM: Drop CONFIG_PM_RUNTIME from the USB core), all occurrences of CONFIG_PM_RUNTIME in the USB core code were replaced by CONFIG_PM. This created the following structure of #ifdef blocks in

Re: [PATCH 1/6] drivers: usb: core: devio.c: remove assignment of variables in if conditions.

2015-02-08 Thread Peter Chen
On Sat, Feb 07, 2015 at 10:55:01PM +0100, Bas Peters wrote: This patch removes assignment of variables in if conditions in accordance witht the CodingStyle. %s/witht/with Signed-off-by: Bas Peters baspeter...@gmail.com --- drivers/usb/core/devio.c | 15 ++- 1 file changed,

Re: [PATCH V5 6/8] USB: f81232: clarify f81232_ioctl()

2015-02-08 Thread Peter Hung
Hello, Sergei Shtylyov 於 2015/2/6 下午 08:21 寫道: We extract TIOCGSERIAL section in f81232_ioctl() to f81232_get_serial_info() to make it clarify You're also changing 'ser.baud_rate' from 460800 to 115200. And explicitly overriding some previously initialized to 0 fields. F81232 max

Re: [PATCH 1/1] usb: chipidea: support runtime power management for otg fsm mode

2015-02-08 Thread Peter Chen
On Mon, Feb 09, 2015 at 11:52:11AM +0800, Li Jun wrote: From: Li Jun b47...@freescale.com This patch adds runtime power management support for otg fsm mode, since A-device in a_idle state cannot detect data pulse irq after suspended, here enable wakeup by connection before suspend to make it

[PATCH 1/1] usb: chipidea: support runtime power management for otg fsm mode

2015-02-08 Thread Li Jun
From: Li Jun b47...@freescale.com This patch adds runtime power management support for otg fsm mode, since A-device in a_idle state cannot detect data pulse irq after suspended, here enable wakeup by connection before suspend to make it can be resumed by DP; and handle wakeup from that state like

Re: [PATCH 2/2] usb: musb: Fix getting a generic phy for musb_dsps

2015-02-08 Thread George Cherian
Hi Tony, On 02/06/2015 10:53 PM, Tony Lindgren wrote: * George Cherian george.cher...@ti.com [150206 05:05]: Hi Tony, You also need to add similar things in dsps_musb_reset(); Otherwise you might not recover from a BABBLE condition. Thank I totally missed that, updated patch below. Do you

Re: [PATCH 4/4] usb: phy: add phy-hi6220

2015-02-08 Thread Peter Chen
On Fri, Feb 06, 2015 at 07:47:12PM +0800, Zhangfei Gao wrote: On 6 February 2015 at 16:41, Peter Chen peter.c...@freescale.com wrote: On Thu, Feb 05, 2015 at 10:47:00PM +0800, Zhangfei Gao wrote: @@ -18,6 +18,7 @@ obj-$(CONFIG_SAMSUNG_USBPHY)+= phy-samsung-usb.o

Re: [PATCH 4/4] usb: phy: add phy-hi6220

2015-02-08 Thread Zhangfei Gao
On 9 February 2015 at 09:57, Peter Chen peter.c...@freescale.com wrote: +static int hi6220_phy_probe(struct platform_device *pdev) +{ + struct hi6220_priv *priv; + struct usb_otg *otg; + struct device_node *np = pdev-dev.of_node; + int ret, irq; + + priv =

Re: [PATCH v2 4/4] usb: phy: add phy-hi6220-usb

2015-02-08 Thread Peter Chen
On Sat, Feb 07, 2015 at 12:56:06PM +0800, Zhangfei Gao wrote: Add usb phy controller for hi6220 platform Signed-off-by: Zhangfei Gao zhangfei@linaro.org --- drivers/usb/phy/Kconfig | 9 ++ drivers/usb/phy/Makefile | 1 + drivers/usb/phy/phy-hi6220-usb.c | 297