Re: [PATCH V2 1/1] usb:serial:f81534 Add F81532/534 Driver

2015-06-25 Thread Johan Hovold
Hi Peter, On Thu, Jun 25, 2015 at 01:16:56PM +0800, Peter Hung wrote: Hello Johan, Peter Hung 於 2015/6/15 上午 09:54 寫道: This driver is for Fintek F81532/F81534 USB to Serial Ports IC. Features: 1. F81534 is 1-to-4 F81532 is 1-to-2 serial ports IC 2. Support Baudrate from B50 to

Re: [PATCH v5 3/3] usb: xhci: remove stop device and ring doorbell in hub control and bus suspend

2015-06-25 Thread Lu, Baolu
On 06/25/2015 10:53 PM, Mathias Nyman wrote: On 09.05.2015 04:15, Lu Baolu wrote: There is no need to call xhci_stop_device() and xhci_ring_device() in hub control and bus suspend functions since all device suspend and resume have been notified through device_suspend/device_resume interfaces.

Re: [PATCH RFC] 2/2 huawei_cdc_ncm: introduce new TX ncm stack

2015-06-25 Thread Enrico Mioso
Hi Oliver. Thank you for your patience, and review. I apreciated it very much. On Thu, 25 Jun 2015, Oliver Neukum wrote: Date: Thu, 25 Jun 2015 11:49:29 From: Oliver Neukum oneu...@suse.com To: Enrico Mioso mrkiko...@gmail.com Cc: linux-usb@vger.kernel.org, net...@vger.kernel.org Subject: Re:

Re: [PATCH RFC] 2/2 huawei_cdc_ncm: introduce new TX ncm stack

2015-06-25 Thread Oliver Neukum
On Thu, 2015-06-25 at 13:44 +0200, Enrico Mioso wrote: On Thu, 25 Jun 2015, Oliver Neukum wrote: Is there any advantage in keeping this in a single function? I did this choice in the light of the fact I think the tx_fixup function will become more complex than it is now, when aggregating

Re: [PATCH RFC] 2/2 huawei_cdc_ncm: introduce new TX ncm stack

2015-06-25 Thread Oliver Neukum
On Tue, 2015-06-23 at 00:32 +0200, Enrico Mioso wrote: This patch introduces a new NCM tx engine, able to operate in standard- and huawei-style mode. In the first case, the NDP is disposed after the initial headers and before any datagram. What works: - is able to communicate with

Re: [PATCH RFC] 2/2 huawei_cdc_ncm: introduce new TX ncm stack

2015-06-25 Thread Oliver Neukum
On Tue, 2015-06-23 at 00:32 +0200, Enrico Mioso wrote: +/* XXX rewrite, not multipacket */ Can you explain what you want to do here? +struct sk_buff * +huawei_ncm_tx_fixup(struct usbnet *dev, struct sk_buff *skb_in, gfp_t flags) { + struct huawei_cdc_ncm_state *drvstate = (void

Re: [PATCH v5 3/3] usb: xhci: remove stop device and ring doorbell in hub control and bus suspend

2015-06-25 Thread Mathias Nyman
On 09.05.2015 04:15, Lu Baolu wrote: There is no need to call xhci_stop_device() and xhci_ring_device() in hub control and bus suspend functions since all device suspend and resume have been notified through device_suspend/device_resume interfaces. I was looking through this code again before

Re: [PATCH RFC] 2/2 huawei_cdc_ncm: introduce new TX ncm stack

2015-06-25 Thread Enrico Mioso
Hi Oliver! And thank you again. I like / recommend the usage of open messaging standards: my preferred XMPP ID (JID) is: mrk...@jit.si. On Thu, 25 Jun 2015, Oliver Neukum wrote: Date: Thu, 25 Jun 2015 15:38:46 From: Oliver Neukum oneu...@suse.de To: Enrico Mioso mrkiko...@gmail.com Cc:

64 byte EP0 OUT data transfer issue on Chipidea highspeed dual role controller

2015-06-25 Thread Jayan John
I am developing a custom USB device on a iMX6q platform (Wandboard) Chipidea HDRC (highspeed dual role controller). The HID interface consists of a single Interrupt IN ep and ep0. It is required to send HID reports from Host to Gadget over ep0 (with set_report cmd on hidraw interface) in OUT

[PATCH 1/1] usb: usleep_range is preferred over udelay where wakeup is flexible

2015-06-25 Thread Sunny Kumar
According to Documentation/timers/timers-howto.txt udelay() is only called once from a place where sleeping is allowed. We can replace it with a call to usleep_range() with a reasonable upper limit. Signed-off-by: Sunny Kumar sunny.kumar@gmail.com --- drivers/usb/storage/transport.c | 2 +-

Re: 64 byte EP0 OUT data transfer issue on Chipidea highspeed dual role controller

2015-06-25 Thread Jayan John
cc Alexander Thanks On Thu, Jun 25, 2015 at 7:41 PM, Jayan John jayanjoh...@gmail.com wrote: I am developing a custom USB device on a iMX6q platform (Wandboard) Chipidea HDRC (highspeed dual role controller). The HID interface consists of a single Interrupt IN ep and ep0. It is required to

Re: [PATCH TRIVIAL] drivers/usb/gadget/composite.c: i18n is not an acronym

2015-06-25 Thread Diego Viola
Ping? On Sun, May 31, 2015 at 3:52 PM, Diego Viola diego.vi...@gmail.com wrote: Signed-off-by: Diego Viola diego.vi...@gmail.com --- drivers/usb/gadget/composite.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/composite.c

[PATCH] USB: cp210x: add ID for Aruba Networks controllers

2015-06-25 Thread Peter Sanford
Add the USB serial console device ID for Aruba Networks 7xxx series controllers which have a USB port for their serial console. Signed-off-by: Peter Sanford pe...@sanford.io --- drivers/usb/serial/cp210x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/serial/cp210x.c

Re: urb-interval differently interpreted via xhci for 2.0

2015-06-25 Thread Clemens Ladisch
(quoting fixed) Bernd Porr wrote: Alan Stern wrote: On Wed, 24 Jun 2015, Bernd Porr wrote: I use urb-interval to control the sampling rate of these devices. That works fine with the ehci driver. When I use the xhci driver it seems to be interpreting the urb-interval in a different way and/or

Re: urb-interval differently interpreted via xhci for 2.0

2015-06-25 Thread Bernd Porr
Hi Clemens, thanks for the reply. I'm using the Cypress chip which offers a fixed set of alternative settings and I use the one offering iso transfer so I cannot easily do that. There are loads of sigma boards out there and because of the linux firmware and the drivers not really into sync I

Re: [PATCH V2 1/1] usb:serial:f81534 Add F81532/534 Driver

2015-06-25 Thread Johan Hovold
On Thu, Jun 25, 2015 at 05:21:01PM +0800, Peter Hung wrote: Hi Johan, Johan Hovold 於 2015/6/25 下午 04:06 寫道: - As Greg already mentioned, you need to implement gpio support using gpiolib, not a custom sysfs interface I don't have time to look closer at the architectural bits until