[PATCH v2 11/13] usb: dwc2: host: avoid usage of dma_alloc_coherent with irqs disabled

2015-11-05 Thread Gregory Herrero
Use Streaming DMA mappings to handle cache coherency of frame list and descriptor list. Cache are always flushed before controller access it or before cpu access it. Signed-off-by: Gregory Herrero --- drivers/usb/dwc2/core.c | 3 ++ drivers/usb/dwc2/core.h |

[PATCH v2 06/13] usb: dwc2: host: add function to compare frame index

2015-11-05 Thread Gregory Herrero
This function allow comparing frame index used for descriptor list which has 64 entries. Signed-off-by: Gregory Herrero --- drivers/usb/dwc2/hcd.h | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/usb/dwc2/hcd.h b/drivers/usb/dwc2/hcd.h index

[PATCH v2 10/13] usb: dwc2: host: enable descriptor dma for fs devices

2015-11-05 Thread Gregory Herrero
From: Mian Yousaf Kaukab As descriptor dma mode does not support split transfers, it can't be enabled for high speed devices. Add a core parameter to enable it for full speed devices. Ensure frame list and descriptor list are correctly freed during disconnect.

[PATCH v2 04/13] usb: dwc2: host: fix use of qtd after free in desc dma mode

2015-11-05 Thread Gregory Herrero
When completing non isoc xfer, dwc2_complete_non_isoc_xfer_ddma() is relying on qtd->n_desc to process the corresponding number of descriptors. During the processing of these descriptors, qtd could be unlinked and freed if xfer is done and urb is no more in progress. In this case,

[PATCH v2 05/13] usb: dwc2: host: spinlock release channel

2015-11-05 Thread Gregory Herrero
Prevent dwc2 driver from accessing channel while it frees it. Signed-off-by: Gregory Herrero --- drivers/usb/dwc2/hcd_ddma.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/dwc2/hcd_ddma.c b/drivers/usb/dwc2/hcd_ddma.c index 4801e69..a76a58c 100644

[PATCH v2 09/13] usb: dwc2: host: process all completed urbs

2015-11-05 Thread Gregory Herrero
Process all completed urbs, if more urbs are complete by the time driver processes completion interrupt. Signed-off-by: Gregory Herrero --- drivers/usb/dwc2/hcd_ddma.c | 38 -- 1 file changed, 36 insertions(+), 2 deletions(-) diff

[PATCH v2 12/13] usb: dwc2: host: fix descriptor list address masking

2015-11-05 Thread Gregory Herrero
From: Mian Yousaf Kaukab Masks for HCDMA.CTD and HCDMA.DMAAddr are incorrect. As we always start from first descriptor, no need to mask the address anyway. Signed-off-by: Mian Yousaf Kaukab Signed-off-by: Gregory Herrero

[PATCH v2 03/13] usb: dwc2: host: rework isochronous halt path

2015-11-05 Thread Gregory Herrero
When a channel is halted because of urb dequeue during transfer completion, no other qtds must be scheduled until halt is done. Moreover, all in progress qtds must be given back. Signed-off-by: Gregory Herrero --- drivers/usb/dwc2/hcd_ddma.c | 22

[PATCH v2 01/13] usb: dwc2: host: ensure filling of isoc desc is correctly done

2015-11-05 Thread Gregory Herrero
Increment qtd->isoc_frame_index_last before testing it, else below check will never be true and IOC (Interrupt On Complete) bit for last frame will never be set in descriptor status. /* Set IOC for each descriptor corresponding to last frame of URB */ if (qtd->isoc_frame_index_last ==

[PATCH v2 07/13] usb: dwc2: host: program descriptor for next frame

2015-11-05 Thread Gregory Herrero
Isochronous descriptor is currently programmed for the frame after the last descriptor was programmed. If the last descriptor frame underrun, then current descriptor must take this into account and must be programmed on the current frame + 1. This overrun usually happens when system is loaded and

[PATCH v2 00/13] usb: dwc2: descriptor dma mode bug fixes

2015-11-05 Thread Gregory Herrero
Hi, This patchset contains bug fixes for host descriptor dma mode. Descriptor dma mode can't be used as the default mode since controller does not support split transfers in this mode. So we add a new configuration parameter which allows descriptor dma mode to be enabled for full-speed devices

Re: [PATCH 1/1] usb: gadget: f_loopback: fix the warning during the enumeration

2015-11-05 Thread Krzysztof Opasiak
On 11/03/2015 08:57 AM, Peter Chen wrote: The current code tries to allocate memory with GFP_KERNEL at interrupt context, it would show below warning during the enumeration when I test it with chipidea hardware, change GFP flag as GFP_ATOMIC can fix this issue. [ 40.438237] zero gadget:

[PATCH v2 02/13] usb: dwc2: host: set active bit in isochronous descriptors

2015-11-05 Thread Gregory Herrero
Active bit must be enabled in all scheduled descriptors. Else transfer never start. Remove previous code which was not correctly configuring descriptors. Active bit was set before calling dwc2_fill_host_isoc_dma_desc() which is erasing dma_desc->status. Signed-off-by: Gregory Herrero

Re: [RFC PATCH 2/2] usb: storage: scsiglue: limit USB3 devices to 2048 sectors

2015-11-05 Thread Oliver Neukum
On Wed, 2015-11-04 at 16:26 -0500, Alan Stern wrote: > This doesn't need to be stored as one of the usb-storage flags. And > since we are close to running out of flag bits (on 32-bit > architectures), it would be better not to use one of them for this. Do we want the opposite flag? 25% for known

Re: f_loopback's new problem

2015-11-05 Thread Krzysztof Opasiak
On 11/02/2015 06:49 AM, Peter Chen wrote: On Fri, Oct 30, 2015 at 10:28:09AM +0100, Krzysztof Opasiak wrote: On 10/30/2015 08:31 AM, Peter Chen wrote: Hi Krzysztof and Felipe, With commit (91c42b0d usb: gadget: loopback: Fix looping back logic implementation), the gadget loopback supports

[PATCH v2 08/13] usb: dwc2: host: always increment available host channel during release

2015-11-05 Thread Gregory Herrero
When releasing a channel, increment hsotg->available_host_channels even in case a periodic channel is released. Signed-off-by: Gregory Herrero --- drivers/usb/dwc2/hcd_ddma.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc2/hcd_ddma.c

[PATCH v2 13/13] usb: dwc2: host: use kmem cache to allocate descriptors

2015-11-05 Thread Gregory Herrero
Kmem caches help to get correct boundary for descriptor buffers which need to be 512 bytes aligned for dwc2 controller. Two kmem caches are needed for generic descriptors and for hs isochronous descriptors which doesn't have same size. Signed-off-by: Gregory Herrero

Re: Overly conservative xHCI bandwidth estimation

2015-11-05 Thread Steinar H. Gunderson
On Thu, Nov 05, 2015 at 04:12:24PM +0800, Lu, Baolu wrote: > 1) apply the attached patch on top the latest kernel. > 2) build and install the kernel. > 3) boot your machine with the new kernel. Do you want this on top of Alan's LPM-disabling patch or on a clean 4.3.0 tree? > 4) insert one

Re: Overly conservative xHCI bandwidth estimation

2015-11-05 Thread Lu, Baolu
Hi Steinar, Do you mind trying attached patch? This is not a fix but to verify whether LPM really works when only one device is used. You can follow below steps: 1) apply the attached patch on top the latest kernel. 2) build and install the kernel. 3) boot your machine with the new kernel. 4)

Re: [PATCH V4] usb: remove unnecessary CONFIG_PM dependency from USB_OTG

2015-11-05 Thread Felipe Balbi
Hi, Peter Chen writes: > On Tue, Nov 03, 2015 at 09:51:11PM -0600, Felipe Balbi wrote: >> >> Hi, >> >> Peter Chen writes: >> > On Tue, Nov 03, 2015 at 07:56:55AM -0600, Felipe Balbi wrote: >> >> >> >> Hi, >> >> >> >> Nathan Sullivan

Re: [PATCH] USB: qmi_wwan: Add quirk for Quectel EC20 Mini PCIe module

2015-11-05 Thread Petr Štetiar
Bjørn Mork [2015-11-05 12:03:36]: > make this function return bool. And the patch should go to netdev. Thanks, done. > With those changes it looks good to me. But I haven't tested it, so I > trust your testing :) usb 2-1.2: new high-speed USB device number 3 using ci_hdrc

[PATCH 1/2] cdc_acm: Ignore Infineon Flash Loader utility

2015-11-05 Thread Jonas Jonsson
Some modems, such as the Telit UE910, are using an Infineon Flash Loader utility. It has two interfaces, 2/2/0 (Abstract Modem) and 10/0/0 (CDC Data). The latter can be used as a serial interface to upgrade the firmware of the modem. However, that isn't possible when the cdc-acm driver takes

[PATCH 2/2] USB: serial: Another Infineon flash loader USB ID

2015-11-05 Thread Jonas Jonsson
This has been seen on a Telit UE910 modem. Signed-off-by: Jonas Jonsson --- drivers/usb/serial/usb-serial-simple.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c index

[PATCH] USB: qmi_wwan: Add quirk for Quectel EC20 Mini PCIe module

2015-11-05 Thread Petr Štetiar
This device has same vendor and product IDs as G2K devices, but it has different number of interfaces(4 vs 5) and also different interface layout where EC20 has QMI on interface 4 instead of 0. lsusb output: Bus 002 Device 003: ID 05c6:9215 Qualcomm, Inc. Acer Gobi 2000 Device

Re: [PATCH] USB: qmi_wwan: Add quirk for Quectel EC20 Mini PCIe module

2015-11-05 Thread Bjørn Mork
Petr Štetiar writes: > This device has same vendor and product IDs as G2K devices, but it has > different number of interfaces(4 vs 5) and also different interface > layout where EC20 has QMI on interface 4 instead of 0. > > lsusb output: > > Bus 002 Device 003: ID 05c6:9215

[PATCH v2] USB: qmi_wwan: Add quirk for Quectel EC20 Mini PCIe module

2015-11-05 Thread Petr Štetiar
This device has same vendor and product IDs as G2K devices, but it has different number of interfaces(4 vs 5) and also different interface layout where EC20 has QMI on interface 4 instead of 0. lsusb output: Bus 002 Device 003: ID 05c6:9215 Qualcomm, Inc. Acer Gobi 2000 Device

Re: [RESEND PATCH] USB: usbmon: Use 64bit timestamp for mon_bin_hdr

2015-11-05 Thread Greg Kroah-Hartman
On Thu, Nov 05, 2015 at 05:18:41PM +0100, Arnd Bergmann wrote: > On Thursday 29 October 2015 22:44:31 Tina Ruchandani wrote: > > struct mon_bin_hdr allows for a 64-bit seconds timestamp. The code > > currently uses 'struct timeval' to populate the timestamp in mon_bin_hdr, > > which has a 32-bit

Re: [PATCH v2] USB: usbmon: Remove timeval usage for timestamp

2015-11-05 Thread Arnd Bergmann
On Thursday 29 October 2015 22:58:28 Tina Ruchandani wrote: > struct timeval' uses 32-bits for its seconds field and will overflow in > the year 2038 and beyond. This patch replaces the usage of 'struct timeval' > in mon_get_timestamp() with timespec64 which uses a 64-bit seconds field > and is

Re: [RESEND PATCH] USB: usbmon: Use 64bit timestamp for mon_bin_hdr

2015-11-05 Thread Arnd Bergmann
On Thursday 29 October 2015 22:44:31 Tina Ruchandani wrote: > struct mon_bin_hdr allows for a 64-bit seconds timestamp. The code > currently uses 'struct timeval' to populate the timestamp in mon_bin_hdr, > which has a 32-bit seconds field and will overflow in year 2038 and beyond. > This patch

Broken usb stick after plug it on an usb port?

2015-11-05 Thread Javier Barroso
Hello, I have a usb stick which was (apparently) broken after plug it on a usb port on my laptop [1] My sequence of operation is attached at kern.log-commented.gz This laptop have a port which "Anytime USB Charge (see inside

Re: [PATCH v2] USB: qmi_wwan: Add quirk for Quectel EC20 Mini PCIe module

2015-11-05 Thread David Miller
From: Petr Štetiar Date: Thu, 5 Nov 2015 12:55:01 +0100 > This device has same vendor and product IDs as G2K devices, but it has > different number of interfaces(4 vs 5) and also different interface > layout where EC20 has QMI on interface 4 instead of 0. > > lsusb output: ...

Re: [PATCH v2] usb: musb: fix tx fifo flush handling

2015-11-05 Thread Sergei Shtylyov
On 11/05/2015 10:54 PM, Bin Liu wrote: Here are a few changes in musb_h_tx_flush_fifo(). - Refering to 2ccc6d30a (usb: musb: fix bit mask for CSR in musb_h_tx_flush_fifo()), the datasheet says that MUSB_TXCSR_FLUSHFIFO is only valid when MUSB_TXCSR_TXPKTRDY is set as well. It means

Re: [PATCH] usb: musb: fix tx fifo flush handling

2015-11-05 Thread Felipe Balbi
Hi, Bin Liu writes: > Here are a few changes in musb_h_tx_flush_fifo(). > > - Refering to 2ccc6d30a (usb: musb: fix bit mask for CSR in > musb_h_tx_flush_fifo()), the datasheet says that MUSB_TXCSR_FLUSHFIFO > is only valid when MUSB_TXCSR_TXPKTRDY is set as well. It means >

[PATCH v2] usb: musb: fix tx fifo flush handling

2015-11-05 Thread Bin Liu
Here are a few changes in musb_h_tx_flush_fifo(). - Refering to 2ccc6d30a (usb: musb: fix bit mask for CSR in musb_h_tx_flush_fifo()), the datasheet says that MUSB_TXCSR_FLUSHFIFO is only valid when MUSB_TXCSR_TXPKTRDY is set as well. It means MUSB_TXCSR_TXPKTRDY should be checked, not set.

[PATCH] usb: musb: fix tx fifo flush handling

2015-11-05 Thread Bin Liu
Here are a few changes in musb_h_tx_flush_fifo(). - Refering to 2ccc6d30a (usb: musb: fix bit mask for CSR in musb_h_tx_flush_fifo()), the datasheet says that MUSB_TXCSR_FLUSHFIFO is only valid when MUSB_TXCSR_TXPKTRDY is set as well. It means MUSB_TXCSR_TXPKTRDY should be checked, not set.

Re: [RESEND PATCH] USB: usbmon: Use 64bit timestamp for mon_bin_hdr

2015-11-05 Thread Arnd Bergmann
On Thursday 05 November 2015 08:37:39 Greg Kroah-Hartman wrote: > On Thu, Nov 05, 2015 at 05:18:41PM +0100, Arnd Bergmann wrote: > > On Thursday 29 October 2015 22:44:31 Tina Ruchandani wrote: > > > struct mon_bin_hdr allows for a 64-bit seconds timestamp. The code > > > currently uses 'struct

Re: [PATCH 0/3] dwc2: Speed up the interrupt handler quite a bit

2015-11-05 Thread Heiko Stuebner
Am Mittwoch, 4. November 2015, 14:53:02 schrieb Douglas Anderson: > The dwc2 interrupt handler is quite slow. On rk3288 with a few things > plugged into the ports and with cpufreq locked at 696MHz (to simulate > real world idle system), I can easily observe dwc2_handle_hcd_intr() > taking > 120

Re: [PATCH v2] usb: musb: fix tx fifo flush handling

2015-11-05 Thread Sergei Shtylyov
On 11/05/2015 10:46 PM, Sergei Shtylyov wrote: Here are a few changes in musb_h_tx_flush_fifo(). - Refering to 2ccc6d30a (usb: musb: fix bit mask for CSR in musb_h_tx_flush_fifo()), the datasheet says that MUSB_TXCSR_FLUSHFIFO is only valid when MUSB_TXCSR_TXPKTRDY is set as well. It

Re: [PATCH v2] usb: musb: fix tx fifo flush handling

2015-11-05 Thread Bin Liu
Hi, On 11/05/2015 01:46 PM, Sergei Shtylyov wrote: Hello. On 11/05/2015 09:53 PM, Bin Liu wrote: Here are a few changes in musb_h_tx_flush_fifo(). - Refering to 2ccc6d30a (usb: musb: fix bit mask for CSR in musb_h_tx_flush_fifo()), the datasheet says that MUSB_TXCSR_FLUSHFIFO is only

Re: [PATCH] usb: musb: fix tx fifo flush handling

2015-11-05 Thread Bin Liu
On 11/05/2015 12:25 PM, Felipe Balbi wrote: Hi, Bin Liu writes: Here are a few changes in musb_h_tx_flush_fifo(). - Refering to 2ccc6d30a (usb: musb: fix bit mask for CSR in musb_h_tx_flush_fifo()), the datasheet says that MUSB_TXCSR_FLUSHFIFO is only valid when

Re: [PATCH v2] usb: musb: fix tx fifo flush handling

2015-11-05 Thread Sergei Shtylyov
Hello. On 11/05/2015 09:53 PM, Bin Liu wrote: Here are a few changes in musb_h_tx_flush_fifo(). - Refering to 2ccc6d30a (usb: musb: fix bit mask for CSR in musb_h_tx_flush_fifo()), the datasheet says that MUSB_TXCSR_FLUSHFIFO is only valid when MUSB_TXCSR_TXPKTRDY is set as well. It

Re: Broken usb stick after plug it on an usb port?

2015-11-05 Thread Greg KH
On Thu, Nov 05, 2015 at 06:03:15PM +0100, Javier Barroso wrote: > Hello, > > I have a usb stick which was (apparently) broken after plug it on a > usb port on my laptop [1] What do you mean exactly by "broken"? > My sequence of operation is attached at kern.log-commented.gz > > This laptop

Re: Broken usb stick after plug it on an usb port?

2015-11-05 Thread Javi Barroso
Hello, El 6 de noviembre de 2015 0:28:40 CET, Greg KH escribió: >On Thu, Nov 05, 2015 at 06:03:15PM +0100, Javier Barroso wrote: >> Hello, >> >> I have a usb stick which was (apparently) broken after plug it on a >> usb port on my laptop [1] > >What do you mean exactly by

Re: Overly conservative xHCI bandwidth estimation

2015-11-05 Thread Steinar H. Gunderson
On Fri, Nov 06, 2015 at 08:24:15AM +0800, Lu, Baolu wrote: > Yeah, sorry about it. > > 1) apply the attached patch on top the latest clean kernel. > 2) build and install the kernel. > 3) boot your machine with the new kernel. > 4) insert one Blackmagic Design device into USB3 root port. > 5)

Re: [PATCH 2/3] usb: dwc2: host: Giveback URB in tasklet context

2015-11-05 Thread Doug Anderson
Alan, On Thu, Nov 5, 2015 at 7:19 AM, Alan Stern wrote: > On Wed, 4 Nov 2015, Doug Anderson wrote: > >> In the ChromeOS gerrit >> Julius Werner >> points out that for EHCI it was good to take the optimization from

Re: Overly conservative xHCI bandwidth estimation

2015-11-05 Thread Lu, Baolu
On 11/06/2015 02:45 AM, Steinar H. Gunderson wrote: On Thu, Nov 05, 2015 at 04:12:24PM +0800, Lu, Baolu wrote: 1) apply the attached patch on top the latest kernel. I applied on top of a clean 4.3.0. $ cat /sys/bus/usb/devices//power/usb3_hardware_lpm_u1 $ cat

Re: [PATCH v2 00/13] usb: dwc2: descriptor dma mode bug fixes

2015-11-05 Thread John Youn
On 11/5/2015 12:41 AM, Gregory Herrero wrote: > Hi, > > This patchset contains bug fixes for host descriptor dma mode. > > Descriptor dma mode can't be used as the default mode since controller > does not support split transfers in this mode. > So we add a new configuration parameter which

Re: [PATCH v2 00/13] usb: dwc2: descriptor dma mode bug fixes

2015-11-05 Thread Doug Anderson
Hi, On Thu, Nov 5, 2015 at 12:41 AM, Gregory Herrero wrote: > Hi, > > This patchset contains bug fixes for host descriptor dma mode. > > Descriptor dma mode can't be used as the default mode since controller > does not support split transfers in this mode. > So we add

Re: [PATCH v2] usb: musb: fix tx fifo flush handling

2015-11-05 Thread Bin Liu
Hi, On 11/05/2015 02:04 PM, Sergei Shtylyov wrote: On 11/05/2015 10:54 PM, Bin Liu wrote: Here are a few changes in musb_h_tx_flush_fifo(). - Refering to 2ccc6d30a (usb: musb: fix bit mask for CSR in musb_h_tx_flush_fifo()), the datasheet says that MUSB_TXCSR_FLUSHFIFO is only valid

Re: [PATCH v2] usb: musb: fix tx fifo flush handling

2015-11-05 Thread Sergei Shtylyov
On 11/05/2015 11:53 PM, Sergei Shtylyov wrote: Here are a few changes in musb_h_tx_flush_fifo(). - Refering to 2ccc6d30a (usb: musb: fix bit mask for CSR in musb_h_tx_flush_fifo()), the datasheet says that MUSB_TXCSR_FLUSHFIFO is only valid when MUSB_TXCSR_TXPKTRDY is set as well. It

Re: [PATCH v2] usb: musb: fix tx fifo flush handling

2015-11-05 Thread Bin Liu
On 11/05/2015 02:53 PM, Sergei Shtylyov wrote: On 11/05/2015 11:34 PM, Bin Liu wrote: Here are a few changes in musb_h_tx_flush_fifo(). - Refering to 2ccc6d30a (usb: musb: fix bit mask for CSR in musb_h_tx_flush_fifo()), the datasheet says that MUSB_TXCSR_FLUSHFIFO is only valid when

Re: [PATCH v2] usb: musb: fix tx fifo flush handling

2015-11-05 Thread Sergei Shtylyov
Hello. On 11/06/2015 12:06 AM, Felipe Balbi wrote: Here are a few changes in musb_h_tx_flush_fifo(). - Refering to 2ccc6d30a (usb: musb: fix bit mask for CSR in musb_h_tx_flush_fifo()), the datasheet says that MUSB_TXCSR_FLUSHFIFO is only valid when MUSB_TXCSR_TXPKTRDY is set as well.

Re: [PATCH v2] usb: musb: fix tx fifo flush handling

2015-11-05 Thread Felipe Balbi
Hi again, Felipe Balbi writes: > Hi, > > Sergei Shtylyov writes: >> On 11/05/2015 11:34 PM, Bin Liu wrote: >> >>> Here are a few changes in musb_h_tx_flush_fifo(). >>> >>> - Refering to 2ccc6d30a (usb: musb: fix bit mask for CSR in

Re: [PATCH v2] usb: musb: fix tx fifo flush handling

2015-11-05 Thread Sergei Shtylyov
On 11/05/2015 11:34 PM, Bin Liu wrote: Here are a few changes in musb_h_tx_flush_fifo(). - Refering to 2ccc6d30a (usb: musb: fix bit mask for CSR in musb_h_tx_flush_fifo()), the datasheet says that MUSB_TXCSR_FLUSHFIFO is only valid when MUSB_TXCSR_TXPKTRDY is set as well. It means

Re: [PATCH v2] usb: musb: fix tx fifo flush handling

2015-11-05 Thread Felipe Balbi
Hi, Sergei Shtylyov writes: > On 11/05/2015 11:34 PM, Bin Liu wrote: > >> Here are a few changes in musb_h_tx_flush_fifo(). >> >> - Refering to 2ccc6d30a (usb: musb: fix bit mask for CSR in >>musb_h_tx_flush_fifo()), the datasheet says

Re: [PATCH v2] usb: musb: fix tx fifo flush handling

2015-11-05 Thread Bin Liu
Hi, On 11/05/2015 03:07 PM, Felipe Balbi wrote: Hi again, Felipe Balbi writes: Hi, Sergei Shtylyov writes: On 11/05/2015 11:34 PM, Bin Liu wrote: Here are a few changes in musb_h_tx_flush_fifo(). - Refering to 2ccc6d30a (usb: musb: fix

Re: [PATCH v2] usb: musb: fix tx fifo flush handling

2015-11-05 Thread Felipe Balbi
Hi, Bin Liu writes: > Hi, > > On 11/05/2015 03:07 PM, Felipe Balbi wrote: >> >> Hi again, >> >> Felipe Balbi writes: >>> Hi, >>> >>> Sergei Shtylyov writes: On 11/05/2015 11:34 PM, Bin Liu wrote: > Here are a

Re: [PATCH v2] usb: musb: fix tx fifo flush handling

2015-11-05 Thread Felipe Balbi
Hi, Sergei Shtylyov writes: > Hello. > > On 11/06/2015 12:06 AM, Felipe Balbi wrote: > Here are a few changes in musb_h_tx_flush_fifo(). - Refering to 2ccc6d30a (usb: musb: fix bit mask for CSR in

[PATCH 0/2] Configure AHB to post data transfers

2015-11-05 Thread Andy Gross
This patch configures the ChipIdea USB 2.0 controller found on Qualcomm platforms to post data transfers on the AHB bus. This yields approximately a 50% increase in performance. Andy Gross (2): usb: chipidea: msm: Use posted data writes on AHB usb: host: ehci-msm: Use posted data writes on

[PATCH 2/2] usb: host: ehci-msm: Use posted data writes on AHB

2015-11-05 Thread Andy Gross
This patch sets the AHBMODE to allow for posted data writes. This results in higher performance. Signed-off-by: Andy Gross --- drivers/usb/host/ehci-msm.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci-msm.c

Re: Overly conservative xHCI bandwidth estimation

2015-11-05 Thread Steinar H. Gunderson
On Fri, Nov 06, 2015 at 08:39:28AM +0800, Lu, Baolu wrote: > Have you set CONFIG_PM? Yes. CONFIG_PM=y. > Can you reproduce the problem with this kernel? I reproduced the U1/U2 disconnect issues several times. I didn't try the issue of not enough bandwidth for two devices. /* Steinar */ --

Re: [PATCH V4] usb: remove unnecessary CONFIG_PM dependency from USB_OTG

2015-11-05 Thread Peter Chen
On Thu, Nov 05, 2015 at 08:36:41AM -0600, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: > > On Tue, Nov 03, 2015 at 09:51:11PM -0600, Felipe Balbi wrote: > >> > >> Hi, > >> > >> Peter Chen writes: > >> > On Tue, Nov 03, 2015 at

[PATCH 1/2] usb: chipidea: msm: Use posted data writes on AHB

2015-11-05 Thread Andy Gross
This patch sets the AHBMODE to allow for posted data writes. This results in higher performance. Signed-off-by: Andy Gross --- drivers/usb/chipidea/ci_hdrc_msm.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c

Re: [PATCH 01/23] usb: gadget: f_sourcesink: make ISO altset user-selectable

2015-11-05 Thread Peter Chen
On Tue, Nov 03, 2015 at 01:53:40PM +0100, Robert Baldyga wrote: > So far it was decided during the bind process whether is iso altsetting > included to f_sourcesink function or not. This decision was based on > availability of isochronous endpoints. > > Since we can assemble gadget driver using

Re: Overly conservative xHCI bandwidth estimation

2015-11-05 Thread Lu, Baolu
On 11/06/2015 08:45 AM, Steinar H. Gunderson wrote: On Fri, Nov 06, 2015 at 08:39:28AM +0800, Lu, Baolu wrote: Have you set CONFIG_PM? Yes. CONFIG_PM=y. Can you reproduce the problem with this kernel? I reproduced the U1/U2 disconnect issues several times. I didn't try the issue of not

Re: [PATCH 02/23] usb: gadget: f_sourcesink: compute req size once

2015-11-05 Thread Peter Chen
On Tue, Nov 03, 2015 at 01:53:41PM +0100, Robert Baldyga wrote: > Compute request size once before the loop instead of computing it in each > loop iteration. > > Signed-off-by: Robert Baldyga > --- > drivers/usb/gadget/function/f_sourcesink.c | 45 >

Re: [PATCH 01/23] usb: gadget: f_sourcesink: make ISO altset user-selectable

2015-11-05 Thread Robert Baldyga
On 11/06/2015 04:05 AM, Peter Chen wrote: > On Tue, Nov 03, 2015 at 01:53:40PM +0100, Robert Baldyga wrote: >> So far it was decided during the bind process whether is iso altsetting >> included to f_sourcesink function or not. This decision was based on >> availability of isochronous endpoints.

Re: [RFC PATCH 1/2] usb: storage: scsiglue: further describe our 240 sector limit

2015-11-05 Thread Felipe Balbi
Hi, Alan Stern writes: > On Wed, 4 Nov 2015, Felipe Balbi wrote: > >> >> + * Tests show that other operating have similar limits with Microsoft >> >> + * Windows™ 7 limitting transfers to 128 sectors for both USB2 and USB3 >> >> + * and Apple Mac OS X™ 10.11

Re: [RFC PATCH 2/2] usb: storage: scsiglue: limit USB3 devices to 2048 sectors

2015-11-05 Thread Felipe Balbi
Hi, Oliver Neukum writes: > On Wed, 2015-11-04 at 16:26 -0500, Alan Stern wrote: >> This doesn't need to be stored as one of the usb-storage flags. And >> since we are close to running out of flag bits (on 32-bit >> architectures), it would be better not to use one of them

Re: [RFC PATCH 2/2] usb: storage: scsiglue: limit USB3 devices to 2048 sectors

2015-11-05 Thread Alan Stern
On Thu, 5 Nov 2015, Felipe Balbi wrote: > Hi, > > Oliver Neukum writes: > > On Wed, 2015-11-04 at 16:26 -0500, Alan Stern wrote: > >> This doesn't need to be stored as one of the usb-storage flags. And > >> since we are close to running out of flag bits (on 32-bit > >>

Re: [RFC PATCH 2/2] usb: storage: scsiglue: limit USB3 devices to 2048 sectors

2015-11-05 Thread Felipe Balbi
Hi, Alan Stern writes: > On Thu, 5 Nov 2015, Felipe Balbi wrote: > >> Hi, >> >> Oliver Neukum writes: >> > On Wed, 2015-11-04 at 16:26 -0500, Alan Stern wrote: >> >> This doesn't need to be stored as one of the usb-storage flags. And >> >> since

Re: [PATCH] uas: use the BIT() macro

2015-11-05 Thread Hans de Goede
Hi, On 05-11-15 16:20, Oliver Neukum wrote: Use this macro to make the driver more readable. Signed-off-by: Oliver Neukum Looks good to me: Reviewed-by: Hans de Goede Regards, Hans --- drivers/usb/storage/uas.c | 24

Re: [RFC PATCH 1/2] usb: storage: scsiglue: further describe our 240 sector limit

2015-11-05 Thread Alan Stern
On Wed, 4 Nov 2015, Felipe Balbi wrote: > >> + * Tests show that other operating have similar limits with Microsoft > >> + * Windows™ 7 limitting transfers to 128 sectors for both USB2 and USB3 > >> + * and Apple Mac OS X™ 10.11 limitting transfers to 256 sectors for USB2 > >> + * and

Re: [RFC PATCH 2/2] usb: storage: scsiglue: limit USB3 devices to 2048 sectors

2015-11-05 Thread Alan Stern
On Thu, 5 Nov 2015, Oliver Neukum wrote: > On Wed, 2015-11-04 at 16:26 -0500, Alan Stern wrote: > > This doesn't need to be stored as one of the usb-storage flags. And > > since we are close to running out of flag bits (on 32-bit > > architectures), it would be better not to use one of them for

[PATCH] uas: use the BIT() macro

2015-11-05 Thread Oliver Neukum
Use this macro to make the driver more readable. Signed-off-by: Oliver Neukum --- drivers/usb/storage/uas.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index

Re: [PATCH 2/3] usb: dwc2: host: Giveback URB in tasklet context

2015-11-05 Thread Alan Stern
On Wed, 4 Nov 2015, Doug Anderson wrote: > In the ChromeOS gerrit > Julius Werner > points out that for EHCI it was good to take the optimization from > commit 9118f9eb4f1e ("USB: EHCI: improve interrupt qh unlink") before > this one. I'm

Re: [PATCH v2] USB: qmi_wwan: Add quirk for Quectel EC20 Mini PCIe module

2015-11-05 Thread Bjørn Mork
Petr Štetiar writes: > This device has same vendor and product IDs as G2K devices, but it has > different number of interfaces(4 vs 5) and also different interface > layout where EC20 has QMI on interface 4 instead of 0. > > lsusb output: > > Bus 002 Device 003: ID 05c6:9215