Re: [PATCH v5 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.

2015-11-28 Thread Dave Penkler
On Wed, Nov 25, 2015 at 10:38:39PM +0200, Andy Shevchenko wrote: > On Wed, Nov 25, 2015 at 11:18 AM, Dave Penkler wrote: > > On Sun, Nov 22, 2015 at 12:32:41PM +0200, Andy Shevchenko wrote: > >> On Sun, Nov 22, 2015 at 11:19 AM, Dave Penkler wrote: > >> >

Re: [PATCH 1/3] usb: musb: convert printk to pr_*

2015-11-28 Thread Sergei Shtylyov
On 11/28/2015 3:04 AM, Greg Kroah-Hartman wrote: This file already uses pr_debug in a few places; this converts the remaining printks. Are you aware that printk(KERN_DEBUG, ...) and pr_debug() are not equivalent? Yes, and that is a good thing, you should be using pr_debug() instead of

[PATCH 2/2] USB: constify usb_mon_operations structure

2015-11-28 Thread Julia Lawall
The usb_mon_operations structure is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/usb/core/hcd.c |4 ++-- drivers/usb/mon/mon_main.c |2 +- 2 files changed, 3 insertions(+), 3 deletions(-)

[PATCH 1/2] USB: constify usb_mon_operations structure

2015-11-28 Thread Julia Lawall
The usb_mon_operations structure is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- include/linux/usb/hcd.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/usb/hcd.h

Re: [PATCH v5 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.

2015-11-28 Thread Dave Penkler
On Sat, Nov 28, 2015 at 04:57:47PM +0200, Andy Shevchenko wrote: > On Sat, Nov 28, 2015 at 1:55 PM, Dave Penkler wrote: > > On Wed, Nov 25, 2015 at 10:38:39PM +0200, Andy Shevchenko wrote: > >> On Wed, Nov 25, 2015 at 11:18 AM, Dave Penkler wrote: > >> >

Re: [PATCH 1/2] USB: constify usb_mon_operations structure

2015-11-28 Thread kbuild test robot
Hi Julia, [auto build test ERROR on: v4.4-rc2] [also build test ERROR on: next-20151127] url: https://github.com/0day-ci/linux/commits/Julia-Lawall/USB-constify-usb_mon_operations-structure/20151128-223726 config: xtensa-allyesconfig (attached as .config) reproduce: wget https

[PATCH v2] USB: constify usb_mon_operations structure

2015-11-28 Thread Julia Lawall
The usb_mon_operations structure is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- v2: Merge the previous 1/2 and 2/2 patches. drivers/usb/core/hcd.c |4 ++-- drivers/usb/mon/mon_main.c |2 +-

Re: [PATCH v5 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.

2015-11-28 Thread Andy Shevchenko
On Sat, Nov 28, 2015 at 1:55 PM, Dave Penkler wrote: > On Wed, Nov 25, 2015 at 10:38:39PM +0200, Andy Shevchenko wrote: >> On Wed, Nov 25, 2015 at 11:18 AM, Dave Penkler wrote: >> > On Sun, Nov 22, 2015 at 12:32:41PM +0200, Andy Shevchenko wrote: >> >> On

[PATCH] usb: gadget: uvc: fix permissions of configfs attributes

2015-11-28 Thread Mian Yousaf Kaukab
76e0da3 "usb-gadget/uvc: use per-attribute show and store methods" removed write permission for writeable attributes. Correct attribute permissions. Fixes: 76e0da3 "usb-gadget/uvc: use per-attribute show and store methods" Signed-off-by: Mian Yousaf Kaukab ---

Re: [PATCH v5 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.

2015-11-28 Thread Andy Shevchenko
On Sat, Nov 28, 2015 at 7:41 PM, Dave Penkler wrote: > On Sat, Nov 28, 2015 at 04:57:47PM +0200, Andy Shevchenko wrote: >> On Sat, Nov 28, 2015 at 1:55 PM, Dave Penkler wrote: >> > On Wed, Nov 25, 2015 at 10:38:39PM +0200, Andy Shevchenko wrote: >> >> On

Re: [PATCHv3 00/14] Equivalent of tcm_usb_gadget with configfs

2015-11-28 Thread Nicholas A. Bellinger
Hi Andrzej & Co, On Mon, 2015-11-23 at 09:22 +0100, Andrzej Pietrasiewicz wrote: > W dniu 15.11.2015 o 00:27, Nicholas A. Bellinger pisze: > > Hi Andrzej & Co, > > > > > > >> > > > > Ok, I've added both series into target-pending/queue-next so kbuild can > > give it a first pass. > > > > We'll