[RFC PATCH 3/5] usb: misc: generic_onboard_hub: add generic onboard USB device driver

2015-12-18 Thread Peter Chen
Current USB device driver lacks of platform interfaces to configure external signal on HUB chip, eg, the PHY input clock and gpio reset pin for HUB, these kinds of devices are usually soldered at the board, and they are not hot-plug USB devices. With this patch, the user can configure the

[RFC PATCH 1/5] usb: hub: add device tree support for populating onboard usb device

2015-12-18 Thread Peter Chen
Although most of USB device is hot-plug's, there are still some USB devices are soldered on the board, and these kinds of devices maybe the upstream device at 1st or 2nd level hub's, so in order to detect all onboard devices, we put the detect device node code at hub's driver, and it will populate

[RFC PATCH 0/5] USB: add generic onboard USB driver

2015-12-18 Thread Peter Chen
Hi all, This is later patch set for generic onboard HUB dirver [1], since I find it can apply for all generic onboard USB devices, so I changed a little for it, it should be work for the use case found at imx6qdl udoo board, but several people have comments for its design, I mark RFC for

Re: [PATCH v3 0/9] phy: use syscon framework APIs to set ctrl mod reg

2015-12-18 Thread Kishon Vijay Abraham I
Hi, On Tuesday 15 December 2015 08:56 PM, Tony Lindgren wrote: > * Kishon Vijay Abraham I [151215 04:47]: >> On Tuesday 15 December 2015 05:25 PM, Arnd Bergmann wrote: > > Can you explain here what the conversion is good for? Why do you > prefer the syscon mapping over

Re: [PATCH v3 1/4] ARM: dts: dra7: Add dt node for the sycon pcie

2015-12-18 Thread Kishon Vijay Abraham I
Hi, On Tuesday 15 December 2015 06:52 PM, Sergei Shtylyov wrote: > Hello. > > On 12/15/2015 12:39 PM, Kishon Vijay Abraham I wrote: > >> Add new device tree node for the control module register space where >> PCIe registers are present. >> >> Signed-off-by: Kishon Vijay Abraham I

[PATCH] drivers/usb : Port USB EHCI host driver for LS102xA

2015-12-18 Thread Sriram Dash
Change Power architecture specific APIs such as in_be32/out_be32 for registers read/write. Instead using ioread/writebe32 which are defined for power as well as arm architecture Signed-off-by: Nikhil Badola Signed-off-by: Sriram Dash

Re: [PATCH 1/2] HID: Use multitouch driver for Type Covers

2015-12-18 Thread Akihiko Odaki
The "Charm" keys seem to issue short-cut key combinations. I also found Microsoft's document by searching for the combinations. https://msdn.microsoft.com/en-us/library/windows/hardware/dn614461(v=vs.85).aspx So the behavior of hid-multitouch is completely fine. On 12/18/2015 03:28 PM, Akihiko

[RFC PATCH 2/5] doc: dt-binding: generic onboard USB device

2015-12-18 Thread Peter Chen
Add dt-binding documentation for generic onboard USB device. Signed-off-by: Peter Chen --- .../bindings/usb/generic-onboard-device.txt| 31 ++ 1 file changed, 31 insertions(+) create mode 100644

[RFC PATCH 4/5] usb: chipidea: host: let the hcd know's parent device node

2015-12-18 Thread Peter Chen
Since the hcd (chipidea core device) has no device node, so if we want to describe the child node under the hcd, we had to put it under its parent's node (glue layer device), and in the code, we need to let the hcd knows glue layer's code, then the USB core can handle this node. Signed-off-by:

[RFC PATCH 5/5] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

2015-12-18 Thread Peter Chen
The current dts describes USB HUB's property at USB controller's entry, it is improper. The USB HUB should be the child node under USB controller. Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx6qdl-udoo.dtsi | 35 ++- 1 file

Re: [PATCH 1/2] HID: Use multitouch driver for Type Covers

2015-12-18 Thread Benjamin Tissoires
On Fri, Dec 18, 2015 at 10:12 AM, Akihiko Odaki wrote: > The "Charm" keys seem to issue short-cut key combinations. > I also found Microsoft's document by searching for the combinations. > >

[PATCH 2/3] usb: phy-generic: register a struct phy device

2015-12-18 Thread Uwe Kleine-König
This is needed to let the omap3 otg controller make use of a generic usb-nop-xceiv phy. --- drivers/usb/phy/phy-generic.c | 50 --- drivers/usb/phy/phy-generic.h | 1 + 2 files changed, 48 insertions(+), 3 deletions(-) diff --git

[PATCH 3/3] usb: phy: ulpi: implement creating a phy via oftree

2015-12-18 Thread Uwe Kleine-König
Todo: binding document, more properties Signed-off-by: Uwe Kleine-König --- drivers/usb/phy/phy-ulpi.c | 129 + 1 file changed, 119 insertions(+), 10 deletions(-) diff --git a/drivers/usb/phy/phy-ulpi.c

[PATCH 1/3] usb: musb: core: call init and shutdown for the usb phy

2015-12-18 Thread Uwe Kleine-König
The phy's init routine must be called before it can be used. Do so in musb_init_controller and the matching shutdown in musb_remove. Signed-off-by: Uwe Kleine-König --- Note I'm not entirely sure this is the right place, but this made usb working on my omap3

[PATCH 0/3] usb: device tree binding and phy integration for musb

2015-12-18 Thread Uwe Kleine-König
Hello, these patches make it possible to use USB on an omap3 machine with an USB3320 external phy. Best regards Uwe Uwe Kleine-König (3): usb: musb: core: call init and shutdown for the usb phy usb: phy-generic: register a struct phy device usb: phy: ulpi: implement creating a phy via

Re: [PATCH v3 1/4] ARM: dts: dra7: Add dt node for the sycon pcie

2015-12-18 Thread Sergei Shtylyov
Hello. On 12/18/2015 1:21 PM, Kishon Vijay Abraham I wrote: Add new device tree node for the control module register space where PCIe registers are present. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra7.dtsi |5 + 1 file changed, 5 insertions(+)

[PATCH RESENT] staging/emxx_udc: fix 64-bit warnings

2015-12-18 Thread Arnd Bergmann
ARCH_SHMOBILE is coming to arm64, which creates new warnings in allmodconfig: drivers/staging/emxx_udc/emxx_udc.c: In function '_nbu2ss_out_dma': drivers/staging/emxx_udc/emxx_udc.c:843:45: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

[PATCH v2 1/2] net: usb: cdc_ncm: Adding Dell DW5812 LTE Verizon Mobile Broadband Card

2015-12-18 Thread Daniele Palmas
Unlike DW5550, Dell DW5812 is a mobile broadband card with no ARP capabilities: the patch makes this device to use wwan_noarp_info struct Signed-off-by: Daniele Palmas --- drivers/net/usb/cdc_ncm.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH v2 0/2] net: usb: cdc_ncm: Adding support for two new Dell devices

2015-12-18 Thread Daniele Palmas
This patch series add support in the cdc_ncm driver for two devices based on the same platform, that are different only for carrier customization. V2: Added comment for highlighting FLAG_NOARP usage for those devices Daniele Palmas (2): net: usb: cdc_ncm: Adding Dell DW5812 LTE Verizon Mobile

Re: [PATCH] make of_usb_get_dr_mode_by_phy helper inline

2015-12-18 Thread Felipe Balbi
Hi, Arnd Bergmann writes: > The recently added of_usb_get_dr_mode_by_phy function causes a link error > when CONFIG_OF is disabled: > > drivers/usb/common/built-in.o: In function `of_usb_get_dr_mode_by_phy': > include/linux/usb/of.h:23: multiple definition of

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-18 Thread Alan Stern
On Fri, 18 Dec 2015, Peter Chen wrote: > On Fri, Dec 18, 2015 at 12:13 AM, Alan Stern > wrote: > > It's not clear (to me, anyway) how this is meant to work. USB is a > > completely discoverable bus: There is no way to represent devices > > statically; they have to

Re: [PATCH v3] extcon: add Maxim MAX3355 driver

2015-12-18 Thread Sergei Shtylyov
Hello. On 12/18/2015 3:19 AM, Krzysztof Kozlowski wrote: [...] Please pass the source through recent coccicheck and fix the findings. Has it been included in the kernel source somewhere already? The rules detecting the unnecessary owner should be there for some time (sice 4.2 or

[PATCH v2 2/2] net: usb: cdc_ncm: Adding Dell DW5813 LTE AT Mobile Broadband Card

2015-12-18 Thread Daniele Palmas
Unlike DW5550, Dell DW5813 is a mobile broadband card with no ARP capabilities: the patch makes this device to use wwan_noarp_info struct Signed-off-by: Daniele Palmas --- drivers/net/usb/cdc_ncm.c | 9 + 1 file changed, 9 insertions(+) diff --git

Re: [PATCH v4] extcon: add Maxim MAX3355 driver

2015-12-18 Thread Sergei Shtylyov
Hello. On 12/18/2015 4:14 AM, Chanwoo Choi wrote: Except for just one comment below, Looks good to me. Acked-by: Chanwoo Choi I'll wait for a few days to get the review from DT maintainer before applying it on extcon-next branch. On 2015년 12월 18일 07:47, Sergei

[PATCH] make of_usb_get_dr_mode_by_phy helper inline

2015-12-18 Thread Arnd Bergmann
The recently added of_usb_get_dr_mode_by_phy function causes a link error when CONFIG_OF is disabled: drivers/usb/common/built-in.o: In function `of_usb_get_dr_mode_by_phy': include/linux/usb/of.h:23: multiple definition of `of_usb_get_dr_mode_by_phy'

Re: [PATCH 1/2] HID: Use multitouch driver for Type Covers

2015-12-18 Thread Bastien Nocera
On Mon, 2015-12-14 at 21:50 +0900, Akihiko Odaki wrote: > Use multitouch driver instead of microsoft one for Microsoft Surface > Type Covers. > > By using MT_CLS_EXPORT_ALL_INPUTS, the keyboards function as well as > the multitouch pads do. > > Signed-off-by: Akihiko Odaki

[PATCH 8/9] usb: gadget: rndis: use list_for_each_entry_safe

2015-12-18 Thread Geliang Tang
Use list_for_each_entry_safe() instead of list_for_each_safe() to simplify the code. Signed-off-by: Geliang Tang --- drivers/usb/gadget/function/rndis.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git

[PATCH 2/9] usb: host: max3421-hcd: use list_for_each_entry*

2015-12-18 Thread Geliang Tang
Use list_for_each_entry*() instead of list_for_each*() to simplify the code. Signed-off-by: Geliang Tang --- drivers/usb/host/max3421-hcd.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/usb/host/max3421-hcd.c

[PATCH 6/9] usb: chipidea: debug: use list_for_each_entry

2015-12-18 Thread Geliang Tang
Use list_for_each_entry() instead of list_for_each() to simplify the code. Signed-off-by: Geliang Tang --- drivers/usb/chipidea/debug.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c index

[PATCH 7/9] usb: dwc2: host: use list_for_each_entry_safe

2015-12-18 Thread Geliang Tang
Use list_for_each_entry_safe() instead of list_for_each_safe() to simplify the code. Signed-off-by: Geliang Tang --- drivers/usb/dwc2/hcd_ddma.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/dwc2/hcd_ddma.c

[PATCH 3/9] usb: host: oxu210hp-hcd: use list_for_each_entry_safe

2015-12-18 Thread Geliang Tang
Use list_for_each_entry_safe() instead of list_for_each_safe() to simplify the code. Signed-off-by: Geliang Tang --- drivers/usb/host/oxu210hp-hcd.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host/oxu210hp-hcd.c

[PATCH 9/9] usb: gadget: bcm63xx_udc: use list_for_each_entry_safe

2015-12-18 Thread Geliang Tang
Use list_for_each_entry_safe() instead of list_for_each_safe() to simplify the code. Signed-off-by: Geliang Tang --- drivers/usb/gadget/udc/bcm63xx_udc.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/usb/gadget/udc/bcm63xx_udc.c

[PATCH 1/9] usb: host: fotg210: use list_for_each_entry_safe

2015-12-18 Thread Geliang Tang
Use list_for_each_entry_safe() instead of list_for_each_safe() to simplify the code. Signed-off-by: Geliang Tang --- drivers/usb/host/fotg210-hcd.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host/fotg210-hcd.c

xhci list corruption on sysfs removal

2015-12-18 Thread Joe Lawrence
Hello Roger and Mathias, Running with slub_debug=FZPU and removing an XHCI host controller via sysfs, I've hit a use-after-free that I've bisected to: 8c24d6d7b09deee3036ddc4f2b81b53b28c8f877 is the first bad commit commit 8c24d6d7b09deee3036ddc4f2b81b53b28c8f877 Author: Roger Quadros

[PATCH 4/9] usb: host: u132-hcd: use list_for_each_entry

2015-12-18 Thread Geliang Tang
Use list_for_each_entry() instead of list_for_each() to simplify the code. Signed-off-by: Geliang Tang --- drivers/usb/host/u132-hcd.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/usb/host/u132-hcd.c

[PATCH 5/9] usb: xhci: use list_for_each_entry

2015-12-18 Thread Geliang Tang
Use list_for_each_entry() instead of list_for_each() to simplify the code. Signed-off-by: Geliang Tang --- drivers/usb/host/xhci-ring.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index

Re: [PATCH 7/9] usb: dwc2: host: use list_for_each_entry_safe

2015-12-18 Thread Julia Lawall
> > Hi Geliang, > > [auto build test WARNING on usb/usb-testing] > [also build test WARNING on v4.4-rc5 next-20151218] > > url: > https://github.com/0day-ci/linux/commits/Geliang-Tang/usb-host-fotg210-use-list_for_each_entry_safe/20151219-003955 > base

Re: [PATCH 5/9] usb: xhci: use list_for_each_entry

2015-12-18 Thread Julia Lawall
63.com>, linux-usb@vger.kernel.org, > linux-ker...@vger.kernel.org > > Hi Geliang, > > [auto build test WARNING on usb/usb-testing] > [also build test WARNING on v4.4-rc5 next-20151218] > > url: > https://github.com/0day-ci/linux/commits/Geliang-Tang

[PATCH] usb: gadget: rndis: fix itnull.cocci warnings

2015-12-18 Thread Julia Lawall
The index variable of list_for_each_entry_safe is never NULL. Generated by: scripts/coccinelle/iterators/itnull.cocci CC: Geliang Tang Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- rndis.c |2 +- 1 file

Re: [PATCH] usb: dwc2: add shutdown callback to platform variant

2015-12-18 Thread Doug Anderson
Heiko, On Fri, Dec 18, 2015 at 3:17 PM, Heiko Stübner wrote: > Hi Doug, > > Am Freitag, 18. Dezember 2015, 14:50:14 schrieb Doug Anderson: >> On Fri, Dec 18, 2015 at 10:30 AM, Heiko Stübner >> wrote: >> > In specific conditions

[PATCH v5] extcon: add Maxim MAX3355 driver

2015-12-18 Thread Sergei Shtylyov
Maxim Integrated MAX3355E chip integrates a charge pump and comparators to enable a system with an integrated USB OTG dual-role transceiver to function as an USB OTG dual-role device. In addition to sensing/controlling Vbus, the chip also passes thru the ID signal from the USB OTG connector. On

Re: [PATCH] usb: dwc2: add shutdown callback to platform variant

2015-12-18 Thread Heiko Stübner
Hi Doug, Am Freitag, 18. Dezember 2015, 14:50:14 schrieb Doug Anderson: > On Fri, Dec 18, 2015 at 10:30 AM, Heiko Stübner > wrote: > > In specific conditions (involving usb hubs) dwc2 devices can create a > > lot of interrupts, even to the point of overwhelming

Re: Help needed for EHCI problem: removing an active bulk-in QH

2015-12-18 Thread Michael Reutman
First, apologies for the delay. This fell off my radar and I'm just getting back around to running your last patch. I'm kicking off our test application to run over the weekend with the last patch provided. I'll let you and everyone else know how it went on Monday morning. Michael Reutman

Re: [PATCH 1/2] HID: Use multitouch driver for Type Covers

2015-12-18 Thread Akihiko Odaki
No, it doesn't work. On 12/19/2015 12:06 AM, Bastien Nocera wrote: > On Mon, 2015-12-14 at 21:50 +0900, Akihiko Odaki wrote: >> Use multitouch driver instead of microsoft one for Microsoft Surface >> Type Covers. >> >> By using MT_CLS_EXPORT_ALL_INPUTS, the keyboards function as well as >> the

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-18 Thread Maciej S. Szmigiero
On 17.12.2015 07:57, Peter Chen wrote: > On Wed, Dec 16, 2015 at 09:05:35PM +0100, Maciej S. Szmigiero wrote: >> Hi Fabio, >> Hi Peter, >> >> On 16.12.2015 11:11, Fabio Estevam wrote: >>> Hi Peter, >>> >>> On Wed, Dec 16, 2015 at 2:11 AM, Peter Chen >>> wrote: >>>

Re: [PATCH v2 0/2] net: usb: cdc_ncm: Adding support for two new Dell devices

2015-12-18 Thread David Miller
From: Daniele Palmas Date: Fri, 18 Dec 2015 14:43:32 +0100 > This patch series add support in the cdc_ncm driver for two devices > based on the same platform, that are different only for carrier > customization. > > V2: Added comment for highlighting FLAG_NOARP usage for those

Re: USB 3 XHCI Host Controller in Ubuntu

2015-12-18 Thread Andor J Kiss
USB3 thumbdrive works on Windows 7 machines. No docking stations, or extension cables. I don't understand what you mean by "seeing any extra pins in the host port?" Can you explain? Booting with USB3 thumbdrive in a USB3 port does not work. How do I disable powermanagement for the purposes of

Re: [PATCH v2 1/3] reset: Add shared reset_control_[de]assert variants

2015-12-18 Thread Maxime Ripard
On Wed, Dec 16, 2015 at 12:21:48PM +0100, Philipp Zabel wrote: > Hi Maxime, > > Am Mittwoch, den 16.12.2015, 11:29 +0100 schrieb Maxime Ripard: > > On Mon, Dec 14, 2015 at 10:50:55AM +0100, Philipp Zabel wrote: > > > Am Montag, den 14.12.2015, 10:36 +0100 schrieb Maxime Ripard: > > > > Hi, > > >

Re: [PATCH] usb: dwc2: add shutdown callback to platform variant

2015-12-18 Thread Doug Anderson
Heiko, On Fri, Dec 18, 2015 at 10:30 AM, Heiko Stübner wrote: > In specific conditions (involving usb hubs) dwc2 devices can create a > lot of interrupts, even to the point of overwhelming devices running > at low frequencies. Some devices need to do special clock

Re: [RFC PATCH 2/5] doc: dt-binding: generic onboard USB device

2015-12-18 Thread Rob Herring
On Fri, Dec 18, 2015 at 05:33:56PM +0800, Peter Chen wrote: > Add dt-binding documentation for generic onboard USB device. As has already been mentioned, please following the existing USB device binding convention. We can debate whether the kernel driver is tied into existing USB drivers or

Re: [PATCH v2] usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller

2015-12-18 Thread Rob Herring
On Wed, Dec 16, 2015 at 11:51:59AM +0900, Yoshihiro Shimoda wrote: > R-Car H3 has USB3.0 peripheral controllers. This controller's has the > following features: > - Supports super, high and full speed > - Contains 30 pipes for bulk or interrupt transfer > - Contains dedicated DMA controller >

Re: [PATCH v4 2/3] usb: renesas_usbhs: add fallback compatibility strings

2015-12-18 Thread Rob Herring
On Wed, Dec 16, 2015 at 01:51:51PM +0900, Simon Horman wrote: > Add fallback compatibility strings for R-Car Gen2 and Gen3. > This is in keeping with the fallback scheme being adopted wherever > appropriate for drivers for Renesas SoCs. > > Signed-off-by: Simon Horman

Re: [PATCH v4] extcon: add Maxim MAX3355 driver

2015-12-18 Thread Rob Herring
On Fri, Dec 18, 2015 at 01:47:14AM +0300, Sergei Shtylyov wrote: > Maxim Integrated MAX3355E chip integrates a charge pump and comparators to > enable a system with an integrated USB OTG dual-role transceiver to > function as an USB OTG dual-role device. In addition to sensing/controlling > Vbus,

Re: [PATCH v4 1/3] usb: renesas_usbhs: add SoC names to compatibility string documentation

2015-12-18 Thread Rob Herring
On Wed, Dec 16, 2015 at 01:51:50PM +0900, Simon Horman wrote: > This extends the documentation of compatibility strings a little to > include the SoC names. > > Signed-off-by: Simon Horman > Acked-by: Kuninori Morimoto > > --- > v3