[PATCH 0/7] fix error return code

2015-12-26 Thread Julia Lawall
The complate semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @ok exists@ identifier f,ret,i; expression e; constant c; @@ // identify a function that returns a negative return value at least once. f(...) { ... when any ( return -c@i; | ret = -c@i; ... when

[PATCH 4/7] usb: gadget: legacy: fix error return code

2015-12-26 Thread Julia Lawall
Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = e1 when !=

[PATCH 0/2] remove assignment from IS_ERR argument

2015-12-26 Thread Julia Lawall
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression e1,e2; statement S1,S2; @@ +e1 = e2; if (IS_ERR( e1 - = e2 )) S1 else S2 // --- drivers/usb/mon/mon_text.c |6 -- ipc/mqueue.c |3 ++- 2 files changed, 6

[PATCH 2/2] USB: usbmon: remove assignment from IS_ERR argument

2015-12-26 Thread Julia Lawall
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression e1,e2; statement S1,S2; @@ +e1 = e2; if (IS_ERR( e1 - = e2 )) S1 else S2 // Signed-off-by: Julia Lawall --- drivers/usb/mon/mon_text.c |6 -- 1 file

Re: [GIT PULL] USB patches for v4.5

2015-12-26 Thread Greg KH
On Wed, Dec 23, 2015 at 10:45:56AM -0600, Felipe Balbi wrote: > Hi Greg, > > Here's the large usb gadget pull request for v4.5. Please consider > merging it to your usb-next branch. We have a total 97 non-merge commits > this time, so a substantial amount of code. Here's a dirstat to show you >

Re: [GIT PULL] USB Chipidea changes for v4.5-rc1

2015-12-26 Thread Greg KH
On Fri, Dec 25, 2015 at 03:43:17AM +, Peter Chen wrote: > The following changes since commit bfccd95e7aba73d0d3154912b17b855cb9938c50: > > Merge 4.4-rc6 into usb-next (2015-12-21 11:11:12 -0800) > > are available in the git repository at: > > >

Re: [PATCH] usb: udc: lpc32xx: fix warnings caused by enabling unprepared clock

2015-12-26 Thread Vladimir Zapolskiy
Hi Felipe, Greg, On 02.12.2015 08:17, Vladimir Zapolskiy wrote: > Hi Felipe, > > On 17.10.2015 22:24, Vladimir Zapolskiy wrote: >> If common clock framework is configured, the driver generates warnings, >> which is fixed by this change: >> >> WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:728