Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child

santosh shilimkar writes: > +Arnd, RMK, > > On 4/1/2016 4:57 AM, Felipe Balbi wrote: >> >> Hi, >> >> Grygorii Strashko writes: >>> On 04/01/2016 01:20 PM, Felipe Balbi wrote: > > [...] > >>> commit 7ace8fc8219e4cbbfd5b4790390d9a01a2541cdf

[PATCH 1/2] usb: dwc3: gadget: combine return points into a single one

dwc3_send_gadget_ep_cmd() had three return points. That becomes a pain to track when we need to debug something or if we need to add more code before returning. Let's combine all three return points into a single one just by introducing a local 'ret' variable. Signed-off-by: Felipe Balbi

[PATCH 2/2] usb: dwc3: gadget: clear SUSPHY bit before StartTransfer

Synopsys Databook 2.60a has a note that if we're sending a Start Transfer command we _must_ make sure that DWC3_GUSB2PHY(n).SUSPHY bit is cleared. This patch implements that particular detail. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 25

Re: [RFC] Create an audit record of USB specific details

On Mon, 2016-04-04 at 00:02 -0400, wmealing wrote: > From: Wade Mealing > > Gday, > > I'm looking to create an audit trail for when devices are added or removed > from the system. > > The audit subsystem is a logging subsystem in kernel space that can be > used to create

Re: [PATCH v2 05/14] USB: ch341: fix USB buffer allocations

On Sat, 2016-04-02 at 19:07 +0200, Grigori Goronzy wrote: > Use the correct types and sizes. > > Signed-off-by: Grigori Goronzy > --- > drivers/usb/serial/ch341.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/serial/ch341.c

Re: [RFC] Create an audit record of USB specific details

Oliver Neukum writes: > On Mon, 2016-04-04 at 00:02 -0400, wmealing wrote: > >> I'm looking to create an audit trail for when devices are added or removed >> from the system. >> >> The audit subsystem is a logging subsystem in kernel space that can be >> used to create advanced

Re: [PATCH 1/2] usb: dwc3: core: Introduce dwc3_device_reinit()

+Abhishek, Ravi, Felipe, On 31/03/16 17:26, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>> We will need this function for a workaround. >>> The function issues a softreset only to the device >>> controller and performs minimal

Re: musb: kernel 3.18.29 build issue

Hi Bin, On Thu, Mar 31, 2016 at 9:58 PM, Bin Liu wrote: > On Thu, Mar 31, 2016 at 12:48:39PM -0700, Greg KH wrote: >> On Thu, Mar 31, 2016 at 02:10:59PM -0500, Bin Liu wrote: >> > Hi Greg, >> > >> > On Thu, Mar 31, 2016 at 09:06:10AM -0700, Greg KH wrote: >> > > On Thu, Mar 31,

Re: usb 3.0 stopped working with 4.6.0 rc1

On 02.04.2016 02:29, Paulo Dias wrote: Would you mind sending me the patches , so i could test with my external HD? even with today git build im getting all but errors with this controller and the driver. with today build i even have one shutdown usb 3.0 port! Regression fix is in Gregs

Re: [PATCH 1/2] usb: dwc3: core: Introduce dwc3_device_reinit()

Hi, Roger Quadros writes: We will need this function for a workaround. The function issues a softreset only to the device controller and performs minimal re-initialization so that the device controller can be usable.

Re: [patch] usb: gadget: f_midi: unlock on error

Hi Dan, On 02/04/16 05:51, Dan Carpenter wrote: > We added some new locking here, but missed an error path where we need > to unlock. > > Fixes: 9acdf4df2fc4 ('usb: gadget: f_midi: added spinlock on transmit > function') > Signed-off-by: Dan Carpenter Acked-by:

Re: XHCI is slow during boot (bios/efi) and leaves many dmesg messages

On 04.04.2016 12:06, Olliver Schinagl wrote: Hi list, I have a Apple Inc. MacBookPro11,1 (with the most recent 'bios': BIOS MBP111.88Z.0138.B16.1509081438 09/08/2015). At the beginning, USB worked normally. After a while (and after newer kernel versions released by debian?) things started to

Re: [PATCH] usb: dwc3: keystone: drop dma_mask configuration

Hi, Grygorii Strashko writes: > The Keystone 2 supports DT-boot only, as result dma_mask will be > always configured properly from DT - > of_platform_device_create_pdata()->of_dma_configure(). More over, > dwc3-keystone.c can be built as module and in this case it's

[PATCH 1/2] usb: dwc3: gadget: extract unlocked dwc3_gadget_wakeup()

we will need this from StartTransfer to make sure link is in U0 before starting a transfer. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git

[PATCH 2/2] usb: dwc3: gadget: put link to U0 before Start Transfer

Synopsys Databook says we should move link to U0 before issuing a Start Transfer command. We could require the gadget driver to call usb_gadget_wakeup() however I feel that changing all gagdget drivers to keep track of Link State and conditionally call usb_gadget_wakeup() would be far too much

Re: [PATCH] usb: dwc2: gadget: avoid null dereference on incomplete transfer

Hi, John Youn writes: > On 3/30/2016 6:22 AM, Felipe Balbi wrote: >> >> Hi, >> >> John Keeping writes: >>> Setting up a gadget with the uac2 function results in: >>> >>> Unable to handle kernel NULL pointer dereference at virtual address >>>

Re: [PATCH v4] usb: xhci: applying XHCI_PME_STUCK_QUIRK to Intel BXT B0 host

Hi Mathias, Robert Dobrowolski writes: > From: Rafal Redzimski > > Broxton B0 also requires XHCI_PME_STUCK_QUIRK. > Adding PCI device ID for Broxton B and adding to quirk. > > Cc: > Signed-off-by: Rafal

Re: [patch] usb: gadget: f_midi: unlock on error

On Sat, Apr 02 2016, Dan Carpenter wrote: > We added some new locking here, but missed an error path where we need > to unlock. > > Fixes: 9acdf4df2fc4 ('usb: gadget: f_midi: added spinlock on transmit > function') > Signed-off-by: Dan Carpenter > Acked-by: Michal

Re: [PATCH 1/5 v10] dt/bindings: Add binding for the DA8xx MUSB driver

On 15.03.2016 03:07, David Lechner wrote: On 03/14/2016 02:00 AM, Felipe Balbi wrote: Hi, why isn't this an actual clock phandle ? Driver could, then, use clk_get_rate() to figure this one out. You could just use a fixed clock here to satisfy the clock API. I've actually been working on

probably missing patch to stable?

Hi Greg, This commit [1] mentions that it affects certain stable versions but I didn't see cc: stable in it nor could find it in any mailing list. Just wanted to bring to your attention. Thanks. cheers, -roger [1] commit e5bdfd50d6f76077bf8441d130c606229e100d40 Author: Greg Kroah-Hartman

Re: function ehci_hub_control in ehci-hub.c

On Sun, Apr 03, 2016 at 02:25:05PM -0400, Alan Stern wrote: > On Sun, 3 Apr 2016, Navin P.S wrote: > > > On Sat, Apr 2, 2016 at 8:00 PM, Alan Stern > > wrote: > > > On Sat, 2 Apr 2016, Navin P.S wrote: > > >>regs->hostpc[(wIndex & 0xff) - 1]; > > > > > > You're

[PATCH] usb: renesas_usbhs: fix to avoid using a disabled ep in usbhsg_queue_done()

This patch fixes an issue that usbhsg_queue_done() may cause kernel panic when dma callback is running and usb_ep_disable() is called by interrupt handler. (Especially, we can reproduce this issue using g_audio with usb-dmac driver.) For example of a flow: usbhsf_dma_complete (on tasklet) -->

Re: cdc-acm: v4.6-rc1: Kernel panic in acm_start_wb

On 04.04.2016 13:07, Oliver Neukum wrote: > On Mon, 2016-04-04 at 12:31 +0200, Torsten Hilbrich wrote: > >> commit a81cf9799ad7299b03a4dff020d9685f9ac5f3e0 >> Author: Oliver Neukum >> Date: Wed Feb 10 10:39:49 2016 +0100 >> >> cdc-acm: implement put_char() and

cdc-acm: v4.6-rc1: Kernel panic in acm_start_wb

Hello When updating the kernel to a post v4.6-rc1 version (based on c05c2ec Merge branch 'parisc-4.6-2' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux) I got the following kernel panic on a T440p system with a 0bdb:193e Ericsson Business Mobile Networks BV while probing with

Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework

Hi, Mark Brown writes: > On Fri, Apr 01, 2016 at 08:43:10AM +0300, Felipe Balbi wrote: >> Mark Brown writes: > >> > IIRC Greg didn't want new classes? > >> good point. Still, this doesn't seem to fit a but_type IMO. > > It does in this new world order.

Re: [RFT PATCH 0/4] usb: dwc2: Fix core reset and force mode delay problems

Hi John, John Youn writes: > The following patch series addresses the core reset and force mode > delay problems we have been seeing on dwc2 for some platforms. > > I think I have identified the source of the inconsistencies between > platforms and this series attempts to

Re: cdc-acm: v4.6-rc1: Kernel panic in acm_start_wb

On Mon, 2016-04-04 at 12:31 +0200, Torsten Hilbrich wrote: > commit a81cf9799ad7299b03a4dff020d9685f9ac5f3e0 > Author: Oliver Neukum > Date: Wed Feb 10 10:39:49 2016 +0100 > > cdc-acm: implement put_char() and flush_chars() Hi, does this fix the issue? Regards

[PATCH] usb: dwc3: keystone: drop dma_mask configuration

The Keystone 2 supports DT-boot only, as result dma_mask will be always configured properly from DT - of_platform_device_create_pdata()->of_dma_configure(). More over, dwc3-keystone.c can be built as module and in this case it's unsafe to assign local variable as dma_mask. Hence, remove dma_mask

XHCI is slow during boot (bios/efi) and leaves many dmesg messages

Hi list, I have a Apple Inc. MacBookPro11,1 (with the most recent 'bios': BIOS MBP111.88Z.0138.B16.1509081438 09/08/2015). At the beginning, USB worked normally. After a while (and after newer kernel versions released by debian?) things started to act strangely. For one, the bios/efi boot

Re: [PATCH] usb: gadget: f_midi: Fixed a bug when buflen was smaller than wMaxPacketSize

Hi Balbi, On 04/04/16 11:46, Felipe Balbi wrote: > > Hi, > > Felipe Ferreri Tonello writes: On 30/03/16 13:33, Michal Nazarewicz wrote: > On Wed, Mar 30 2016, Felipe Balbi wrote: >> a USB packet, right. that's correct. But a struct usb_request can >>

[PATCH] usb: gadget: udc-core: remove manual dma configuration

Since commit 7ace8fc8219e ("usb: gadget: udc: core: Fix argument of dma_map_single for IOMMU") it is not necessary to configure DMA for usb_gadget device manually, because all DMA operation are performed using parent/controller device. Cc: Yoshihiro Shimoda

dwc3: wakeup request details (was: Re: [PATCH 2/2] usb: dwc3: gadget: put link to U0 before Start Transfer)

Hi John, Felipe Balbi writes: > Synopsys Databook says we should move link to U0 > before issuing a Start Transfer command. We could > require the gadget driver to call > usb_gadget_wakeup() however I feel that changing all > gagdget drivers to keep track of Link

Re: [PATCH] usb: gadget: f_midi: Fixed a bug when buflen was smaller than wMaxPacketSize

Hi, Felipe Ferreri Tonello writes: >>> On 30/03/16 13:33, Michal Nazarewicz wrote: On Wed, Mar 30 2016, Felipe Balbi wrote: > a USB packet, right. that's correct. But a struct usb_request can > point to whatever size buffer it wants and UDC is required to

Re: probably missing patch to stable?

Just to recap: The description of the original patch d8f00cd685f5 ("usb: hub: do not clear BOS field during reset device") indicates that it fixes an oops, but it also had a bug that introduced a different oops (reported by me). That patch has now been reverted in mainline, fixing the new oops

Re: function ehci_hub_control in ehci-hub.c

On Mon, 4 Apr 2016, Navin P.S wrote: > I was proposing something like the attached. > When you have an oppurtunity to fix or be complaint let us use that so. > > I finally leave this here for you to accept or reject. It's hard to comment on attachments. You should put your patches in the body

[PATCH] cdc-acm: fix crash if flushed with nothing buffered

Under some circumstances acm_tty_flush_chars() is called with no buffer to flush. We simply need to do nothing. Signed-off-by: Oliver Neukum Reported-by: Torsten Hilbrich --- drivers/usb/class/cdc-acm.c | 4 1 file changed, 4 insertions(+)

[PATCH] cdc-acm: fix crash if flushed with nothing buffered

Under some circumstances acm_tty_flush_chars() is called with no buffer to flush. We simply need to do nothing. Signed-off-by: Oliver Neukum Reported-by: Torsten Hilbrich --- drivers/usb/class/cdc-acm.c | 4 1 file changed, 4 insertions(+)

Re: [RFC] Create an audit record of USB specific details

On Mon, Apr 04, 2016 at 12:02:42AM -0400, wmealing wrote: > From: Wade Mealing > > Gday, > > I'm looking to create an audit trail for when devices are added or removed > from the system. Then please do it in userspace, as I suggested before, that way you catch all types of

Re: [PATCH 5/6] usb: dwc3: core: don't access DMA bits directly

On 04/02/2016 11:28 AM, Felipe Balbi wrote: > instead of manually copying DMA bits from parent > device, we should let DMA API do its job. > > Signed-off-by: Felipe Balbi > --- > drivers/usb/dwc3/core.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-)

Re: [patch] usb: gadget: f_midi: unlock on error

Hi Michal, On 04/04/16 13:11, Michal Nazarewicz wrote: > On Sat, Apr 02 2016, Dan Carpenter wrote: >> We added some new locking here, but missed an error path where we need >> to unlock. >> >> Fixes: 9acdf4df2fc4 ('usb: gadget: f_midi: added spinlock on transmit >> function') >> Signed-off-by:

Re: [PATCH 2/2] usb: dwc3: gadget: put link to U0 before Start Transfer

On 4/4/2016 3:38 PM, Felipe Balbi wrote: On 4/4/2016 12:49 PM, Felipe Balbi wrote: Synopsys Databook says we should move link to U0 Why "databook" is capitalized? :-) because I like capital leters before issuing a Start Transfer command. We could require the gadget driver to call

Re: probably missing patch to stable?

On 04/04/16 17:07, Tony Battersby wrote: > Just to recap: > > The description of the original patch d8f00cd685f5 ("usb: hub: do not > clear BOS field during reset device") indicates that it fixes an oops, > but it also had a bug that introduced a different oops (reported by > me). That patch has

Re: [PATCH 2/2] usb: dwc3: gadget: put link to U0 before Start Transfer

On 4/4/2016 12:49 PM, Felipe Balbi wrote: Synopsys Databook says we should move link to U0 Why "databook" is capitalized? :-) before issuing a Start Transfer command. We could require the gadget driver to call usb_gadget_wakeup() however I feel that changing all gagdget drivers to keep

Re: USB gadgets with configfs hang reboot

On Sat, Apr 02 2016, Alan Stern wrote: > On Sat, 2 Apr 2016, Michal Nazarewicz wrote: >> At the same time, mass storage should work fine if it’s bound to >> multiple configurations. Only one configuration can be active at any >> given time so interfaces on different configurations cannot

Re: [PATCH] usb: dwc3: keystone: drop dma_mask configuration

On 04/04/2016 02:45 PM, Felipe Balbi wrote: Hi, Grygorii Strashko writes: The Keystone 2 supports DT-boot only, as result dma_mask will be always configured properly from DT - of_platform_device_create_pdata()->of_dma_configure(). More over, dwc3-keystone.c can be

Re: [patch] usb: gadget: f_midi: unlock on error

Michal Nazarewicz writes: > On Sat, Apr 02 2016, Dan Carpenter wrote: >> We added some new locking here, but missed an error path where we need >> to unlock. >> >> Fixes: 9acdf4df2fc4 ('usb: gadget: f_midi: added spinlock on transmit >> function') >> Signed-off-by: Dan

Re: [PATCH 2/2] usb: dwc3: gadget: put link to U0 before Start Transfer

Sergei Shtylyov writes: > On 4/4/2016 12:49 PM, Felipe Balbi wrote: > >> Synopsys Databook says we should move link to U0 > > Why "databook" is capitalized? :-) because I like capital leters >> before issuing a Start Transfer command. We could >> require

Re: [PATCH 2/6] usb: dwc3: omap: don't access DMA bits directly

On 04/02/2016 11:28 AM, Felipe Balbi wrote: > Instead of having a static global just for > initializing dma_mask directly, let's use > dma_coerce_mask_and_coherent() for that. > > Signed-off-by: Felipe Balbi > --- > drivers/usb/dwc3/dwc3-omap.c | 4 +--- > 1 file

Re: [RFC] Create an audit record of USB specific details

On Tue, Apr 05, 2016 at 11:54:07AM +1000, Wade Mealing wrote: > That is a good question, maybe I've been lucky in the devices that I have > been testing with. Most of them seem to be ascii, my assumption was that > shouldn't be a problem. The same encoding function used by the path >

Re: [PATCH 1/2] phy: Group vendor specific phy drivers

Hi Krzysztof, On Sat, Apr 2, 2016 at 11:05 PM, Krzysztof Kozlowski wrote: > On Fri, Apr 01, 2016 at 04:59:15PM +0530, Vivek Gautam wrote: >> Adding vendor specific directories in phy to group >> phy drivers under their respective vendor umbrella. >> >> Signed-off-by:

Re: [RFC] Create an audit record of USB specific details

On April 4, 2016 6:17:23 PM Greg KH wrote: On Mon, Apr 04, 2016 at 05:37:58PM -0400, Paul Moore wrote: On Monday, April 04, 2016 05:56:26 AM Greg KH wrote: > On Mon, Apr 04, 2016 at 12:02:42AM -0400, wmealing wrote: > > From: Wade Mealing > > >

Re: [RFC] Create an audit record of USB specific details

A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Tue, Apr 05, 2016 at

Re: [RFC] Create an audit record of USB specific details

On Mon, Apr 04, 2016 at 10:54:56PM -0400, Paul Moore wrote: > On April 4, 2016 6:17:23 PM Greg KH wrote: > > On Mon, Apr 04, 2016 at 05:37:58PM -0400, Paul Moore wrote: > > > On Monday, April 04, 2016 05:56:26 AM Greg KH wrote: > > > > On Mon, Apr 04, 2016 at

Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child

santosh shilimkar writes: > On 4/3/2016 11:28 PM, Felipe Balbi wrote: >> santosh shilimkar writes: >>> +Arnd, RMK, >>> >>> On 4/1/2016 4:57 AM, Felipe Balbi wrote: Hi, Grygorii Strashko

Re: [RFC] Create an audit record of USB specific details

That is a good question, maybe I've been lucky in the devices that I have been testing with. Most of them seem to be ascii, my assumption was that shouldn't be a problem. The same encoding function used by the path audit_log_d_path, definitely audits UTF8 named files: # ausearch -i -f

Re: [PATCH 1/2] phy: Group vendor specific phy drivers

On Fri, Apr 1, 2016 at 8:31 AM, kbuild test robot wrote: > Hi Vivek, > > [auto build test ERROR on rockchip/for-next] > [also build test ERROR on v4.6-rc1 next-20160401] > [if your patch is applied to the wrong git tree, please drop us a note to > help improving the system] > >

Re: [PATCH 2/6] usb: dwc3: omap: don't access DMA bits directly

Grygorii Strashko writes: > On 04/02/2016 11:28 AM, Felipe Balbi wrote: >> Instead of having a static global just for >> initializing dma_mask directly, let's use >> dma_coerce_mask_and_coherent() for that. >> >> Signed-off-by: Felipe Balbi

Re: [PATCH 2/2] usb: dwc3: gadget: clear SUSPHY bit before StartTransfer

Hi, Felipe Balbi writes: > Synopsys Databook 2.60a has a note that if we're > sending a Start Transfer command we _must_ make sure > that DWC3_GUSB2PHY(n).SUSPHY bit is cleared. > > This patch implements that particular detail. > > Signed-off-by: Felipe Balbi

Re: [PATCH 5/6] usb: dwc3: core: don't access DMA bits directly

Grygorii Strashko writes: > On 04/02/2016 11:28 AM, Felipe Balbi wrote: >> instead of manually copying DMA bits from parent >> device, we should let DMA API do its job. >> >> Signed-off-by: Felipe Balbi >> --- >> drivers/usb/dwc3/core.c

Re: [PATCH 2/2] usb: dwc3: gadget: clear SUSPHY bit before StartTransfer

Hi, Felipe Balbi writes: > Felipe Balbi writes: >> Synopsys Databook 2.60a has a note that if we're >> sending a Start Transfer command we _must_ make sure >> that DWC3_GUSB2PHY(n).SUSPHY bit is cleared. >> >> This patch implements

Re: [PATCH] usb: dwc3: keystone: drop dma_mask configuration

Hi, Grygorii Strashko writes: > On 04/04/2016 02:45 PM, Felipe Balbi wrote: >> >> Hi, >> >> Grygorii Strashko writes: >>> The Keystone 2 supports DT-boot only, as result dma_mask will be >>> always configured properly from DT - >>>

Re: [PATCH 2/2] usb: dwc3: gadget: put link to U0 before Start Transfer

Sergei Shtylyov writes: > On 4/4/2016 3:38 PM, Felipe Balbi wrote: > >>> On 4/4/2016 12:49 PM, Felipe Balbi wrote: >>> Synopsys Databook says we should move link to U0 >>> >>> Why "databook" is capitalized? :-) >> >> because I like capital leters >>

Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework

On Mon, Apr 04, 2016 at 01:47:50PM +0300, Felipe Balbi wrote: > Mark Brown writes: > > It does in this new world order. IIRC on an earlier round of review > > there was some code that didn't use a bus but that got complaints that > > it was trying to reimplement the bus

Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child

On 4/3/2016 11:28 PM, Felipe Balbi wrote: santosh shilimkar writes: +Arnd, RMK, On 4/1/2016 4:57 AM, Felipe Balbi wrote: Hi, Grygorii Strashko writes: On 04/01/2016 01:20 PM, Felipe Balbi wrote: [...] commit

Re: USB gadgets with configfs hang reboot

Hi, On 4.04.2016 15:57, Michal Nazarewicz wrote: On Sat, Apr 02 2016, Alan Stern wrote: On Sat, 2 Apr 2016, Michal Nazarewicz wrote: Because of all that, I think the best course of action is to just check whether the thread is running and conditionally start it in fsg_bind, i.e.: ---

Re: [PATCH 1/5 v10] dt/bindings: Add binding for the DA8xx MUSB driver

On 04/04/2016 03:45 AM, Petr Kulhavy wrote: I'm trying to move on with my USB2.0 patch set because my projects is blocked waiting for it. I've seen your PHY patch but it contains only on/off functions and does not handle the clocks, which IMHO should be moved to the PHY driver as well if we

Re: USB gadgets with configfs hang reboot

On Mon, 4 Apr 2016, Michal Nazarewicz wrote: > On Sat, Apr 02 2016, Alan Stern wrote: > > On Sat, 2 Apr 2016, Michal Nazarewicz wrote: > >> At the same time, mass storage should work fine if it’s bound to > >> multiple configurations. Only one configuration can be active at any > >> given time

Re: function ehci_hub_control in ehci-hub.c

On Mon, 4 Apr 2016, Navin P.S wrote: > > You want to replace 2 statements with 8 statements that do exactly > > the same thing? This does not seem like an improvement. > > > > I think Yes i have replaced 2 incorrect statements with 8 correct ones > due to below reason. The original

Re: function ehci_hub_control in ehci-hub.c

On Mon, 4 Apr 2016, Navin P.S wrote: > On Mon, Apr 04, 2016 at 11:57:27AM -0400, Alan Stern wrote: > > On Mon, 4 Apr 2016, Navin P.S wrote: > > > > > > You want to replace 2 statements with 8 statements that do exactly > > > > the same thing? This does not seem like an improvement. > > > > > >

Re: XHCI is slow during boot (bios/efi) and leaves many dmesg messages

Hey Mathias, On 04-04-16 13:30, Mathias Nyman wrote: On 04.04.2016 12:06, Olliver Schinagl wrote: Hi list, I have a Apple Inc. MacBookPro11,1 (with the most recent 'bios': BIOS MBP111.88Z.0138.B16.1509081438 09/08/2015). At the beginning, USB worked normally. After a while (and after newer

Re: function ehci_hub_control in ehci-hub.c

On Mon, Apr 04, 2016 at 11:57:27AM -0400, Alan Stern wrote: > On Mon, 4 Apr 2016, Navin P.S wrote: > > > > You want to replace 2 statements with 8 statements that do exactly > > > the same thing? This does not seem like an improvement. > > > > > > > I think Yes i have replaced 2 incorrect

Re: function ehci_hub_control in ehci-hub.c

On Mon, Apr 04, 2016 at 10:38:37AM -0400, Alan Stern wrote: > On Mon, 4 Apr 2016, Navin P.S wrote: > > > I was proposing something like the attached. > > When you have an oppurtunity to fix or be complaint let us use that so. > > > > I finally leave this here for you to accept or reject. > >

Re: USB gadgets with configfs hang reboot

On Mon, 4 Apr 2016, Michal Nazarewicz wrote: > On Mon, Apr 04 2016, Alan Stern wrote: > > So there is no way to add a single function to several configurations? > > There is. f_mass_storage (and any other usb_function_instance) simply > has to have multiple usb_function structures. > > > It

Re: [patch] usb: gadget: f_midi: unlock on error

> On 04/04/16 13:11, Michal Nazarewicz wrote: >> Or maybe even this which gets away with gotos all together: >> >> diff --git a/drivers/usb/gadget/function/f_midi.c >> b/drivers/usb/gadget/function/f_midi.c >> index 56e2dde..91cae60 100644 >> --- a/drivers/usb/gadget/function/f_midi.c >> +++

Re: XHCI is slow during boot (bios/efi) and leaves many dmesg messages

Hey Mathias, On 04-04-16 13:30, Mathias Nyman wrote: On 04.04.2016 12:06, Olliver Schinagl wrote: Hi list, I have a Apple Inc. MacBookPro11,1 (with the most recent 'bios': BIOS MBP111.88Z.0138.B16.1509081438 09/08/2015). At the beginning, USB worked normally. After a while (and after newer

Re: [PATCH v7 1/4] gadget: Introduce the usb charger framework

On Mon, Apr 04, 2016 at 09:04:48AM -0700, Mark Brown wrote: > On Mon, Apr 04, 2016 at 01:47:50PM +0300, Felipe Balbi wrote: > > Mark Brown writes: > > > > It does in this new world order. IIRC on an earlier round of review > > > there was some code that didn't use a bus but

Re: USB gadgets with configfs hang reboot

On Mon, Apr 04 2016, Alan Stern wrote: > So there is no way to add a single function to several configurations? There is. f_mass_storage (and any other usb_function_instance) simply has to have multiple usb_function structures. > It sounds like there are two problems then. The first problem is

Re: USB gadgets with configfs hang reboot

On Mon, Apr 04 2016, Ivaylo Dimitrov wrote: > Who and when is going to destroy the thread if one does > "/sys/bus/platform/drivers/musb-hdrc# echo musb-hdrc.0.auto > unbind"? > Wouldn't some kind of refcounting make sense here? Currently the thread is killed when fsg_common structure is released

Re: usb 3.0 stopped working with 4.6.0 rc1

ok, i applied 59b9023 usb: fix regression in SuperSpeed endpoint descriptor parsing to linus rc2. everything is working again :) Abr 04 18:07:55 hydra systemd[1]: Starting Stop ureadahead data collection... Abr 04 18:07:55 hydra systemd[1]: Stopped Read required files in advance. Abr 04 18:07:55

RE: [PATCH 1/2] usb: dwc3: core: Introduce dwc3_device_reinit()

Roger I am sorry but this mail chain is unreadable!! I am not able to filter out the >>>... Please send me a clean version of the mail if possible...i will be unable to respond without that.. ---Abhishek -Original Message- From: Felipe Balbi [mailto:ba...@kernel.org] Sent: Monday,

Re: [RFC] Create an audit record of USB specific details

On Monday, April 04, 2016 05:56:26 AM Greg KH wrote: > On Mon, Apr 04, 2016 at 12:02:42AM -0400, wmealing wrote: > > From: Wade Mealing > > > > Gday, > > > > I'm looking to create an audit trail for when devices are added or removed > > from the system. > > Then please do

Re: [RFC] Create an audit record of USB specific details

On Mon, Apr 04, 2016 at 05:33:10PM -0400, Steve Grubb wrote: > On Monday, April 04, 2016 05:56:26 AM Greg KH wrote: > > On Mon, Apr 04, 2016 at 12:02:42AM -0400, wmealing wrote: > > > From: Wade Mealing > > > > > > Gday, > > > > > > I'm looking to create an audit trail for

Re: [RFC] Create an audit record of USB specific details

On Mon, Apr 04, 2016 at 05:37:58PM -0400, Paul Moore wrote: > On Monday, April 04, 2016 05:56:26 AM Greg KH wrote: > > On Mon, Apr 04, 2016 at 12:02:42AM -0400, wmealing wrote: > > > From: Wade Mealing > > > > > > Gday, > > > > > > I'm looking to create an audit trail for

Re: [RFC] Create an audit record of USB specific details

On Mon, Apr 04, 2016 at 02:48:43PM -0700, Greg KH wrote: > On Mon, Apr 04, 2016 at 05:33:10PM -0400, Steve Grubb wrote: > > On Monday, April 04, 2016 05:56:26 AM Greg KH wrote: > > > On Mon, Apr 04, 2016 at 12:02:42AM -0400, wmealing wrote: > > > > From: Wade Mealing > > > >

Re: [PATCH v5 1/4] leds: core: add generic support for RGB Color LED's

Hi Pavel, On 04/01/2016 11:18 PM, Pavel Machek wrote: Hi! It would have the same downsides as in case of having r, g and b in separate attributes, i.e. - problems with setting LED colour in a consistent way. This way LED blinking in whatever colour couldn't be supported reliably. It was one

Re: [RFC] Create an audit record of USB specific details

On Monday, April 04, 2016 12:02:42 AM wmealing wrote: > I'm looking to create an audit trail for when devices are added or removed > from the system. > > The audit subsystem is a logging subsystem in kernel space that can be > used to create advanced filters on generated events. It has partnered

Re: [RFC] Create an audit record of USB specific details

On Monday, April 04, 2016 05:56:26 AM Greg KH wrote: > On Mon, Apr 04, 2016 at 12:02:42AM -0400, wmealing wrote: > > From: Wade Mealing > > > > Gday, > > > > I'm looking to create an audit trail for when devices are added or removed > > from the system. > > Then please do

Re: [RFC] Create an audit record of USB specific details

On Mon, 2016-04-04 at 17:37 -0400, Steve Grubb wrote: > On Monday, April 04, 2016 12:02:42 AM wmealing wrote: > > I'm looking to create an audit trail for when devices are added or removed > > from the system. > > > > The audit subsystem is a logging subsystem in kernel space that can be > > used

Re: [RFC] Create an audit record of USB specific details

On Mon, Apr 04, 2016 at 05:37:01PM -0400, Steve Grubb wrote: > On Monday, April 04, 2016 12:02:42 AM wmealing wrote: > > I'm looking to create an audit trail for when devices are added or removed > > from the system. > > > > The audit subsystem is a logging subsystem in kernel space that can be >