Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

On 09/06/16 13:58, Roger Quadros wrote: > On 09/06/16 12:27, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: >>> [ Unknown signature status ] >>> On 09/06/16 11:00, Felipe Balbi wrote: Hi, Roger Quadros writes: > Felipe, > >

RE: [PATCH v9 00/14] USB OTG/dual-role framework

Hi Roger, > From: Roger Quadros > Sent: Thursday, June 09, 2016 4:31 PM > > Peter & Yoshihiro, > > On 09/06/16 08:27, Peter Chen wrote: > > On Wed, Jun 8, 2016 at 5:03 PM, Roger Quadros wrote: > >> Hi, > >> > >> This series centralizes OTG/Dual-role functionality in the kernel.

Re: [RFC v4 01/14] regulator: of: Add helper for getting all supplies

On Thu, Jun 09, 2016 at 11:44:18AM +0200, Krzysztof Kozlowski wrote: > Few drivers have a need of getting regulator supplies without knowing > their names: > 1. The Simple Framebuffer driver works on setup provided by bootloader >(outside of scope of kernel); > 2. Generic power sequence driver

RE: [PATCH v9 13/14] usb: gadget: udc: adapt to OTG core

Hi Roger, > From: Roger Quadros > Sent: Wednesday, June 08, 2016 6:04 PM > > The OTG state machine needs a mechanism to start and > stop the gadget controller as well as connect/disconnect > from the bus. Add usb_gadget_start(), usb_gadget_stop() > and usb_gadget_connect_control(). > >

Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

Hi, Roger Quadros writes: we're only suspending with cable detached, if you need to maintain >>> >>> That's true only for device mode. What about host mode? Devices are still >>> connected to the host port and are most probably just suspended, not >>> disconnected. >> >>

Re: [RFC v4 01/14] regulator: of: Add helper for getting all supplies

On Thu, Jun 9, 2016 at 12:29 PM, Mark Brown wrote: > On Thu, Jun 09, 2016 at 11:44:18AM +0200, Krzysztof Kozlowski wrote: >> Few drivers have a need of getting regulator supplies without knowing >> their names: >> 1. The Simple Framebuffer driver works on setup provided by

Re: [PATCH v9 03/14] usb: hcd.h: Add OTG to HCD interface

Hello. On 6/9/2016 10:31 AM, Roger Quadros wrote: The OTG core will use struct otg_hcd_ops to interface with the HCD controller. Host controller driver (HCD) controller? Maybe just HC? :-) OK. OTOH, my googling has shown that HCD may stand for both HC driver and HC device... The

Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

On 09/06/16 12:27, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> [ Unknown signature status ] >> On 09/06/16 11:00, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Roger Quadros writes: Felipe, On 30/05/16 14:34, Felipe Balbi wrote: > now

Re: [RFC v4 01/14] regulator: of: Add helper for getting all supplies

On 06/09/2016 12:29 PM, Mark Brown wrote: > On Thu, Jun 09, 2016 at 11:44:18AM +0200, Krzysztof Kozlowski wrote: >> Few drivers have a need of getting regulator supplies without knowing >> their names: >> 1. The Simple Framebuffer driver works on setup provided by bootloader >>(outside of

Re: [PATCH v10 08/14] usb: otg: add OTG/dual-role core

On 6/9/2016 10:53 AM, Roger Quadros wrote: It provides APIs for the following tasks - Registering an OTG/dual-role capable controller - Registering Host and Gadget controllers to OTG core - Providing inputs to and kicking the OTG state machine Provide a dual-role device (DRD) state machine.

Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

On 09/06/16 11:00, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> Felipe, >> >> On 30/05/16 14:34, Felipe Balbi wrote: >>> now that we have re-factored dwc3_core_init() and >>> dwc3_core_exit() we can use them for suspend/resume >>> operations. >>> >>> This will help us

[RFC v4 08/14] power: pwrseq: simple: Add support for regulators and generic property

Some devices need real hard-reset by cutting the power. During power sequence turn off and on all of provided regulators. Additionally add support for instantiating the pwrseq-simple device on a generic property 'power-sequence'. The device will attach itself to the node containing the property

[RFC v4 12/14] EXAMPLE CODE: usb: hub: Power sequence the ports on activation

The autodetection of attached USB device might not work on certain boards where the power is delivered externally. These devices also might require a hard reset. Use pwrseq for that in USB hub. Signed-off-by: Krzysztof Kozlowski --- drivers/usb/core/hub.c | 10

Re: [PATCH v9 00/14] USB OTG/dual-role framework

Peter & Yoshihiro, On 09/06/16 08:27, Peter Chen wrote: > On Wed, Jun 8, 2016 at 5:03 PM, Roger Quadros wrote: >> Hi, >> >> This series centralizes OTG/Dual-role functionality in the kernel. >> As of now I've got Dual-role functionality working pretty reliably on >> dra7-evm and

Re: [PATCH v9 03/14] usb: hcd.h: Add OTG to HCD interface

On 08/06/16 15:10, Sergei Shtylyov wrote: > On 6/8/2016 3:04 PM, Roger Quadros wrote: > The OTG core will use struct otg_hcd_ops to interface with the HCD controller. >>> >>>Host controller driver (HCD) controller? Maybe just HC? :-) >> >> OK. > >OTOH, my googling has shown

Re: [PATCH v9 08/14] usb: otg: add OTG/dual-role core

On 08/06/16 15:42, Peter Chen wrote: > On Wed, Jun 08, 2016 at 01:12:10PM +0300, Roger Quadros wrote: >> Hi, >> >> On 08/06/16 12:53, Peter Chen wrote: >>> On Wed, Jun 08, 2016 at 12:03:40PM +0300, Roger Quadros wrote: +int usb_otg_unregister(struct device *dev) +{ + struct usb_otg

Re: [PATCH v9 11/14] usb: otg: use dev_dbg() instead of VDBG()

On 08/06/16 18:10, Joe Perches wrote: > On Wed, 2016-06-08 at 12:03 +0300, Roger Quadros wrote: >> Now that we have a device reference in struct usb_otg >> let's use dev_dbg() for debug messages. > > dev_vdbg vs dev_dbg > > The patch subject and commit message don't match the code changes.

[RFC] pushing common CDC parser into message.c

Hi, it turns out that the common parser in usbnet leads to dependency hell. It just makes no sense for serial code to depend on a network driver. So, is it OK for this to live in generic USB code or should I make a generic CDC module? -- To unsubscribe from this list: send the line "unsubscribe

[PATCH 2/4] cdc-acm: use the common parser

This introduces the common parser for extra CDC headers now that it no longer depends on usbnet. Signed-off-by: Oliver Neukum --- drivers/usb/class/cdc-acm.c | 68 +++-- 1 file changed, 10 insertions(+), 58 deletions(-) diff --git

[PATCH 4/4] cdc-wdm: use the common CDC parser

Now that the common parser resides in USB core, it can be used for CDC-WDM. Signed-off-by: Oliver Neukum --- drivers/usb/class/cdc-wdm.c | 30 +- 1 file changed, 5 insertions(+), 25 deletions(-) diff --git a/drivers/usb/class/cdc-wdm.c

[PATCH 1/4] usbnet: move the CDC parser into USB core

The dependencies were impossible to handle preventing drivers for CDC devices not which are not network drivers from using the common parser. Signed-off-by: Oliver Neukum --- drivers/net/usb/usbnet.c | 138 drivers/usb/core/message.c

[RFC v4 09/14] power: pwrseq: Add support for USB hubs with external power

Some USB devices on embedded boards have external power supply which has to be reset in certain conditions. Add pwrseq interface for this. Signed-off-by: Krzysztof Kozlowski --- drivers/power/pwrseq/pwrseq.c | 47 ++-

Re: [RFC][PATCH] usb: gadget: Allow to build both USB functions and legacy gadgets

On Wed, Jun 8, 2016 at 9:02 AM, Peter Chen wrote: > On Tue, Jun 07, 2016 at 11:59:57AM +0200, Krzysztof Opasiak wrote: >> Hi, >> >> On Tue, Jun 7, 2016 at 11:06 AM, Peter Chen wrote: >> > >> > >> >>-Original Message- >> >>From:

[RFC v4 04/14] MAINTAINERS: Retain Ulf Hansson as the same maintainer of pwrseq

Before moving pwrseq drivers from drivers/mmc/core/ to drivers/power/, they were maintained by Ulf Hansson. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+)

Re: [PATCH 1/4] usbnet: move the CDC parser into USB core

On Thu, 2016-06-09 at 11:26 +0200, Oliver Neukum wrote: > The dependencies were impossible to handle preventing > drivers for CDC devices not which are not network drivers > from using the common parser. Hi Greg, this is just for discussion. Something went wrong mailing it. Sorry

[RFC v4 02/14] simplefb: Use new devm_of_regulator_all_get helper and bulk API

Switch from manual way of getting all regulators to usage of devm_of_regulator_all_get(). Additionally use the regulator bulk API which changes the logic in case of failure of regulator enable. Before if regulator_enable() returned error for one regulator, rest of them were still enabled. The

[RFC v4 11/14] EXAMPLE CODE: usb: port: Parse pwrseq phandle from Device Tree

Parse usb-pwrseq property from Device Tree to get the phandle to pwrseq device. The pwrseq device will be used by USB hub to cycle the power before activating ports. Signed-off-by: Krzysztof Kozlowski --- drivers/usb/core/hub.h | 3 +++ drivers/usb/core/port.c | 16

[RFC v4 03/14] power/mmc: Move pwrseq drivers to power/pwrseq

The MMC power sequence drivers are useful also outside of MMC world: for USB devices needed a hard-reset before probing. Before extending and re-using pwrseq drivers, move them to a new place. The commit does not introduce significant changes in the pwrseq drivers code so still all the functions

[RFC v4 01/14] regulator: of: Add helper for getting all supplies

Few drivers have a need of getting regulator supplies without knowing their names: 1. The Simple Framebuffer driver works on setup provided by bootloader (outside of scope of kernel); 2. Generic power sequence driver may be attached to any device node. Add a Device Tree helper for parsing

[RFC v4 07/14] power: pwrseq: Generalize mmc_pwrseq operations by removing mmc prefix

The power sequence hooks (mmc_pwrseq_pre_power_on(), mmc_pwrseq_post_power_on() and mmc_pwrseq_power_off()) can be made more generic to allow re-use in other subsystems. They do not need to take pointer to struct mmc_host but instead the struct pwrseq should be sufficient. Remove the "mmc" prefix

Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

Hi, Roger Quadros writes: > Felipe, > > On 30/05/16 14:34, Felipe Balbi wrote: >> now that we have re-factored dwc3_core_init() and >> dwc3_core_exit() we can use them for suspend/resume >> operations. >> >> This will help us avoid some common mistakes when >> patching code when

[PATCH 3/4] cdc-acm: cleanup error handling

A small update to unify error handling during probe(). Signed-off-by: Oliver Neukum --- drivers/usb/class/cdc-acm.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 1620542..2e5dea8

Re: [PATCH v9 12/14] usb: hcd: Adapt to OTG core

On 08/06/16 15:11, Sergei Shtylyov wrote: > On 6/8/2016 3:06 PM, Roger Quadros wrote: > Introduce usb_otg_add/remove_hcd() for use by host controllers that are part of OTG/dual-role port. Non Device tree platforms can use the otg_dev argument to specify the OTG controller

[PATCH v10 11/14] usb: otg: use dev_dbg() instead of VDBG()

Now that we have a device reference in struct usb_otg let's use dev_vdbg() for debug messages instead of VDBG(). Signed-off-by: Roger Quadros Acked-by: Peter Chen --- v10: - in the commit message say dev_vdbg() instead of dev_dbg()

[RFC v4 10/14] usb: hub: Handle deferred probe

Add support for deferred probing to the usb hub. Currently EPROBE_DEFER does not exist in usb hub path but future patches will add it on the port level. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas ---

[RFC v4 06/14] power: pwrseq: Remove mmc prefix from mmc_pwrseq

The "mmc" prefix is no longer needed after moving the pwrseq core code from mmc/ to power/. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- drivers/power/pwrseq/pwrseq.c| 18 +-

[RFC v4 14/14] ARM: dts: exynos: Fix LAN and HUB after bootloader initialization on Odroid U3

On Odroid U3 (Exynos4412-based) board if USB was initialized by bootloader (in U-Boot "usb start" before tftpboot), the HUB (usb3503) and LAN (smsc95xx) after after successful probing were not visible in the system ("lsusb"). In such case the devices had to be fully reset before configuring.

[PATCH v10 08/14] usb: otg: add OTG/dual-role core

It provides APIs for the following tasks - Registering an OTG/dual-role capable controller - Registering Host and Gadget controllers to OTG core - Providing inputs to and kicking the OTG state machine Provide a dual-role device (DRD) state machine. DRD mode is a reduced functionality OTG mode.

[PATCH v10 03/14] usb: hcd.h: Add OTG to HCD interface

The OTG core will use struct otg_hcd_ops to interface with the HCD (Host Controller Device). The main purpose of this interface is to avoid directly calling HCD APIs from the OTG core as they wouldn't be defined in the built-in symbol table if CONFIG_USB is m. Signed-off-by: Roger Quadros

Re: [PATCH 00/21] Delete CURRENT_TIME and CURRENT_TIME_SEC macros

Hi, Deepa Dinamani writes: > drivers/usb/gadget/function/f_fs.c | 2 +- > drivers/usb/gadget/legacy/inode.c | 2 +- for drivers/usb/gadget: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP

Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

Hi, Roger Quadros writes: > [ Unknown signature status ] > On 09/06/16 11:00, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: >>> Felipe, >>> >>> On 30/05/16 14:34, Felipe Balbi wrote: now that we have re-factored dwc3_core_init() and

[RFC v4 13/14] ARM: dts: exynos: Switch the buck8 to GPIO mode on Odroid U3

Switch the control of buck8 to GPIO mode. It is faster than I2C/register mode and it is the easiest way to disable it (regulator state is a logical OR state of GPIO and register value). Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas

[RFC v4 00/14] usb/mmc/power: Generic power sequence (and fix USB/LAN when TFTP booting)

Hi, Another version for solving a problem of power sequence on USB hubs and devices. Apparently I am not the only one experiencing it. The patchset tries to provide a framework for generic power sequence of USB devices but the USB part is left to Peter Chen. Patchset is also available here:

Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

Hi, Felipe Balbi writes: >> However, if I comment out the phy_exit()/init(), phy_power_off/on() part then >> I do see the devices resume correctly. > > okay, so in some cases we don't want phy_exit()/phy_init(), I can move > that elsewhere. Let me check. wait a

Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

On 09/06/16 16:58, Felipe Balbi wrote: > > Hi, > > Felipe Balbi writes: >>> However, if I comment out the phy_exit()/init(), phy_power_off/on() part >>> then >>> I do see the devices resume correctly. >> >> okay, so in some cases we don't want

Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

On 09/06/16 16:10, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>> okay, so we actually want to power the hole thing down when in deep >>> sleep. What does deep sleep map to in linux parlance? suspend-to-ram? >>> suspend-to-disk? >> >> SoC standby == echo standby >

Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

+Kishon, On 09/06/16 14:50, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: > we're only suspending with cable detached, if you need to maintain That's true only for device mode. What about host mode? Devices are still connected to the host port and are

Re: [PATCH v3 1/4] USB: Fix of_usb_get_dr_mode_by_phy with a shared phy block

Hi, On 09-06-16 16:30, Bin Liu wrote: Hi, On Sun, Jun 05, 2016 at 04:59:33PM +0200, Hans de Goede wrote: Some SoCs have a single phy-hw-block with multiple phys, this is modelled by a single phy dts node, so we end up with multiple controller nodes with a phys property pointing to the

Re: [PATCH v7] input: tablet: add Pegasus Notetaker tablet driver

On Wed, 2016-06-01 at 14:55 +0200, Martin Kepplinger wrote: > It's *really* fun to use as an input tablet though! So let's support this > for everybody. Nice job, but a few issues are left. I'll comment in the code. > +static void pegasus_close(struct input_dev *dev) > +{ > + struct

Re: [PATCH v10 11/14] usb: otg: use dev_dbg() instead of VDBG()

On Thu, 2016-06-09 at 10:55 +0300, Roger Quadros wrote: > Now that we have a device reference in struct usb_otg > let's use dev_vdbg() for debug messages instead of VDBG(). > > Signed-off-by: Roger Quadros > Acked-by: Peter Chen > --- > v10: > - in the commit

Re: [RFC v4 01/14] regulator: of: Add helper for getting all supplies

On Thu, Jun 09, 2016 at 02:50:26PM +0200, Rafael J. Wysocki wrote: > On Thu, Jun 9, 2016 at 12:29 PM, Mark Brown wrote: > > The external interface shouldn't be DT specific, the Intel people are > > busy importing all of DT into ACPI > Well, not really. > If you are

Re: [RESENDING] dwc2: Using internal phy (fs mode) for STM32F4x9 platform

On 6/9/2016 10:18 AM, Bruno Herrera wrote: > Hello all, > I'm bringing the linux kernel for the STM32F4 MCU (mmu-less). This MCU > has two DWC2 cores on it:one for USB OTG HS and one for USB OTG FS. > I was able to make the DWC2 driver to work in FS mode using a internal > phy in both cores (HS

Re: Nokia N900: musb is in wrong state after boot

Hi, On Wed, Jun 08, 2016 at 01:02:00PM +0300, Felipe Balbi wrote: > > Hi, > > Tony Lindgren writes: > > * Pali Rohár [160607 05:53]: > >> > Tony, what do you think about that patch? > >> > > >> > >> Tony, PING > > > > Yeah I don't know, AFAIK we don't

Re: Nokia N900: musb is in wrong state after boot

Hi, On Sun, May 29, 2016 at 12:38:24PM +0200, Pali Rohár wrote: > > Hello, attached patch for musb debugfs adds option to force both > > hostmode with speed. It is just example, I tested only compilation. > > > > Something like that will be needed for usb host mode on Nokia N900. > > > > -- >

Re: [PATCH] musb: sunxi: Remove bogus "Frees glue" comment

Hi, On Sat, Jun 04, 2016 at 05:23:04PM +0200, Hans de Goede wrote: > The comment is wrong, glue is devm_kzalloc-ed mem attached to the > "allwinner,sun4i-a10-musb" compatible platform-dev. Where as > glue->musb_pdev is a newly created "musb-hdrc" platform-dev. > > Signed-off-by: Hans de Goede

Re: [PATCH] musb: sunxi: Fix NULL ptr deref when gadget is registered before musb

Hi, On Sat, Jun 04, 2016 at 05:17:50PM +0200, Hans de Goede wrote: > Stop using the return value of platform_device_register_full() to get to > the struct musb in sunxi_musb_work(). If a gadget has been registered > (insmod-ed) before the musb driver, then musb_start will get called > from the

Re: Nokia N900: musb is in wrong state after boot

On Thu 09 June 2016 15:58:56 Bin Liu wrote: > But I am not sure how this will fix n900 host mode problem, since > testmode is not used in normal operation. Please see http://talk.maemo.org/showthread.php?p=685367 and http://maemo.org/packages/view/hostmode-gui/ which indeed is _no_ normal

Re: BUG: using smp_processor_id() in preemptible [00000000] code]

Alan Stern wrote: > On Thu, 9 Jun 2016, M G Berberich wrote: > >> Hello, >> >> With 4.7-rc2, after detecting a USB Mass Storage device >> >> [ 11.589843] usb-storage 4-2:1.0: USB Mass Storage device detected >> >> a constant flow of kernel-BUGS is reported

BUG: using smp_processor_id() in preemptible [00000000] code]

Hello, With 4.7-rc2, after detecting a USB Mass Storage device [ 11.589843] usb-storage 4-2:1.0: USB Mass Storage device detected a constant flow of kernel-BUGS is reported (several per second). [ 11.599215] BUG: using smp_processor_id() in preemptible [] code: systemd-udevd/389

Re: [PATCH v3] usb: phy: mxs: Add DT bindings to configure TX settings

Peter, On Wed, Jun 8, 2016 at 10:41 PM, Peter Chen wrote: > On Thu, Jun 9, 2016 at 5:27 AM, Jaret Cantu wrote: >> On 03/23/2016 10:21 PM, Peter Chen wrote: >>> >>> On Wed, Mar 23, 2016 at 02:17:27PM -0400, Jaret Cantu wrote: On

Re: [PATCH v3 1/4] USB: Fix of_usb_get_dr_mode_by_phy with a shared phy block

Hi, On Thu, Jun 09, 2016 at 04:51:45PM +0200, Hans de Goede wrote: > Hi, > > On 09-06-16 16:30, Bin Liu wrote: > >Hi, > > > >On Sun, Jun 05, 2016 at 04:59:33PM +0200, Hans de Goede wrote: > >>Some SoCs have a single phy-hw-block with multiple phys, this is > >>modelled by a single phy dts node,

Re: [PATCH v9 03/14] usb: hcd.h: Add OTG to HCD interface

On Thu, 9 Jun 2016, Sergei Shtylyov wrote: > Hello. > > On 6/9/2016 10:31 AM, Roger Quadros wrote: > > > The OTG core will use struct otg_hcd_ops to interface > > with the HCD controller. > > Host controller driver (HCD) controller? Maybe just HC? :-) > >>> > >>> OK. > >> >

Re: [PATCH v3 1/4] USB: Fix of_usb_get_dr_mode_by_phy with a shared phy block

Hi, On Sun, Jun 05, 2016 at 04:59:33PM +0200, Hans de Goede wrote: > Some SoCs have a single phy-hw-block with multiple phys, this is > modelled by a single phy dts node, so we end up with multiple > controller nodes with a phys property pointing to the phy-node > of the otg-phy. > > Only one of

Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

Hi, Roger Quadros writes: >> okay, so we actually want to power the hole thing down when in deep >> sleep. What does deep sleep map to in linux parlance? suspend-to-ram? >> suspend-to-disk? > > SoC standby == echo standby > /sys/power/state > SoC deepsleep == echo mem >

Re: BUG: using smp_processor_id() in preemptible [00000000] code]

On Thu, 9 Jun 2016, M G Berberich wrote: > Hello, > > With 4.7-rc2, after detecting a USB Mass Storage device > > [ 11.589843] usb-storage 4-2:1.0: USB Mass Storage device detected > > a constant flow of kernel-BUGS is reported (several per second). > > [ 11.599215] BUG: using