Re: [PATCH] drivers: usb: usbip: Add missing break statement to switch

On 02/09/2017 12:49 AM, Gustavo A. R. Silva wrote: > Add missing break statement to prevent the code for case > USB_PORT_FEAT_C_RESET falling through to the default case. > > Addresses-Coverity-ID: 143155 > Signed-off-by: Gustavo A. R. Silva > --- >

Re: [PATCH v3 0/2] Fixes for sierra_net driver

From: Stefan Brüns Date: Wed, 8 Feb 2017 02:46:31 +0100 > When trying to initiate a dual-stack (ipv4v6) connection, a MC7710, FW > version SWI9200X_03.05.24.00ap answers with an unsupported LSI. Add support > for this LSI. > Also the link_type should be ignored when

Re: [PATCH 0/8] usb: dwc3: add dual-role support

Vivek, On 09/02/17 08:42, Vivek Gautam wrote: > Hi Roger, > > On Mon, Jan 23, 2017 at 4:49 PM, Roger Quadros wrote: >> Hi, >> >> We rely on the OTG controller block to provide us with >> VBUS and ID line status via an interrupt. >> >> This is then used to switch the controller

drivers: usb: dwc3: A question...

Hello everybody, I ran into the following piece of code at drivers/usb/dwc3/dwc3-omap.c:218 (linux-next) 218static void dwc3_omap_set_mailbox(struct dwc3_omap *omap, 219enum omap_dwc3_vbus_id_status status) 220{ 221int ret; 222u32 val; 223 224switch

RE: How to resolve "Waited 2000ms for CONNECT" in system resuming?

Hi Alan, Thank you for the reply! > From: Alan Stern > Sent: Thursday, February 09, 2017 12:39 AM > > On Wed, 8 Feb 2017, Yoshihiro Shimoda wrote: > > > Hi, > > > > In my environment, it causes the following message during system resume if > > debug messages are enabled: > > > > usb 2-1:

[PATCH] drivers: usb: usbip: Add missing break statement to switch

Add missing break statement to prevent the code for case USB_PORT_FEAT_C_RESET falling through to the default case. Addresses-Coverity-ID: 143155 Signed-off-by: Gustavo A. R. Silva --- drivers/usb/usbip/vhci_hcd.c | 1 + 1 file changed, 1 insertion(+) diff --git

drivers: usb: musb: question about missing break in switch

Hello everybody, I ran into the following piece of code at drivers/usb/musb/musb_core.c:1854 (linux-next) 1854/* 1855 * Check the musb devctl session bit to determine if we want to 1856 * allow PM runtime for the device. In general, we want to keep things 1857 * active when the session bit

Re: drivers: usb: dwc3: A question...

Hi, On 09/02/17 10:14, Gustavo A. R. Silva wrote: > Hello everybody, > > I ran into the following piece of code at drivers/usb/dwc3/dwc3-omap.c:218 > (linux-next) > > 218static void dwc3_omap_set_mailbox(struct dwc3_omap *omap, > 219enum omap_dwc3_vbus_id_status status) > 220{ > 221

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

On 02/08/2017 09:16 PM, Andy Shevchenko wrote: > On Wed, 2017-02-08 at 21:03 +0100, Richard Leitner wrote: >> Should I keep my inline {clr,set}_bit_in_byte() >> functions an use BIT() in there, or delete them and use BIT() >> directly >> in usb251xb_get_ofdata() ? > > Does it make any sense? >

Re: [PATCH] ARM: dts: Odroid XU4: fix USB3.0 ports

2017-01-27 8:29 GMT+01:00 Richard Genoud : > On 25/01/2017 15:17, Krzysztof Kozlowski wrote: >> On Wed, Jan 25, 2017 at 3:48 PM, Marek Szyprowski >> wrote: >>> Hi Krzysztof, >>> >>> On 2017-01-25 08:55, Krzysztof Kozlowski wrote: On

[PATCH v2] usb: dwc2: skip regulator operations if supplies vusb_a and vusb_d are not available

Supplies for vusb_a and vusb_d are needed only on a minority of systems supported by the dwc2 driver (AFAIK systems with Samsung SoCs). On all other systems this results in harmless but annoying warnings: c900.usb supply vusb_d not found, using dummy regulator c900.usb supply vusb_a not

Re: drivers: usb: musb: question about missing break in switch

Hello Bin, Quoting Bin Liu : On Thu, Feb 09, 2017 at 02:37:34AM -0600, Gustavo A. R. Silva wrote: Hello everybody, I ran into the following piece of code at drivers/usb/musb/musb_core.c:1854 (linux-next) 1854/* 1855 * Check the musb devctl session bit to determine if we want

[PATCH] drivers: usb: musb: add code comment for clarification

Add code comment to make it clear that the fall-through is intentional. Read the link for more details: https://lkml.org/lkml/2017/2/9/292 Signed-off-by: Gustavo A. R. Silva --- drivers/usb/musb/musb_core.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration

On Thu, Feb 09, 2017 at 05:40:50PM +0530, Vivek Gautam wrote: > On Thu, Feb 9, 2017 at 5:24 PM, Roger Quadros wrote: > > > > > > On 09/02/17 13:53, Roger Quadros wrote: > >> > >> > >> On 08/02/17 22:43, Jack Pham wrote: > >>> Hi Peter, Sriram, Arnd, > >>> > >>> On Mon, Feb 06, 2017

[RESEND PATCH v2 0/2] add multiple clock handling for dwc2 driver

Resend this series to involve device tree maintainer and add 'Reviewed-by' tag for driver. The Current default dwc2 just handle one clock named otg, however, it may have two or more clock need to manage for some new SoCs(such as RK3328), so this adds change clk to clk's array of dwc2_hsotg to

[RESEND PATCH v2 1/2] Documentation: dt: dwc2: amend clocks property

Move 'clocks' to optional properties since not every platform is going to need to specify it and add pmu/utmi/ulpi/utmifs optional clocks into 'clock-names' list. Signed-off-by: Frank Wang --- Documentation/devicetree/bindings/usb/dwc2.txt | 13 ++--- 1 file

[RESEND PATCH v2 2/2] usb: dwc2: add multiple clocks handling

Since dwc2 may have one or more input clocks need to manage for some platform, so this adds change clk to clk's array of struct dwc2_hsotg to handle more clocks operation. Signed-off-by: Frank Wang Reviewed-by: Heiko Stuebner ---

Re: [PATCH v3] usb: gadget: configfs: Fix KASAN use-after-free

Hi Jim, > Jim Lin writes: > > When gadget is disconnected, running sequence is like this. > > . composite_disconnect > > . Call trace: > > usb_string_copy+0xd0/0x128 > > gadget_config_name_configuration_store+0x4 > > gadget_config_name_attr_store+0x40/0x50 > >

RE: [PATCH v4 3/3] USB3/DWC3: Enable undefined length INCR burst type

> -Original Message- > From: Changming Huang [mailto:jerry.hu...@nxp.com] > Sent: Wednesday, January 18, 2017 4:12 PM > To: ba...@kernel.org; robh...@kernel.org; mark.rutl...@arm.com; > catalin.mari...@arm.com > Cc: linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; >

Re: [PATCH 0/8] usb: dwc3: add dual-role support

On Thu, Feb 9, 2017 at 1:19 PM, Roger Quadros wrote: > Vivek, > > On 09/02/17 08:42, Vivek Gautam wrote: >> Hi Roger, >> >> On Mon, Jan 23, 2017 at 4:49 PM, Roger Quadros wrote: >>> Hi, >>> >>> We rely on the OTG controller block to provide us with >>> VBUS and ID

Re: drivers: usb: musb: question about missing break in switch

On Thu, Feb 09, 2017 at 02:37:34AM -0600, Gustavo A. R. Silva wrote: > Hello everybody, > > I ran into the following piece of code at > drivers/usb/musb/musb_core.c:1854 (linux-next) > > 1854/* > 1855 * Check the musb devctl session bit to determine if we want to > 1856 * allow PM runtime for

Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

Florian Fainelli writes: >>> If not, for something like this it's a must: >>> >>> drivers/net/wireless/ath/wil6210/cfg80211.c:24:30: error: expected ‘)’ >>> before ‘bool’ >>> module_param(disable_ap_sme, bool, 0444); >>> ^ >>>

RE: How to resolve "Waited 2000ms for CONNECT" in system resuming?

On Thu, 9 Feb 2017, Yoshihiro Shimoda wrote: > Hi Alan, > > Thank you for the reply! > > > From: Alan Stern > > Sent: Thursday, February 09, 2017 12:39 AM > > > > On Wed, 8 Feb 2017, Yoshihiro Shimoda wrote: > > > > > Hi, > > > > > > In my environment, it causes the following message during

[PATCH] USB: serial: mos7840: fix another NULL-deref at open

Fix another NULL-pointer dereference at open should a malicious device lack an interrupt-in endpoint. Note that the driver has a broken check for an interrupt-in endpoint, which means that an interrupt URB has never even been submitted. Fixes: 3f5429746d91 ("USB: Moschip 7840 USB-Serial Driver")

Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration

On Thu, Feb 9, 2017 at 5:24 PM, Roger Quadros wrote: > > > On 09/02/17 13:53, Roger Quadros wrote: >> >> >> On 08/02/17 22:43, Jack Pham wrote: >>> Hi Peter, Sriram, Arnd, >>> >>> On Mon, Feb 06, 2017 at 05:13:38PM +0800, Peter Chen wrote: From: Arnd Bergmann

Re: [GIT PULL] USB-serial updates for v4.11-rc1

On Thu, Feb 09, 2017 at 01:36:10PM +0100, Johan Hovold wrote: > The following changes since commit 49def1853334396f948dcb4cedb9347abb318df5: > > Linux 4.10-rc4 (2017-01-15 16:21:59 -0800) > > are available in the git repository at: > >

Re: [PATCH v2 2/2] usb: dwc2: add multiple clocks handling

Am Donnerstag, 9. Februar 2017, 10:44:39 CET schrieb Frank Wang: > Since dwc2 may have one or more input clocks need to manage for some > platform, so this adds change clk to clk's array of struct dwc2_hsotg > to handle more clocks operation. > > Signed-off-by: Frank Wang

Re: [PATCH] USB: serial: mos7840: fix another NULL-deref at open

On Thu, Feb 09, 2017 at 12:11:41PM +0100, Johan Hovold wrote: > Fix another NULL-pointer dereference at open should a malicious device > lack an interrupt-in endpoint. > > Note that the driver has a broken check for an interrupt-in endpoint, > which means that an interrupt URB has never even been

[GIT PULL] USB-serial updates for v4.11-rc1

The following changes since commit 49def1853334396f948dcb4cedb9347abb318df5: Linux 4.10-rc4 (2017-01-15 16:21:59 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git tags/usb-serial-4.11-rc1 for you to fetch changes up to

Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration

On 08/02/17 22:43, Jack Pham wrote: > Hi Peter, Sriram, Arnd, > > On Mon, Feb 06, 2017 at 05:13:38PM +0800, Peter Chen wrote: >> From: Arnd Bergmann >> >> For xhci-hcd platform device, all the DMA parameters are not >> configured properly, notably dma ops for dwc3 devices. So,

Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration

On 09/02/17 13:53, Roger Quadros wrote: > > > On 08/02/17 22:43, Jack Pham wrote: >> Hi Peter, Sriram, Arnd, >> >> On Mon, Feb 06, 2017 at 05:13:38PM +0800, Peter Chen wrote: >>> From: Arnd Bergmann >>> >>> For xhci-hcd platform device, all the DMA parameters are not >>>

Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration

On Thu, Feb 9, 2017 at 5:23 PM, Roger Quadros wrote: > > > On 08/02/17 22:43, Jack Pham wrote: >> Hi Peter, Sriram, Arnd, >> >> On Mon, Feb 06, 2017 at 05:13:38PM +0800, Peter Chen wrote: >>> From: Arnd Bergmann >>> >>> For xhci-hcd platform device, all the DMA

[PATCH 1/3 v2] usb: host: fotg2: add device tree probing

Add device tree probe for fotg2 driver v2: fix in wrong MODULE_DEVICE_TABLE Signed-off-by: Hans Ulli Kroll --- drivers/usb/host/fotg210-hcd.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/usb/host/fotg210-hcd.c

Re: [PATCH resend v5 0/4] xhci fixes for usb-linus

On Thu, 9 Feb 2017, Peter Chen wrote: > Modified patch like below: > > From 083c2bc7f05b520c51f64ef6b8ee6a0bae499442 Mon Sep 17 00:00:00 2001 > From: Peter Chen > Date: Mon, 6 Feb 2017 14:50:33 +0800 > Subject: [PATCH 1/1] usb: ehci: use bus->sysdev for DMA configuration >

Re: Periodic reconnects of USB mouse on Dell PowerEdge R730

Dear Johan, On 02/08/17 17:54, Johan Hovold wrote: On Wed, Feb 08, 2017 at 05:41:33PM +0100, Paul Menzel wrote: On 02/08/17 16:50, Johan Hovold wrote: On Wed, Feb 08, 2017 at 04:15:02PM +0100, Paul Menzel wrote: On 02/08/17 14:02, Greg KH wrote: On Wed, Feb 08, 2017 at 12:16:44PM +0100,

Re: [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric

On 2017-02-01 08:59, Stefan Agner wrote: > On 2017-02-01 00:06, Greg KH wrote: >> On Tue, Jan 31, 2017 at 06:19:16PM -0800, Stefan Agner wrote: >>> Currently qw_sign requires UTF-8 character to set, but returns UTF-16 >>> when read. This isn't obvious when simply using cat since the null >>>